35956 2010-03-10 00:13:51 -0800 [Chromium] Have a grd file live upstream for resources that we pull from WebKit/WebCore 2010-03-10 00:41:37 -0800 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 tony tony fishd oldest_to_newest 197908 0 tony 2010-03-10 00:13:51 -0800 We should have a grd file in WebKit/chromium/ for resources that live upstream. This has a couple of advantages: - If a resource we depend on upstream moves, whoever moves the file can fix the chromium build by updating the grd file. - As part of the chromium DRT work, we need to be able to build webkit_resources.grd upstream. The references to third_party files won't resolve upstream, so this allows us to get rid of the third_party references. Patch coming with a small grd file. The Chromium side patch that will start using this file is here: http://codereview.chromium.org/792005 197910 1 50375 tony 2010-03-10 00:16:13 -0800 Created attachment 50375 Patch 197912 2 tony 2010-03-10 00:17:53 -0800 (In reply to comment #1) > Created an attachment (id=50375) [details] > Patch I am open to suggestions on where to put the file (e.g., the WebKit/win port has a .rc file in WebKit/win/WebKit.vcproj/) and on what to name the grd file. Right now they are all dev tool resources, but you could imagine us wanting to include other resources here (like the missing image png). 197914 3 50375 tony 2010-03-10 00:28:28 -0800 Comment on attachment 50375 Patch Based on offline discussion, I'm going to give this a more general filename so we can add other resources (not devtool related) to it in the future. 197918 4 tony 2010-03-10 00:41:37 -0800 Committed r55769: <http://trac.webkit.org/changeset/55769> 50375 2010-03-10 00:16:13 -0800 2010-03-10 00:28:28 -0800 Patch bug-35956-20100310171611.patch text/plain 1494 tony ZGlmZiAtLWdpdCBhL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cgYi9XZWJLaXQvY2hyb21pdW0v Q2hhbmdlTG9nCmluZGV4IDdlOWFhYWYuLmE4ODljOWIgMTAwNjQ0Ci0tLSBhL1dlYktpdC9jaHJv bWl1bS9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwpAQCAtMSwzICsx LDEzIEBACisyMDEwLTAzLTEwICBUb255IENoYW5nICA8dG9ueUBjaHJvbWl1bS5vcmc+CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM1OTU2CisgICAgICAgIENyZWF0ZSBhIGdyZCBm aWxlIHVwc3RyZWFtIGZvciByZXNvdXJjZXMgdGhhdCBjaHJvbWl1bSB1c2VzCisgICAgICAgIHRo YXQgYXJlIHB1bGxlZCBkaXJlY3RseSBmcm9tIHRoZSB1cHN0cmVhbSByZXBvc2l0b3J5LgorCisg ICAgICAgICogZGV2dG9vbHNfcmVzb3VyY2VzLmdyZDogQWRkZWQuCisKIDIwMTAtMDMtMTAgIFJv bGFuZCBTdGVpbmVyICA8cm9sYW5kc3RlaW5lckBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2 aWV3ZWQgYnkgRGF2aWQgTGV2aW4uCmRpZmYgLS1naXQgYS9XZWJLaXQvY2hyb21pdW0vZGV2dG9v bHNfcmVzb3VyY2VzLmdyZCBiL1dlYktpdC9jaHJvbWl1bS9kZXZ0b29sc19yZXNvdXJjZXMuZ3Jk Cm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAuLjA0NzE2OTYKLS0tIC9kZXYvbnVs bAorKysgYi9XZWJLaXQvY2hyb21pdW0vZGV2dG9vbHNfcmVzb3VyY2VzLmdyZApAQCAtMCwwICsx LDE2IEBACis8P3htbCB2ZXJzaW9uPSIxLjAiIGVuY29kaW5nPSJVVEYtOCI/PgorPGdyaXQgbGF0 ZXN0X3B1YmxpY19yZWxlYXNlPSIwIiBjdXJyZW50X3JlbGVhc2U9IjEiPgorICA8b3V0cHV0cz4K KyAgICA8b3V0cHV0IGZpbGVuYW1lPSJncml0L2RldnRvb2xzX3Jlc291cmNlcy5oIiB0eXBlPSJy Y19oZWFkZXIiPgorICAgICAgPGVtaXQgZW1pdF90eXBlPSdwcmVwZW5kJz48L2VtaXQ+CisgICAg PC9vdXRwdXQ+CisgICAgPG91dHB1dCBmaWxlbmFtZT0iZGV2dG9vbHNfcmVzb3VyY2VzLnJjIiB0 eXBlPSJyY19hbGwiIC8+CisgICAgPG91dHB1dCBmaWxlbmFtZT0iZGV2dG9vbHNfcmVzb3VyY2Vz LnBhayIgdHlwZT0iZGF0YV9wYWNrYWdlIiAvPgorICA8L291dHB1dHM+CisgIDxyZWxlYXNlIHNl cT0iMSI+CisgICAgPGluY2x1ZGVzPgorICAgICAgPGluY2x1ZGUgbmFtZT0iSURSX0RFVlRPT0xT X0lOSkVDVF9ESVNQQVRDSF9KUyIgZmlsZT0ic3JjXGpzXEluamVjdERpc3BhdGNoLmpzIiAgdHlw ZT0iQklOREFUQSIvPgorICAgICAgPGluY2x1ZGUgbmFtZT0iSURSX0RFVlRPT0xTX0lOSkVDVF9X RUJLSVRfSlMiIGZpbGU9Ii4uXC4uXFdlYkNvcmVcaW5zcGVjdG9yXGZyb250LWVuZFxJbmplY3Rl ZFNjcmlwdC5qcyIgdHlwZT0iQklOREFUQSIvPgorICAgIDwvaW5jbHVkZXM+CisgIDwvcmVsZWFz ZT4KKzwvZ3JpdD4K