35950 2010-03-09 16:29:25 -0800 [chromium] Screen coordinate flipping in Chromium Mac event conversion should use primary monitor 2010-03-11 19:04:49 -0800 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) Mac OS X 10.5 RESOLVED FIXED P2 Normal --- 1 stuartmorgan stuartmorgan commit-queue darin oldest_to_newest 197837 0 stuartmorgan 2010-03-09 16:29:25 -0800 Screen-coordinate flipping should be based on the primary monitor (the one with the menu bar), but currently the Chromium event factory code is using the screen that the window is on. This has mostly worked out before because we have the same bug in the window frame conversion: http://codereview.chromium.org/751002 I'll coordinate with the WebKit gardner to get both patches in at the same time. 197839 1 50360 stuartmorgan 2010-03-09 16:43:27 -0800 Created attachment 50360 Fix Fixes the bug, and eliminates the duplicate location conversion code between mouse events and mouse wheel events. Also fixes the way the global coordinates are calculated so that it actually uses the passed event, rather than the current location of the mouse. 197895 2 50360 fishd 2010-03-09 22:28:59 -0800 Comment on attachment 50360 Fix Since this is a dual-sided patch, I'm assuming you need to coordinate this landing with the appropriate webkit gardener. 198237 3 50360 japhet 2010-03-10 11:18:42 -0800 Comment on attachment 50360 Fix I'm the appropriate chromium webkit gardener, and I think this is a good time for this patch, so switching to cq+ 198899 4 50360 commit-queue 2010-03-11 19:04:45 -0800 Comment on attachment 50360 Fix Clearing flags on attachment: 50360 Committed r55877: <http://trac.webkit.org/changeset/55877> 198900 5 commit-queue 2010-03-11 19:04:49 -0800 All reviewed patches have been landed. Closing bug. 50360 2010-03-09 16:43:27 -0800 2010-03-11 19:04:45 -0800 Fix 35950.patch text/plain 3831 stuartmorgan SW5kZXg6IFdlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZwkocmV2aXNpb24gNTU3NTMpCisrKyBXZWJLaXQvY2hyb21pdW0vQ2hh bmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjEgQEAKKzIwMTAtMDMtMDkgIFN0dWFy dCBNb3JnYW4gIDxzdHVhcnRtb3JnYW5AY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEZpeCB0aGUgc2NyZWVuIGNvb3JkaW5hdGUg Y29udmVyc2lvbiBvZiBDaHJvbWl1bSBNYWMgbW91c2UgZXZlbnRzIGZvcgorICAgICAgICBtdWx0 aXBsZS1tb25pdGVyIHNldHVwcy4gQWxzbyBjaGFuZ2VzIHRoZSBnbG9iYWwgY29vcmRpbmF0ZSB2 YWx1ZXMKKyAgICAgICAgdG8gYmUgY29tcHV0ZWQgZnJvbSB0aGUgZXZlbnQsIHJhdGhlciB0aGFu IHRoZSBpbnN0YW50YW5lb3VzIG1vdXNlCisgICAgICAgIGxvY2F0aW9uLCBhbmQgcmVkdWNlcyBj b2RlIGR1cGxpY2F0aW9uIGZvciBsb2NhdGlvbiBjb252ZXJzaW9uLgorCisgICAgICAgIER1YWwt c2lkZWQgcGF0Y2ggd2l0aCBodHRwOi8vY29kZXJldmlldy5jaHJvbWl1bS5vcmcvNzUxMDAyCisK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM1OTUwCisK KyAgICAgICAgKiBzcmMvbWFjL1dlYklucHV0RXZlbnRGYWN0b3J5Lm1tOgorICAgICAgICAoV2Vi S2l0OjpzZXRXZWJFdmVudExvY2F0aW9uRnJvbUV2ZW50SW5WaWV3KToKKyAgICAgICAgKFdlYktp dDo6V2ViSW5wdXRFdmVudEZhY3Rvcnk6Om1vdXNlRXZlbnQpOgorICAgICAgICAoV2ViS2l0OjpX ZWJJbnB1dEV2ZW50RmFjdG9yeTo6bW91c2VXaGVlbEV2ZW50KToKKwogMjAxMC0wMy0wOSAgQW50 b24gTXVoaW4gIDxhbnRvbm1AY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERh cmluIEZpc2hlci4KSW5kZXg6IFdlYktpdC9jaHJvbWl1bS9zcmMvbWFjL1dlYklucHV0RXZlbnRG YWN0b3J5Lm1tCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdC9jaHJvbWl1bS9zcmMvbWFjL1dlYklucHV0 RXZlbnRGYWN0b3J5Lm1tCShyZXZpc2lvbiA1NDg5OCkKKysrIFdlYktpdC9jaHJvbWl1bS9zcmMv bWFjL1dlYklucHV0RXZlbnRGYWN0b3J5Lm1tCSh3b3JraW5nIGNvcHkpCkBAIC04NjEsNiArODYx LDI5IEBAIHN0YXRpYyBpbmxpbmUgaW50IG1vZGlmaWVyc0Zyb21FdmVudChOU0UKICAgICByZXR1 cm4gbW9kaWZpZXJzOwogfQogCitzdGF0aWMgaW5saW5lIHZvaWQgc2V0V2ViRXZlbnRMb2NhdGlv bkZyb21FdmVudEluVmlldyhXZWJNb3VzZUV2ZW50KiByZXN1bHQsCisgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBOU0V2ZW50KiBldmVudCwKKyAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIE5TVmll dyogdmlldykgeworICAgIE5TUG9pbnQgd2luZG93TG9jYWwgPSBbZXZlbnQgbG9jYXRpb25Jbldp bmRvd107CisKKyAgICBOU1BvaW50IHNjcmVlbkxvY2FsID0gW1t2aWV3IHdpbmRvd10gY29udmVy dEJhc2VUb1NjcmVlbjp3aW5kb3dMb2NhbF07CisgICAgcmVzdWx0LT5nbG9iYWxYID0gc2NyZWVu TG9jYWwueDsKKyAgICAvLyBGbGlwIHkuCisgICAgTlNTY3JlZW4qIHByaW1hcnlTY3JlZW4gPSAo W1tOU1NjcmVlbiBzY3JlZW5zXSBjb3VudF0gPiAwKSA/CisgICAgICAgIFtbTlNTY3JlZW4gc2Ny ZWVuc10gb2JqZWN0QXRJbmRleDowXSA6IG5pbDsKKyAgICBpZiAocHJpbWFyeVNjcmVlbikKKyAg ICAgICAgcmVzdWx0LT5nbG9iYWxZID0gW3ByaW1hcnlTY3JlZW4gZnJhbWVdLnNpemUuaGVpZ2h0 IC0gc2NyZWVuTG9jYWwueTsKKyAgICBlbHNlCisgICAgICAgIHJlc3VsdC0+Z2xvYmFsWSA9IHNj cmVlbkxvY2FsLnk7CisKKyAgICBOU1BvaW50IGNvbnRlbnRMb2NhbCA9IFt2aWV3IGNvbnZlcnRQ b2ludDp3aW5kb3dMb2NhbCBmcm9tVmlldzpuaWxdOworICAgIHJlc3VsdC0+eCA9IGNvbnRlbnRM b2NhbC54OworICAgIHJlc3VsdC0+eSA9IFt2aWV3IGZyYW1lXS5zaXplLmhlaWdodCAtIGNvbnRl bnRMb2NhbC55OyAgLy8gRmxpcCB5LgorCisgICAgcmVzdWx0LT53aW5kb3dYID0gcmVzdWx0LT54 OworICAgIHJlc3VsdC0+d2luZG93WSA9IHJlc3VsdC0+eTsKK30KKwogV2ViS2V5Ym9hcmRFdmVu dCBXZWJJbnB1dEV2ZW50RmFjdG9yeTo6a2V5Ym9hcmRFdmVudChOU0V2ZW50KiBldmVudCkKIHsK ICAgICBXZWJLZXlib2FyZEV2ZW50IHJlc3VsdDsKQEAgLTEwMjEsMTYgKzEwNDQsNyBAQCBXZWJN b3VzZUV2ZW50IFdlYklucHV0RXZlbnRGYWN0b3J5Ojptb3VzCiAgICAgICAgIEFTU0VSVF9OT1Rf UkVBQ0hFRCgpOwogICAgIH0KIAotICAgIE5TUG9pbnQgbG9jYXRpb24gPSBbTlNFdmVudCBtb3Vz ZUxvY2F0aW9uXTsgIC8vIGdsb2JhbCBjb29yZGluYXRlcwotICAgIHJlc3VsdC5nbG9iYWxYID0g bG9jYXRpb24ueDsKLSAgICByZXN1bHQuZ2xvYmFsWSA9IFtbW3ZpZXcgd2luZG93XSBzY3JlZW5d IGZyYW1lXS5zaXplLmhlaWdodCAtIGxvY2F0aW9uLnk7Ci0KLSAgICBOU1BvaW50IHdpbmRvd0xv Y2FsID0gW2V2ZW50IGxvY2F0aW9uSW5XaW5kb3ddOwotICAgIGxvY2F0aW9uID0gW3ZpZXcgY29u dmVydFBvaW50OndpbmRvd0xvY2FsIGZyb21WaWV3Om5pbF07Ci0gICAgcmVzdWx0LnkgPSBbdmll dyBmcmFtZV0uc2l6ZS5oZWlnaHQgLSBsb2NhdGlvbi55OyAgLy8gZmxpcCB5Ci0gICAgcmVzdWx0 LnggPSBsb2NhdGlvbi54OwotICAgIHJlc3VsdC53aW5kb3dYID0gcmVzdWx0Lng7Ci0gICAgcmVz dWx0LndpbmRvd1kgPSByZXN1bHQueTsKKyAgICBzZXRXZWJFdmVudExvY2F0aW9uRnJvbUV2ZW50 SW5WaWV3KCZyZXN1bHQsIGV2ZW50LCB2aWV3KTsKIAogICAgIHJlc3VsdC5tb2RpZmllcnMgPSBt b2RpZmllcnNGcm9tRXZlbnQoZXZlbnQpOwogCkBAIC0xMDUwLDE2ICsxMDY0LDcgQEAgV2ViTW91 c2VXaGVlbEV2ZW50IFdlYklucHV0RXZlbnRGYWN0b3J5OgogCiAgICAgcmVzdWx0Lm1vZGlmaWVy cyA9IG1vZGlmaWVyc0Zyb21FdmVudChldmVudCk7CiAKLSAgICAvLyBTZXQgY29vcmRpbmF0ZXMg YnkgdHJhbnNsYXRpbmcgZXZlbnQgY29vcmRpbmF0ZXMgZnJvbSBzY3JlZW4gdG8gY2xpZW50Lgot ICAgIE5TUG9pbnQgbG9jYXRpb24gPSBbTlNFdmVudCBtb3VzZUxvY2F0aW9uXTsgIC8vIGdsb2Jh bCBjb29yZGluYXRlcwotICAgIHJlc3VsdC5nbG9iYWxYID0gbG9jYXRpb24ueDsKLSAgICByZXN1 bHQuZ2xvYmFsWSA9IGxvY2F0aW9uLnk7Ci0gICAgTlNQb2ludCB3aW5kb3dMb2NhbCA9IFtldmVu dCBsb2NhdGlvbkluV2luZG93XTsKLSAgICBsb2NhdGlvbiA9IFt2aWV3IGNvbnZlcnRQb2ludDp3 aW5kb3dMb2NhbCBmcm9tVmlldzpuaWxdOwotICAgIHJlc3VsdC54ID0gbG9jYXRpb24ueDsKLSAg ICByZXN1bHQueSA9IFt2aWV3IGZyYW1lXS5zaXplLmhlaWdodCAtIGxvY2F0aW9uLnk7ICAvLyBm bGlwIHkKLSAgICByZXN1bHQud2luZG93WCA9IHJlc3VsdC54OwotICAgIHJlc3VsdC53aW5kb3dZ ID0gcmVzdWx0Lnk7CisgICAgc2V0V2ViRXZlbnRMb2NhdGlvbkZyb21FdmVudEluVmlldygmcmVz dWx0LCBldmVudCwgdmlldyk7CiAKICAgICAvLyBPZiBNaWNlIGFuZCBNZW4KICAgICAvLyAtLS0t LS0tLS0tLS0tLS0K