35946 2010-03-09 15:04:01 -0800 [chromium] Fix memory leak in WebImageDecoder API 2010-03-12 08:36:52 -0800 1 1 1 Unclassified WebKit WebKit API 528+ (Nightly build) PC All RESOLVED FIXED P2 Normal --- 0 kkanetkar webkit-unassigned commit-queue darin dglazkov fishd yaar oldest_to_newest 197794 0 kkanetkar 2010-03-09 15:04:01 -0800 Fix getFrameAtIndex() that causes leak in WebImage. 197803 1 50356 kkanetkar 2010-03-09 15:18:38 -0800 Created attachment 50356 proposed fix 2-sided fix. Needs a downstream fix as well. 197829 2 50356 fishd 2010-03-09 16:04:00 -0800 Comment on attachment 50356 proposed fix r- for reasons discussed in person. (sorry folks if you are following at home, you'll just have to guess) 197838 3 dglazkov 2010-03-09 16:30:43 -0800 Was it the peanut butter? 198763 4 50535 kkanetkar 2010-03-11 14:01:29 -0800 Created attachment 50535 patch2 Thanks Darin, for the comments. 199070 5 50535 commit-queue 2010-03-12 08:36:47 -0800 Comment on attachment 50535 patch2 Clearing flags on attachment: 50535 Committed r55906: <http://trac.webkit.org/changeset/55906> 199071 6 commit-queue 2010-03-12 08:36:52 -0800 All reviewed patches have been landed. Closing bug. 50356 2010-03-09 15:18:38 -0800 2010-03-09 16:04:00 -0800 proposed fix valgrind-fix.txt text/plain 3729 kkanetkar SW5kZXg6IFdlYktpdC9jaHJvbWl1bS9zcmMvV2ViSW1hZ2VEZWNvZGVyLmNwcAo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBXZWJLaXQvY2hyb21pdW0vc3JjL1dlYkltYWdlRGVjb2Rlci5jcHAJKHJldmlzaW9uIDU1 NzM5KQorKysgV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJJbWFnZURlY29kZXIuY3BwCSh3b3JraW5n IGNvcHkpCkBAIC0zOCw2ICszOCwxNCBAQAogI2luY2x1ZGUgIldlYkltYWdlLmgiCiAjaW5jbHVk ZSAiV2ViU2l6ZS5oIgogCisjaWYgV0VCS0lUX1VTSU5HX1NLSUEKKyNpbmNsdWRlIDx3dGYvT3du UHRyLmg+CisjaW5jbHVkZSA8d3RmL1Bhc3NSZWZQdHIuaD4KKyNlbGlmIFdFQktJVF9VU0lOR19D RworI2luY2x1ZGUgPENvcmVHcmFwaGljcy9DR0ltYWdlLmg+CisjaW5jbHVkZSA8d3RmL1JldGFp blB0ci5oPgorI2VuZGlmCisKIHVzaW5nIG5hbWVzcGFjZSBXZWJDb3JlOwogCiBuYW1lc3BhY2Ug V2ViS2l0IHsKQEAgLTQ5LDYgKzU3LDcgQEAKIAogdm9pZCBXZWJJbWFnZURlY29kZXI6OmluaXQo VHlwZSB0eXBlKQogeworICAgIG1fZGF0YSA9IDA7CiAgICAgc3dpdGNoICh0eXBlKSB7CiAgICAg Y2FzZSBUeXBlQk1QOgogICAgICAgICBtX3ByaXZhdGUgPSBuZXcgQk1QSW1hZ2VEZWNvZGVyKCk7 CkBAIC01OSwxMSArNjgsMTIgQEAKICAgICB9CiB9CiAKLXZvaWQgV2ViSW1hZ2VEZWNvZGVyOjpz ZXREYXRhKGNvbnN0IFdlYkRhdGEmIGRhdGEsIGJvb2wgYWxsRGF0YVJlY2VpdmVkKQordm9pZCBX ZWJJbWFnZURlY29kZXI6OnNldERhdGEoY29uc3QgV2ViRGF0YSogZGF0YSwgYm9vbCBhbGxEYXRh UmVjZWl2ZWQpCiB7CiAgICAgQVNTRVJUKG1fcHJpdmF0ZSk7Ci0gICAgUmVmUHRyPFNoYXJlZEJ1 ZmZlcj4gYnVmZmVyKFNoYXJlZEJ1ZmZlcjo6Y3JlYXRlKGRhdGEuZGF0YSgpLCBkYXRhLnNpemUo KSkpOworICAgIFJlZlB0cjxTaGFyZWRCdWZmZXI+IGJ1ZmZlcihTaGFyZWRCdWZmZXI6OmNyZWF0 ZShkYXRhLT5kYXRhKCksIGRhdGEtPnNpemUoKSkpOwogICAgIG1fcHJpdmF0ZS0+c2V0RGF0YShi dWZmZXIuZ2V0KCksIGFsbERhdGFSZWNlaXZlZCk7CisgICAgbV9kYXRhID0gZGF0YTsKIH0KIAog Ym9vbCBXZWJJbWFnZURlY29kZXI6OmlzRmFpbGVkKCkgY29uc3QKQEAgLTEwMiwxMyArMTEyLDIz IEBACiBXZWJJbWFnZSBXZWJJbWFnZURlY29kZXI6OmdldEZyYW1lQXRJbmRleChpbnQgaW5kZXgg PSAwKSBjb25zdAogewogICAgIEFTU0VSVChtX3ByaXZhdGUpOwotICAgIFJHQkEzMkJ1ZmZlciog Y29uc3QgZnJhbWVCdWZmZXIgPSBtX3ByaXZhdGUtPmZyYW1lQnVmZmVyQXRJbmRleChpbmRleCk7 Ci0gICAgaWYgKCFmcmFtZUJ1ZmZlcikKKyAgICBJbWFnZVNvdXJjZSBzb3VyY2U7CisgICAgc291 cmNlLnNldERhdGEoUGFzc1JlZlB0cjxTaGFyZWRCdWZmZXI+KCptX2RhdGEpLmdldCgpLCB0cnVl KTsKKyAgICBpZiAoIXNvdXJjZS5pc1NpemVBdmFpbGFibGUoKSkKICAgICAgICAgcmV0dXJuIFdl YkltYWdlKCk7CisKICNpZiBXRUJLSVRfVVNJTkdfU0tJQQotICAgIHJldHVybiBXZWJJbWFnZSgq KGZyYW1lQnVmZmVyLT5hc05ld05hdGl2ZUltYWdlKCkpKTsKKyAgICBPd25QdHI8TmF0aXZlSW1h Z2VTa2lhPiBmcmFtZShzb3VyY2UuY3JlYXRlRnJhbWVBdEluZGV4KGluZGV4KSk7CisgICAgaWYg KCFmcmFtZS5nZXQoKSkKKyAgICAgICAgcmV0dXJuIFdlYkltYWdlKCk7CisKKyAgICByZXR1cm4g V2ViSW1hZ2UoKmZyYW1lKTsKICNlbGlmIFdFQktJVF9VU0lOR19DRwotICAgIHJldHVybiBXZWJJ bWFnZShmcmFtZUJ1ZmZlci0+YXNOZXdOYXRpdmVJbWFnZSgpKTsKKyAgICBSZXRhaW5QdHI8Q0dJ bWFnZVJlZj4gZnJhbWUwKEFkb3B0Q0YsIHNvdXJjZS5jcmVhdGVGcmFtZUF0SW5kZXgoMCkpOwor ICAgIGlmICghZnJhbWUwKQorICAgICAgICByZXR1cm4gV2ViSW1hZ2UoKTsKKworICAgIHJldHVy biBXZWJJbWFnZShmcmFtZTAuZ2V0KCkpOwogI2VuZGlmCiB9CiAKSW5kZXg6IFdlYktpdC9jaHJv bWl1bS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwko cmV2aXNpb24gNTU3NTApCisrKyBXZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCSh3b3JraW5nIGNv cHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTAtMDMtMDkgIEthdml0YSBLYW5ldGthciAgPGtrYW5l dGthckBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgRml4IG1lbW9yeSBsZWFrIGluIFdlYkltYWdlRGVjb2RlciBBUEkKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM1OTQ2CisKKyAgICAg ICAgKiBwdWJsaWMvV2ViSW1hZ2VEZWNvZGVyLmg6IE5lZWQgdG8ga2VlcCBoYW5kbGUgdG8gZGF0 YSBwb2ludGUsIHNpbmNlIHRoZXJlIGlzIG5vIGdldERhdGEoKSBvbiBXZWJDb3JlOjpJbWFnZWRl Y29kZXIoKS4KKyAgICAgICAgKiBzcmMvV2ViSW1hZ2VEZWNvZGVyLmNwcDogQWRkZWQgY29kZSBz aW1pbGFyIHRvIFdlYkltYWdlQ0cvV2ViSW1hZ2VTa2lhLmNwcC4KKyAgICAgICAgKFdlYktpdDo6 V2ViSW1hZ2VEZWNvZGVyOjppbml0KToKKyAgICAgICAgKFdlYktpdDo6V2ViSW1hZ2VEZWNvZGVy OjpzZXREYXRhKTogCisgICAgICAgIChXZWJLaXQ6OldlYkltYWdlRGVjb2Rlcjo6Z2V0RnJhbWVB dEluZGV4KToKKwogMjAxMC0wMy0wOSAgQW50b24gTXVoaW4gIDxhbnRvbm1AY2hyb21pdW0ub3Jn PgogCiAgICAgICAgIFJldmlld2VkIGJ5IERhcmluIEZpc2hlci4KSW5kZXg6IFdlYktpdC9jaHJv bWl1bS9wdWJsaWMvV2ViSW1hZ2VEZWNvZGVyLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L2Nocm9t aXVtL3B1YmxpYy9XZWJJbWFnZURlY29kZXIuaAkocmV2aXNpb24gNTU3MzkpCisrKyBXZWJLaXQv Y2hyb21pdW0vcHVibGljL1dlYkltYWdlRGVjb2Rlci5oCSh3b3JraW5nIGNvcHkpCkBAIC01NSw3 ICs1NSw3IEBACiAKICAgICAvLyBTZXRzIGRhdGEgY29udGVudHMgZm9yIHVuZGVybHlpbmcgZGVj b2Rlci4gQWxsIHRoZSBBUEkgbWV0aG9kcwogICAgIC8vIHJlcXVpcmUgdGhhdCBzZXREYXRhKCkg aXMgY2FsbGVkIHByaW9yIHRvIHRoZWlyIHVzZS4KLSAgICBXRUJLSVRfQVBJIHZvaWQgc2V0RGF0 YShjb25zdCBXZWJEYXRhJiBkYXRhLCBib29sIGFsbERhdGFSZWNlaXZlZCk7CisgICAgV0VCS0lU X0FQSSB2b2lkIHNldERhdGEoY29uc3QgV2ViRGF0YSogZGF0YSwgYm9vbCBhbGxEYXRhUmVjZWl2 ZWQpOwogCiAgICAgLy8gRGVsZXRlcyBvd25lZCBkZWNvZGVyLgogICAgIFdFQktJVF9BUEkgdm9p ZCByZXNldCgpOwpAQCAtODMsNiArODMsOSBAQAogICAgIFdFQktJVF9BUEkgdm9pZCBpbml0KFR5 cGUgdHlwZSk7CiAKICAgICBXZWJJbWFnZURlY29kZXJQcml2YXRlKiBtX3ByaXZhdGU7CisKKyAg ICAvLyBIb2xkcyBhIHBvaW50ZXIgdG8gdW5kZXJseWluZyBpbWFnZSBkYXRhIGJ1ZmZlciAodXNl ZCBmb3IgZ2V0RnJhbWVBdEluZGV4KS4KKyAgICBjb25zdCBXZWJEYXRhKiBtX2RhdGE7CiB9Owog CiB9IC8vIG5hbWVzcGFjZSBXZWJLaXQK 50535 2010-03-11 14:01:29 -0800 2010-03-12 08:36:47 -0800 patch2 leak-fix.txt text/plain 2739 kkanetkar SW5kZXg6IFdlYktpdC9jaHJvbWl1bS9zcmMvV2ViSW1hZ2VEZWNvZGVyLmNwcAo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBXZWJLaXQvY2hyb21pdW0vc3JjL1dlYkltYWdlRGVjb2Rlci5jcHAJKHJldmlzaW9uIDU1 NzM5KQorKysgV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJJbWFnZURlY29kZXIuY3BwCSh3b3JraW5n IGNvcHkpCkBAIC0xLDEwICsxLDEwIEBACiAvKgogICogQ29weXJpZ2h0IChDKSAyMDEwIEdvb2ds ZSBJbmMuIEFsbCByaWdodHMgcmVzZXJ2ZWQuCi0gKiAKKyAqCiAgKiBSZWRpc3RyaWJ1dGlvbiBh bmQgdXNlIGluIHNvdXJjZSBhbmQgYmluYXJ5IGZvcm1zLCB3aXRoIG9yIHdpdGhvdXQKICAqIG1v ZGlmaWNhdGlvbiwgYXJlIHBlcm1pdHRlZCBwcm92aWRlZCB0aGF0IHRoZSBmb2xsb3dpbmcgY29u ZGl0aW9ucyBhcmUKICAqIG1ldDoKLSAqIAorICoKICAqICAgICAqIFJlZGlzdHJpYnV0aW9ucyBv ZiBzb3VyY2UgY29kZSBtdXN0IHJldGFpbiB0aGUgYWJvdmUgY29weXJpZ2h0CiAgKiBub3RpY2Us IHRoaXMgbGlzdCBvZiBjb25kaXRpb25zIGFuZCB0aGUgZm9sbG93aW5nIGRpc2NsYWltZXIuCiAg KiAgICAgKiBSZWRpc3RyaWJ1dGlvbnMgaW4gYmluYXJ5IGZvcm0gbXVzdCByZXByb2R1Y2UgdGhl IGFib3ZlCkBAIC0xNCw3ICsxNCw3IEBACiAgKiAgICAgKiBOZWl0aGVyIHRoZSBuYW1lIG9mIEdv b2dsZSBJbmMuIG5vciB0aGUgbmFtZXMgb2YgaXRzCiAgKiBjb250cmlidXRvcnMgbWF5IGJlIHVz ZWQgdG8gZW5kb3JzZSBvciBwcm9tb3RlIHByb2R1Y3RzIGRlcml2ZWQgZnJvbQogICogdGhpcyBz b2Z0d2FyZSB3aXRob3V0IHNwZWNpZmljIHByaW9yIHdyaXR0ZW4gcGVybWlzc2lvbi4KLSAqIAor ICoKICAqIFRISVMgU09GVFdBUkUgSVMgUFJPVklERUQgQlkgVEhFIENPUFlSSUdIVCBIT0xERVJT IEFORCBDT05UUklCVVRPUlMKICAqICJBUyBJUyIgQU5EIEFOWSBFWFBSRVNTIE9SIElNUExJRUQg V0FSUkFOVElFUywgSU5DTFVESU5HLCBCVVQgTk9UCiAgKiBMSU1JVEVEIFRPLCBUSEUgSU1QTElF RCBXQVJSQU5USUVTIE9GIE1FUkNIQU5UQUJJTElUWSBBTkQgRklUTkVTUyBGT1IKQEAgLTM4LDYg KzM4LDExIEBACiAjaW5jbHVkZSAiV2ViSW1hZ2UuaCIKICNpbmNsdWRlICJXZWJTaXplLmgiCiAK KyNpZiBXRUJLSVRfVVNJTkdfU0tJQQorI2luY2x1ZGUgPHd0Zi9Pd25QdHIuaD4KKyNpbmNsdWRl IDx3dGYvUGFzc1JlZlB0ci5oPgorI2VuZGlmCisKIHVzaW5nIG5hbWVzcGFjZSBXZWJDb3JlOwog CiBuYW1lc3BhY2UgV2ViS2l0IHsKQEAgLTYyLDggKzY3LDcgQEAKIHZvaWQgV2ViSW1hZ2VEZWNv ZGVyOjpzZXREYXRhKGNvbnN0IFdlYkRhdGEmIGRhdGEsIGJvb2wgYWxsRGF0YVJlY2VpdmVkKQog ewogICAgIEFTU0VSVChtX3ByaXZhdGUpOwotICAgIFJlZlB0cjxTaGFyZWRCdWZmZXI+IGJ1ZmZl cihTaGFyZWRCdWZmZXI6OmNyZWF0ZShkYXRhLmRhdGEoKSwgZGF0YS5zaXplKCkpKTsKLSAgICBt X3ByaXZhdGUtPnNldERhdGEoYnVmZmVyLmdldCgpLCBhbGxEYXRhUmVjZWl2ZWQpOworICAgIG1f cHJpdmF0ZS0+c2V0RGF0YShQYXNzUmVmUHRyPFNoYXJlZEJ1ZmZlcj4oZGF0YSkuZ2V0KCksIGFs bERhdGFSZWNlaXZlZCk7CiB9CiAKIGJvb2wgV2ViSW1hZ2VEZWNvZGVyOjppc0ZhaWxlZCgpIGNv bnN0CkBAIC0xMDYsOCArMTEwLDEwIEBACiAgICAgaWYgKCFmcmFtZUJ1ZmZlcikKICAgICAgICAg cmV0dXJuIFdlYkltYWdlKCk7CiAjaWYgV0VCS0lUX1VTSU5HX1NLSUEKLSAgICByZXR1cm4gV2Vi SW1hZ2UoKihmcmFtZUJ1ZmZlci0+YXNOZXdOYXRpdmVJbWFnZSgpKSk7CisgICAgT3duUHRyPE5h dGl2ZUltYWdlU2tpYT5pbWFnZShmcmFtZUJ1ZmZlci0+YXNOZXdOYXRpdmVJbWFnZSgpKTsKKyAg ICByZXR1cm4gV2ViSW1hZ2UoKmltYWdlKTsKICNlbGlmIFdFQktJVF9VU0lOR19DRworICAgIC8v IEZJWE1FOiBJbXBsZW1lbnQgQ0cgc2lkZSBvZiB0aGlzLgogICAgIHJldHVybiBXZWJJbWFnZShm cmFtZUJ1ZmZlci0+YXNOZXdOYXRpdmVJbWFnZSgpKTsKICNlbmRpZgogfQpJbmRleDogV2ViS2l0 L2Nocm9taXVtL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXQvY2hyb21pdW0vQ2hhbmdl TG9nCShyZXZpc2lvbiA1NTg1NCkKKysrIFdlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cJKHdvcmtp bmcgY29weSkKQEAgLTEsMyArMSwxNCBAQAorMjAxMC0wMy0xMSAgS2F2aXRhIEthbmV0a2FyICA8 a2thbmV0a2FyQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBbY2hyb21pdW1dIEZpeCBtZW1vcnkgbGVhayBpbiBXZWJJbWFnZURl Y29kZXIgQVBJCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0zNTk0NgorCisgICAgICAgICogc3JjL1dlYkltYWdlRGVjb2Rlci5jcHA6CisgICAgICAgIChX ZWJLaXQ6OldlYkltYWdlRGVjb2Rlcjo6c2V0RGF0YSk6CisgICAgICAgIChXZWJLaXQ6OldlYklt YWdlRGVjb2Rlcjo6Z2V0RnJhbWVBdEluZGV4KToKKwogMjAxMC0wMy0xMCAgRGFyaW4gRmlzaGVy ICA8ZGFyaW5AY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEplcmVteSBPcmxv dy4K