35940 2010-03-09 12:59:36 -0800 Remove unused SPI in WebPluginController.mm 2010-03-12 07:45:35 -0800 1 1 1 Unclassified WebKit WebKit API 528+ (Nightly build) Mac OS X 10.5 RESOLVED FIXED P2 Normal --- 1 beidson aestes aestes commit-queue oldest_to_newest 197730 0 beidson 2010-03-09 12:59:36 -0800 In WebPluginController.mm, I noticed: // For compatibility only. - (void)showURL:(NSURL *)URL inFrame:(NSString *)target { ... } I did some digging, and this method was left around to support an ANCIENT version of the java plug-in and is no longer needed. We should nuke it. 197744 1 beidson 2010-03-09 13:25:53 -0800 http://trac.webkit.org/changeset/55742 197745 2 beidson 2010-03-09 13:26:10 -0800 (In reply to comment #1) > http://trac.webkit.org/changeset/55742 Disregard, put this in the wrong bug. 198687 3 50518 aestes 2010-03-11 11:20:14 -0800 Created attachment 50518 Patch 198707 4 50518 beidson 2010-03-11 11:44:41 -0800 Comment on attachment 50518 Patch r+ 198710 5 50518 beidson 2010-03-11 11:51:07 -0800 Comment on attachment 50518 Patch Actually to be a stickler - you should mention this bug in the ChangeLog. 198711 6 beidson 2010-03-11 11:51:26 -0800 (changed to r-) 198714 7 50523 aestes 2010-03-11 11:54:50 -0800 Created attachment 50523 Patch (v2) 198717 8 50525 aestes 2010-03-11 11:56:00 -0800 Created attachment 50525 Patch (v3) Tabs! 198721 9 50525 beidson 2010-03-11 11:59:09 -0800 Comment on attachment 50525 Patch (v3) r+ 199049 10 50525 commit-queue 2010-03-12 07:45:31 -0800 Comment on attachment 50525 Patch (v3) Clearing flags on attachment: 50525 Committed r55901: <http://trac.webkit.org/changeset/55901> 199050 11 commit-queue 2010-03-12 07:45:35 -0800 All reviewed patches have been landed. Closing bug. 50518 2010-03-11 11:20:14 -0800 2010-03-11 11:54:50 -0800 Patch 35940.patch text/plain 1095 aestes SW5kZXg6IFdlYktpdC9tYWMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdC9tYWMvQ2hh bmdlTG9nCShyZXZpc2lvbiA1NTg0NykKKysrIFdlYktpdC9tYWMvQ2hhbmdlTG9nCSh3b3JraW5n IGNvcHkpCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTAtMDMtMTEgIEFuZHkgRXN0ZXMgIDxhZXN0ZXNA YXBwbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIFJlbW92ZSBhbiB1bnVzZWQgbWV0aG9kLgorCisgICAgICAgICogUGx1Z2lucy9XZWJQbHVn aW5Db250cm9sbGVyLm1tOgorICAgICAgICByZW1vdmVkIC0gKHZvaWQpc2hvd1VSTDooTlNVUkwg KikgaW5GcmFtZTooTlNTdHJpbmcgKikKKwogMjAxMC0wMy0xMCAgU2ltb24gRnJhc2VyICA8c2lt b24uZnJhc2VyQGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBEYXJpbiBBZGxlci4K SW5kZXg6IFdlYktpdC9tYWMvUGx1Z2lucy9XZWJQbHVnaW5Db250cm9sbGVyLm1tCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIFdlYktpdC9tYWMvUGx1Z2lucy9XZWJQbHVnaW5Db250cm9sbGVyLm1tCShyZXZpc2lv biA1NTgzMSkKKysrIFdlYktpdC9tYWMvUGx1Z2lucy9XZWJQbHVnaW5Db250cm9sbGVyLm1tCSh3 b3JraW5nIGNvcHkpCkBAIC0zNTEsMTIgKzM1MSw2IEBAIC0gKHZvaWQpd2ViUGx1Z0luQ29udGFp bmVyTG9hZFJlcXVlc3Q6KE4KICAgICB9CiB9CiAKLS8vIEZvciBjb21wYXRpYmlsaXR5IG9ubHku Ci0tICh2b2lkKXNob3dVUkw6KE5TVVJMICopVVJMIGluRnJhbWU6KE5TU3RyaW5nICopdGFyZ2V0 Ci17Ci0gICAgW3NlbGYgd2ViUGx1Z0luQ29udGFpbmVyTG9hZFJlcXVlc3Q6W05TVVJMUmVxdWVz dCByZXF1ZXN0V2l0aFVSTDpVUkxdIGluRnJhbWU6dGFyZ2V0XTsKLX0KLQogLSAodm9pZCl3ZWJQ bHVnSW5Db250YWluZXJTaG93U3RhdHVzOihOU1N0cmluZyAqKW1lc3NhZ2UKIHsKICAgICBpZiAo IW1lc3NhZ2UpIHsK 50523 2010-03-11 11:54:50 -0800 2010-03-11 11:56:00 -0800 Patch (v2) 35940.patch text/plain 1146 aestes SW5kZXg6IFdlYktpdC9tYWMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdC9tYWMvQ2hh bmdlTG9nCShyZXZpc2lvbiA1NTg0NykKKysrIFdlYktpdC9tYWMvQ2hhbmdlTG9nCSh3b3JraW5n IGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTAtMDMtMTEgIEFuZHkgRXN0ZXMgIDxhZXN0ZXNA YXBwbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIFJlbW92ZSBhbiB1bnVzZWQgbWV0aG9kLgorCisJCWh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0zNTk0MAorCisgICAgICAgICogUGx1Z2lucy9XZWJQbHVnaW5Db250 cm9sbGVyLm1tOgorICAgICAgICByZW1vdmVkIC0gKHZvaWQpc2hvd1VSTDooTlNVUkwgKikgaW5G cmFtZTooTlNTdHJpbmcgKikKKwogMjAxMC0wMy0xMCAgU2ltb24gRnJhc2VyICA8c2ltb24uZnJh c2VyQGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBEYXJpbiBBZGxlci4KSW5kZXg6 IFdlYktpdC9tYWMvUGx1Z2lucy9XZWJQbHVnaW5Db250cm9sbGVyLm1tCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IFdlYktpdC9tYWMvUGx1Z2lucy9XZWJQbHVnaW5Db250cm9sbGVyLm1tCShyZXZpc2lvbiA1NTgz MSkKKysrIFdlYktpdC9tYWMvUGx1Z2lucy9XZWJQbHVnaW5Db250cm9sbGVyLm1tCSh3b3JraW5n IGNvcHkpCkBAIC0zNTEsMTIgKzM1MSw2IEBAIC0gKHZvaWQpd2ViUGx1Z0luQ29udGFpbmVyTG9h ZFJlcXVlc3Q6KE4KICAgICB9CiB9CiAKLS8vIEZvciBjb21wYXRpYmlsaXR5IG9ubHkuCi0tICh2 b2lkKXNob3dVUkw6KE5TVVJMICopVVJMIGluRnJhbWU6KE5TU3RyaW5nICopdGFyZ2V0Ci17Ci0g ICAgW3NlbGYgd2ViUGx1Z0luQ29udGFpbmVyTG9hZFJlcXVlc3Q6W05TVVJMUmVxdWVzdCByZXF1 ZXN0V2l0aFVSTDpVUkxdIGluRnJhbWU6dGFyZ2V0XTsKLX0KLQogLSAodm9pZCl3ZWJQbHVnSW5D b250YWluZXJTaG93U3RhdHVzOihOU1N0cmluZyAqKW1lc3NhZ2UKIHsKICAgICBpZiAoIW1lc3Nh Z2UpIHsK 50525 2010-03-11 11:56:00 -0800 2010-03-12 07:45:30 -0800 Patch (v3) 35940.patch text/plain 1152 aestes SW5kZXg6IFdlYktpdC9tYWMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdC9tYWMvQ2hh bmdlTG9nCShyZXZpc2lvbiA1NTg0NykKKysrIFdlYktpdC9tYWMvQ2hhbmdlTG9nCSh3b3JraW5n IGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTAtMDMtMTEgIEFuZHkgRXN0ZXMgIDxhZXN0ZXNA YXBwbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIFJlbW92ZSBhbiB1bnVzZWQgbWV0aG9kLgorCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zNTk0MAorCisgICAgICAgICogUGx1Z2lucy9XZWJQbHVn aW5Db250cm9sbGVyLm1tOgorICAgICAgICByZW1vdmVkIC0gKHZvaWQpc2hvd1VSTDooTlNVUkwg KikgaW5GcmFtZTooTlNTdHJpbmcgKikKKwogMjAxMC0wMy0xMCAgU2ltb24gRnJhc2VyICA8c2lt b24uZnJhc2VyQGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBEYXJpbiBBZGxlci4K SW5kZXg6IFdlYktpdC9tYWMvUGx1Z2lucy9XZWJQbHVnaW5Db250cm9sbGVyLm1tCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIFdlYktpdC9tYWMvUGx1Z2lucy9XZWJQbHVnaW5Db250cm9sbGVyLm1tCShyZXZpc2lv biA1NTgzMSkKKysrIFdlYktpdC9tYWMvUGx1Z2lucy9XZWJQbHVnaW5Db250cm9sbGVyLm1tCSh3 b3JraW5nIGNvcHkpCkBAIC0zNTEsMTIgKzM1MSw2IEBAIC0gKHZvaWQpd2ViUGx1Z0luQ29udGFp bmVyTG9hZFJlcXVlc3Q6KE4KICAgICB9CiB9CiAKLS8vIEZvciBjb21wYXRpYmlsaXR5IG9ubHku Ci0tICh2b2lkKXNob3dVUkw6KE5TVVJMICopVVJMIGluRnJhbWU6KE5TU3RyaW5nICopdGFyZ2V0 Ci17Ci0gICAgW3NlbGYgd2ViUGx1Z0luQ29udGFpbmVyTG9hZFJlcXVlc3Q6W05TVVJMUmVxdWVz dCByZXF1ZXN0V2l0aFVSTDpVUkxdIGluRnJhbWU6dGFyZ2V0XTsKLX0KLQogLSAodm9pZCl3ZWJQ bHVnSW5Db250YWluZXJTaG93U3RhdHVzOihOU1N0cmluZyAqKW1lc3NhZ2UKIHsKICAgICBpZiAo IW1lc3NhZ2UpIHsK