35933 2010-03-09 11:20:37 -0800 [Qt] [Symbian] Can not backward select (highlight) text using virtual keyboard 2010-03-29 04:02:58 -0700 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) S60 Hardware S60 3rd edition RESOLVED FIXED PlatformOnly, Qt P2 Normal --- 1 shenyi2006 shenyi2006 commit-queue hausmann laszlo.gombos shenyi2006 oldest_to_newest 197681 0 shenyi2006 2010-03-09 11:20:37 -0800 By using the virtual keyboard on a symbian device, the user can not select texts from right to left (the cursor position is before the anchor position); 197699 1 50334 shenyi2006 2010-03-09 11:37:45 -0800 Created attachment 50334 proposal fix for bug 35933 197709 2 shenyi2006 2010-03-09 11:55:19 -0800 This issue is Qt only, and the root cause is that webcore assumes the selection's start position is always before the end position. In RenderTextControl.cpp; void RenderTextControl::setSelectionEnd(int end) { setSelectionRange(min(end, selectionStart()), end); } The setSelectionEnd(int) function was called from QWebPagePrivate::inputMethodEvent(QInputMethodEvent*) at qwebpage.cpp case QInputMethodEvent::Selection: { if (renderTextControl) { renderTextControl->setSelectionStart(a.start); renderTextControl->setSelectionEnd(a.start + a.length); } break; } However, in above code, the a.length, which is from QcoeFepInputContext, is negative when doing backward selection: void QCoeFepInputContext::SetCursorSelectionForFepL(const TCursorSelection&) { int pos = aCursorSelection.iAnchorPos; int length = aCursorSelection.iCursorPos - pos; QList<QInputMethodEvent::Attribute> attributes; attributes << QInputMethodEvent::Attribute(QInputMethodEvent::Selection, pos, length, QVariant()); } It can explain why the backward selection doesn't work, that is, when start position is larger than end position, setSelectionRange(min(end, selectionStart()), end); equals setSelectionRange(end, end); The patch I attached would check/adjust the start & end position before calling the setSelectionStart & setSelectionEnd. I have tested it on both s60 emulator & target. 200197 3 50795 shenyi2006 2010-03-16 08:20:20 -0700 Created attachment 50795 proposal patch 200315 4 50812 shenyi2006 2010-03-16 11:20:07 -0700 Created attachment 50812 patch for bug35933 201774 5 50812 hausmann 2010-03-19 00:57:27 -0700 Comment on attachment 50812 patch for bug35933 I think the patch is fine, but please make a unit test for this. See the inputMethods() unit tests in WebKit/qt/tests/qwebpage. You could test this by sending a synthetic input method event with a selection set. After sending the event you could verify that the selection is set correctly. 201868 6 51157 shenyi2006 2010-03-19 08:54:21 -0700 Created attachment 51157 new patch with the unit test The new patch contains the unit test for qwebpage. 202491 7 51157 commit-queue 2010-03-22 08:10:04 -0700 Comment on attachment 51157 new patch with the unit test Clearing flags on attachment: 51157 Committed r56334: <http://trac.webkit.org/changeset/56334> 202492 8 commit-queue 2010-03-22 08:10:09 -0700 All reviewed patches have been landed. Closing bug. 205391 9 hausmann 2010-03-29 04:02:58 -0700 Cherry-picked into qtwebkit-4.6 with commit edc778e0b452640d8e05c4a88903c18b6afe20ec 50334 2010-03-09 11:37:45 -0800 2010-03-16 08:20:20 -0700 proposal fix for bug 35933 bug35933.patch text/plain 783 shenyi2006 SW5kZXg6IHF3ZWJwYWdlLmNwcA0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQ0KLS0tIHF3ZWJwYWdlLmNwcAkocmV2aXNp b24gNTU3MzYpDQorKysgcXdlYnBhZ2UuY3BwCSh3b3JraW5nIGNvcHkpDQpAQCAtMTMxMSw4ICsx MzExLDEwIEBADQogI2lmIFFUX1ZFUlNJT04gPj0gMHgwNDA2MDAKICAgICAgICAgY2FzZSBRSW5w dXRNZXRob2RFdmVudDo6U2VsZWN0aW9uOiB7CiAgICAgICAgICAgICBpZiAocmVuZGVyVGV4dENv bnRyb2wpIHsKLSAgICAgICAgICAgICAgICByZW5kZXJUZXh0Q29udHJvbC0+c2V0U2VsZWN0aW9u U3RhcnQoYS5zdGFydCk7Ci0gICAgICAgICAgICAgICAgcmVuZGVyVGV4dENvbnRyb2wtPnNldFNl bGVjdGlvbkVuZChhLnN0YXJ0ICsgYS5sZW5ndGgpOworICAgICAgICAgICAgICAgIGludCBzdGFy dCA9IGEuc3RhcnQgPCAoYS5zdGFydCArIGEubGVuZ3RoKSA/IGEuc3RhcnQgOiAoYS5zdGFydCAr IGEubGVuZ3RoKTsKKyAgICAgICAgICAgICAgICBpbnQgZW5kID0gYS5zdGFydCA8IChhLnN0YXJ0 ICsgYS5sZW5ndGgpID8gKGEuc3RhcnQgKyBhLmxlbmd0aCkgOiBhLnN0YXJ0OworICAgICAgICAg ICAgICAgIHJlbmRlclRleHRDb250cm9sLT5zZXRTZWxlY3Rpb25TdGFydChzdGFydCk7CisgICAg ICAgICAgICAgICAgcmVuZGVyVGV4dENvbnRyb2wtPnNldFNlbGVjdGlvbkVuZChlbmQpOwogICAg ICAgICAgICAgfQogICAgICAgICAgICAgYnJlYWs7CiAgICAgICAgIH0K 50795 2010-03-16 08:20:20 -0700 2010-03-16 11:20:07 -0700 proposal patch 35933.patch text/plain 658 shenyi2006 SW5kZXg6IHF3ZWJwYWdlLmNwcA0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQ0KLS0tIHF3ZWJwYWdlLmNwcAkocmV2aXNp b24gNTYwNjEpDQorKysgcXdlYnBhZ2UuY3BwCSh3b3JraW5nIGNvcHkpDQpAQCAtMTMxNiw4ICsx MzE2LDggQEANCiAjaWYgUVRfVkVSU0lPTiA+PSAweDA0MDYwMAogICAgICAgICBjYXNlIFFJbnB1 dE1ldGhvZEV2ZW50OjpTZWxlY3Rpb246IHsKICAgICAgICAgICAgIGlmIChyZW5kZXJUZXh0Q29u dHJvbCkgewotICAgICAgICAgICAgICAgIHJlbmRlclRleHRDb250cm9sLT5zZXRTZWxlY3Rpb25T dGFydChhLnN0YXJ0KTsKLSAgICAgICAgICAgICAgICByZW5kZXJUZXh0Q29udHJvbC0+c2V0U2Vs ZWN0aW9uRW5kKGEuc3RhcnQgKyBhLmxlbmd0aCk7CisgICAgICAgICAgICAgICAgcmVuZGVyVGV4 dENvbnRyb2wtPnNldFNlbGVjdGlvblN0YXJ0KHFNaW4oYS5zdGFydCwgKGEuc3RhcnQgKyBhLmxl bmd0aCkpKTsKKyAgICAgICAgICAgICAgICByZW5kZXJUZXh0Q29udHJvbC0+c2V0U2VsZWN0aW9u RW5kKHFNYXgoYS5zdGFydCwgKGEuc3RhcnQgKyBhLmxlbmd0aCkpKTsKICAgICAgICAgICAgIH0K ICAgICAgICAgICAgIGJyZWFrOwogICAgICAgICB9Cg== 50812 2010-03-16 11:20:07 -0700 2010-03-19 08:54:21 -0700 patch for bug35933 bug35933.patch text/plain 1412 shenyi2006 SW5kZXg6IFdlYktpdC9xdC9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L3F0L0NoYW5n ZUxvZwkocmV2aXNpb24gNTYwNzIpCisrKyBXZWJLaXQvcXQvQ2hhbmdlTG9nCSh3b3JraW5nIGNv cHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTAtMDMtMTYgIFlpIFNoZW4gIDxzaGVueWkyMDA2QGdt YWlsLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzU5MzMgIAorICAgICAg ICBbUXRdIFtTeW1iaWFuXSBDYW4gbm90IGJhY2t3YXJkIHNlbGVjdCAoaGlnaGxpZ2h0KSB0ZXh0 IHVzaW5nIHZpcnR1YWwga2V5Ym9hcmQKKworICAgICAgICBNYWtlIHN1cmUgdGhlIHNlbGVjdGlv biBzdGFydCBpbmRleCBpcyBzbWFsbGVyIHRoYW4gdGhlIHNlbGVjdGlvbiBlbmQgaW5kZXguCisK KyAgICAgICAgKiBBcGkvcXdlYnBhZ2UuY3BwOgorICAgICAgICAoUVdlYlBhZ2VQcml2YXRlOjpp bnB1dE1ldGhvZEV2ZW50KToKKwogMjAxMC0wMy0xNSAgQW50dGkgS29pdmlzdG8gIDxrb2l2aXN0 b0Bpa2kuZmk+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgU2ltb24gSGF1c21hbm4uCkluZGV4OiBX ZWJLaXQvcXQvQXBpL3F3ZWJwYWdlLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXQvcXQvQXBpL3F3 ZWJwYWdlLmNwcAkocmV2aXNpb24gNTYwNjkpCisrKyBXZWJLaXQvcXQvQXBpL3F3ZWJwYWdlLmNw cAkod29ya2luZyBjb3B5KQpAQCAtMTMxNiw4ICsxMzE2LDggQEAgdm9pZCBRV2ViUGFnZVByaXZh dGU6OmlucHV0TWV0aG9kRXZlbnQoUQogI2lmIFFUX1ZFUlNJT04gPj0gMHgwNDA2MDAKICAgICAg ICAgY2FzZSBRSW5wdXRNZXRob2RFdmVudDo6U2VsZWN0aW9uOiB7CiAgICAgICAgICAgICBpZiAo cmVuZGVyVGV4dENvbnRyb2wpIHsKLSAgICAgICAgICAgICAgICByZW5kZXJUZXh0Q29udHJvbC0+ c2V0U2VsZWN0aW9uU3RhcnQoYS5zdGFydCk7Ci0gICAgICAgICAgICAgICAgcmVuZGVyVGV4dENv bnRyb2wtPnNldFNlbGVjdGlvbkVuZChhLnN0YXJ0ICsgYS5sZW5ndGgpOworICAgICAgICAgICAg ICAgIHJlbmRlclRleHRDb250cm9sLT5zZXRTZWxlY3Rpb25TdGFydChxTWluKGEuc3RhcnQsIChh LnN0YXJ0ICsgYS5sZW5ndGgpKSk7CisgICAgICAgICAgICAgICAgcmVuZGVyVGV4dENvbnRyb2wt PnNldFNlbGVjdGlvbkVuZChxTWF4KGEuc3RhcnQsIChhLnN0YXJ0ICsgYS5sZW5ndGgpKSk7CiAg ICAgICAgICAgICB9CiAgICAgICAgICAgICBicmVhazsKICAgICAgICAgfQo= 51157 2010-03-19 08:54:21 -0700 2010-03-22 08:10:04 -0700 new patch with the unit test bug35933.patch text/plain 2756 shenyi2006 SW5kZXg6IFdlYktpdC9xdC9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L3F0L0NoYW5n ZUxvZwkocmV2aXNpb24gNTYyNDApCisrKyBXZWJLaXQvcXQvQ2hhbmdlTG9nCSh3b3JraW5nIGNv cHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTAtMDMtMTkgIFlpIFNoZW4gIDxzaGVueWkyMDA2QGdt YWlsLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzU5MzMgIAorICAgICAg ICBbUXRdIFtTeW1iaWFuXSBDYW4gbm90IGJhY2t3YXJkIHNlbGVjdCAoaGlnaGxpZ2h0KSB0ZXh0 IHVzaW5nIHZpcnR1YWwga2V5Ym9hcmQKKyAgICAgICAgTWFrZSBzdXJlIHRoZSBzZWxlY3Rpb24g c3RhcnQgaW5kZXggaXMgc21hbGxlciB0aGFuIHRoZSBzZWxlY3Rpb24gZW5kIGluZGV4LgorCisg ICAgICAgICogQXBpL3F3ZWJwYWdlLmNwcDoKKyAgICAgICAgKFFXZWJQYWdlUHJpdmF0ZTo6aW5w dXRNZXRob2RFdmVudCk6CisgICAgICAgICogdGVzdHMvcXdlYnBhZ2UvdHN0X3F3ZWJwYWdlLmNw cDoKKyAgICAgICAgKHRzdF9RV2ViUGFnZTo6aW5wdXRNZXRob2RzKToKKwogMjAxMC0wMy0xOCAg S2VubmV0aCBSb2hkZSBDaHJpc3RpYW5zZW4gIDxrZW5uZXRoQHdlYmtpdC5vcmc+CiAKICAgICAg ICAgUmV2aWV3ZWQgYnkgRGFyaW4gQWRsZXIuCkluZGV4OiBXZWJLaXQvcXQvQXBpL3F3ZWJwYWdl LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXQvcXQvQXBpL3F3ZWJwYWdlLmNwcAkocmV2aXNpb24g NTYyMzYpCisrKyBXZWJLaXQvcXQvQXBpL3F3ZWJwYWdlLmNwcAkod29ya2luZyBjb3B5KQpAQCAt MTMxNiw4ICsxMzE2LDggQEAgdm9pZCBRV2ViUGFnZVByaXZhdGU6OmlucHV0TWV0aG9kRXZlbnQo UQogI2lmIFFUX1ZFUlNJT04gPj0gMHgwNDA2MDAKICAgICAgICAgY2FzZSBRSW5wdXRNZXRob2RF dmVudDo6U2VsZWN0aW9uOiB7CiAgICAgICAgICAgICBpZiAocmVuZGVyVGV4dENvbnRyb2wpIHsK LSAgICAgICAgICAgICAgICByZW5kZXJUZXh0Q29udHJvbC0+c2V0U2VsZWN0aW9uU3RhcnQoYS5z dGFydCk7Ci0gICAgICAgICAgICAgICAgcmVuZGVyVGV4dENvbnRyb2wtPnNldFNlbGVjdGlvbkVu ZChhLnN0YXJ0ICsgYS5sZW5ndGgpOworICAgICAgICAgICAgICAgIHJlbmRlclRleHRDb250cm9s LT5zZXRTZWxlY3Rpb25TdGFydChxTWluKGEuc3RhcnQsIChhLnN0YXJ0ICsgYS5sZW5ndGgpKSk7 CisgICAgICAgICAgICAgICAgcmVuZGVyVGV4dENvbnRyb2wtPnNldFNlbGVjdGlvbkVuZChxTWF4 KGEuc3RhcnQsIChhLnN0YXJ0ICsgYS5sZW5ndGgpKSk7CiAgICAgICAgICAgICB9CiAgICAgICAg ICAgICBicmVhazsKICAgICAgICAgfQpJbmRleDogV2ViS2l0L3F0L3Rlc3RzL3F3ZWJwYWdlL3Rz dF9xd2VicGFnZS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L3F0L3Rlc3RzL3F3ZWJwYWdlL3Rz dF9xd2VicGFnZS5jcHAJKHJldmlzaW9uIDU2MjM2KQorKysgV2ViS2l0L3F0L3Rlc3RzL3F3ZWJw YWdlL3RzdF9xd2VicGFnZS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTE0MDMsNiArMTQwMywyNiBA QCB2b2lkIHRzdF9RV2ViUGFnZTo6aW5wdXRNZXRob2RzKCkKICAgICB2YXJpYW50ID0gcGFnZS0+ aW5wdXRNZXRob2RRdWVyeShRdDo6SW1DdXJyZW50U2VsZWN0aW9uKTsKICAgICBRU3RyaW5nIHNl bGVjdGlvblZhbHVlID0gdmFyaWFudC52YWx1ZTxRU3RyaW5nPigpOwogICAgIFFDT01QQVJFKHNl bGVjdGlvblZhbHVlLCBRU3RyaW5nKCJlYiIpKTsKKworICAgIC8vU2V0IHNlbGVjdGlvbiB3aXRo IG5lZ2F0aXZlIGxlbmd0aAorICAgIGlucHV0QXR0cmlidXRlcyA8PCBRSW5wdXRNZXRob2RFdmVu dDo6QXR0cmlidXRlKFFJbnB1dE1ldGhvZEV2ZW50OjpTZWxlY3Rpb24sIDYsIC01LCBRVmFyaWFu dCgpKTsKKyAgICBRSW5wdXRNZXRob2RFdmVudCBldmVudFNlbGVjdGlvbjIoIiIsaW5wdXRBdHRy aWJ1dGVzKTsKKyAgICBwYWdlLT5ldmVudCgmZXZlbnRTZWxlY3Rpb24yKTsKKworICAgIC8vSW1B bmNob3JQb3NpdGlvbgorICAgIHZhcmlhbnQgPSBwYWdlLT5pbnB1dE1ldGhvZFF1ZXJ5KFF0OjpJ bUFuY2hvclBvc2l0aW9uKTsKKyAgICBhbmNob3JQb3NpdGlvbiA9ICB2YXJpYW50LnRvSW50KCk7 CisgICAgUUNPTVBBUkUoYW5jaG9yUG9zaXRpb24sIDEpOworCisgICAgLy9JbUN1cnNvclBvc2l0 aW9uCisgICAgdmFyaWFudCA9IHBhZ2UtPmlucHV0TWV0aG9kUXVlcnkoUXQ6OkltQ3Vyc29yUG9z aXRpb24pOworICAgIGN1cnNvclBvc2l0aW9uID0gIHZhcmlhbnQudG9JbnQoKTsKKyAgICBRQ09N UEFSRShjdXJzb3JQb3NpdGlvbiwgNik7CisKKyAgICAvL0ltQ3VycmVudFNlbGVjdGlvbgorICAg IHZhcmlhbnQgPSBwYWdlLT5pbnB1dE1ldGhvZFF1ZXJ5KFF0OjpJbUN1cnJlbnRTZWxlY3Rpb24p OworICAgIHNlbGVjdGlvblZhbHVlID0gdmFyaWFudC52YWx1ZTxRU3RyaW5nPigpOworICAgIFFD T01QQVJFKHNlbGVjdGlvblZhbHVlLCBRU3RyaW5nKCJ0V2ViSyIpKTsKICNlbmRpZgogCiAgICAg Ly9JbVN1cnJvdW5kaW5nVGV4dAo=