35926 2010-03-09 09:38:24 -0800 Web Inspector: Hangup when expanding elements with enormous text node content in Elements panel 2010-06-23 19:04:35 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED https://zlibdroidtest.appspot.com/ P2 Normal --- 1 apavlov apavlov abarth bweinstein commit-queue dglazkov enrica eric hyatt joepeck keishi pfeldman pmuellr rik timothy webkit.review.bot oldest_to_newest 197632 0 apavlov 2010-03-09 09:38:24 -0800 Steps to reproduce: 1. Visit https://zlibdroidtest.appspot.com/ 2. Bring up the Web Inspector 3. Try switching to the Elements panel A hangup occurs. Upstreaming http://code.google.com/p/chromium/issues/detail?id=31832 198008 1 50395 apavlov 2010-03-10 05:59:04 -0800 Created attachment 50395 [PATCH] Suggested solution 198010 2 webkit.review.bot 2010-03-10 06:02:00 -0800 Attachment 50395 did not build on chromium: Build output: http://webkit-commit-queue.appspot.com/results/530014 198011 3 webkit.review.bot 2010-03-10 06:02:55 -0800 Attachment 50395 did not build on qt: Build output: http://webkit-commit-queue.appspot.com/results/566018 198012 4 eric 2010-03-10 06:04:01 -0800 Attachment 50395 did not build on mac: Build output: http://webkit-commit-queue.appspot.com/results/578012 198019 5 50395 pfeldman 2010-03-10 06:11:58 -0800 Comment on attachment 50395 [PATCH] Suggested solution You are optimizing for the corner-case. Do you think it improves average case as well? (r- for bots failures). 198125 6 50403 apavlov 2010-03-10 07:30:11 -0800 Created attachment 50403 [PATCH] Bots fixed, explanation added 198132 7 apavlov 2010-03-10 07:38:47 -0800 (In reply to comment #5) > (From update of attachment 50395 [details]) > You are optimizing for the corner-case. Do you think it improves average case > as well? At least, it does not regress an average case (since inRenderedText() is called for isText() renderers which usually have at least one InlineTextBox). 199865 8 50403 eric 2010-03-15 15:30:46 -0700 Comment on attachment 50403 [PATCH] Bots fixed, explanation added Looks good. However, you should also add a comment next to inRenderedText in Position.h explaining the runtime of the function, or at least warning that it's slow. 199875 9 pfeldman 2010-03-15 15:37:14 -0700 Eric, I think this could regress average case since we check potentially invisible nodes for being selectable. I would not be landing this - it optimizes for the inspector's corner case only. 199877 10 50403 eric 2010-03-15 15:44:39 -0700 Comment on attachment 50403 [PATCH] Bots fixed, explanation added Pavel is obviously attempting to r- through comment... Not sure why he didn't just r- it himself. ;) 199883 11 pfeldman 2010-03-15 15:52:42 -0700 (In reply to comment #10) > (From update of attachment 50403 [details]) > Pavel is obviously attempting to r- through comment... Not sure why he didn't > just r- it himself. ;) Thing is I am not sure. My gut tells me that optimizing for the corner case described in the bug must have trade-offs :). But we don't have real world metrics that would prove it either so or otherwise. So am just being cautious. If you think that doing an inexpensive extra check that might be unnecessary prior to doing necessary expensive check is fine in this context - I am all for it. 203090 12 apavlov 2010-03-23 10:03:54 -0700 *** Bug 35764 has been marked as a duplicate of this bug. *** 236806 13 58469 pfeldman 2010-06-11 07:02:08 -0700 Created attachment 58469 [PATCH] Rebaselined. 236809 14 pfeldman 2010-06-11 07:03:26 -0700 This now looks sane to me. Dave, could you please review this tiny change? 236837 15 eric 2010-06-11 08:18:25 -0700 Can't we make a test for this? I seem to remember Enrica recently made some Editor perf tests, or at least talked about doing so. 241981 16 58469 hyatt 2010-06-23 11:37:13 -0700 Comment on attachment 58469 [PATCH] Rebaselined. Good change. r=me. 242227 17 58469 commit-queue 2010-06-23 18:33:32 -0700 Comment on attachment 58469 [PATCH] Rebaselined. Clearing flags on attachment: 58469 Committed r61724: <http://trac.webkit.org/changeset/61724> 242228 18 commit-queue 2010-06-23 18:33:38 -0700 All reviewed patches have been landed. Closing bug. 242247 19 webkit.review.bot 2010-06-23 19:04:35 -0700 http://trac.webkit.org/changeset/61724 might have broken GTK Linux 64-bit Debug 50395 2010-03-10 05:59:04 -0800 2010-03-10 07:30:11 -0800 [PATCH] Suggested solution optimizepositions.patch text/plain 3411 apavlov ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg ZWY4NTQ0NS4uOTVmZTM4NCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMyBAQAorMjAxMC0wMy0xMCAgQWxleGFuZGVyIFBh dmxvdiAgPGFwYXZsb3ZAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFdlYiBJbnNwZWN0b3I6IEhhbmd1cCB3aGVuIGV4cGFuZGlu ZyBlbGVtZW50cyB3aXRoIGVub3Jtb3VzCisgICAgICAgIHRleHQgbm9kZSBjb250ZW50IGluIEVs ZW1lbnRzIHBhbmVsCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0zNTkyNgorCisgICAgICAgIElubGluZWQgdW5jaGVja2VkUHJldmlvdXNPZmZzZXQoKS91 bmNoZWNrZWROZXh0T2Zmc2V0KCkgYXMgYWR2aXNlZCBieSBTaGFyaywKKyAgICAgICAgcGxhY2Vk IGV4dHJlbWVseSBzbG93IGluUmVuZGVyZWRUZXh0KCkgY2FsbCBsYXN0IGluIHRoZSBpc0NhbmRp ZGF0ZSgpIG1ldGhvZHMnCisgICAgICAgIGZvciB0aGUgcmVuZGVyZXItPmlzVGV4dCgpIGNhc2U6 IHdoZW4gY2FsbGVkIGZyb20gV2ViQ29yZTo6RE9NU2VsZWN0aW9uOjphZGRSYW5nZSgpLAorICAg ICAgICBjb3VsZCB0YWtlIHVwIHRvIDk5JSBvZiB0aW1lLgorCisgICAgICAgICogZG9tL1Bvc2l0 aW9uLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlBvc2l0aW9uOjp1bmNoZWNrZWRQcmV2aW91c09m ZnNldCk6CisgICAgICAgIChXZWJDb3JlOjpQb3NpdGlvbjo6dW5jaGVja2VkTmV4dE9mZnNldCk6 CisgICAgICAgIChXZWJDb3JlOjpQb3NpdGlvbjo6aXNDYW5kaWRhdGUpOgorICAgICAgICAqIGRv bS9Qb3NpdGlvbkl0ZXJhdG9yLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlBvc2l0aW9uSXRlcmF0 b3I6OmlzQ2FuZGlkYXRlKToKKwogMjAxMC0wMy0xMCAgSG9sZ2VyIEhhbnMgUGV0ZXIgRnJleXRo ZXIgIDx6ZWNrZUBzZWxmaXNoLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBTaW1vbiBIYXVz bWFubi4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvZG9tL1Bvc2l0aW9uLmNwcCBiL1dlYkNvcmUvZG9t L1Bvc2l0aW9uLmNwcAppbmRleCBlZjBiM2MxLi45OTQ5MDc2IDEwMDY0NAotLS0gYS9XZWJDb3Jl L2RvbS9Qb3NpdGlvbi5jcHAKKysrIGIvV2ViQ29yZS9kb20vUG9zaXRpb24uY3BwCkBAIC0yNzgs NyArMjc4LDcgQEAgUG9zaXRpb24gUG9zaXRpb246Om5leHQoUG9zaXRpb25Nb3ZlVHlwZSBtb3Zl VHlwZSkgY29uc3QKICAgICByZXR1cm4gUG9zaXRpb24ocGFyZW50LCBuLT5ub2RlSW5kZXgoKSAr IDEpOwogfQogCi1pbnQgUG9zaXRpb246OnVuY2hlY2tlZFByZXZpb3VzT2Zmc2V0KGNvbnN0IE5v ZGUqIG4sIGludCBjdXJyZW50KQoraW5saW5lIGludCBQb3NpdGlvbjo6dW5jaGVja2VkUHJldmlv dXNPZmZzZXQoY29uc3QgTm9kZSogbiwgaW50IGN1cnJlbnQpCiB7CiAgICAgcmV0dXJuIG4tPnJl bmRlcmVyKCkgPyBuLT5yZW5kZXJlcigpLT5wcmV2aW91c09mZnNldChjdXJyZW50KSA6IGN1cnJl bnQgLSAxOwogfQpAQCAtMjg4LDcgKzI4OCw3IEBAIGludCBQb3NpdGlvbjo6dW5jaGVja2VkUHJl dmlvdXNPZmZzZXRGb3JCYWNrd2FyZERlbGV0aW9uKGNvbnN0IE5vZGUqIG4sIGludCBjdXJyCiAg ICAgcmV0dXJuIG4tPnJlbmRlcmVyKCkgPyBuLT5yZW5kZXJlcigpLT5wcmV2aW91c09mZnNldEZv ckJhY2t3YXJkRGVsZXRpb24oY3VycmVudCkgOiBjdXJyZW50IC0gMTsKIH0KIAotaW50IFBvc2l0 aW9uOjp1bmNoZWNrZWROZXh0T2Zmc2V0KGNvbnN0IE5vZGUqIG4sIGludCBjdXJyZW50KQoraW5s aW5lIGludCBQb3NpdGlvbjo6dW5jaGVja2VkTmV4dE9mZnNldChjb25zdCBOb2RlKiBuLCBpbnQg Y3VycmVudCkKIHsKICAgICByZXR1cm4gbi0+cmVuZGVyZXIoKSA/IG4tPnJlbmRlcmVyKCktPm5l eHRPZmZzZXQoY3VycmVudCkgOiBjdXJyZW50ICsgMTsKIH0KQEAgLTczNiwxMCArNzM2LDEwIEBA IGJvb2wgUG9zaXRpb246OmlzQ2FuZGlkYXRlKCkgY29uc3QKICAgICAgICAgcmV0dXJuIGZhbHNl OwogCiAgICAgaWYgKHJlbmRlcmVyLT5pc0JSKCkpCi0gICAgICAgIHJldHVybiBtX29mZnNldCA9 PSAwICYmICFub2RlSXNVc2VyU2VsZWN0Tm9uZShub2RlKCktPnBhcmVudCgpKTsKKyAgICAgICAg cmV0dXJuICFtX29mZnNldCAmJiAhbm9kZUlzVXNlclNlbGVjdE5vbmUobm9kZSgpLT5wYXJlbnQo KSk7CiAKICAgICBpZiAocmVuZGVyZXItPmlzVGV4dCgpKQotICAgICAgICByZXR1cm4gaW5SZW5k ZXJlZFRleHQoKSAmJiAhbm9kZUlzVXNlclNlbGVjdE5vbmUobm9kZSgpKTsKKyAgICAgICAgcmV0 dXJuICFub2RlSXNVc2VyU2VsZWN0Tm9uZShub2RlKCkpICYmIGluUmVuZGVyZWRUZXh0KCk7CiAK ICAgICBpZiAoaXNUYWJsZUVsZW1lbnQobm9kZSgpKSB8fCBlZGl0aW5nSWdub3Jlc0NvbnRlbnQo bm9kZSgpKSkKICAgICAgICAgcmV0dXJuIChhdEZpcnN0RWRpdGluZ1Bvc2l0aW9uRm9yTm9kZSgp IHx8IGF0TGFzdEVkaXRpbmdQb3NpdGlvbkZvck5vZGUoKSkgJiYgIW5vZGVJc1VzZXJTZWxlY3RO b25lKG5vZGUoKS0+cGFyZW50KCkpOwpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9kb20vUG9zaXRpb25J dGVyYXRvci5jcHAgYi9XZWJDb3JlL2RvbS9Qb3NpdGlvbkl0ZXJhdG9yLmNwcAppbmRleCBmNWI2 NWY1Li5jYjQ5NWRlIDEwMDY0NAotLS0gYS9XZWJDb3JlL2RvbS9Qb3NpdGlvbkl0ZXJhdG9yLmNw cAorKysgYi9XZWJDb3JlL2RvbS9Qb3NpdGlvbkl0ZXJhdG9yLmNwcApAQCAtMTUxLDcgKzE1MSw3 IEBAIGJvb2wgUG9zaXRpb25JdGVyYXRvcjo6aXNDYW5kaWRhdGUoKSBjb25zdAogICAgICAgICBy ZXR1cm4gIW1fb2Zmc2V0SW5BbmNob3IgJiYgIVBvc2l0aW9uOjpub2RlSXNVc2VyU2VsZWN0Tm9u ZShtX2FuY2hvck5vZGUtPnBhcmVudCgpKTsKIAogICAgIGlmIChyZW5kZXJlci0+aXNUZXh0KCkp Ci0gICAgICAgIHJldHVybiBQb3NpdGlvbigqdGhpcykuaW5SZW5kZXJlZFRleHQoKSAmJiAhUG9z aXRpb246Om5vZGVJc1VzZXJTZWxlY3ROb25lKG1fYW5jaG9yTm9kZSk7CisgICAgICAgIHJldHVy biAhUG9zaXRpb246Om5vZGVJc1VzZXJTZWxlY3ROb25lKG1fYW5jaG9yTm9kZSkgJiYgUG9zaXRp b24oKnRoaXMpLmluUmVuZGVyZWRUZXh0KCk7CiAKICAgICBpZiAoaXNUYWJsZUVsZW1lbnQobV9h bmNob3JOb2RlKSB8fCBlZGl0aW5nSWdub3Jlc0NvbnRlbnQobV9hbmNob3JOb2RlKSkKICAgICAg ICAgcmV0dXJuIChhdFN0YXJ0T2ZOb2RlKCkgfHwgYXRFbmRPZk5vZGUoKSkgJiYgIVBvc2l0aW9u Ojpub2RlSXNVc2VyU2VsZWN0Tm9uZShtX2FuY2hvck5vZGUtPnBhcmVudCgpKTsK 50403 2010-03-10 07:30:11 -0800 2010-06-11 07:02:08 -0700 [PATCH] Bots fixed, explanation added optimizepositions.patch text/plain 2561 apavlov ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg ZWY4NTQ0NS4uMmVmZGUwOCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMCBAQAorMjAxMC0wMy0xMCAgQWxleGFuZGVyIFBh dmxvdiAgPGFwYXZsb3ZAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFdlYiBJbnNwZWN0b3I6IEhhbmd1cCB3aGVuIGV4cGFuZGlu ZyBlbGVtZW50cyB3aXRoIGVub3Jtb3VzIHRleHQgbm9kZSBjb250ZW50IGluIEVsZW1lbnRzIHBh bmVsCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zNTky NgorCisgICAgICAgIFBsYWNlZCBleHRyZW1lbHkgc2xvdyBpblJlbmRlcmVkVGV4dCgpIGNhbGwg bGFzdCBpbiB0aGUgaXNDYW5kaWRhdGUoKSBtZXRob2RzJworICAgICAgICBmb3IgdGhlIHJlbmRl cmVyLT5pc1RleHQoKSBjYXNlOiB3aGVuIGNhbGxlZCBmcm9tIFdlYkNvcmU6OkRPTVNlbGVjdGlv bjo6YWRkUmFuZ2UoKSwKKyAgICAgICAgY291bGQgdGFrZSB1cCB0byA5OSUgb2YgdGltZS4gVGhl IGNoYW5nZSBkb2VzIG5vdCByZWdyZXNzIGlzQ2FuZGlkYXRlKCkgbWV0aG9kcyBvbgorICAgICAg ICBhdmVyYWdlIGZvciB0aGUgY2FzZSBvZiBhIHRleHQgcmVuZGVyZXIgKHdoZXJlIGluUmVuZGVy ZWRUZXh0KCkgPT0gdHJ1ZSkuCisKKyAgICAgICAgKiBkb20vUG9zaXRpb24uY3BwOgorICAgICAg ICAoV2ViQ29yZTo6UG9zaXRpb246OmlzQ2FuZGlkYXRlKToKKyAgICAgICAgKiBkb20vUG9zaXRp b25JdGVyYXRvci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpQb3NpdGlvbkl0ZXJhdG9yOjppc0Nh bmRpZGF0ZSk6CisKIDIwMTAtMDMtMTAgIEhvbGdlciBIYW5zIFBldGVyIEZyZXl0aGVyICA8emVj a2VAc2VsZmlzaC5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgU2ltb24gSGF1c21hbm4uCmRp ZmYgLS1naXQgYS9XZWJDb3JlL2RvbS9Qb3NpdGlvbi5jcHAgYi9XZWJDb3JlL2RvbS9Qb3NpdGlv bi5jcHAKaW5kZXggZWYwYjNjMS4uYmM1MWY5ZiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9kb20vUG9z aXRpb24uY3BwCisrKyBiL1dlYkNvcmUvZG9tL1Bvc2l0aW9uLmNwcApAQCAtNzM2LDEwICs3MzYs MTAgQEAgYm9vbCBQb3NpdGlvbjo6aXNDYW5kaWRhdGUoKSBjb25zdAogICAgICAgICByZXR1cm4g ZmFsc2U7CiAKICAgICBpZiAocmVuZGVyZXItPmlzQlIoKSkKLSAgICAgICAgcmV0dXJuIG1fb2Zm c2V0ID09IDAgJiYgIW5vZGVJc1VzZXJTZWxlY3ROb25lKG5vZGUoKS0+cGFyZW50KCkpOworICAg ICAgICByZXR1cm4gIW1fb2Zmc2V0ICYmICFub2RlSXNVc2VyU2VsZWN0Tm9uZShub2RlKCktPnBh cmVudCgpKTsKIAogICAgIGlmIChyZW5kZXJlci0+aXNUZXh0KCkpCi0gICAgICAgIHJldHVybiBp blJlbmRlcmVkVGV4dCgpICYmICFub2RlSXNVc2VyU2VsZWN0Tm9uZShub2RlKCkpOworICAgICAg ICByZXR1cm4gIW5vZGVJc1VzZXJTZWxlY3ROb25lKG5vZGUoKSkgJiYgaW5SZW5kZXJlZFRleHQo KTsKIAogICAgIGlmIChpc1RhYmxlRWxlbWVudChub2RlKCkpIHx8IGVkaXRpbmdJZ25vcmVzQ29u dGVudChub2RlKCkpKQogICAgICAgICByZXR1cm4gKGF0Rmlyc3RFZGl0aW5nUG9zaXRpb25Gb3JO b2RlKCkgfHwgYXRMYXN0RWRpdGluZ1Bvc2l0aW9uRm9yTm9kZSgpKSAmJiAhbm9kZUlzVXNlclNl bGVjdE5vbmUobm9kZSgpLT5wYXJlbnQoKSk7CmRpZmYgLS1naXQgYS9XZWJDb3JlL2RvbS9Qb3Np dGlvbkl0ZXJhdG9yLmNwcCBiL1dlYkNvcmUvZG9tL1Bvc2l0aW9uSXRlcmF0b3IuY3BwCmluZGV4 IGY1YjY1ZjUuLmNiNDk1ZGUgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvZG9tL1Bvc2l0aW9uSXRlcmF0 b3IuY3BwCisrKyBiL1dlYkNvcmUvZG9tL1Bvc2l0aW9uSXRlcmF0b3IuY3BwCkBAIC0xNTEsNyAr MTUxLDcgQEAgYm9vbCBQb3NpdGlvbkl0ZXJhdG9yOjppc0NhbmRpZGF0ZSgpIGNvbnN0CiAgICAg ICAgIHJldHVybiAhbV9vZmZzZXRJbkFuY2hvciAmJiAhUG9zaXRpb246Om5vZGVJc1VzZXJTZWxl Y3ROb25lKG1fYW5jaG9yTm9kZS0+cGFyZW50KCkpOwogCiAgICAgaWYgKHJlbmRlcmVyLT5pc1Rl eHQoKSkKLSAgICAgICAgcmV0dXJuIFBvc2l0aW9uKCp0aGlzKS5pblJlbmRlcmVkVGV4dCgpICYm ICFQb3NpdGlvbjo6bm9kZUlzVXNlclNlbGVjdE5vbmUobV9hbmNob3JOb2RlKTsKKyAgICAgICAg cmV0dXJuICFQb3NpdGlvbjo6bm9kZUlzVXNlclNlbGVjdE5vbmUobV9hbmNob3JOb2RlKSAmJiBQ b3NpdGlvbigqdGhpcykuaW5SZW5kZXJlZFRleHQoKTsKIAogICAgIGlmIChpc1RhYmxlRWxlbWVu dChtX2FuY2hvck5vZGUpIHx8IGVkaXRpbmdJZ25vcmVzQ29udGVudChtX2FuY2hvck5vZGUpKQog ICAgICAgICByZXR1cm4gKGF0U3RhcnRPZk5vZGUoKSB8fCBhdEVuZE9mTm9kZSgpKSAmJiAhUG9z aXRpb246Om5vZGVJc1VzZXJTZWxlY3ROb25lKG1fYW5jaG9yTm9kZS0+cGFyZW50KCkpOwo= 58469 2010-06-11 07:02:08 -0700 2010-06-23 18:33:32 -0700 [PATCH] Rebaselined. position_candidate text/plain 2301 pfeldman ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg NWQ1MGUzMC4uM2ZjNjEzZCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMSBAQAorMjAxMC0wNi0xMSAgQWxleGVuZGFyIFBh dmxvdiAgPGFwYXZsb3ZAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFN3YXAgY2hlY2tzIGluIFBvc2l0aW9uOjppc0NhbmRpZGF0 ZSBzbyB0aGF0IHRoZSBsZXNzIGV4cGVuc2l2ZQorICAgICAgICBub2RlSXNVc2VyU2VsZWN0Tm9k ZSAgKG5vZGUgJiYgbm9kZS0+cmVuZGVyZXIoKSAmJgorICAgICAgICBub2RlLT5yZW5kZXJlcigp LT5zdHlsZSgpLT51c2VyU2VsZWN0KCkgPT0gU0VMRUNUX05PTkUpIGNhbWUgZmlyc3QuCisKKyAg ICAgICAgKFdhcyBXZWIgSW5zcGVjdG9yOiBIYW5ndXAgd2hlbiBleHBhbmRpbmcgZWxlbWVudHMg d2l0aCBlbm9ybW91cworICAgICAgICB0ZXh0IG5vZGUgY29udGVudCBpbiBFbGVtZW50cyBwYW5l bCkuCisKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM1 OTI2CisKKyAgICAgICAgKiBkb20vUG9zaXRpb24uY3BwOgorICAgICAgICAoV2ViQ29yZTo6UG9z aXRpb246OmlzQ2FuZGlkYXRlKToKKyAgICAgICAgKiBkb20vUG9zaXRpb25JdGVyYXRvci5jcHA6 CisgICAgICAgIChXZWJDb3JlOjpQb3NpdGlvbkl0ZXJhdG9yOjppc0NhbmRpZGF0ZSk6CisKIDIw MTAtMDYtMTAgIFBhdmVsIEZlbGRtYW4gIDxwZmVsZG1hbkBjaHJvbWl1bS5vcmc+CiAKICAgICAg ICAgUmV2aWV3ZWQgYnkgWXVyeSBTZW1pa2hhdHNreS4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvZG9t L1Bvc2l0aW9uLmNwcCBiL1dlYkNvcmUvZG9tL1Bvc2l0aW9uLmNwcAppbmRleCA3ODYxZmJlLi42 NWI3MjYxIDEwMDY0NAotLS0gYS9XZWJDb3JlL2RvbS9Qb3NpdGlvbi5jcHAKKysrIGIvV2ViQ29y ZS9kb20vUG9zaXRpb24uY3BwCkBAIC03MzksNyArNzM5LDcgQEAgYm9vbCBQb3NpdGlvbjo6aXND YW5kaWRhdGUoKSBjb25zdAogICAgICAgICByZXR1cm4gbV9vZmZzZXQgPT0gMCAmJiAhbm9kZUlz VXNlclNlbGVjdE5vbmUobm9kZSgpLT5wYXJlbnQoKSk7CiAKICAgICBpZiAocmVuZGVyZXItPmlz VGV4dCgpKQotICAgICAgICByZXR1cm4gaW5SZW5kZXJlZFRleHQoKSAmJiAhbm9kZUlzVXNlclNl bGVjdE5vbmUobm9kZSgpKTsKKyAgICAgICAgcmV0dXJuICFub2RlSXNVc2VyU2VsZWN0Tm9uZShu b2RlKCkpICYmIGluUmVuZGVyZWRUZXh0KCk7CiAKICAgICBpZiAoaXNUYWJsZUVsZW1lbnQobm9k ZSgpKSB8fCBlZGl0aW5nSWdub3Jlc0NvbnRlbnQobm9kZSgpKSkKICAgICAgICAgcmV0dXJuIChh dEZpcnN0RWRpdGluZ1Bvc2l0aW9uRm9yTm9kZSgpIHx8IGF0TGFzdEVkaXRpbmdQb3NpdGlvbkZv ck5vZGUoKSkgJiYgIW5vZGVJc1VzZXJTZWxlY3ROb25lKG5vZGUoKS0+cGFyZW50KCkpOwpkaWZm IC0tZ2l0IGEvV2ViQ29yZS9kb20vUG9zaXRpb25JdGVyYXRvci5jcHAgYi9XZWJDb3JlL2RvbS9Q b3NpdGlvbkl0ZXJhdG9yLmNwcAppbmRleCA2MTllMzc2Li5kMmMzYTNmIDEwMDY0NAotLS0gYS9X ZWJDb3JlL2RvbS9Qb3NpdGlvbkl0ZXJhdG9yLmNwcAorKysgYi9XZWJDb3JlL2RvbS9Qb3NpdGlv bkl0ZXJhdG9yLmNwcApAQCAtMTUwLDcgKzE1MCw3IEBAIGJvb2wgUG9zaXRpb25JdGVyYXRvcjo6 aXNDYW5kaWRhdGUoKSBjb25zdAogICAgICAgICByZXR1cm4gIW1fb2Zmc2V0SW5BbmNob3IgJiYg IVBvc2l0aW9uOjpub2RlSXNVc2VyU2VsZWN0Tm9uZShtX2FuY2hvck5vZGUtPnBhcmVudCgpKTsK IAogICAgIGlmIChyZW5kZXJlci0+aXNUZXh0KCkpCi0gICAgICAgIHJldHVybiBQb3NpdGlvbigq dGhpcykuaW5SZW5kZXJlZFRleHQoKSAmJiAhUG9zaXRpb246Om5vZGVJc1VzZXJTZWxlY3ROb25l KG1fYW5jaG9yTm9kZSk7CisgICAgICAgIHJldHVybiAhUG9zaXRpb246Om5vZGVJc1VzZXJTZWxl Y3ROb25lKG1fYW5jaG9yTm9kZSkgJiYgUG9zaXRpb24oKnRoaXMpLmluUmVuZGVyZWRUZXh0KCk7 CiAKICAgICBpZiAoaXNUYWJsZUVsZW1lbnQobV9hbmNob3JOb2RlKSB8fCBlZGl0aW5nSWdub3Jl c0NvbnRlbnQobV9hbmNob3JOb2RlKSkKICAgICAgICAgcmV0dXJuIChhdFN0YXJ0T2ZOb2RlKCkg fHwgYXRFbmRPZk5vZGUoKSkgJiYgIVBvc2l0aW9uOjpub2RlSXNVc2VyU2VsZWN0Tm9uZShtX2Fu Y2hvck5vZGUtPnBhcmVudCgpKTsK