35909 2010-03-09 03:24:26 -0800 [GTK] GTK_WIDGET_IS_SENSITIVE is deprecated in GTK+ 2.20 2010-03-15 01:36:08 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 pnormand webkit-unassigned gustavo webkit.review.bot xan.lopez oldest_to_newest 197519 0 pnormand 2010-03-09 03:24:26 -0800 We should use gtk_widget_is_sensitive() instead if GTK version is >= 2.18. 197521 1 50287 pnormand 2010-03-09 03:29:03 -0800 Created attachment 50287 proposed patch 197869 2 50287 zecke 2010-03-09 20:22:12 -0800 Comment on attachment 50287 proposed patch I might miss my morning coffee... or people from shelbyville has put stuff into the water... > + [GTK] GTK_WIDGET_IS_SENSITIVE deprecated in GTK+ 2.20 please put a verb like "is" there to make it a sentence. :) > + > +#if GTK_CHECK_VERSION(2, 18, 0) > if (GTK_WIDGET_IS_SENSITIVE(widget)) { > +#else > + if (GTK_WIDGET_IS_SENSITIVE(widget)) { > +#endif this looks identical. I think you want to make one of them gtk_widget_is_sensitive? 197905 3 50372 pnormand 2010-03-10 00:10:31 -0800 Created attachment 50372 updated patch 197906 4 50373 pnormand 2010-03-10 00:11:25 -0800 Created attachment 50373 updated patch 197907 5 webkit.review.bot 2010-03-10 00:13:27 -0800 Attachment 50372 did not build on gtk: Build output: http://webkit-commit-queue.appspot.com/results/579005 199574 6 pnormand 2010-03-15 01:36:08 -0700 Landed in r55989. 50287 2010-03-09 03:29:03 -0800 2010-03-10 00:10:31 -0800 proposed patch proposed-patch.patch text/plain 1625 pnormand RnJvbSBkYzdmYWJkYmYzMzI3YTQzMTYxMzZiYWFhOTA2NGMyNjI4MTMxOTczIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQaGlsaXBwZSBOb3JtYW5kIDxwbm9ybWFuZEBpZ2FsaWEuY29t PgpEYXRlOiBUdWUsIDkgTWFyIDIwMTAgMTI6Mjg6MTMgKzAxMDAKU3ViamVjdDogW1BBVENIXSBw cm9wb3NlZCBwYXRjaAoKLS0tCiBXZWJLaXQvZ3RrL0NoYW5nZUxvZyAgICAgICAgICAgICAgICB8 ICAgMTAgKysrKysrKysrKwogV2ViS2l0L2d0ay93ZWJraXQvd2Via2l0d2Vidmlldy5jcHAgfCAg ICA1ICsrKysrCiAyIGZpbGVzIGNoYW5nZWQsIDE1IGluc2VydGlvbnMoKyksIDAgZGVsZXRpb25z KC0pCgpkaWZmIC0tZ2l0IGEvV2ViS2l0L2d0ay9DaGFuZ2VMb2cgYi9XZWJLaXQvZ3RrL0NoYW5n ZUxvZwppbmRleCA5NGVjMjg4Li5lMzk0YzkzIDEwMDY0NAotLS0gYS9XZWJLaXQvZ3RrL0NoYW5n ZUxvZworKysgYi9XZWJLaXQvZ3RrL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDEwLTAz LTA5ICBQaGlsaXBwZSBOb3JtYW5kICA8cG5vcm1hbmRAaWdhbGlhLmNvbT4KKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbR1RLXSBHVEtfV0lER0VUX0lT X1NFTlNJVElWRSBkZXByZWNhdGVkIGluIEdUSysgMi4yMAorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzU5MDkKKworICAgICAgICAqIHdlYmtpdC93ZWJr aXR3ZWJ2aWV3LmNwcDogR1RLX1dJREdFVF9JU19TRU5TSVRJVkUgaGFzIGJlZW4KKyAgICAgICAg ZGVwcmVjYXRlZCBpbiBndGsgMi4yMC4gVXNlIGd0a193aWRnZXRfaXNfc2Vuc2l0aXZlIHdoZW4g YXZhaWxhYmxlLgorCiAyMDEwLTAzLTA4ICBDc2FiYSBPc3p0cm9nb27DoWMgIDxvc3N5QHdlYmtp dC5vcmc+CiAKICAgICAgICAgW0dUS10gVW5yZXZpZXdlZCBidWlsZGZpeCBhZnRlciByNTU2ODgu CmRpZmYgLS1naXQgYS9XZWJLaXQvZ3RrL3dlYmtpdC93ZWJraXR3ZWJ2aWV3LmNwcCBiL1dlYktp dC9ndGsvd2Via2l0L3dlYmtpdHdlYnZpZXcuY3BwCmluZGV4IDI3NDAzMGMuLjhlNzA2MGQgMTAw NjQ0Ci0tLSBhL1dlYktpdC9ndGsvd2Via2l0L3dlYmtpdHdlYnZpZXcuY3BwCisrKyBiL1dlYktp dC9ndGsvd2Via2l0L3dlYmtpdHdlYnZpZXcuY3BwCkBAIC02ODgsNyArNjg4LDEyIEBAIHN0YXRp YyB2b2lkIHdlYmtpdF93ZWJfdmlld19zaXplX2FsbG9jYXRlKEd0a1dpZGdldCogd2lkZ2V0LCBH dGtBbGxvY2F0aW9uKiBhbGxvCiAKIHN0YXRpYyB2b2lkIHdlYmtpdF93ZWJfdmlld19ncmFiX2Zv Y3VzKEd0a1dpZGdldCogd2lkZ2V0KQogeworCisjaWYgR1RLX0NIRUNLX1ZFUlNJT04oMiwgMTgs IDApCiAgICAgaWYgKEdUS19XSURHRVRfSVNfU0VOU0lUSVZFKHdpZGdldCkpIHsKKyNlbHNlCisg ICAgaWYgKEdUS19XSURHRVRfSVNfU0VOU0lUSVZFKHdpZGdldCkpIHsKKyNlbmRpZgogICAgICAg ICBXZWJLaXRXZWJWaWV3KiB3ZWJWaWV3ID0gV0VCS0lUX1dFQl9WSUVXKHdpZGdldCk7CiAgICAg ICAgIEZvY3VzQ29udHJvbGxlciogZm9jdXNDb250cm9sbGVyID0gY29yZSh3ZWJWaWV3KS0+Zm9j dXNDb250cm9sbGVyKCk7CiAKLS0gCjEuNi4zLjM= 50372 2010-03-10 00:10:31 -0800 2010-03-10 00:11:25 -0800 updated patch updated-patch.patch text/plain 1698 pnormand RnJvbSAzZWUyMWEzMGQxM2RlNTMzOTY2ODMwNjkxMjhiZDg4MmMyZjAyZTk2IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQaGlsaXBwZSBOb3JtYW5kIDxwbm9ybWFuZEBpZ2FsaWEuY29t PgpEYXRlOiBUdWUsIDkgTWFyIDIwMTAgMTI6Mjg6MTMgKzAxMDAKU3ViamVjdDogW1BBVENIXSB1 cGRhdGVkIHBhdGNoCgotLS0KIFdlYktpdC9ndGsvQ2hhbmdlTG9nICAgICAgICAgICAgICAgIHwg ICAxMCArKysrKysrKysrCiBXZWJLaXQvZ3RrL3dlYmtpdC93ZWJraXR3ZWJ2aWV3LmNwcCB8ICAg IDUgKysrKysKIDIgZmlsZXMgY2hhbmdlZCwgMTUgaW5zZXJ0aW9ucygrKSwgMCBkZWxldGlvbnMo LSkKCmRpZmYgLS1naXQgYS9XZWJLaXQvZ3RrL0NoYW5nZUxvZyBiL1dlYktpdC9ndGsvQ2hhbmdl TG9nCmluZGV4IDlhZGQ2ZTIuLjEyMjk1MjYgMTAwNjQ0Ci0tLSBhL1dlYktpdC9ndGsvQ2hhbmdl TG9nCisrKyBiL1dlYktpdC9ndGsvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTUgQEAKIDIwMTAtMDMt MDkgIFBoaWxpcHBlIE5vcm1hbmQgIDxwbm9ybWFuZEBpZ2FsaWEuY29tPgogCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtHVEtdIEdUS19XSURHRVRfSVNf U0VOU0lUSVZFIGlzIGRlcHJlY2F0ZWQgaW4gR1RLKyAyLjIwCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zNTkwOQorCisgICAgICAgICogd2Via2l0L3dl YmtpdHdlYnZpZXcuY3BwOiBHVEtfV0lER0VUX0lTX1NFTlNJVElWRSBoYXMgYmVlbgorICAgICAg ICBkZXByZWNhdGVkIGluIGd0ayAyLjIwLiBVc2UgZ3RrX3dpZGdldF9pc19zZW5zaXRpdmUgd2hl biBhdmFpbGFibGUuCisKKzIwMTAtMDMtMDkgIFBoaWxpcHBlIE5vcm1hbmQgIDxwbm9ybWFuZEBp Z2FsaWEuY29tPgorCiAgICAgICAgIFJldmlld2VkIGJ5IEd1c3Rhdm8gTm9yb25oYSBTaWx2YS4K IAogICAgICAgICBbR1RLXSB0ZXN0a2V5ZXZlbnRzIGRvZXNuJ3Qgc3RvcCBpZiBpbnB1dCBldmVu dCBpbmplY3Rpb24gZmFpbHMKZGlmZiAtLWdpdCBhL1dlYktpdC9ndGsvd2Via2l0L3dlYmtpdHdl YnZpZXcuY3BwIGIvV2ViS2l0L2d0ay93ZWJraXQvd2Via2l0d2Vidmlldy5jcHAKaW5kZXggMjc0 MDMwYy4uNTg2MTc2YSAxMDA2NDQKLS0tIGEvV2ViS2l0L2d0ay93ZWJraXQvd2Via2l0d2Vidmll dy5jcHAKKysrIGIvV2ViS2l0L2d0ay93ZWJraXQvd2Via2l0d2Vidmlldy5jcHAKQEAgLTY4OCw3 ICs2ODgsMTIgQEAgc3RhdGljIHZvaWQgd2Via2l0X3dlYl92aWV3X3NpemVfYWxsb2NhdGUoR3Rr V2lkZ2V0KiB3aWRnZXQsIEd0a0FsbG9jYXRpb24qIGFsbG8KIAogc3RhdGljIHZvaWQgd2Via2l0 X3dlYl92aWV3X2dyYWJfZm9jdXMoR3RrV2lkZ2V0KiB3aWRnZXQpCiB7CisKKyNpZiBHVEtfQ0hF Q0tfVkVSU0lPTigyLCAxOCwgMCkKKyAgICBpZiAoZ3RrX3dpZGdldF9pc19zZW5zaXRpdih3aWRn ZXQpKSB7CisjZWxzZQogICAgIGlmIChHVEtfV0lER0VUX0lTX1NFTlNJVElWRSh3aWRnZXQpKSB7 CisjZW5kaWYKICAgICAgICAgV2ViS2l0V2ViVmlldyogd2ViVmlldyA9IFdFQktJVF9XRUJfVklF Vyh3aWRnZXQpOwogICAgICAgICBGb2N1c0NvbnRyb2xsZXIqIGZvY3VzQ29udHJvbGxlciA9IGNv cmUod2ViVmlldyktPmZvY3VzQ29udHJvbGxlcigpOwogCi0tIAoxLjYuMy4z 50373 2010-03-10 00:11:25 -0800 2010-03-14 18:58:25 -0700 updated patch updated-patch.patch text/plain 1699 pnormand RnJvbSA2M2VjZDAwNDVjOTYwYTVhNmM4NDkwMDkyNzVlZjFkYzI3OWI3YTA2IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQaGlsaXBwZSBOb3JtYW5kIDxwbm9ybWFuZEBpZ2FsaWEuY29t PgpEYXRlOiBUdWUsIDkgTWFyIDIwMTAgMTI6Mjg6MTMgKzAxMDAKU3ViamVjdDogW1BBVENIXSB1 cGRhdGVkIHBhdGNoCgotLS0KIFdlYktpdC9ndGsvQ2hhbmdlTG9nICAgICAgICAgICAgICAgIHwg ICAxMCArKysrKysrKysrCiBXZWJLaXQvZ3RrL3dlYmtpdC93ZWJraXR3ZWJ2aWV3LmNwcCB8ICAg IDUgKysrKysKIDIgZmlsZXMgY2hhbmdlZCwgMTUgaW5zZXJ0aW9ucygrKSwgMCBkZWxldGlvbnMo LSkKCmRpZmYgLS1naXQgYS9XZWJLaXQvZ3RrL0NoYW5nZUxvZyBiL1dlYktpdC9ndGsvQ2hhbmdl TG9nCmluZGV4IDlhZGQ2ZTIuLjEyMjk1MjYgMTAwNjQ0Ci0tLSBhL1dlYktpdC9ndGsvQ2hhbmdl TG9nCisrKyBiL1dlYktpdC9ndGsvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTUgQEAKIDIwMTAtMDMt MDkgIFBoaWxpcHBlIE5vcm1hbmQgIDxwbm9ybWFuZEBpZ2FsaWEuY29tPgogCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtHVEtdIEdUS19XSURHRVRfSVNf U0VOU0lUSVZFIGlzIGRlcHJlY2F0ZWQgaW4gR1RLKyAyLjIwCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zNTkwOQorCisgICAgICAgICogd2Via2l0L3dl YmtpdHdlYnZpZXcuY3BwOiBHVEtfV0lER0VUX0lTX1NFTlNJVElWRSBoYXMgYmVlbgorICAgICAg ICBkZXByZWNhdGVkIGluIGd0ayAyLjIwLiBVc2UgZ3RrX3dpZGdldF9pc19zZW5zaXRpdmUgd2hl biBhdmFpbGFibGUuCisKKzIwMTAtMDMtMDkgIFBoaWxpcHBlIE5vcm1hbmQgIDxwbm9ybWFuZEBp Z2FsaWEuY29tPgorCiAgICAgICAgIFJldmlld2VkIGJ5IEd1c3Rhdm8gTm9yb25oYSBTaWx2YS4K IAogICAgICAgICBbR1RLXSB0ZXN0a2V5ZXZlbnRzIGRvZXNuJ3Qgc3RvcCBpZiBpbnB1dCBldmVu dCBpbmplY3Rpb24gZmFpbHMKZGlmZiAtLWdpdCBhL1dlYktpdC9ndGsvd2Via2l0L3dlYmtpdHdl YnZpZXcuY3BwIGIvV2ViS2l0L2d0ay93ZWJraXQvd2Via2l0d2Vidmlldy5jcHAKaW5kZXggMjc0 MDMwYy4uNTQ3YjM5OCAxMDA2NDQKLS0tIGEvV2ViS2l0L2d0ay93ZWJraXQvd2Via2l0d2Vidmll dy5jcHAKKysrIGIvV2ViS2l0L2d0ay93ZWJraXQvd2Via2l0d2Vidmlldy5jcHAKQEAgLTY4OCw3 ICs2ODgsMTIgQEAgc3RhdGljIHZvaWQgd2Via2l0X3dlYl92aWV3X3NpemVfYWxsb2NhdGUoR3Rr V2lkZ2V0KiB3aWRnZXQsIEd0a0FsbG9jYXRpb24qIGFsbG8KIAogc3RhdGljIHZvaWQgd2Via2l0 X3dlYl92aWV3X2dyYWJfZm9jdXMoR3RrV2lkZ2V0KiB3aWRnZXQpCiB7CisKKyNpZiBHVEtfQ0hF Q0tfVkVSU0lPTigyLCAxOCwgMCkKKyAgICBpZiAoZ3RrX3dpZGdldF9pc19zZW5zaXRpdmUod2lk Z2V0KSkgeworI2Vsc2UKICAgICBpZiAoR1RLX1dJREdFVF9JU19TRU5TSVRJVkUod2lkZ2V0KSkg eworI2VuZGlmCiAgICAgICAgIFdlYktpdFdlYlZpZXcqIHdlYlZpZXcgPSBXRUJLSVRfV0VCX1ZJ RVcod2lkZ2V0KTsKICAgICAgICAgRm9jdXNDb250cm9sbGVyKiBmb2N1c0NvbnRyb2xsZXIgPSBj b3JlKHdlYlZpZXcpLT5mb2N1c0NvbnRyb2xsZXIoKTsKIAotLSAKMS42LjMuMw==