35907 2010-03-09 01:03:09 -0800 Allow custom memory allocation control for AtomicString class 2010-03-17 09:02:03 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) PC All RESOLVED FIXED P2 Normal --- 1 zoltan zoltan darin eric oldest_to_newest 197492 0 zoltan 2010-03-09 01:03:09 -0800 Inherits the following class from FastAllocBase because it is instantiated by 'new': class name - instantiated at: WebCore/'location' AtomicString - WebCore/html/HTMLTableElement.cpp:525 197494 1 50281 zoltan 2010-03-09 01:04:47 -0800 Created attachment 50281 proposed patch 199870 2 50281 eric 2010-03-15 15:34:23 -0700 Comment on attachment 50281 proposed patch There was concern expressed before that these were making classes bigger? Was that issue ever resolved? Otherwise this change looks fine. 199896 3 eric 2010-03-15 15:58:03 -0700 Attachment 50281 was posted by a committer and has review+, assigning to Zoltan Horvath for commit. 200599 4 50281 zoltan 2010-03-17 00:40:11 -0700 Comment on attachment 50281 proposed patch Clearing flags on attachment: 50281 Committed r56100: <http://trac.webkit.org/changeset/56100> 200600 5 zoltan 2010-03-17 00:40:19 -0700 All reviewed patches have been landed. Closing bug. 200602 6 zoltan 2010-03-17 00:42:06 -0700 (In reply to comment #2) > There was concern expressed before that these were making classes bigger? Was > that issue ever resolved? Otherwise this change looks fine. I opened a bug for it (bug #33896) and made a static analysis on the classes. 200818 7 darin 2010-03-17 09:02:03 -0700 (In reply to comment #6) > (In reply to comment #2) > > There was concern expressed before that these were making classes bigger? Was > > that issue ever resolved? Otherwise this change looks fine. > > I opened a bug for it (bug #33896) and made a static analysis on the classes. I'm not sure what the status is, though. If additional introduction of these changes are making our classes still bigger maybe we should hold off until we decide if that's OK. 50281 2010-03-09 01:04:47 -0800 2010-03-17 00:40:11 -0700 proposed patch AtomicString.patch text/plain 1142 zoltan SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1NTY1OCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTggQEAKKzIwMTAtMDMtMDggIFpvbHRhbiBIb3J2YXRoICA8em9sdGFuQHdlYmtp dC5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg QWxsb3cgY3VzdG9tIG1lbW9yeSBhbGxvY2F0aW9uIGNvbnRyb2wgZm9yIEF0b21pY1N0cmluZyBj bGFzcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzU5 MDcKKworICAgICAgICBJbmhlcml0cyB0aGUgZm9sbG93aW5nIGNsYXNzIGZyb20gRmFzdEFsbG9j QmFzZSBiZWNhdXNlIGl0IGlzCisgICAgICAgIGluc3RhbnRpYXRlZCBieSAnbmV3JzoKKworICAg ICAgICBjbGFzcyBuYW1lICAgLSBpbnN0YW50aWF0ZWQgYXQ6IFdlYkNvcmUvJ2xvY2F0aW9uJwor ICAgICAgICBBdG9taWNTdHJpbmcgLSBXZWJDb3JlL2h0bWwvSFRNTFRhYmxlRWxlbWVudC5jcHA6 NTI1CisKKyAgICAgICAgKiBwbGF0Zm9ybS90ZXh0L0F0b21pY1N0cmluZy5oOgorCiAyMDEwLTAz LTA0ICBQaGlsaXBwZSBOb3JtYW5kICA8cG5vcm1hbmRAaWdhbGlhLmNvbT4KIAogICAgICAgICBS ZXZpZXdlZCBieSBFcmljIFNlaWRlbC4KSW5kZXg6IFdlYkNvcmUvcGxhdGZvcm0vdGV4dC9BdG9t aWNTdHJpbmcuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL3BsYXRmb3JtL3RleHQvQXRvbWljU3Ry aW5nLmgJKHJldmlzaW9uIDU1NjU4KQorKysgV2ViQ29yZS9wbGF0Zm9ybS90ZXh0L0F0b21pY1N0 cmluZy5oCSh3b3JraW5nIGNvcHkpCkBAIC0zNiw3ICszNiw3IEBACiAKIHN0cnVjdCBBdG9taWNT dHJpbmdIYXNoOwogCi1jbGFzcyBBdG9taWNTdHJpbmcgeworY2xhc3MgQXRvbWljU3RyaW5nIDog cHVibGljIEZhc3RBbGxvY0Jhc2UgewogcHVibGljOgogICAgIHN0YXRpYyB2b2lkIGluaXQoKTsK IAo=