35891 2010-03-08 15:37:13 -0800 [GStreamer] Fails to go to Loaded state because of floating point discrepancies 2013-06-04 14:03:51 -0700 1 1 1 Unclassified WebKit Media 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 9243 1 gustavo gustavo eric pnormand oldest_to_newest 197366 0 gustavo 2010-03-08 15:37:13 -0800 Watching debug logs I noticed that maxTimeLoaded was getting very close to, but not exactly equal to duration. I think we need to stop relying on the floating point calculations for the 'completed' case. 197369 1 50261 gustavo 2010-03-08 15:40:05 -0800 Created attachment 50261 try to avoid the floating point comparison by using the fill status variable 197483 2 pnormand 2010-03-09 00:05:12 -0800 LGTM! 203591 3 eric 2010-03-24 14:32:34 -0700 Attachment 50261 was posted by a committer and has review+, assigning to Gustavo Noronha Silva for commit. 203666 4 50261 gustavo 2010-03-24 16:02:37 -0700 Comment on attachment 50261 try to avoid the floating point comparison by using the fill status variable Finally got this committed as r56465. Thanks! 50261 2010-03-08 15:40:05 -0800 2010-03-24 16:02:37 -0700 try to avoid the floating point comparison by using the fill status variable 0001-Use-m_fillStatus-instead-of-calculation-for-the-comp.patch text/plain 2214 gustavo RnJvbSAyODVjNmNhOWRiNThkNTkwZmY0NmQyYzUyYTZkMGM4MWE1YmRhZjlkIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBHdXN0YXZvIE5vcm9uaGEgU2lsdmEgPGduc0Bnbm9tZS5vcmc+ CkRhdGU6IE1vbiwgOCBNYXIgMjAxMCAyMDozODo0MiAtMDMwMApTdWJqZWN0OiBbUEFUQ0hdIFVz ZSBtX2ZpbGxTdGF0dXMgaW5zdGVhZCBvZiBjYWxjdWxhdGlvbiBmb3IgdGhlIGNvbXBsZXRlZCBj YXNlCgotLS0KIFdlYkNvcmUvQ2hhbmdlTG9nICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgIHwgICAxMyArKysrKysrKysrKysrCiAuLi4vZ3N0cmVhbWVyL01lZGlhUGxheWVyUHJpdmF0 ZUdTdHJlYW1lci5jcHAgICAgICB8ICAgIDUgKysrKy0KIDIgZmlsZXMgY2hhbmdlZCwgMTcgaW5z ZXJ0aW9ucygrKSwgMSBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9XZWJDb3JlL0NoYW5nZUxv ZyBiL1dlYkNvcmUvQ2hhbmdlTG9nCmluZGV4IDNjMmVhOGUuLmNlYmFjZjcgMTAwNjQ0Ci0tLSBh L1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0yLDYgKzIsMTkg QEAKIAogICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KIAorICAgICAgICBbR1N0 cmVhbWVyXSBGYWlscyB0byBnbyB0byBMb2FkZWQgc3RhdGUgYmVjYXVzZSBvZiBmbG9hdGluZyBw b2ludCBkaXNjcmVwYW5jaWVzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0zNTg5MQorCisgICAgICAgIFVzZSB0aGUgbV9maWxsU3RhdHVzIHZhcmlhYmxl LCB3aGljaCBpcyBtb3JlIHJlbGlhYmxlLCBpbnN0ZWFkIG9mCisgICAgICAgIHVzaW5nIHRoZSBj YWxjdWxhdGlvbiwgZm9yIHRoZSBjb21wbGV0ZWQgY2FzZS4KKworICAgICAgICAqIHBsYXRmb3Jt L2dyYXBoaWNzL2dzdHJlYW1lci9NZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXIuY3BwOgorICAg ICAgICAoV2ViQ29yZTo6TWVkaWFQbGF5ZXJQcml2YXRlOjpmaWxsVGltZXJGaXJlZCk6CisKKzIw MTAtMDMtMDggIEd1c3Rhdm8gTm9yb25oYSBTaWx2YSAgPGd1c3Rhdm8ubm9yb25oYUBjb2xsYWJv cmEuY28udWs+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKICAgICAg ICAgW0dTdHJlYW1lcl0gQnVmZmVyaW5nIGxvZ2ljIGlzIG5vdCBjb3JyZWN0LCBhbmQgZG9lcyBu b3Qgd29yayB2ZXJ5IHdlbGwKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTM1NzA2CiAKZGlmZiAtLWdpdCBhL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mv Z3N0cmVhbWVyL01lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lci5jcHAgYi9XZWJDb3JlL3BsYXRm b3JtL2dyYXBoaWNzL2dzdHJlYW1lci9NZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXIuY3BwCmlu ZGV4IGRhMTY2ZTMuLmYwNDMxOGYgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhp Y3MvZ3N0cmVhbWVyL01lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lci5jcHAKKysrIGIvV2ViQ29y ZS9wbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvTWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVy LmNwcApAQCAtNzA0LDcgKzcwNCwxMCBAQCB2b2lkIE1lZGlhUGxheWVyUHJpdmF0ZTo6ZmlsbFRp bWVyRmlyZWQoVGltZXI8TWVkaWFQbGF5ZXJQcml2YXRlPiopCiAgICAgLy8gVXBkYXRlIG1heFRp bWVMb2FkZWQgb25seSBpZiB0aGUgbWVkaWEgZHVyYXRpb24gaXMKICAgICAvLyBhdmFpbGFibGUu IE90aGVyd2lzZSB3ZSBjYW4ndCBjb21wdXRlIGl0LgogICAgIGlmIChtX21lZGlhRHVyYXRpb24p IHsKLSAgICAgICAgbV9tYXhUaW1lTG9hZGVkID0gc3RhdGljX2Nhc3Q8ZmxvYXQ+KChtX2ZpbGxT dGF0dXMgKiBtX21lZGlhRHVyYXRpb24pIC8gMTAwLjApOworICAgICAgICBpZiAobV9maWxsU3Rh dHVzID09IDEwMC4wKQorICAgICAgICAgICAgbV9tYXhUaW1lTG9hZGVkID0gbV9tZWRpYUR1cmF0 aW9uOworICAgICAgICBlbHNlCisgICAgICAgICAgICBtX21heFRpbWVMb2FkZWQgPSBzdGF0aWNf Y2FzdDxmbG9hdD4oKG1fZmlsbFN0YXR1cyAqIG1fbWVkaWFEdXJhdGlvbikgLyAxMDAuMCk7CiAg ICAgICAgIExPR19WRVJCT1NFKE1lZGlhLCAiW0J1ZmZlcmluZ10gVXBkYXRlZCBtYXhUaW1lTG9h ZGVkOiAlZiIsIG1fbWF4VGltZUxvYWRlZCk7CiAgICAgfQogCi0tIAoxLjcuMAoK