35867 2010-03-08 07:56:18 -0800 [chromium]: update Linux layout test scripts for RedHat like systems. 2010-03-12 08:02:30 -0800 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 agl webkit-unassigned commit-queue dpranke evan oldest_to_newest 197167 0 agl 2010-03-08 07:56:18 -0800 [chromium]: update Linux layout test scripts for RedHat like systems. 197168 1 50221 agl 2010-03-08 07:57:45 -0800 Created attachment 50221 patch 197174 2 evan 2010-03-08 08:10:05 -0800 + if self._is_redhat_based(): + package_name = 'dwdiff' + else: + package_name = 'wdiff' + + _log.error(' Please install using: "sudo apt-get install ' + + package_name) Does apt-get work on Redhat? I kinda wonder if the dwdiff/wdiff distinction could be factored into one place instead of tested twice. I'm trying to think of a WebKit reviewer who uses Redhat but the GTK guys use Debian I think. 197180 3 50225 agl 2010-03-08 08:22:54 -0800 Created attachment 50225 patch Evan: you're right. We don't try to have distro specific messages for the other cases so I won't try to here. Linux people can figure it out and I don't think it's worth trying to reflect all that complexity in our scripts for these minor cases. 197181 4 agl 2010-03-08 08:26:36 -0800 That wasn't a review to death :) But, in hindsight, trying to maintain the 'apt-get' vs 'yum' messages for everyone and their distro specific package names is just going to rot. I still need the other changes or I can't run layout tests! 198598 5 agl 2010-03-11 07:07:01 -0800 dpranke has been unresponsive for a week and a half now (there was a previous Chromium CL which did the same thing.) Since moving the layout test running in WebKit has completly broken layout tests on all Fedora systems I'll probably land this as an unreviewed build fix later today. 198705 6 50225 dpranke 2010-03-11 11:40:39 -0800 Comment on attachment 50225 patch LGTM. 198706 7 dpranke 2010-03-11 11:41:09 -0800 Hi Adam, Sorry for the delay. Somehow I completely missed this bug, although I've been pretty busy fixing other bugs in this stuff for the past three days. 198758 8 50225 dglazkov 2010-03-11 13:39:50 -0800 Comment on attachment 50225 patch rs=me. 199058 9 50225 commit-queue 2010-03-12 08:02:26 -0800 Comment on attachment 50225 patch Clearing flags on attachment: 50225 Committed r55903: <http://trac.webkit.org/changeset/55903> 199059 10 commit-queue 2010-03-12 08:02:30 -0800 All reviewed patches have been landed. Closing bug. 50221 2010-03-08 07:57:45 -0800 2010-03-08 08:22:54 -0800 patch patch text/plain 2824 agl ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCAwZjM2Y2QxLi5iNDVmYjAwIDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VM b2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTAtMDMt MDggIEFkYW0gTGFuZ2xleSAgPGFnbEBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW2Nocm9taXVtXTogdXBkYXRlIExpbnV4IGxh eW91dCB0ZXN0IHNjcmlwdHMgZm9yIFJlZEhhdCBsaWtlIHN5c3RlbXMuCisKKyAgICAgICAgKFRl c3RlZCBvbiBGZWRvcmEgMTIuKQorCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0zNTg2NworCisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS9sYXlvdXRf dGVzdHMvcG9ydC9jaHJvbWl1bV9saW51eC5weToKKwogMjAxMC0wMy0wOCAgR3VzdGF2byBOb3Jv bmhhIFNpbHZhICA8Z25zQGdub21lLm9yZz4KIAogICAgICAgICBObyByZXZpZXcsIHJvbGxpbmcg b3V0IHI1NTY2Mi4KZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5 b3V0X3Rlc3RzL3BvcnQvY2hyb21pdW1fbGludXgucHkgYi9XZWJLaXRUb29scy9TY3JpcHRzL3dl YmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L2Nocm9taXVtX2xpbnV4LnB5CmluZGV4IDQzNWUxZTAu Ljc5NmE4ZmIgMTAwNjQ0Ci0tLSBhL1dlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0 X3Rlc3RzL3BvcnQvY2hyb21pdW1fbGludXgucHkKKysrIGIvV2ViS2l0VG9vbHMvU2NyaXB0cy93 ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC9jaHJvbWl1bV9saW51eC5weQpAQCAtMTI0LDggKzEy NCwxMyBAQCBjbGFzcyBDaHJvbWl1bUxpbnV4UG9ydChjaHJvbWl1bS5DaHJvbWl1bVBvcnQpOgog ICAgIGRlZiBfY2hlY2tfd2RpZmZfaW5zdGFsbChzZWxmKToKICAgICAgICAgcmVzdWx0ID0gY2hy b21pdW0uY2hlY2tfZmlsZV9leGlzdHMoc2VsZi5fcGF0aF90b193ZGlmZigpLCAnd2RpZmYnKQog ICAgICAgICBpZiBub3QgcmVzdWx0OgotICAgICAgICAgICAgX2xvZy5lcnJvcignICAgIFBsZWFz ZSBpbnN0YWxsIHVzaW5nOiAic3VkbyBhcHQtZ2V0IGluc3RhbGwgJwotICAgICAgICAgICAgICAg ICAgICAgICAnd2RpZmYiJykKKyAgICAgICAgICAgIGlmIHNlbGYuX2lzX3JlZGhhdF9iYXNlZCgp OgorICAgICAgICAgICAgICAgIHBhY2thZ2VfbmFtZSA9ICdkd2RpZmYnCisgICAgICAgICAgICBl bHNlOgorICAgICAgICAgICAgICAgIHBhY2thZ2VfbmFtZSA9ICd3ZGlmZicKKworICAgICAgICAg ICAgX2xvZy5lcnJvcignICAgIFBsZWFzZSBpbnN0YWxsIHVzaW5nOiAic3VkbyBhcHQtZ2V0IGlu c3RhbGwgJyArCisgICAgICAgICAgICAgICAgICAgICAgIHBhY2thZ2VfbmFtZSkKICAgICAgICAg ICAgIF9sb2cuZXJyb3IoJycpCiAgICAgICAgIHJldHVybiByZXN1bHQKIApAQCAtMTQ1LDExICsx NTAsMTkgQEAgY2xhc3MgQ2hyb21pdW1MaW51eFBvcnQoY2hyb21pdW0uQ2hyb21pdW1Qb3J0KToK ICAgICAgICAgbnVsbC5jbG9zZSgpCiAKICAgICBkZWYgX3BhdGhfdG9fYXBhY2hlKHNlbGYpOgot ICAgICAgICByZXR1cm4gJy91c3Ivc2Jpbi9hcGFjaGUyJworICAgICAgICBpZiBzZWxmLl9pc19y ZWRoYXRfYmFzZWQoKToKKyAgICAgICAgICAgIHJldHVybiAnL3Vzci9zYmluL2h0dHBkJworICAg ICAgICBlbHNlOgorICAgICAgICAgICAgcmV0dXJuICcvdXNyL3NiaW4vYXBhY2hlMicKIAogICAg IGRlZiBfcGF0aF90b19hcGFjaGVfY29uZmlnX2ZpbGUoc2VsZik6CisgICAgICAgIGlmIHNlbGYu X2lzX3JlZGhhdF9iYXNlZCgpOgorICAgICAgICAgICAgY29uZmlnX25hbWUgPSAnZmVkb3JhLWh0 dHBkLmNvbmYnCisgICAgICAgIGVsc2U6CisgICAgICAgICAgICBjb25maWdfbmFtZSA9ICdhcGFj aGUyLWRlYmlhbi1odHRwZC5jb25mJworCiAgICAgICAgIHJldHVybiBvcy5wYXRoLmpvaW4oc2Vs Zi5sYXlvdXRfdGVzdHNfZGlyKCksICdodHRwJywgJ2NvbmYnLAotICAgICAgICAgICAgICAgICAg ICAgICAgICAgICdhcGFjaGUyLWRlYmlhbi1odHRwZC5jb25mJykKKyAgICAgICAgICAgICAgICAg ICAgICAgICAgICBjb25maWdfbmFtZSkKIAogICAgIGRlZiBfcGF0aF90b19saWdodHRwZChzZWxm KToKICAgICAgICAgcmV0dXJuICIvdXNyL3NiaW4vbGlnaHR0cGQiCkBAIC0xNzIsNyArMTg1LDEz IEBAIGNsYXNzIENocm9taXVtTGludXhQb3J0KGNocm9taXVtLkNocm9taXVtUG9ydCk6CiAgICAg ICAgIHJldHVybiBzZWxmLl9idWlsZF9wYXRoKHNlbGYuX29wdGlvbnMudGFyZ2V0LCAnaW1hZ2Vf ZGlmZicpCiAKICAgICBkZWYgX3BhdGhfdG9fd2RpZmYoc2VsZik6Ci0gICAgICAgIHJldHVybiAn L3Vzci9iaW4vd2RpZmYnCisgICAgICAgIGlmIHNlbGYuX2lzX3JlZGhhdF9iYXNlZCgpOgorICAg ICAgICAgICAgcmV0dXJuICcvdXNyL2Jpbi9kd2RpZmYnCisgICAgICAgIGVsc2U6CisgICAgICAg ICAgICByZXR1cm4gJy91c3IvYmluL3dkaWZmJworCisgICAgZGVmIF9pc19yZWRoYXRfYmFzZWQo c2VsZik6CisgICAgICAgIHJldHVybiBvcy5wYXRoLmV4aXN0cyhvcy5wYXRoLmpvaW4oJy9ldGMn LCAncmVkaGF0LXJlbGVhc2UnKSkKIAogICAgIGRlZiBfc2h1dF9kb3duX2h0dHBfc2VydmVyKHNl bGYsIHNlcnZlcl9waWQpOgogICAgICAgICAiIiJTaHV0IGRvd24gdGhlIGxpZ2h0dHBkIHdlYiBz ZXJ2ZXIuIEJsb2NrcyB1bnRpbCBpdCdzIGZ1bGx5Cg== 50225 2010-03-08 08:22:54 -0800 2010-03-12 08:02:26 -0800 patch patch text/plain 2197 agl ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCAwZjM2Y2QxLi5iNDVmYjAwIDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VM b2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTAtMDMt MDggIEFkYW0gTGFuZ2xleSAgPGFnbEBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW2Nocm9taXVtXTogdXBkYXRlIExpbnV4IGxh eW91dCB0ZXN0IHNjcmlwdHMgZm9yIFJlZEhhdCBsaWtlIHN5c3RlbXMuCisKKyAgICAgICAgKFRl c3RlZCBvbiBGZWRvcmEgMTIuKQorCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0zNTg2NworCisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS9sYXlvdXRf dGVzdHMvcG9ydC9jaHJvbWl1bV9saW51eC5weToKKwogMjAxMC0wMy0wOCAgR3VzdGF2byBOb3Jv bmhhIFNpbHZhICA8Z25zQGdub21lLm9yZz4KIAogICAgICAgICBObyByZXZpZXcsIHJvbGxpbmcg b3V0IHI1NTY2Mi4KZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5 b3V0X3Rlc3RzL3BvcnQvY2hyb21pdW1fbGludXgucHkgYi9XZWJLaXRUb29scy9TY3JpcHRzL3dl YmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L2Nocm9taXVtX2xpbnV4LnB5CmluZGV4IDQzNWUxZTAu LmUxNDdiZmQgMTAwNjQ0Ci0tLSBhL1dlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0 X3Rlc3RzL3BvcnQvY2hyb21pdW1fbGludXgucHkKKysrIGIvV2ViS2l0VG9vbHMvU2NyaXB0cy93 ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC9jaHJvbWl1bV9saW51eC5weQpAQCAtMTQ1LDExICsx NDUsMTkgQEAgY2xhc3MgQ2hyb21pdW1MaW51eFBvcnQoY2hyb21pdW0uQ2hyb21pdW1Qb3J0KToK ICAgICAgICAgbnVsbC5jbG9zZSgpCiAKICAgICBkZWYgX3BhdGhfdG9fYXBhY2hlKHNlbGYpOgot ICAgICAgICByZXR1cm4gJy91c3Ivc2Jpbi9hcGFjaGUyJworICAgICAgICBpZiBzZWxmLl9pc19y ZWRoYXRfYmFzZWQoKToKKyAgICAgICAgICAgIHJldHVybiAnL3Vzci9zYmluL2h0dHBkJworICAg ICAgICBlbHNlOgorICAgICAgICAgICAgcmV0dXJuICcvdXNyL3NiaW4vYXBhY2hlMicKIAogICAg IGRlZiBfcGF0aF90b19hcGFjaGVfY29uZmlnX2ZpbGUoc2VsZik6CisgICAgICAgIGlmIHNlbGYu X2lzX3JlZGhhdF9iYXNlZCgpOgorICAgICAgICAgICAgY29uZmlnX25hbWUgPSAnZmVkb3JhLWh0 dHBkLmNvbmYnCisgICAgICAgIGVsc2U6CisgICAgICAgICAgICBjb25maWdfbmFtZSA9ICdhcGFj aGUyLWRlYmlhbi1odHRwZC5jb25mJworCiAgICAgICAgIHJldHVybiBvcy5wYXRoLmpvaW4oc2Vs Zi5sYXlvdXRfdGVzdHNfZGlyKCksICdodHRwJywgJ2NvbmYnLAotICAgICAgICAgICAgICAgICAg ICAgICAgICAgICdhcGFjaGUyLWRlYmlhbi1odHRwZC5jb25mJykKKyAgICAgICAgICAgICAgICAg ICAgICAgICAgICBjb25maWdfbmFtZSkKIAogICAgIGRlZiBfcGF0aF90b19saWdodHRwZChzZWxm KToKICAgICAgICAgcmV0dXJuICIvdXNyL3NiaW4vbGlnaHR0cGQiCkBAIC0xNzIsNyArMTgwLDEz IEBAIGNsYXNzIENocm9taXVtTGludXhQb3J0KGNocm9taXVtLkNocm9taXVtUG9ydCk6CiAgICAg ICAgIHJldHVybiBzZWxmLl9idWlsZF9wYXRoKHNlbGYuX29wdGlvbnMudGFyZ2V0LCAnaW1hZ2Vf ZGlmZicpCiAKICAgICBkZWYgX3BhdGhfdG9fd2RpZmYoc2VsZik6Ci0gICAgICAgIHJldHVybiAn L3Vzci9iaW4vd2RpZmYnCisgICAgICAgIGlmIHNlbGYuX2lzX3JlZGhhdF9iYXNlZCgpOgorICAg ICAgICAgICAgcmV0dXJuICcvdXNyL2Jpbi9kd2RpZmYnCisgICAgICAgIGVsc2U6CisgICAgICAg ICAgICByZXR1cm4gJy91c3IvYmluL3dkaWZmJworCisgICAgZGVmIF9pc19yZWRoYXRfYmFzZWQo c2VsZik6CisgICAgICAgIHJldHVybiBvcy5wYXRoLmV4aXN0cyhvcy5wYXRoLmpvaW4oJy9ldGMn LCAncmVkaGF0LXJlbGVhc2UnKSkKIAogICAgIGRlZiBfc2h1dF9kb3duX2h0dHBfc2VydmVyKHNl bGYsIHNlcnZlcl9waWQpOgogICAgICAgICAiIiJTaHV0IGRvd24gdGhlIGxpZ2h0dHBkIHdlYiBz ZXJ2ZXIuIEJsb2NrcyB1bnRpbCBpdCdzIGZ1bGx5Cg==