35866 2010-03-08 07:39:10 -0800 [Qt] Enable accelerated compositing by default 2010-05-14 08:42:35 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other All CLOSED FIXED Qt P2 Normal --- 36234 37381 38744 1 hausmann hausmann christophe.public commit-queue jesus kenneth laszlo.gombos noam ossy oldest_to_newest 197158 0 hausmann 2010-03-08 07:39:10 -0800 [Qt] Enable accelerated compositing by default 197159 1 50220 hausmann 2010-03-08 07:39:39 -0800 Created attachment 50220 Patch 197160 2 hausmann 2010-03-08 07:40:43 -0800 Noam, could you also take a quick look at this patch and double check the "documentation" I've added? Thanks :) 197230 3 noam 2010-03-08 10:49:26 -0800 I'd also maybe add a word about 3D and video? without AC the perspective attribute doesn't render at all, and the video tag makes WebCore render for each frame. So there are some UIs that are only achievable with AC, regardless of performance. Otherwise LGTM 198111 4 vestbo 2010-03-10 06:44:14 -0800 Please follow the QtWebKit bug reporting guidelines when reporting bugs. See http://trac.webkit.org/wiki/QtWebKitBugs Specifically: - The 'QtWebKit' component should only be used for bugs/features in the public QtWebKit API layer, not to signify that the bug is specific to the Qt port of WebKit http://trac.webkit.org/wiki/QtWebKitBugs#Component - Add the keyword 'Qt' to signal that it's a Qt-related bug http://trac.webkit.org/wiki/QtWebKitBugs#Keywords 199173 5 50220 kenneth 2010-03-12 12:38:43 -0800 Comment on attachment 50220 Patch Looks good, but a follow up patch is needed to the QtLauncher. 199329 6 50220 commit-queue 2010-03-13 01:21:30 -0800 Comment on attachment 50220 Patch Clearing flags on attachment: 50220 Committed r55955: <http://trac.webkit.org/changeset/55955> 199330 7 commit-queue 2010-03-13 01:21:34 -0800 All reviewed patches have been landed. Closing bug. 199369 8 ossy 2010-03-13 10:14:31 -0800 This patch broke 3 animation test, so I had to roll-out. (http://trac.webkit.org/changeset/55963) detailed results: http://build.webkit.org/results/Qt%20Linux%20Release/r55955%20%288504%29/results.html 199373 9 kenneth 2010-03-13 10:23:11 -0800 I cq'ed 2 other patches providing fixed to AC. When these land, could you retest with this patch? It would be nice to have this enabled by default so that we can actually make sure that our AC works as expected. 199420 10 ossy 2010-03-13 15:48:23 -0800 (In reply to comment #9) > I cq'ed 2 other patches providing fixed to AC. When these land, could you > retest with this patch? I retested r55970 with this patch, but unfortunately the three animation test still fail. 200428 11 jesus 2010-03-16 14:13:22 -0700 Is this Mac OS specific? If not, could you please change the OS so we don't add another item to the Mac specific bugs list? (I can't edit the bugzilla entry, otherwise I would edit this.) 200431 12 ossy 2010-03-16 14:18:59 -0700 (In reply to comment #11) > Is this Mac OS specific? No, I changed it. 200451 13 50840 ossy 2010-03-16 14:43:02 -0700 Created attachment 50840 enable AC, skip failing tests Kenneth told me on #qtwebkit that enabling AC is more important than these three failing tests now, so we can enable AC, and skip them until fix. Thank for Noam to file another bug for fixing these tests. 200707 14 50840 ossy 2010-03-17 05:48:48 -0700 Comment on attachment 50840 enable AC, skip failing tests I landed it manually, because CQ didin't work for a day: http://trac.webkit.org/changeset/56106 200934 15 jesus 2010-03-17 13:06:59 -0700 Follow up patch for QtLauncher is here: https://bugs.webkit.org/show_bug.cgi?id=36234 201617 16 hausmann 2010-03-18 15:51:32 -0700 *** Bug 35522 has been marked as a duplicate of this bug. *** 203531 17 kenneth 2010-03-24 12:10:26 -0700 Can this bug be closed? or what is missing? 203539 18 ossy 2010-03-24 12:27:38 -0700 (In reply to comment #17) > Can this bug be closed? or what is missing? Fixing the 3 tests was broken by enabling AC is missing: https://bugs.webkit.org/show_bug.cgi?id=36191 From now this bug depends on b36191, I suggest we shouldn't close it until fix. 209169 19 kenneth 2010-04-06 12:18:27 -0700 Can we close this one? or what is missing? 225776 20 ossy 2010-05-14 06:06:59 -0700 (In reply to comment #19) > Can we close this one? or what is missing? Yes, because all test work and are unskipped now. 225847 21 hausmann 2010-05-14 08:42:22 -0700 Revision r55955 cherry-picked into qtwebkit-2.0 with commit 75fb772135fa93687ef31e76224d0d5b3c0bbd5f 50220 2010-03-08 07:39:39 -0800 2010-03-16 14:43:02 -0700 Patch bug-35866-20100308163936.patch text/plain 2088 hausmann ZGlmZiAtLWdpdCBhL1dlYktpdC9xdC9BcGkvcXdlYnNldHRpbmdzLmNwcCBiL1dlYktpdC9xdC9B cGkvcXdlYnNldHRpbmdzLmNwcAppbmRleCBjMzVkZDc5Li5mNzE0ZTFhIDEwMDY0NAotLS0gYS9X ZWJLaXQvcXQvQXBpL3F3ZWJzZXR0aW5ncy5jcHAKKysrIGIvV2ViS2l0L3F0L0FwaS9xd2Vic2V0 dGluZ3MuY3BwCkBAIC0zOTIsNiArMzkyLDEwIEBAIFFXZWJTZXR0aW5ncyogUVdlYlNldHRpbmdz OjpnbG9iYWxTZXR0aW5ncygpCiAgICAgXHZhbHVlIExvY2FsQ29udGVudENhbkFjY2Vzc1JlbW90 ZVVybHMgU3BlY2lmaWVzIHdoZXRoZXIgbG9jYWxseSBsb2FkZWQgZG9jdW1lbnRzIGFyZSBhbGxv d2VkIHRvIGFjY2VzcyByZW1vdGUgdXJscy4KICAgICBcdmFsdWUgTG9jYWxDb250ZW50Q2FuQWNj ZXNzRmlsZVVybHMgU3BlY2lmaWVzIHdoZXRoZXIgbG9jYWxseSBsb2FkZWQgZG9jdW1lbnRzIGFy ZSBhbGxvd2VkIHRvIGFjY2VzcyBvdGhlciBsb2NhbCAgdXJscy4KICAgICBcdmFsdWUgWFNTQXVk aXRvckVuYWJsZWQgU3BlY2lmaWVzIHdoZXRoZXIgbG9hZCByZXF1ZXN0cyBzaG91bGQgYmUgbW9u aXRvcmVkIGZvciBjcm9zcy1zaXRlIHNjcmlwdGluZyBhdHRlbXB0cy4KKyAgICBcdmFsdWUgQWNj ZWxlcmF0ZWRDb21wb3NpdGluZ0VuYWJsZWQgVGhpcyBmZWF0dXJlLCB3aGVuIHVzZWQgaW4gY29u anVuY3Rpb24gd2l0aAorICAgICAgICBRR3JhcGhpY3NXZWJWaWV3LCBhY2NlbGVyYXRlcyBhbmlt YXRpb25zIG9mIHdlYiBjb250ZW50LiBDU1MgYW5pbWF0aW9ucyBvZiB0aGUgdHJhbnNmb3JtIGFu ZAorICAgICAgICBvcGFjaXR5IHByb3BlcnRpZXMgd2lsbCBiZSByZW5kZXJlZCBieSBjb21wb3Np bmcgdGhlIGNhY2hlZCBjb250ZW50IG9mIHRoZSBhbmltYXRlZCBlbGVtZW50cy4KKyAgICAgICAg VGhpcyBmZWF0dXJlIGlzIGVuYWJsZWQgYnkgZGVmYXVsdAogKi8KIAogLyohCkBAIC00MjQsNyAr NDI4LDcgQEAgUVdlYlNldHRpbmdzOjpRV2ViU2V0dGluZ3MoKQogICAgIGQtPmF0dHJpYnV0ZXMu aW5zZXJ0KFFXZWJTZXR0aW5nczo6TG9jYWxTdG9yYWdlRW5hYmxlZCwgZmFsc2UpOwogICAgIGQt PmF0dHJpYnV0ZXMuaW5zZXJ0KFFXZWJTZXR0aW5nczo6TG9jYWxDb250ZW50Q2FuQWNjZXNzUmVt b3RlVXJscywgZmFsc2UpOwogICAgIGQtPmF0dHJpYnV0ZXMuaW5zZXJ0KFFXZWJTZXR0aW5nczo6 TG9jYWxDb250ZW50Q2FuQWNjZXNzRmlsZVVybHMsIHRydWUpOwotICAgIGQtPmF0dHJpYnV0ZXMu aW5zZXJ0KFFXZWJTZXR0aW5nczo6QWNjZWxlcmF0ZWRDb21wb3NpdGluZ0VuYWJsZWQsIGZhbHNl KTsKKyAgICBkLT5hdHRyaWJ1dGVzLmluc2VydChRV2ViU2V0dGluZ3M6OkFjY2VsZXJhdGVkQ29t cG9zaXRpbmdFbmFibGVkLCB0cnVlKTsKICAgICBkLT5hdHRyaWJ1dGVzLmluc2VydChRV2ViU2V0 dGluZ3M6OldlYkdMRW5hYmxlZCwgZmFsc2UpOwogICAgIGQtPm9mZmxpbmVTdG9yYWdlRGVmYXVs dFF1b3RhID0gNSAqIDEwMjQgKiAxMDI0OwogICAgIGQtPmRlZmF1bHRUZXh0RW5jb2RpbmcgPSBR TGF0aW4xU3RyaW5nKCJpc28tODg1OS0xIik7CmRpZmYgLS1naXQgYS9XZWJLaXQvcXQvQ2hhbmdl TG9nIGIvV2ViS2l0L3F0L0NoYW5nZUxvZwppbmRleCA0YzAwMjc4Li43YWUxZjUzIDEwMDY0NAot LS0gYS9XZWJLaXQvcXQvQ2hhbmdlTG9nCisrKyBiL1dlYktpdC9xdC9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxMyBAQAorMjAxMC0wMy0wOCAgU2ltb24gSGF1c21hbm4gIDxzaW1vbi5oYXVzbWFubkBu b2tpYS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgW1F0XSBFbmFibGUgYWNjZWxlcmF0ZWQgY29tcG9zaXRpbmcgYnkgZGVmYXVsdAorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzU4NjYKKworICAgICAg ICAqIEFwaS9xd2Vic2V0dGluZ3MuY3BwOgorICAgICAgICAoUVdlYlNldHRpbmdzOjpRV2ViU2V0 dGluZ3MpOgorCiAyMDEwLTAzLTA2ICBNYXJrIFJvd2UgIDxtcm93ZUBhcHBsZS5jb20+CiAKICAg ICAgICAgUnViYmVyLXN0YW1wZWQgYnkgU2FtIFdlaW5pZy4K 50840 2010-03-16 14:43:02 -0700 2010-03-17 05:48:48 -0700 enable AC, skip failing tests AC.patch text/plain 3472 ossy SW5kZXg6IFdlYktpdC9xdC9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L3F0L0NoYW5n ZUxvZwkocmV2aXNpb24gNTYwODcpCisrKyBXZWJLaXQvcXQvQ2hhbmdlTG9nCSh3b3JraW5nIGNv cHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTAtMDMtMTYgIENzYWJhIE9zenRyb2dvbsOhYyAgPG9z c3lAd2Via2l0Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBbUXRdIEVuYWJsZSBhY2NlbGVyYXRlZCBjb21wb3NpdGluZyBieSBkZWZhdWx0Cisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zNTg2NgorCisg ICAgICAgICogQXBpL3F3ZWJzZXR0aW5ncy5jcHA6CisgICAgICAgIChRV2ViU2V0dGluZ3M6OlFX ZWJTZXR0aW5ncyk6CisKIDIwMTAtMDMtMTUgIEFudHRpIEtvaXZpc3RvICA8a29pdmlzdG9AaWtp LmZpPgogCiAgICAgICAgIFJldmlld2VkIGJ5IFNpbW9uIEhhdXNtYW5uLgpJbmRleDogV2ViS2l0 L3F0L0FwaS9xd2Vic2V0dGluZ3MuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdC9xdC9BcGkvcXdl YnNldHRpbmdzLmNwcAkocmV2aXNpb24gNTYwODUpCisrKyBXZWJLaXQvcXQvQXBpL3F3ZWJzZXR0 aW5ncy5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTM5Nyw2ICszOTcsMTAgQEAKICAgICBcdmFsdWUg TG9jYWxDb250ZW50Q2FuQWNjZXNzUmVtb3RlVXJscyBTcGVjaWZpZXMgd2hldGhlciBsb2NhbGx5 IGxvYWRlZCBkb2N1bWVudHMgYXJlIGFsbG93ZWQgdG8gYWNjZXNzIHJlbW90ZSB1cmxzLgogICAg IFx2YWx1ZSBMb2NhbENvbnRlbnRDYW5BY2Nlc3NGaWxlVXJscyBTcGVjaWZpZXMgd2hldGhlciBs b2NhbGx5IGxvYWRlZCBkb2N1bWVudHMgYXJlIGFsbG93ZWQgdG8gYWNjZXNzIG90aGVyIGxvY2Fs IHVybHMuCiAgICAgXHZhbHVlIFhTU0F1ZGl0b3JFbmFibGVkIFNwZWNpZmllcyB3aGV0aGVyIGxv YWQgcmVxdWVzdHMgc2hvdWxkIGJlIG1vbml0b3JlZCBmb3IgY3Jvc3Mtc2l0ZSBzY3JpcHRpbmcg YXR0ZW1wdHMuCisgICAgXHZhbHVlIEFjY2VsZXJhdGVkQ29tcG9zaXRpbmdFbmFibGVkIFRoaXMg ZmVhdHVyZSwgd2hlbiB1c2VkIGluIGNvbmp1bmN0aW9uIHdpdGgKKyAgICAgICAgUUdyYXBoaWNz V2ViVmlldywgYWNjZWxlcmF0ZXMgYW5pbWF0aW9ucyBvZiB3ZWIgY29udGVudC4gQ1NTIGFuaW1h dGlvbnMgb2YgdGhlIHRyYW5zZm9ybSBhbmQKKyAgICAgICAgb3BhY2l0eSBwcm9wZXJ0aWVzIHdp bGwgYmUgcmVuZGVyZWQgYnkgY29tcG9zaW5nIHRoZSBjYWNoZWQgY29udGVudCBvZiB0aGUgYW5p bWF0ZWQgZWxlbWVudHMuCisgICAgICAgIFRoaXMgZmVhdHVyZSBpcyBlbmFibGVkIGJ5IGRlZmF1 bHQKICovCiAKIC8qIQpAQCAtNDI5LDcgKzQzMyw3IEBACiAgICAgZC0+YXR0cmlidXRlcy5pbnNl cnQoUVdlYlNldHRpbmdzOjpMb2NhbFN0b3JhZ2VFbmFibGVkLCBmYWxzZSk7CiAgICAgZC0+YXR0 cmlidXRlcy5pbnNlcnQoUVdlYlNldHRpbmdzOjpMb2NhbENvbnRlbnRDYW5BY2Nlc3NSZW1vdGVV cmxzLCBmYWxzZSk7CiAgICAgZC0+YXR0cmlidXRlcy5pbnNlcnQoUVdlYlNldHRpbmdzOjpMb2Nh bENvbnRlbnRDYW5BY2Nlc3NGaWxlVXJscywgdHJ1ZSk7Ci0gICAgZC0+YXR0cmlidXRlcy5pbnNl cnQoUVdlYlNldHRpbmdzOjpBY2NlbGVyYXRlZENvbXBvc2l0aW5nRW5hYmxlZCwgZmFsc2UpOwor ICAgIGQtPmF0dHJpYnV0ZXMuaW5zZXJ0KFFXZWJTZXR0aW5nczo6QWNjZWxlcmF0ZWRDb21wb3Np dGluZ0VuYWJsZWQsIHRydWUpOwogICAgIGQtPmF0dHJpYnV0ZXMuaW5zZXJ0KFFXZWJTZXR0aW5n czo6V2ViR0xFbmFibGVkLCBmYWxzZSk7CiAgICAgZC0+b2ZmbGluZVN0b3JhZ2VEZWZhdWx0UXVv dGEgPSA1ICogMTAyNCAqIDEwMjQ7CiAgICAgZC0+ZGVmYXVsdFRleHRFbmNvZGluZyA9IFFMYXRp bjFTdHJpbmcoImlzby04ODU5LTEiKTsKSW5kZXg6IExheW91dFRlc3RzL3BsYXRmb3JtL3F0L1Nr aXBwZWQKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvcGxhdGZvcm0vcXQvU2tpcHBlZAkocmV2 aXNpb24gNTYwODUpCisrKyBMYXlvdXRUZXN0cy9wbGF0Zm9ybS9xdC9Ta2lwcGVkCSh3b3JraW5n IGNvcHkpCkBAIC01MTA5LDMgKzUxMDksOSBAQAogCiAjIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0zNTk3MwogZmFzdC9tdWx0aWNvbC9oaXQtdGVzdC1hYm92ZS1vci1i ZWxvdy5odG1sCisKKyMgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM2 MTkxCitbUXRdIEdyYXBoaWNzTGF5ZXI6IGZpeCB0ZXN0IHJlZ3Jlc3Npb25zCithbmltYXRpb25z L2ZpbGwtbW9kZS10cmFuc2Zvcm0uaHRtbAorYW5pbWF0aW9ucy9wbGF5LXN0YXRlLmh0bWwKK2Fu aW1hdGlvbnMvc2ltdWx0YW5lb3VzLXN0YXJ0LWxlZnQuaHRtbApJbmRleDogTGF5b3V0VGVzdHMv Q2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL0NoYW5nZUxvZwkocmV2aXNpb24g NTYwODcpCisrKyBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyAr MSwxOSBAQAorMjAxMC0wMy0xNiAgQ3NhYmEgT3N6dHJvZ29uw6FjICA8b3NzeUB3ZWJraXQub3Jn PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtRdF0g R3JhcGhpY3NMYXllcjogZml4IHRlc3QgcmVncmVzc2lvbnMKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM2MTkxCisKKyAgICAgICAgRW5hYmxpbmcgYWNj ZWxlcmF0ZWQgY29tcG9zaXRpbmcgKEFDKSBieSBkZWZhdWx0IG1ha2UgMyB0ZXN0cyBmYWlsLgor ICAgICAgICBBQyBpcyBtb3JlIGltcG9ydGFudCBub3cgdGhhbiB0aGVzZSB0ZXN0cywgc28gdGhl eSBhcmUgc2tpcHBlZCB1bnRpbCAKKyAgICAgICAgZml4IGFuZCBBQyBpcyBlbmFibGVkLgorCisg ICAgICAgICogcGxhdGZvcm0vcXQvU2tpcHBlZDoKKyAgICAgICAgIC0gYW5pbWF0aW9ucy9maWxs LW1vZGUtdHJhbnNmb3JtLmh0bWwgc2tpcHBlZAorICAgICAgICAgLSBhbmltYXRpb25zL3BsYXkt c3RhdGUuaHRtbCBza2lwcGVkCisgICAgICAgICAtIGFuaW1hdGlvbnMvc2ltdWx0YW5lb3VzLXN0 YXJ0LWxlZnQuaHRtbCBza2lwcGVkCisKIDIwMTAtMDMtMTYgIEFsZXhleSBQcm9za3VyeWFrb3Yg IDxhcEBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGFyaW4gQWRsZXIuCg==