35864 2010-03-08 07:00:30 -0800 [GStreamer] soften dependency on libsoup in the http src element 2010-03-26 02:00:28 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 pnormand pnormand eric gustavo oldest_to_newest 197147 0 pnormand 2010-03-08 07:00:30 -0800 So other ports not using libsoup could reuse this code. Not much to do, replace a SoupURI use with KURL and pause/unpause internal soup messages only if libsoup supprt is enabled. 197152 1 50218 pnormand 2010-03-08 07:16:45 -0800 Created attachment 50218 proposed patch 197298 2 50218 gustavo 2010-03-08 13:48:03 -0800 Comment on attachment 50218 proposed patch Looks sane to me, but priv->paused may no longer be true, depending on the network implementation. May warrant a comment? 197496 3 pnormand 2010-03-09 01:07:22 -0800 (In reply to comment #2) > (From update of attachment 50218 [details]) > Looks sane to me, but priv->paused may no longer be true, depending on the > network implementation. May warrant a comment? Why? It will still be assigned to true in webKitWebSrcEnoughDataMainCb. Not sure to understand what comment I should add ;) 198181 4 gustavo 2010-03-10 09:49:11 -0800 (In reply to comment #3) > (In reply to comment #2) > > (From update of attachment 50218 [details] [details]) > > Looks sane to me, but priv->paused may no longer be true, depending on the > > network implementation. May warrant a comment? > > Why? It will still be assigned to true in webKitWebSrcEnoughDataMainCb. Not > sure to understand what comment I should add ;) Sorry, I meant that it will be telling lies, since the http download has not been truly paused. 199895 5 eric 2010-03-15 15:57:59 -0700 Attachment 50218 was posted by a committer and has review+, assigning to Philippe Normand for commit. 204472 6 pnormand 2010-03-26 02:00:28 -0700 Landed as r56615. Sorry for the delay ;) Also added comments suggesting about pause/unpause. 50218 2010-03-08 07:16:45 -0800 2010-03-08 13:48:03 -0800 proposed patch proposed-patch.patch text/plain 3409 pnormand RnJvbSBiYTUwOTYzZmE1MTUwZDM1MTUwYjNmMGIwOWI4MTcxNWU0NThlNzhjIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQaGlsaXBwZSBOb3JtYW5kIDxwbm9ybWFuZEBpZ2FsaWEuY29t PgpEYXRlOiBNb24sIDggTWFyIDIwMTAgMTY6MDQ6MjUgKzAxMDAKU3ViamVjdDogW1BBVENIXSBw cm9wb3NlZCBwYXRjaAoKLS0tCiBXZWJDb3JlL0NoYW5nZUxvZyAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICB8ICAgMTcgKysrKysrKysrKysrKysrKysKIC4uLi9nc3RyZWFtZXIvV2Vi S2l0V2ViU291cmNlR1N0cmVhbWVyLmNwcCAgICAgICAgIHwgICAxNiArKysrKysrKystLS0tLS0t CiAyIGZpbGVzIGNoYW5nZWQsIDI2IGluc2VydGlvbnMoKyksIDcgZGVsZXRpb25zKC0pCgpkaWZm IC0tZ2l0IGEvV2ViQ29yZS9DaGFuZ2VMb2cgYi9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBjOTBj YzFiLi4zZDUzYTcwIDEwMDY0NAotLS0gYS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9XZWJDb3Jl L0NoYW5nZUxvZwpAQCAtMiw2ICsyLDIzIEBACiAKICAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCiAKKyAgICAgICAgW0dTdHJlYW1lcl0gc29mdGVuIGRlcGVuZGVuY3kgb24gbGli c291cCBpbiB0aGUgaHR0cCBzcmMgZWxlbWVudAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzU4NjQKKworICAgICAgICBSZXBsYWNlZCBTb3VwVVJJIGNh bGxzIHdpdGggS1VSTCBhbmQgcGF1c2UvcmVzdW1lIGludGVybmFsIHNvdXAKKyAgICAgICAgbWVz c2FnZXMgb25seSBpZiB0aGUgZWxlbWVudCBpcyBjb21waWxlZCBmb3IgYSBwb3J0IGRlcGVuZGlu ZyBvbgorICAgICAgICBsaWJzb3VwLgorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0 cmVhbWVyL1dlYktpdFdlYlNvdXJjZUdTdHJlYW1lci5jcHA6CisgICAgICAgICh3ZWJraXRfd2Vi X3NyY19pbml0KToKKyAgICAgICAgKHdlYktpdFdlYlNyY1NldFVyaSk6CisgICAgICAgICh3ZWJL aXRXZWJTcmNOZWVkRGF0YU1haW5DYik6CisgICAgICAgICh3ZWJLaXRXZWJTcmNFbm91Z2hEYXRh TWFpbkNiKToKKworMjAxMC0wMy0wOCAgUGhpbGlwcGUgTm9ybWFuZCAgPHBub3JtYW5kQGlnYWxp YS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKICAgICAgICAg W0dUS10gR1RLX1dJREdFVF9OT19XSU5ET1cgZGVwcmVjYXRlZCBpbiBHVEsrIDIuMjAKICAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM1NzI3CiAKZGlmZiAt LWdpdCBhL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL1dlYktpdFdlYlNvdXJj ZUdTdHJlYW1lci5jcHAgYi9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9XZWJL aXRXZWJTb3VyY2VHU3RyZWFtZXIuY3BwCmluZGV4IDc0YTc4NTIuLmU5YzBiODkgMTAwNjQ0Ci0t LSBhL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL1dlYktpdFdlYlNvdXJjZUdT dHJlYW1lci5jcHAKKysrIGIvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvV2Vi S2l0V2ViU291cmNlR1N0cmVhbWVyLmNwcApAQCAtMjU1LDYgKzI1NSw3IEBAIHN0YXRpYyB2b2lk IHdlYmtpdF93ZWJfc3JjX2luaXQoV2ViS2l0V2ViU3JjKiBzcmMsCiAgICAgLy8gYWxyZWFkeSBp ZiB0aGUgcXVldWUgaXMgMjAlIGVtcHR5LCBpdCdzIG11Y2ggbW9yZQogICAgIC8vIGxpa2VseSB0 aGF0IGxpYnNvdXAgYWxyZWFkeSBwcm92aWRlcyBuZXcgZGF0YSBiZWZvcmUKICAgICAvLyB0aGUg cXVldWUgaXMgcmVhbGx5IGVtcHR5LgorICAgIC8vIFRoaXMgbWlnaHQgbmVlZCB0d2Vha2luZyBm b3IgcG9ydHMgbm90IHVzaW5nIGxpYnNvdXAuCiAgICAgaWYgKHByaXYtPmhhdmVBcHBTcmMyNykK ICAgICAgICAgZ19vYmplY3Rfc2V0KHByaXYtPmFwcHNyYywgIm1pbi1wZXJjZW50IiwgMjAsIE5V TEwpOwogCkBAIC01MDUsMTcgKzUwNiwxNCBAQCBzdGF0aWMgZ2Jvb2xlYW4gd2ViS2l0V2ViU3Jj U2V0VXJpKEdzdFVSSUhhbmRsZXIqIGhhbmRsZXIsIGNvbnN0IGdjaGFyKiB1cmkpCiAgICAgaWYg KCF1cmkpCiAgICAgICAgIHJldHVybiBUUlVFOwogCi0gICAgU291cFVSSSogc291cFVyaSA9IHNv dXBfdXJpX25ldyh1cmkpOworICAgIEtVUkwgdXJsKEtVUkwoKSwgdXJpKTsKIAotICAgIGlmICgh c291cFVyaSB8fCAhU09VUF9VUklfVkFMSURfRk9SX0hUVFAoc291cFVyaSkpIHsKKyAgICBpZiAo IXVybC5pc1ZhbGlkKCkgfHwgIXVybC5wcm90b2NvbEluSFRUUEZhbWlseSgpKSB7CiAgICAgICAg IEdTVF9FUlJPUl9PQkpFQ1Qoc3JjLCAiSW52YWxpZCBVUkkgJyVzJyIsIHVyaSk7Ci0gICAgICAg IHNvdXBfdXJpX2ZyZWUoc291cFVyaSk7CiAgICAgICAgIHJldHVybiBGQUxTRTsKICAgICB9CiAK LSAgICBwcml2LT51cmkgPSBzb3VwX3VyaV90b19zdHJpbmcoc291cFVyaSwgRkFMU0UpOwotICAg IHNvdXBfdXJpX2ZyZWUoc291cFVyaSk7Ci0KKyAgICBwcml2LT51cmkgPSBnX3N0cmR1cCh1cmwu c3RyaW5nKCkudXRmOCgpLmRhdGEoKSk7CiAgICAgcmV0dXJuIFRSVUU7CiB9CiAKQEAgLTUzNSw5 ICs1MzMsMTEgQEAgc3RhdGljIGdib29sZWFuIHdlYktpdFdlYlNyY05lZWREYXRhTWFpbkNiKFdl YktpdFdlYlNyYyogc3JjKQogewogICAgIFdlYktpdFdlYlNyY1ByaXZhdGUqIHByaXYgPSBzcmMt PnByaXY7CiAKKyNpZiBVU0UoTkVUV09SS19TT1VQKQogICAgIFJlc291cmNlSGFuZGxlSW50ZXJu YWwqIGQgPSBwcml2LT5yZXNvdXJjZUhhbmRsZS0+Z2V0SW50ZXJuYWwoKTsKICAgICBpZiAoZC0+ bV9tc2cpCiAgICAgICAgIHNvdXBfc2Vzc2lvbl91bnBhdXNlX21lc3NhZ2UoUmVzb3VyY2VIYW5k bGU6OmRlZmF1bHRTZXNzaW9uKCksIGQtPm1fbXNnKTsKKyNlbmRpZgogCiAgICAgcHJpdi0+cGF1 c2VkID0gRkFMU0U7CiAgICAgcHJpdi0+bmVlZERhdGFJRCA9IDA7CkBAIC01NjAsOSArNTYwLDEx IEBAIHN0YXRpYyBnYm9vbGVhbiB3ZWJLaXRXZWJTcmNFbm91Z2hEYXRhTWFpbkNiKFdlYktpdFdl YlNyYyogc3JjKQogewogICAgIFdlYktpdFdlYlNyY1ByaXZhdGUqIHByaXYgPSBzcmMtPnByaXY7 CiAKKyNpZiBVU0UoTkVUV09SS19TT1VQKQogICAgIFJlc291cmNlSGFuZGxlSW50ZXJuYWwqIGQg PSBwcml2LT5yZXNvdXJjZUhhbmRsZS0+Z2V0SW50ZXJuYWwoKTsKICAgICBzb3VwX3Nlc3Npb25f cGF1c2VfbWVzc2FnZShSZXNvdXJjZUhhbmRsZTo6ZGVmYXVsdFNlc3Npb24oKSwgZC0+bV9tc2cp OwotICAgIAorI2VuZGlmCisKICAgICBwcml2LT5wYXVzZWQgPSBUUlVFOwogICAgIHByaXYtPmVu b3VnaERhdGFJRCA9IDA7CiAgICAgcmV0dXJuIEZBTFNFOwotLSAKMS42LjMuMw==