35848 2010-03-07 17:16:10 -0800 Remove inconsistent "Too few arguments" handling for window.atob() and window.btoa() 2010-03-07 17:27:11 -0800 1 1 1 Unclassified WebKit WebCore JavaScript 528+ (Nightly build) All OS X 10.5 RESOLVED FIXED P2 Normal --- 1 sam webkit-unassigned oldest_to_newest 197045 0 sam 2010-03-07 17:16:10 -0800 window.atob() and window.btoa() throw on too few arguments being passed which is inconsistent and unnecessary. We should convert it treat arguments not passed as undefined like we do for almost all other functions. 197046 1 50181 sam 2010-03-07 17:19:22 -0800 Created attachment 50181 patch 197047 2 50181 mitz 2010-03-07 17:22:33 -0800 Comment on attachment 50181 patch > +>>>>>>> .r55629 I was instructed to ignore this, so r=me 197048 3 sam 2010-03-07 17:27:11 -0800 Landed in r55637. 50181 2010-03-07 17:19:22 -0800 2010-03-07 17:22:33 -0800 patch patch.diff text/plain 7091 sam SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1NTYzNikKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTggQEAKKzIwMTAtMDMtMDcgIFNhbSBXZWluaWcgIDxzYW1Ad2Via2l0Lm9yZz4K KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBSZW1vdmUg aW5jb25zaXN0ZW50ICJUb28gZmV3IGFyZ3VtZW50cyIgaGFuZGxpbmcgZm9yIHdpbmRvdy5hdG9i KCkgYW5kIHdpbmRvdy5idG9hKCkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTM1ODQ4CisKKyAgICAgICAgLSBUYWtlIHRoZSBvcHBvcnR1bml0eSB0byBm dWxseSBhdXRvZ2VuZXJhdGUgd2luZG93LmF0b2IoKSBhbmQgd2luZG93LmJ0b2EoKS4KKworICAg ICAgICAqIGJpbmRpbmdzL2pzL0pTRE9NV2luZG93Q3VzdG9tLmNwcDoKKyAgICAgICAgKiBwYWdl L0RPTVdpbmRvdy5jcHA6CisgICAgICAgIChXZWJDb3JlOjpET01XaW5kb3c6OmJ0b2EpOgorICAg ICAgICAoV2ViQ29yZTo6RE9NV2luZG93OjphdG9iKToKKyAgICAgICAgKiBwYWdlL0RPTVdpbmRv dy5pZGw6CisKIDIwMTAtMDMtMDcgIERhbiBCZXJuc3RlaW4gIDxtaXR6QGFwcGxlLmNvbT4KIAog ICAgICAgICBSZXZpZXdlZCBieSBTaW1vbiBGcmFzZXIuCkluZGV4OiBXZWJDb3JlL2JpbmRpbmdz L2pzL0pTRE9NV2luZG93Q3VzdG9tLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL2JpbmRpbmdz L2pzL0pTRE9NV2luZG93Q3VzdG9tLmNwcAkocmV2aXNpb24gNTU2MjkpCisrKyBXZWJDb3JlL2Jp bmRpbmdzL2pzL0pTRE9NV2luZG93Q3VzdG9tLmNwcAkod29ya2luZyBjb3B5KQpAQCAtOTQwLDM0 ICs5NDAsNiBAQCBKU1ZhbHVlIEpTRE9NV2luZG93OjpzZXRJbnRlcnZhbChFeGVjU3RhCiAgICAg cmV0dXJuIGpzTnVtYmVyKGV4ZWMsIHJlc3VsdCk7CiB9CiAKLUpTVmFsdWUgSlNET01XaW5kb3c6 OmF0b2IoRXhlY1N0YXRlKiBleGVjLCBjb25zdCBBcmdMaXN0JiBhcmdzKQotewotICAgIGlmIChh cmdzLnNpemUoKSA8IDEpCi0gICAgICAgIHJldHVybiB0aHJvd0Vycm9yKGV4ZWMsIFN5bnRheEVy cm9yLCAiTm90IGVub3VnaCBhcmd1bWVudHMiKTsKLSAgICBpZiAoYXJncy5hdCgwKS5pc051bGwo KSkKLSAgICAgICAgcmV0dXJuIGpzRW1wdHlTdHJpbmcoZXhlYyk7Ci0KLSAgICBFeGNlcHRpb25D b2RlIGVjID0gMDsKLSAgICBTdHJpbmcgcmVzdWx0ID0gaW1wbCgpLT5hdG9iKGFyZ3MuYXQoMCku dG9TdHJpbmcoZXhlYyksIGVjKTsKLSAgICBzZXRET01FeGNlcHRpb24oZXhlYywgZWMpOwotCi0g ICAgcmV0dXJuIGpzU3RyaW5nKGV4ZWMsIHJlc3VsdCk7Ci19Ci0KLUpTVmFsdWUgSlNET01XaW5k b3c6OmJ0b2EoRXhlY1N0YXRlKiBleGVjLCBjb25zdCBBcmdMaXN0JiBhcmdzKQotewotICAgIGlm IChhcmdzLnNpemUoKSA8IDEpCi0gICAgICAgIHJldHVybiB0aHJvd0Vycm9yKGV4ZWMsIFN5bnRh eEVycm9yLCAiTm90IGVub3VnaCBhcmd1bWVudHMiKTsKLSAgICBpZiAoYXJncy5hdCgwKS5pc051 bGwoKSkKLSAgICAgICAgcmV0dXJuIGpzRW1wdHlTdHJpbmcoZXhlYyk7Ci0KLSAgICBFeGNlcHRp b25Db2RlIGVjID0gMDsKLSAgICBTdHJpbmcgcmVzdWx0ID0gaW1wbCgpLT5idG9hKGFyZ3MuYXQo MCkudG9TdHJpbmcoZXhlYyksIGVjKTsKLSAgICBzZXRET01FeGNlcHRpb24oZXhlYywgZWMpOwot Ci0gICAgcmV0dXJuIGpzU3RyaW5nKGV4ZWMsIHJlc3VsdCk7Ci19Ci0KIEpTVmFsdWUgSlNET01X aW5kb3c6OmFkZEV2ZW50TGlzdGVuZXIoRXhlY1N0YXRlKiBleGVjLCBjb25zdCBBcmdMaXN0JiBh cmdzKQogewogICAgIEZyYW1lKiBmcmFtZSA9IGltcGwoKS0+ZnJhbWUoKTsKSW5kZXg6IFdlYkNv cmUvcGFnZS9ET01XaW5kb3cuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvcGFnZS9ET01XaW5k b3cuY3BwCShyZXZpc2lvbiA1NTYyOSkKKysrIFdlYkNvcmUvcGFnZS9ET01XaW5kb3cuY3BwCSh3 b3JraW5nIGNvcHkpCkBAIC04NDAsNiArODQwLDkgQEAgc3RhdGljIGJvb2wgaXNTYWZlVG9Db252 ZXJ0Q2hhckxpc3QoY29ucwogCiBTdHJpbmcgRE9NV2luZG93OjpidG9hKGNvbnN0IFN0cmluZyYg c3RyaW5nVG9FbmNvZGUsIEV4Y2VwdGlvbkNvZGUmIGVjKQogeworICAgIGlmIChzdHJpbmdUb0Vu Y29kZS5pc051bGwoKSkKKyAgICAgICAgcmV0dXJuIFN0cmluZygpOworCiAgICAgaWYgKCFpc1Nh ZmVUb0NvbnZlcnRDaGFyTGlzdChzdHJpbmdUb0VuY29kZSkpIHsKICAgICAgICAgZWMgPSBJTlZB TElEX0NIQVJBQ1RFUl9FUlI7CiAgICAgICAgIHJldHVybiBTdHJpbmcoKTsKQEAgLTg1Niw2ICs4 NTksOSBAQCBTdHJpbmcgRE9NV2luZG93OjpidG9hKGNvbnN0IFN0cmluZyYgc3RyCiAKIFN0cmlu ZyBET01XaW5kb3c6OmF0b2IoY29uc3QgU3RyaW5nJiBlbmNvZGVkU3RyaW5nLCBFeGNlcHRpb25D b2RlJiBlYykKIHsKKyAgICBpZiAoZW5jb2RlZFN0cmluZy5pc051bGwoKSkKKyAgICAgICAgcmV0 dXJuIFN0cmluZygpOworCiAgICAgaWYgKCFpc1NhZmVUb0NvbnZlcnRDaGFyTGlzdChlbmNvZGVk U3RyaW5nKSkgewogICAgICAgICBlYyA9IElOVkFMSURfQ0hBUkFDVEVSX0VSUjsKICAgICAgICAg cmV0dXJuIFN0cmluZygpOwpJbmRleDogV2ViQ29yZS9wYWdlL0RPTVdpbmRvdy5pZGwKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gV2ViQ29yZS9wYWdlL0RPTVdpbmRvdy5pZGwJKHJldmlzaW9uIDU1NjI5KQorKysg V2ViQ29yZS9wYWdlL0RPTVdpbmRvdy5pZGwJKHdvcmtpbmcgY29weSkKQEAgLTIwNCw5ICsyMDQs OSBAQCBtb2R1bGUgd2luZG93IHsKICAgICAgICAgdm9pZCBjbGVhckludGVydmFsKGluIGxvbmcg aGFuZGxlKTsKIAogICAgICAgICAvLyBCYXNlNjQKLSAgICAgICAgW0N1c3RvbV0gRE9NU3RyaW5n IGF0b2IoaW4gRE9NU3RyaW5nIHN0cmluZykKKyAgICAgICAgRE9NU3RyaW5nIGF0b2IoaW4gW0Nv bnZlcnROdWxsVG9OdWxsU3RyaW5nXSBET01TdHJpbmcgc3RyaW5nKQogICAgICAgICAgICAgcmFp c2VzKERPTUV4Y2VwdGlvbik7Ci0gICAgICAgIFtDdXN0b21dIERPTVN0cmluZyBidG9hKGluIERP TVN0cmluZyBzdHJpbmcpCisgICAgICAgIERPTVN0cmluZyBidG9hKGluIFtDb252ZXJ0TnVsbFRv TnVsbFN0cmluZ10gRE9NU3RyaW5nIHN0cmluZykKICAgICAgICAgICAgIHJhaXNlcyhET01FeGNl cHRpb24pOwogCiAgICAgICAgIC8vIEV2ZW50cwpJbmRleDogTGF5b3V0VGVzdHMvQ2hhbmdlTG9n Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL0NoYW5nZUxvZwkocmV2aXNpb24gNTU2MjkpCisr KyBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxMyBAQAor MjAxMC0wMy0wNyAgU2FtIFdlaW5pZyAgPHNhbUB3ZWJraXQub3JnPgorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFJlbW92ZSBpbmNvbnNpc3RlbnQgIlRv byBmZXcgYXJndW1lbnRzIiBoYW5kbGluZyBmb3Igd2luZG93LmF0b2IoKSBhbmQgd2luZG93LmJ0 b2EoKQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzU4 NDgKKworICAgICAgICAqIGZhc3QvZG9tL1dpbmRvdy9hdG9iLWJ0b2EtZXhwZWN0ZWQudHh0Ogor ICAgICAgICAqIGZhc3QvZG9tL1dpbmRvdy9hdG9iLWJ0b2EuaHRtbDoKKwogMjAxMC0wMy0wNiAg Sm9hbm1hcmllIERpZ2dzICA8am9hbm1hcmllLmRpZ2dzQGdtYWlsLmNvbT4KIAogICAgICAgICBS ZXZpZXdlZCBieSBFcmljIFNlaWRlbC4KQEAgLTUyMTgsNiArNTIyOCw3IEBACiAgICAgICAgICog bWVkaWEvdmlkZW8tbG9vcC1leHBlY3RlZC50eHQ6CiAgICAgICAgICogbWVkaWEvdmlkZW8tbG9v cC5odG1sOgogCis+Pj4+Pj4+IC5yNTU2MjkKIDIwMTAtMDItMDUgIENzYWJhIE9zenRyb2dvbsOh YyAgPG9zc3lAd2Via2l0Lm9yZz4KIAogICAgICAgICBSdWJiZXItc3RhbXBlZCBieSBLZW5uZXRo IFJvaGRlIENocmlzdGlhbnNlbi4KSW5kZXg6IExheW91dFRlc3RzL2Zhc3QvZG9tL1dpbmRvdy9h dG9iLWJ0b2EtZXhwZWN0ZWQudHh0Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2Zhc3QvZG9t L1dpbmRvdy9hdG9iLWJ0b2EtZXhwZWN0ZWQudHh0CShyZXZpc2lvbiA1NTYyOSkKKysrIExheW91 dFRlc3RzL2Zhc3QvZG9tL1dpbmRvdy9hdG9iLWJ0b2EtZXhwZWN0ZWQudHh0CSh3b3JraW5nIGNv cHkpCkBAIC0xMSw5ICsxMSwxMCBAQCBQQVNTIHdpbmRvdy5idG9hKCJhYmNkIikgaXMgIllXSmpa QT09IgogUEFTUyB3aW5kb3cuYnRvYSgiYWJjZGUiKSBpcyAiWVdKalpHVT0iCiBQQVNTIHdpbmRv dy5idG9hKCJhYmNkZWYiKSBpcyAiWVdKalpHVm0iCiBQQVNTIHR5cGVvZiB3aW5kb3cuYnRvYSBp cyAiZnVuY3Rpb24iCi1QQVNTIHdpbmRvdy5idG9hKCkgdGhyZXcgZXhjZXB0aW9uIFN5bnRheEVy cm9yOiBOb3QgZW5vdWdoIGFyZ3VtZW50cy4KK1BBU1Mgd2luZG93LmJ0b2EoKSBpcyAiZFc1a1pX WnBibVZrIgogUEFTUyB3aW5kb3cuYnRvYSgiIikgaXMgIiIKIFBBU1Mgd2luZG93LmJ0b2EobnVs bCkgaXMgIiIKK1BBU1Mgd2luZG93LmJ0b2EodW5kZWZpbmVkKSBpcyAiZFc1a1pXWnBibVZrIgog UEFTUyB3aW5kb3cuYnRvYSh3aW5kb3cpIGlzICJXMjlpYW1WamRDQkVUMDFYYVc1a2IzZGQiCiBQ QVNTIHdpbmRvdy5idG9hKCLDqcOpIikgaXMgIjZlaz0iCiBQQVNTIHdpbmRvdy5idG9hKCJcdTAw ODBcdTAwODEiKSBpcyAiZ0lFPSIKQEAgLTIxLDkgKzIyLDEwIEBAIFBBU1Mgd2luZG93LmJ0b2Eo ItGC0LXRgdGCIikgdGhyZXcgZXhjZXAKIFBBU1Mgd2luZG93LmJ0b2EgaXMgMAogUEFTUyB0eXBl b2Ygd2luZG93LmJ0b2EgaXMgIm51bWJlciIKIFBBU1MgdHlwZW9mIHdpbmRvdy5hdG9iIGlzICJm dW5jdGlvbiIKLVBBU1Mgd2luZG93LmF0b2IoKSB0aHJldyBleGNlcHRpb24gU3ludGF4RXJyb3I6 IE5vdCBlbm91Z2ggYXJndW1lbnRzLgorUEFTUyB3aW5kb3cuYXRvYigpIHRocmV3IGV4Y2VwdGlv biBFcnJvcjogSU5WQUxJRF9DSEFSQUNURVJfRVJSOiBET00gRXhjZXB0aW9uIDUuCiBQQVNTIHdp bmRvdy5hdG9iKCIiKSBpcyAiIgogUEFTUyB3aW5kb3cuYXRvYihudWxsKSBpcyAiIgorUEFTUyB3 aW5kb3cuYXRvYih1bmRlZmluZWQpIHRocmV3IGV4Y2VwdGlvbiBFcnJvcjogSU5WQUxJRF9DSEFS QUNURVJfRVJSOiBET00gRXhjZXB0aW9uIDUuCiBQQVNTIHdpbmRvdy5hdG9iKCIgWVE9PSIpIHRo cmV3IGV4Y2VwdGlvbiBFcnJvcjogSU5WQUxJRF9DSEFSQUNURVJfRVJSOiBET00gRXhjZXB0aW9u IDUuCiBQQVNTIHdpbmRvdy5hdG9iKCJZUT09XHUwMDBhIikgdGhyZXcgZXhjZXB0aW9uIEVycm9y OiBJTlZBTElEX0NIQVJBQ1RFUl9FUlI6IERPTSBFeGNlcHRpb24gNS4KIFBBU1Mgd2luZG93LmF0 b2IoIjZlaz0iKSBpcyAiw6nDqSIKSW5kZXg6IExheW91dFRlc3RzL2Zhc3QvZG9tL1dpbmRvdy9h dG9iLWJ0b2EuaHRtbAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9mYXN0L2RvbS9XaW5kb3cv YXRvYi1idG9hLmh0bWwJKHJldmlzaW9uIDU1NjI5KQorKysgTGF5b3V0VGVzdHMvZmFzdC9kb20v V2luZG93L2F0b2ItYnRvYS5odG1sCSh3b3JraW5nIGNvcHkpCkBAIC0yMiw5ICsyMiwxMCBAQCBz aG91bGRCZSgnd2luZG93LmJ0b2EoImFiY2RlIiknLCAnIllXSmpaCiBzaG91bGRCZSgnd2luZG93 LmJ0b2EoImFiY2RlZiIpJywgJyJZV0pqWkdWbSInKTsKIAogc2hvdWxkQmUoJ3R5cGVvZiB3aW5k b3cuYnRvYScsICciZnVuY3Rpb24iJyk7Ci1zaG91bGRUaHJvdygnd2luZG93LmJ0b2EoKScpOwor c2hvdWxkQmUoJ3dpbmRvdy5idG9hKCknLCAnImRXNWtaV1pwYm1WayInKTsKIHNob3VsZEJlKCd3 aW5kb3cuYnRvYSgiIiknLCAnIiInKTsKIHNob3VsZEJlKCd3aW5kb3cuYnRvYShudWxsKScsICci IicpOworc2hvdWxkQmUoJ3dpbmRvdy5idG9hKHVuZGVmaW5lZCknLCAnImRXNWtaV1pwYm1WayIn KTsKIHNob3VsZEJlKCd3aW5kb3cuYnRvYSh3aW5kb3cpJywgJyJXMjlpYW1WamRDQkVUMDFYYVc1 a2IzZGQiJyk7IC8vICJbb2JqZWN0IERPTVdpbmRvd10iCiBzaG91bGRCZSgnd2luZG93LmJ0b2Eo IsOpw6kiKScsICciNmVrPSInKTsKIHNob3VsZEJlKCd3aW5kb3cuYnRvYSgiXFx1MDA4MFxcdTAw ODEiKScsICciZ0lFPSInKTsKQEAgLTM0LDkgKzM1LDEwIEBAIHNob3VsZEJlKCd3aW5kb3cuYnRv YScsICcwJyk7CiBzaG91bGRCZSgndHlwZW9mIHdpbmRvdy5idG9hJywgJyJudW1iZXIiJyk7CiAK IHNob3VsZEJlKCd0eXBlb2Ygd2luZG93LmF0b2InLCAnImZ1bmN0aW9uIicpOwotc2hvdWxkVGhy b3coJ3dpbmRvdy5hdG9iKCknKTsKK3Nob3VsZFRocm93KCd3aW5kb3cuYXRvYigpJyk7IC8vICd1 bmRlZmluZWQnIAogc2hvdWxkQmUoJ3dpbmRvdy5hdG9iKCIiKScsICciIicpOwogc2hvdWxkQmUo J3dpbmRvdy5hdG9iKG51bGwpJywgJyIiJyk7CitzaG91bGRUaHJvdygnd2luZG93LmF0b2IodW5k ZWZpbmVkKScpOwogc2hvdWxkVGhyb3coJ3dpbmRvdy5hdG9iKCIgWVE9PSIpJyk7CiBzaG91bGRU aHJvdygnd2luZG93LmF0b2IoIllRPT1cXHUwMDBhIiknKTsKIHNob3VsZEJlKCd3aW5kb3cuYXRv YigiNmVrPSIpJywgJyLDqcOpIicpOwo=