35840 2010-03-06 21:28:58 -0800 Update QtWebKit library name under Windows in webkitdir.pm so that run-launcher can work. 2010-03-10 20:10:27 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC Windows XP RESOLVED FIXED Qt P2 Normal --- 1 dbates dbates eric jturcotte manyoso vestbo oldest_to_newest 196975 0 dbates 2010-03-06 21:28:58 -0800 We should update the library name in webkitdir.pm to match the change made in changeset 53924 <http://trac.webkit.org/changeset/53924> so that run-launcher can find the built QtWebKit library and launch the QtLauncher application. 197186 1 50226 dbates 2010-03-08 08:51:04 -0800 Created attachment 50226 Patch 197499 2 jturcotte 2010-03-09 01:23:37 -0800 > We should update the library name in webkitdir.pm to match the change made in > changeset 53924 <http://trac.webkit.org/changeset/53924> so that run-launcher > can find the built QtWebKit library and launch the QtLauncher application. Agreed, the 'd' suffix is only in debug so you might want to add something like if configuration() eq "Debug"(In reply to comment #0) 197589 3 50226 dbates 2010-03-09 08:02:24 -0800 Comment on attachment 50226 Patch Will update patch 197894 4 50371 dbates 2010-03-09 22:24:52 -0800 Created attachment 50371 Patch Updated patch to only add the "d" suffix if its a debug Windows build. 198110 5 vestbo 2010-03-10 06:44:02 -0800 Please follow the QtWebKit bug reporting guidelines when reporting bugs. See http://trac.webkit.org/wiki/QtWebKitBugs Specifically: - The 'QtWebKit' component should only be used for bugs/features in the public QtWebKit API layer, not to signify that the bug is specific to the Qt port of WebKit http://trac.webkit.org/wiki/QtWebKitBugs#Component - Add the keyword 'Qt' to signal that it's a Qt-related bug http://trac.webkit.org/wiki/QtWebKitBugs#Keywords 198465 6 50371 dbates 2010-03-10 20:10:21 -0800 Comment on attachment 50371 Patch Clearing flags on attachment: 50371 Committed r55829: <http://trac.webkit.org/changeset/55829> 198466 7 dbates 2010-03-10 20:10:27 -0800 All reviewed patches have been landed. Closing bug. 50226 2010-03-08 08:51:04 -0800 2010-03-09 22:24:52 -0800 Patch Bug35840.patch text/plain 1610 dbates SW5kZXg6IFdlYktpdFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXRUb29scy9D aGFuZ2VMb2cJKHJldmlzaW9uIDU1NjMyKQorKysgV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTAtMDMtMDYgIERhbmllbCBCYXRlcyAgPGRi YXRlc0ByaW0uY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zNTg0MAorCisg ICAgICAgIFVwZGF0ZXMgdGhlIHN1YnJvdXRpbmUgYnVpbHREeWxpYlBhdGhGb3JOYW1lKCkgc28g dGhhdCBpdCBhZGRzIHRoZSAiZCIgc3VmZml4IHRvCisgICAgICAgIHRoZSBRdFdlYktpdCBsaWJy YXJ5IG5hbWUgb24gV2luZG93cy4gVGhpcyBjaGFuZ2UgbWFrZXMgcnVuLWxhdW5jaGVyIHdvcmsg YWdhaW4KKyAgICAgICAgdW5kZXIgV2luZG93cy4gTW9yZW92ZXIsIHRoaXMgY2hhbmdlIGNvcnJl c3BvbmRzIHRvIHRoZSBjaGFuZ2UgbWFkZSBpbiBjaGFuZ2UtCisgICAgICAgIHNldCA1MzkyNCA8 aHR0cDovL3RyYWMud2Via2l0Lm9yZy9jaGFuZ2VzZXQvNTM5MjQ+LgorCisgICAgICAgICogU2Ny aXB0cy93ZWJraXRkaXJzLnBtOgorCiAyMDEwLTAzLTA2ICBIaXJvbm9yaSBCb25vICA8aGJvbm9A Y2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEVyaWMgU2VpZGVsLgpJbmRleDog V2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRkaXJzLnBtCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdFRv b2xzL1NjcmlwdHMvd2Via2l0ZGlycy5wbQkocmV2aXNpb24gNTU2MzApCisrKyBXZWJLaXRUb29s cy9TY3JpcHRzL3dlYmtpdGRpcnMucG0JKHdvcmtpbmcgY29weSkKQEAgLTU0MSw2ICs1NDEsOSBA QCBzdWIgYnVpbHREeWxpYlBhdGhGb3JOYW1lCiAgICAgICAgIGlmIChpc0RhcndpbigpIGFuZCAt ZCAiJGNvbmZpZ3VyYXRpb25Qcm9kdWN0RGlyL2xpYi8kbGlicmFyeU5hbWUuZnJhbWV3b3JrIikg ewogICAgICAgICAgICAgcmV0dXJuICIkY29uZmlndXJhdGlvblByb2R1Y3REaXIvbGliLyRsaWJy YXJ5TmFtZS5mcmFtZXdvcmsvJGxpYnJhcnlOYW1lIjsKICAgICAgICAgfSBlbHNpZiAoaXNXaW5k b3dzKCkpIHsKKyAgICAgICAgICAgICMgT24gV2luZG93cywgdGhlcmUgaXMgYSAiZCIgc3VmZml4 IHRvIHRoZSBsaWJyYXJ5IG5hbWUuIFNlZSA8aHR0cDovL3RyYWMud2Via2l0Lm9yZy9jaGFuZ2Vz ZXQvNTM5MjQvPi4KKyAgICAgICAgICAgICRsaWJyYXJ5TmFtZSAuPSAiZCI7CisKICAgICAgICAg ICAgIG15ICRta3NwZWMgPSBgcW1ha2UgLXF1ZXJ5IFFNQUtFX01LU1BFQ1NgOwogICAgICAgICAg ICAgJG1rc3BlYyA9fiBzL1tcbnxccl0kLy9nOwogICAgICAgICAgICAgbXkgJHF0TWFqb3JWZXJz aW9uID0gcmV0cmlldmVRTWFrZXNwZWNWYXIoIiRta3NwZWMvcWNvbmZpZy5wcmkiLCAiUVRfTUFK T1JfVkVSU0lPTiIpOwo= 50371 2010-03-09 22:24:52 -0800 2010-03-10 20:10:21 -0800 Patch Bug35840_1.patch text/plain 1681 dbates SW5kZXg6IFdlYktpdFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXRUb29scy9D aGFuZ2VMb2cJKHJldmlzaW9uIDU1NjMyKQorKysgV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTAtMDMtMDYgIERhbmllbCBCYXRlcyAgPGRi YXRlc0ByaW0uY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zNTg0MAorCisg ICAgICAgIFVwZGF0ZXMgdGhlIHN1YnJvdXRpbmUgYnVpbHREeWxpYlBhdGhGb3JOYW1lKCkgc28g dGhhdCBpdCBhZGRzIHRoZSAiZCIgc3VmZml4IHRvCisgICAgICAgIHRoZSBRdFdlYktpdCBsaWJy YXJ5IG5hbWUgb24gV2luZG93cy4gVGhpcyBjaGFuZ2UgbWFrZXMgcnVuLWxhdW5jaGVyIHdvcmsg YWdhaW4KKyAgICAgICAgdW5kZXIgV2luZG93cy4gTW9yZW92ZXIsIHRoaXMgY2hhbmdlIGNvcnJl c3BvbmRzIHRvIHRoZSBjaGFuZ2UgbWFkZSBpbiBjaGFuZ2UtCisgICAgICAgIHNldCA1MzkyNCA8 aHR0cDovL3RyYWMud2Via2l0Lm9yZy9jaGFuZ2VzZXQvNTM5MjQ+LgorCisgICAgICAgICogU2Ny aXB0cy93ZWJraXRkaXJzLnBtOgorCiAyMDEwLTAzLTA2ICBIaXJvbm9yaSBCb25vICA8aGJvbm9A Y2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEVyaWMgU2VpZGVsLgpJbmRleDog V2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRkaXJzLnBtCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdFRv b2xzL1NjcmlwdHMvd2Via2l0ZGlycy5wbQkocmV2aXNpb24gNTU2MzApCisrKyBXZWJLaXRUb29s cy9TY3JpcHRzL3dlYmtpdGRpcnMucG0JKHdvcmtpbmcgY29weSkKQEAgLTU0MSw2ICs1NDEsMTEg QEAgc3ViIGJ1aWx0RHlsaWJQYXRoRm9yTmFtZQogICAgICAgICBpZiAoaXNEYXJ3aW4oKSBhbmQg LWQgIiRjb25maWd1cmF0aW9uUHJvZHVjdERpci9saWIvJGxpYnJhcnlOYW1lLmZyYW1ld29yayIp IHsKICAgICAgICAgICAgIHJldHVybiAiJGNvbmZpZ3VyYXRpb25Qcm9kdWN0RGlyL2xpYi8kbGli cmFyeU5hbWUuZnJhbWV3b3JrLyRsaWJyYXJ5TmFtZSI7CiAgICAgICAgIH0gZWxzaWYgKGlzV2lu ZG93cygpKSB7CisgICAgICAgICAgICBpZiAoY29uZmlndXJhdGlvbigpIGVxICJEZWJ1ZyIpIHsK KyAgICAgICAgICAgICAgICAjIE9uIFdpbmRvd3MsIHRoZXJlIGlzIGEgImQiIHN1ZmZpeCB0byB0 aGUgbGlicmFyeSBuYW1lLiBTZWUgPGh0dHA6Ly90cmFjLndlYmtpdC5vcmcvY2hhbmdlc2V0LzUz OTI0Lz4uCisgICAgICAgICAgICAgICAgJGxpYnJhcnlOYW1lIC49ICJkIjsKKyAgICAgICAgICAg IH0KKwogICAgICAgICAgICAgbXkgJG1rc3BlYyA9IGBxbWFrZSAtcXVlcnkgUU1BS0VfTUtTUEVD U2A7CiAgICAgICAgICAgICAkbWtzcGVjID1+IHMvW1xufFxyXSQvL2c7CiAgICAgICAgICAgICBt eSAkcXRNYWpvclZlcnNpb24gPSByZXRyaWV2ZVFNYWtlc3BlY1ZhcigiJG1rc3BlYy9xY29uZmln LnByaSIsICJRVF9NQUpPUl9WRVJTSU9OIik7Cg==