35827 2010-03-06 01:53:27 -0800 Web Inspector: in Timeline panel, click followed with mouse move resets popover. 2010-03-06 03:01:00 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 pfeldman pfeldman bweinstein joepeck rik timothy oldest_to_newest 196873 0 pfeldman 2010-03-06 01:53:27 -0800 There is a small glitch that closes / openes new popover upon mouse move in case original popover was opened on mouse click. 196874 1 50149 loislo 2010-03-06 02:47:52 -0800 Created attachment 50149 initial version of patch. 196875 2 50149 pfeldman 2010-03-06 02:55:01 -0800 Comment on attachment 50149 initial version of patch. I'll land. 196876 3 pfeldman 2010-03-06 03:01:00 -0800 Variation of patch landed (killed timer upon click and brushed up url business in timeline's popover). Committing to http://svn.webkit.org/repository/webkit/trunk ... M LayoutTests/inspector/timeline-network-resource-expected.txt M WebCore/ChangeLog M WebCore/English.lproj/localizedStrings.js M WebCore/inspector/front-end/Popover.js M WebCore/inspector/front-end/TimelinePanel.js Committed r55614 50149 2010-03-06 02:47:52 -0800 2010-03-06 02:55:01 -0800 initial version of patch. popover_glitch text/plain 2424 loislo ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg YzBlNGY1OC4uNWNhMGQxZSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAxMC0wMy0wNiAgSWx5YSBUaWtob25v dnNreSAgPGxvaXNsb0BjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogaW4gVGltZWxpbmUgcGFuZWwsIGNs aWNrIGZvbGxvd2VkIHdpdGggbW91c2UgbW92ZSByZXNldHMgcG9wb3Zlci4KKworICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzU4MjcKKworICAgICAgICAq IGluc3BlY3Rvci9mcm9udC1lbmQvUG9wb3Zlci5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rvci5Q b3BvdmVySGVscGVyLnByb3RvdHlwZS5fbW91c2VEb3duKToKKyAgICAgICAgKFdlYkluc3BlY3Rv ci5Qb3BvdmVySGVscGVyLnByb3RvdHlwZS5fbW91c2VNb3ZlKToKKyAgICAgICAgKFdlYkluc3Bl Y3Rvci5Qb3BvdmVySGVscGVyLnByb3RvdHlwZS5faGFuZGxlTW91c2VBY3Rpb24pOgorCiAyMDEw LTAzLTA1ICBQYXZlbCBGZWxkbWFuICA8cGZlbGRtYW5AY2hyb21pdW0ub3JnPgogCiAgICAgICAg IE5vdCByZXZpZXdlZC4gUm9sbCBiYWNrIHI1NTUyMiBzaW5jZSBpdCByZWdyZXNlcyBwZXJmb3Jt YW5jZQpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1BvcG92ZXIuanMg Yi9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvUG9wb3Zlci5qcwppbmRleCA4ZjU3NGQwLi43 Y2IxMGU2IDEwMDY0NAotLS0gYS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvUG9wb3Zlci5q cworKysgYi9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvUG9wb3Zlci5qcwpAQCAtMTYwLDI1 ICsxNjAsMjIgQEAgV2ViSW5zcGVjdG9yLlBvcG92ZXJIZWxwZXIgPSBmdW5jdGlvbihwYW5lbEVs ZW1lbnQsIGdldEFuY2hvciwgc2hvd1BvcHVwLCBzaG93T24KIFdlYkluc3BlY3Rvci5Qb3BvdmVy SGVscGVyLnByb3RvdHlwZSA9IHsKICAgICBfbW91c2VEb3duOiBmdW5jdGlvbihldmVudCkKICAg ICB7Ci0gICAgICAgIHRoaXMuX3Jlc2V0SG92ZXJUaW1lcigpOwotICAgICAgICBpZiAodGhpcy5f c2hvd09uQ2xpY2spIHsKLSAgICAgICAgICAgIHZhciBhbmNob3IgPSB0aGlzLl9nZXRBbmNob3Io ZXZlbnQudGFyZ2V0KTsKLSAgICAgICAgICAgIGlmIChhbmNob3IpIHsKLSAgICAgICAgICAgICAg ICB0aGlzLl9wb3B1cCA9IHRoaXMuX3Nob3dQb3B1cChhbmNob3IpOwotICAgICAgICAgICAgICAg IHRoaXMuX2tpbGxIaWRlUG9wdXBUaW1lcigpOwotICAgICAgICAgICAgfQotICAgICAgICB9Cisg ICAgICAgIHRoaXMuX2hhbmRsZU1vdXNlQWN0aW9uKGV2ZW50LCB0cnVlKTsKICAgICB9LAogCiAg ICAgX21vdXNlTW92ZTogZnVuY3Rpb24oZXZlbnQpCiAgICAgeworICAgICAgICB0aGlzLl9oYW5k bGVNb3VzZUFjdGlvbihldmVudCk7CisgICAgfSwKKworICAgIF9oYW5kbGVNb3VzZUFjdGlvbjog ZnVuY3Rpb24oZXZlbnQsIGlzTW91c2VEb3duKQorICAgIHsKICAgICAgICAgLy8gUHJldGVuZCB0 aGF0IG5vdGhpbmcgaGFzIGhhcHBlbmVkLgogICAgICAgICBpZiAodGhpcy5faG92ZXJFbGVtZW50 ID09PSBldmVudC50YXJnZXQgfHwgKHRoaXMuX2hvdmVyRWxlbWVudCAmJiB0aGlzLl9ob3ZlckVs ZW1lbnQuaXNBbmNlc3RvcihldmVudC50YXJnZXQpKSkKICAgICAgICAgICAgIHJldHVybjsKLQog ICAgICAgICB0aGlzLl9yZXNldEhvdmVyVGltZXIoKTsKICAgICAgICAgLy8gVXNlciBoYXMgNTAw bXMgdG8gcmVhY2ggdGhlIHBvcHVwLgotICAgICAgICBpZiAodGhpcy5fcG9wdXApIHsKKyAgICAg ICAgaWYgKHRoaXMuX3BvcHVwICYmICF0aGlzLl9oaWRlUG9wdXBUaW1lcikgewogICAgICAgICAg ICAgdmFyIHNlbGYgPSB0aGlzOwogICAgICAgICAgICAgZnVuY3Rpb24gZG9IaWRlKCkKICAgICAg ICAgICAgIHsKQEAgLTE5Miw3ICsxODksNyBAQCBXZWJJbnNwZWN0b3IuUG9wb3ZlckhlbHBlci5w cm90b3R5cGUgPSB7CiAgICAgICAgIGlmICghdGhpcy5faG92ZXJFbGVtZW50KQogICAgICAgICAg ICAgcmV0dXJuOwogCi0gICAgICAgIGNvbnN0IHRvb2xUaXBEZWxheSA9IHRoaXMuX3BvcHVwID8g NjAwIDogMTAwMDsKKyAgICAgICAgY29uc3QgdG9vbFRpcERlbGF5ID0gaXNNb3VzZURvd24gPyAw IDogKHRoaXMuX3BvcHVwID8gNjAwIDogMTAwMCk7CiAgICAgICAgIHRoaXMuX2hvdmVyVGltZXIg PSBzZXRUaW1lb3V0KHRoaXMuX21vdXNlSG92ZXIuYmluZCh0aGlzLCB0aGlzLl9ob3ZlckVsZW1l bnQpLCB0b29sVGlwRGVsYXkpOwogICAgIH0sCiAK