35822 2010-03-05 17:09:51 -0800 webkit-patch land fails if not run from the root directory 2010-03-31 20:50:10 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 eric webkit-unassigned abarth cjerdonek dpranke oldest_to_newest 196819 0 eric 2010-03-05 17:09:51 -0800 webkit-patch land fails if not run from the root directory Parsing ChangeLog: LayoutTests/ChangeLog Traceback (most recent call last): File "/Users/eseidel/Projects/WebKit/WebKitTools/Scripts/webkit-patch", line 109, in <module> WebKitPatch().main() File "/Users/eseidel/Projects/WebKit/WebKitTools/Scripts/webkitpy/multicommandtool.py", line 299, in main return command.check_arguments_and_execute(options, args, self) File "/Users/eseidel/Projects/WebKit/WebKitTools/Scripts/webkitpy/multicommandtool.py", line 113, in check_arguments_and_execute return self.execute(options, args, tool) or 0 File "/Users/eseidel/Projects/WebKit/WebKitTools/Scripts/webkitpy/commands/abstractsequencedcommand.py", line 43, in execute self._sequence.run_and_handle_errors(tool, options, self._prepare_state(options, args, tool)) File "/Users/eseidel/Projects/WebKit/WebKitTools/Scripts/webkitpy/stepsequence.py", line 66, in run_and_handle_errors self._run(tool, options, state) File "/Users/eseidel/Projects/WebKit/WebKitTools/Scripts/webkitpy/stepsequence.py", line 60, in _run step(tool, options).run(state) File "/Users/eseidel/Projects/WebKit/WebKitTools/Scripts/webkitpy/steps/commit.py", line 34, in run commit_message = self._tool.scm().commit_message_for_this_commit() File "/Users/eseidel/Projects/WebKit/WebKitTools/Scripts/webkitpy/scm.py", line 181, in commit_message_for_this_commit changelog_entry = ChangeLog(changelog_path).latest_entry() File "/Users/eseidel/Projects/WebKit/WebKitTools/Scripts/webkitpy/changelogs.py", line 73, in latest_entry changelog_file = open(self.path) IOError: [Errno 2] No such file or directory: 'LayoutTests/ChangeLog' I feel like this used to work fine. 197104 1 cjerdonek 2010-03-08 03:02:20 -0800 (In reply to comment #0) > webkit-patch land fails if not run from the root directory > > <snip> > > I feel like this used to work fine. check-webkit-style used to have this problem, too: https://bugs.webkit.org/show_bug.cgi?id=33791 206932 2 52250 eric 2010-03-31 20:45:49 -0700 Created attachment 52250 Patch 206933 3 52250 abarth 2010-03-31 20:47:40 -0700 Comment on attachment 52250 Patch yay! 206935 4 eric 2010-03-31 20:50:06 -0700 Somehow we got a second parsing changlog message. Parsing ChangeLog: /Projects/WebKit/WebKitTools/ChangeLog Fetching: https://bugs.webkit.org/show_bug.cgi?id=35822&ctype=xml Guessing "Adam Barth" as reviewer from attachment 52250 on bug 35822. Parsing ChangeLog: /Projects/WebKit/WebKitTools/ChangeLog It's slightly lame that it gives the full path now. 206936 5 eric 2010-03-31 20:50:10 -0700 Committed r56891: <http://trac.webkit.org/changeset/56891> 52250 2010-03-31 20:45:49 -0700 2010-03-31 20:47:40 -0700 Patch bug-35822-20100331204546.patch text/plain 2897 eric ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCA5YjdmMmI5Li43ODVjNjZjIDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VM b2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMTAtMDMt MzEgIEVyaWMgU2VpZGVsICA8ZXJpY0B3ZWJraXQub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIHdlYmtpdC1wYXRjaCBsYW5kIGZhaWxzIGlmIG5v dCBydW4gZnJvbSB0aGUgcm9vdCBkaXJlY3RvcnkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTM1ODIyCisKKyAgICAgICAgVGhlIHJvb3Qgb2YgdGhlIHBy b2JsZW0gd2FzIHRoYXQgQ2hhbmdlTG9nLl9faW5pdF9fIGV4cGVjdHMgYSBwYXRoCisgICAgICAg IHJlbGF0aXZlIHRvIHRoZSBjdXJyZW50IHdvcmtpbmcgZGlyZWN0b3J5LCBhbmQgU0NNIGV4cGVj dHMgdG8KKyAgICAgICAgcmV0dXJuIHBhdGhzIHJlbGF0aXZlIHRvIHRoZSBTQ00gcm9vdC4gIEZp eCBpdCBieSBjb252ZXJ0aW5nIGZyb20KKyAgICAgICAgU0NNLXJlbGF0aXZlIHRvIGFic29sdXRl IHBhdGhzIGluIENoZWNrb3V0Lm1vZGlmaWVkX2NoYW5nZWxvZ3MKKworICAgICAgICAqIFNjcmlw dHMvd2Via2l0cHkvY29tbW9uL2NoZWNrb3V0L2FwaS5weToKKyAgICAgICAgKiBTY3JpcHRzL3dl YmtpdHB5L2NvbW1vbi9jaGVja291dC9hcGlfdW5pdHRlc3QucHk6CisKIDIwMTAtMDMtMzEgIEFk YW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBFcmlj IFNlaWRlbC4KZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9u L2NoZWNrb3V0L2FwaS5weSBiL1dlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL2No ZWNrb3V0L2FwaS5weQppbmRleCAwZjc5YjJiLi5iZmExMDg4IDEwMDY0NAotLS0gYS9XZWJLaXRU b29scy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9jaGVja291dC9hcGkucHkKKysrIGIvV2ViS2l0 VG9vbHMvU2NyaXB0cy93ZWJraXRweS9jb21tb24vY2hlY2tvdXQvYXBpLnB5CkBAIC03OSw3ICs3 OSwxMiBAQCBjbGFzcyBDaGVja291dChvYmplY3QpOgogICAgICAgICByZXR1cm4gc2VsZi5jb21t aXRfaW5mb19mb3JfcmV2aXNpb24ocmV2aXNpb24pLmJ1Z19pZCgpCiAKICAgICBkZWYgbW9kaWZp ZWRfY2hhbmdlbG9ncyhzZWxmKToKLSAgICAgICAgcmV0dXJuIFtwYXRoIGZvciBwYXRoIGluIHNl bGYuX3NjbS5jaGFuZ2VkX2ZpbGVzKCkgaWYgc2VsZi5faXNfcGF0aF90b19jaGFuZ2Vsb2cocGF0 aCldCisgICAgICAgICMgU0NNIHJldHVybnMgcGF0aHMgcmVsYXRpdmUgdG8gc2NtLmNoZWNrb3V0 X3Jvb3QKKyAgICAgICAgIyBDYWxsZXJzIChlc3BlY2lhbGx5IHRob3NlIHVzaW5nIHRoZSBDaGFu Z2VMb2cgY2xhc3MpIG1heQorICAgICAgICAjIGV4cGVjdCBhYnNvbHV0ZSBwYXRocywgc28gdGhp cyBtZXRob2QgcmV0dXJucyBhYnNvbHV0ZSBwYXRocy4KKyAgICAgICAgY2hhbmdlZF9maWxlcyA9 IHNlbGYuX3NjbS5jaGFuZ2VkX2ZpbGVzKCkKKyAgICAgICAgYWJzb2x1dGVfcGF0aHMgPSBbb3Mu cGF0aC5qb2luKHNlbGYuX3NjbS5jaGVja291dF9yb290LCBwYXRoKSBmb3IgcGF0aCBpbiBjaGFu Z2VkX2ZpbGVzXQorICAgICAgICByZXR1cm4gW3BhdGggZm9yIHBhdGggaW4gYWJzb2x1dGVfcGF0 aHMgaWYgc2VsZi5faXNfcGF0aF90b19jaGFuZ2Vsb2cocGF0aCldCiAKICAgICBkZWYgY29tbWl0 X21lc3NhZ2VfZm9yX3RoaXNfY29tbWl0KHNlbGYpOgogICAgICAgICBjaGFuZ2Vsb2dfcGF0aHMg PSBzZWxmLm1vZGlmaWVkX2NoYW5nZWxvZ3MoKQpkaWZmIC0tZ2l0IGEvV2ViS2l0VG9vbHMvU2Ny aXB0cy93ZWJraXRweS9jb21tb24vY2hlY2tvdXQvYXBpX3VuaXR0ZXN0LnB5IGIvV2ViS2l0VG9v bHMvU2NyaXB0cy93ZWJraXRweS9jb21tb24vY2hlY2tvdXQvYXBpX3VuaXR0ZXN0LnB5CmluZGV4 IDY3NzZkYzAuLjM1NmI2ODggMTAwNjQ0Ci0tLSBhL1dlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0 cHkvY29tbW9uL2NoZWNrb3V0L2FwaV91bml0dGVzdC5weQorKysgYi9XZWJLaXRUb29scy9TY3Jp cHRzL3dlYmtpdHB5L2NvbW1vbi9jaGVja291dC9hcGlfdW5pdHRlc3QucHkKQEAgLTE1NiwzICsx NTYsMTEgQEAgY2xhc3MgQ2hlY2tvdXRUZXN0KHVuaXR0ZXN0LlRlc3RDYXNlKToKICAgICAgICAg Y2hlY2tvdXQgPSBDaGVja291dChzY20pCiAgICAgICAgIGNoZWNrb3V0LmNvbW1pdF9tZXNzYWdl X2Zvcl90aGlzX2NvbW1pdCA9IGxhbWJkYTogQ29tbWl0TWVzc2FnZShDaGFuZ2VMb2dFbnRyeShf Y2hhbmdlbG9nMWVudHJ5MSkuY29udGVudHMoKS5zcGxpdGxpbmVzKCkpCiAgICAgICAgIHNlbGYu YXNzZXJ0RXF1YWwoY2hlY2tvdXQuYnVnX2lkX2Zvcl90aGlzX2NvbW1pdCgpLCAzNjYyOSkKKwor ICAgIGRlZiB0ZXN0X21vZGlmaWVkX2NoYW5nZWxvZ3Moc2VsZik6CisgICAgICAgIHNjbSA9IE1v Y2soKQorICAgICAgICBzY20uY2hlY2tvdXRfcm9vdCA9ICIvZm9vL2JhciIKKyAgICAgICAgc2Nt LmNoYW5nZWRfZmlsZXMgPSBsYW1iZGE6WyJmaWxlMSIsICJDaGFuZ2VMb2ciLCAicmVsYXRpdmUv cGF0aC9DaGFuZ2VMb2ciXQorICAgICAgICBjaGVja291dCA9IENoZWNrb3V0KHNjbSkKKyAgICAg ICAgZXhwZWN0ZWRfY2hhbmdsb2dzID0gWyIvZm9vL2Jhci9DaGFuZ2VMb2ciLCAiL2Zvby9iYXIv cmVsYXRpdmUvcGF0aC9DaGFuZ2VMb2ciXQorICAgICAgICBzZWxmLmFzc2VydEVxdWFsKGNoZWNr b3V0Lm1vZGlmaWVkX2NoYW5nZWxvZ3MoKSwgZXhwZWN0ZWRfY2hhbmdsb2dzKQo=