35814 2010-03-05 14:58:57 -0800 JSC should cache int- to Identifier conversion as it does for ordinary strings 2010-03-05 15:29:27 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 oliver webkit-unassigned oldest_to_newest 196707 0 oliver 2010-03-05 14:58:57 -0800 JSC should cache int- to Identifier conversion as it does for ordinary strings 196711 1 50130 oliver 2010-03-05 15:05:11 -0800 Created attachment 50130 Patch 196717 2 50130 barraclough 2010-03-05 15:10:04 -0800 Comment on attachment 50130 Patch Please note any perf improvement in the changelog, and 'y' is a pretty crumby variable name, otherwise r+. 196738 3 oliver 2010-03-05 15:29:27 -0800 Committed r55599: <http://trac.webkit.org/changeset/55599> 50130 2010-03-05 15:05:11 -0800 2010-03-05 15:10:03 -0800 Patch bug-35814-20100305150510.patch text/plain 6164 oliver ZGlmZiAtLWdpdCBhL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZyBiL0phdmFTY3JpcHRDb3JlL0No YW5nZUxvZwppbmRleCBjOTFlMjljLi5iNWNiN2IwIDEwMDY0NAotLS0gYS9KYXZhU2NyaXB0Q29y ZS9DaGFuZ2VMb2cKKysrIGIvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMzAg QEAKKzIwMTAtMDMtMDUgIE9saXZlciBIdW50ICA8b2xpdmVyQGFwcGxlLmNvbT4KKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBKU0Mgc2hvdWxkIGNhY2hl IGludCB0byBJZGVudGlmaWVyIGNvbnZlcnNpb24gYXMgaXQgZG9lcyBmb3Igb3JkaW5hcnkgc3Ry aW5ncworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzU4 MTQKKworICAgICAgICBNYWtlIHRoZSBOdW1lcmljU3RyaW5ncyBjYWNoZSBjYWNoZSB1bnNpZ25l ZCBpbnRzIGluIGFkZGl0aW9uIHRvIHNpZ25lZC4KKyAgICAgICAgV2Uga2VlcCB0aGVtIHNlcGFy YXRlIGZyb20gdGhlIGludCBjYWNoZSBhcyBpdCBib3RoIHNpbXBsaWZpZXMgY29kZSwgYW5kCisg ICAgICAgIGFsc28gYmVjYXVzZSB0aGUgdW5zaWduZWQgcGF0aCBpcyBleGNsdXNpdmUgdG8gcHJv cGVydHkgYWNjZXNzIGFuZCB0aGVyZWZvcmUKKyAgICAgICAgc2VlbXMgdG8gaGF2ZSBkaWZmZXJl bnQgdXNhZ2UgcGF0dGVybnMuCisKKyAgICAgICAgVGhlIHByaW1hcnkgdHJpZ2dlciBmb3IgdGhl IHVuc2lnbmVkIHRvIElkZW50aWZpZXIgcHJvcGVydHlOYW1lIGNvbnZlcnNpb24KKyAgICAgICAg aXMgdGhlIGNvbnN0cnVjdGlvbiBvZiBhcnJheS1saWtlIG9iamVjdHMgb3V0IG9mIG5vcm1hbCBv YmplY3RzLiAgR2l2ZW4gdGhlc2UKKyAgICAgICAgdGVuZCB0byBiZSByZWxhdGl2ZSBzbWFsbCBu dW1iZXJzLCBhbmQgdGhlIGFycmF5LWxpa2UgYmVoYXZpb3VyIGxlbmRzIGl0c2VsZgorICAgICAg ICB0byBzZXF1ZW50aWFsIHZhbHVlcyB0aGlzIHBhdGNoIGFsc28gYWRkcyBhIG5vbi1jb2xsaWRp bmcgY2FjaGUgZm9yIGFsbCBzbWFsbAorICAgICAgICBudW1iZXJzLgorCisgICAgICAgICogSmF2 YVNjcmlwdENvcmUuZXhwOgorICAgICAgICAqIHJ1bnRpbWUvSWRlbnRpZmllci5jcHA6CisgICAg ICAgIChKU0M6OklkZW50aWZpZXI6OmZyb20pOgorICAgICAgICAqIHJ1bnRpbWUvSWRlbnRpZmll ci5oOgorICAgICAgICAqIHJ1bnRpbWUvTnVtZXJpY1N0cmluZ3MuaDoKKyAgICAgICAgKEpTQzo6 TnVtZXJpY1N0cmluZ3M6OmFkZCk6CisgICAgICAgIChKU0M6Ok51bWVyaWNTdHJpbmdzOjpsb29r dXApOgorICAgICAgICAoSlNDOjpOdW1lcmljU3RyaW5nczo6bG9va3VwU21hbGxTdHJpbmcpOgor CiAyMDEwLTAzLTAzICBPbGl2ZXIgSHVudCAgPG9saXZlckBhcHBsZS5jb20+CiAKICAgICAgICAg UmV2aWV3ZWQgYnkgR2F2aW4gQmFycmFjbG91Z2guCmRpZmYgLS1naXQgYS9KYXZhU2NyaXB0Q29y ZS9KYXZhU2NyaXB0Q29yZS5leHAgYi9KYXZhU2NyaXB0Q29yZS9KYXZhU2NyaXB0Q29yZS5leHAK aW5kZXggZjcwNGYzMS4uYTE2OGIxNCAxMDA2NDQKLS0tIGEvSmF2YVNjcmlwdENvcmUvSmF2YVNj cmlwdENvcmUuZXhwCisrKyBiL0phdmFTY3JpcHRDb3JlL0phdmFTY3JpcHRDb3JlLmV4cApAQCAt OTUsNiArOTUsOCBAQCBfX1pOM0pTQzEwSWRlbnRpZmllcjExYWRkU2xvd0Nhc2VFUE5TXzlFeGVj U3RhdGVFUE5TXzExVVN0cmluZ0ltcGxFCiBfX1pOM0pTQzEwSWRlbnRpZmllcjI0Y2hlY2tTYW1l SWRlbnRpZmllclRhYmxlRVBOU18xMkpTR2xvYmFsRGF0YUVQTlNfMTFVU3RyaW5nSW1wbEUKIF9f Wk4zSlNDMTBJZGVudGlmaWVyMjRjaGVja1NhbWVJZGVudGlmaWVyVGFibGVFUE5TXzlFeGVjU3Rh dGVFUE5TXzExVVN0cmluZ0ltcGxFCiBfX1pOM0pTQzEwSWRlbnRpZmllcjNhZGRFUE5TXzlFeGVj U3RhdGVFUEtjCitfX1pOM0pTQzEwSWRlbnRpZmllcjRmcm9tRVBOU185RXhlY1N0YXRlRWkKK19f Wk4zSlNDMTBJZGVudGlmaWVyNGZyb21FUE5TXzlFeGVjU3RhdGVFagogX19aTjNKU0MxMElkZW50 aWZpZXI1ZXF1YWxFUEtOU18xMVVTdHJpbmdJbXBsRVBLYwogX19aTjNKU0MxMEpTRnVuY3Rpb25D MUVQTlNfOUV4ZWNTdGF0ZUVOM1dURjE3Tm9uTnVsbFBhc3NSZWZQdHJJTlNfOVN0cnVjdHVyZUVF RWlSS05TXzEwSWRlbnRpZmllckVQRk5TXzdKU1ZhbHVlRVMyX1BOU184SlNPYmplY3RFU0FfUktO U183QXJnTGlzdEVFCiBfX1pOM0pTQzEwdGhyb3dFcnJvckVQTlNfOUV4ZWNTdGF0ZUVOU185RXJy b3JUeXBlRQpkaWZmIC0tZ2l0IGEvSmF2YVNjcmlwdENvcmUvcnVudGltZS9JZGVudGlmaWVyLmNw cCBiL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvSWRlbnRpZmllci5jcHAKaW5kZXggNDZmY2QwYi4u MTgxYWM1MSAxMDA2NDQKLS0tIGEvSmF2YVNjcmlwdENvcmUvcnVudGltZS9JZGVudGlmaWVyLmNw cAorKysgYi9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0lkZW50aWZpZXIuY3BwCkBAIC0yMiw2ICsy Miw3IEBACiAjaW5jbHVkZSAiSWRlbnRpZmllci5oIgogCiAjaW5jbHVkZSAiQ2FsbEZyYW1lLmgi CisjaW5jbHVkZSAiTnVtZXJpY1N0cmluZ3MuaCIKICNpbmNsdWRlIDxuZXc+IC8vIGZvciBwbGFj ZW1lbnQgbmV3CiAjaW5jbHVkZSA8c3RyaW5nLmg+IC8vIGZvciBzdHJsZW4KICNpbmNsdWRlIDx3 dGYvQXNzZXJ0aW9ucy5oPgpAQCAtMjM2LDYgKzIzNywyMSBAQCB2b2lkIElkZW50aWZpZXI6OnJl bW92ZShVU3RyaW5nOjpSZXAqIHIpCiB7CiAgICAgY3VycmVudElkZW50aWZpZXJUYWJsZSgpLT5y ZW1vdmUocik7CiB9CisgICAgCitJZGVudGlmaWVyIElkZW50aWZpZXI6OmZyb20oRXhlY1N0YXRl KiBleGVjLCB1bnNpZ25lZCB5KQoreworICAgIHJldHVybiBJZGVudGlmaWVyKGV4ZWMsIGV4ZWMt Pmdsb2JhbERhdGEoKS5udW1lcmljU3RyaW5ncy5hZGQoeSkpOworfQorCitJZGVudGlmaWVyIElk ZW50aWZpZXI6OmZyb20oRXhlY1N0YXRlKiBleGVjLCBpbnQgeSkKK3sKKyAgICByZXR1cm4gSWRl bnRpZmllcihleGVjLCBleGVjLT5nbG9iYWxEYXRhKCkubnVtZXJpY1N0cmluZ3MuYWRkKHkpKTsK K30KKworSWRlbnRpZmllciBJZGVudGlmaWVyOjpmcm9tKEV4ZWNTdGF0ZSogZXhlYywgZG91Ymxl IHkpCit7CisgICAgcmV0dXJuIElkZW50aWZpZXIoZXhlYywgZXhlYy0+Z2xvYmFsRGF0YSgpLm51 bWVyaWNTdHJpbmdzLmFkZCh5KSk7Cit9CiAKICNpZm5kZWYgTkRFQlVHCiAKZGlmZiAtLWdpdCBh L0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvSWRlbnRpZmllci5oIGIvSmF2YVNjcmlwdENvcmUvcnVu dGltZS9JZGVudGlmaWVyLmgKaW5kZXggNzNlMmFmOC4uMjUzZjNjMSAxMDA2NDQKLS0tIGEvSmF2 YVNjcmlwdENvcmUvcnVudGltZS9JZGVudGlmaWVyLmgKKysrIGIvSmF2YVNjcmlwdENvcmUvcnVu dGltZS9JZGVudGlmaWVyLmgKQEAgLTU0LDkgKzU0LDkgQEAgbmFtZXNwYWNlIEpTQyB7CiAgICAg ICAgIAogICAgICAgICBjb25zdCBjaGFyKiBhc2NpaSgpIGNvbnN0IHsgcmV0dXJuIF91c3RyaW5n LmFzY2lpKCk7IH0KICAgICAgICAgCi0gICAgICAgIHN0YXRpYyBJZGVudGlmaWVyIGZyb20oRXhl Y1N0YXRlKiBleGVjLCB1bnNpZ25lZCB5KSB7IHJldHVybiBJZGVudGlmaWVyKGV4ZWMsIFVTdHJp bmc6OmZyb20oeSkpOyB9Ci0gICAgICAgIHN0YXRpYyBJZGVudGlmaWVyIGZyb20oRXhlY1N0YXRl KiBleGVjLCBpbnQgeSkgeyByZXR1cm4gSWRlbnRpZmllcihleGVjLCBVU3RyaW5nOjpmcm9tKHkp KTsgfQotICAgICAgICBzdGF0aWMgSWRlbnRpZmllciBmcm9tKEV4ZWNTdGF0ZSogZXhlYywgZG91 YmxlIHkpIHsgcmV0dXJuIElkZW50aWZpZXIoZXhlYywgVVN0cmluZzo6ZnJvbSh5KSk7IH0KKyAg ICAgICAgc3RhdGljIElkZW50aWZpZXIgZnJvbShFeGVjU3RhdGUqIGV4ZWMsIHVuc2lnbmVkIHkp OworICAgICAgICBzdGF0aWMgSWRlbnRpZmllciBmcm9tKEV4ZWNTdGF0ZSogZXhlYywgaW50IHkp OworICAgICAgICBzdGF0aWMgSWRlbnRpZmllciBmcm9tKEV4ZWNTdGF0ZSogZXhlYywgZG91Ymxl IHkpOwogICAgICAgICAKICAgICAgICAgYm9vbCBpc051bGwoKSBjb25zdCB7IHJldHVybiBfdXN0 cmluZy5pc051bGwoKTsgfQogICAgICAgICBib29sIGlzRW1wdHkoKSBjb25zdCB7IHJldHVybiBf dXN0cmluZy5pc0VtcHR5KCk7IH0KZGlmZiAtLWdpdCBhL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUv TnVtZXJpY1N0cmluZ3MuaCBiL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvTnVtZXJpY1N0cmluZ3Mu aAppbmRleCBjMDY5NmE0Li44OTIzNWFmIDEwMDY0NAotLS0gYS9KYXZhU2NyaXB0Q29yZS9ydW50 aW1lL051bWVyaWNTdHJpbmdzLmgKKysrIGIvSmF2YVNjcmlwdENvcmUvcnVudGltZS9OdW1lcmlj U3RyaW5ncy5oCkBAIC00NSw2ICs0NSw4IEBAIG5hbWVzcGFjZSBKU0MgewogCiAgICAgICAgIFVT dHJpbmcgYWRkKGludCBpKQogICAgICAgICB7CisgICAgICAgICAgICBpZiAoc3RhdGljX2Nhc3Q8 dW5zaWduZWQ+KGkpIDwgY2FjaGVTaXplKQorICAgICAgICAgICAgICAgIHJldHVybiBsb29rdXBT bWFsbFN0cmluZyhzdGF0aWNfY2FzdDx1bnNpZ25lZD4oaSkpOwogICAgICAgICAgICAgQ2FjaGVF bnRyeTxpbnQ+JiBlbnRyeSA9IGxvb2t1cChpKTsKICAgICAgICAgICAgIGlmIChpID09IGVudHJ5 LmtleSAmJiAhZW50cnkudmFsdWUuaXNOdWxsKCkpCiAgICAgICAgICAgICAgICAgcmV0dXJuIGVu dHJ5LnZhbHVlOwpAQCAtNTMsNiArNTUsMTcgQEAgbmFtZXNwYWNlIEpTQyB7CiAgICAgICAgICAg ICByZXR1cm4gZW50cnkudmFsdWU7CiAgICAgICAgIH0KIAorICAgICAgICBVU3RyaW5nIGFkZCh1 bnNpZ25lZCBpKQorICAgICAgICB7CisgICAgICAgICAgICBpZiAoaSA8IGNhY2hlU2l6ZSkKKyAg ICAgICAgICAgICAgICByZXR1cm4gbG9va3VwU21hbGxTdHJpbmcoc3RhdGljX2Nhc3Q8dW5zaWdu ZWQ+KGkpKTsKKyAgICAgICAgICAgIENhY2hlRW50cnk8dW5zaWduZWQ+JiBlbnRyeSA9IGxvb2t1 cChpKTsKKyAgICAgICAgICAgIGlmIChpID09IGVudHJ5LmtleSAmJiAhZW50cnkudmFsdWUuaXNO dWxsKCkpCisgICAgICAgICAgICAgICAgcmV0dXJuIGVudHJ5LnZhbHVlOworICAgICAgICAgICAg ZW50cnkua2V5ID0gaTsKKyAgICAgICAgICAgIGVudHJ5LnZhbHVlID0gVVN0cmluZzo6ZnJvbShp KTsKKyAgICAgICAgICAgIHJldHVybiBlbnRyeS52YWx1ZTsKKyAgICAgICAgfQogICAgIHByaXZh dGU6CiAgICAgICAgIHN0YXRpYyBjb25zdCBzaXplX3QgY2FjaGVTaXplID0gNjQ7CiAKQEAgLTY0 LDkgKzc3LDE5IEBAIG5hbWVzcGFjZSBKU0MgewogCiAgICAgICAgIENhY2hlRW50cnk8ZG91Ymxl PiYgbG9va3VwKGRvdWJsZSBkKSB7IHJldHVybiBkb3VibGVDYWNoZVtXVEY6OkZsb2F0SGFzaDxk b3VibGU+OjpoYXNoKGQpICYgKGNhY2hlU2l6ZSAtIDEpXTsgfQogICAgICAgICBDYWNoZUVudHJ5 PGludD4mIGxvb2t1cChpbnQgaSkgeyByZXR1cm4gaW50Q2FjaGVbV1RGOjpJbnRIYXNoPGludD46 Omhhc2goaSkgJiAoY2FjaGVTaXplIC0gMSldOyB9CisgICAgICAgIENhY2hlRW50cnk8dW5zaWdu ZWQ+JiBsb29rdXAodW5zaWduZWQgaSkgeyByZXR1cm4gdW5zaWduZWRDYWNoZVtXVEY6OkludEhh c2g8dW5zaWduZWQ+OjpoYXNoKGkpICYgKGNhY2hlU2l6ZSAtIDEpXTsgfQorICAgICAgICBjb25z dCBVU3RyaW5nJiBsb29rdXBTbWFsbFN0cmluZyh1bnNpZ25lZCBpKQorICAgICAgICB7CisgICAg ICAgICAgICBBU1NFUlQoaSA8IGNhY2hlU2l6ZSk7CisgICAgICAgICAgICBpZiAoc21hbGxJbnRD YWNoZVtpXS5pc051bGwoKSkKKyAgICAgICAgICAgICAgICBzbWFsbEludENhY2hlW2ldID0gVVN0 cmluZzo6ZnJvbShpKTsKKyAgICAgICAgICAgIHJldHVybiBzbWFsbEludENhY2hlW2ldOworICAg ICAgICB9CiAKICAgICAgICAgQ2FjaGVFbnRyeTxkb3VibGU+IGRvdWJsZUNhY2hlW2NhY2hlU2l6 ZV07CiAgICAgICAgIENhY2hlRW50cnk8aW50PiBpbnRDYWNoZVtjYWNoZVNpemVdOworICAgICAg ICBDYWNoZUVudHJ5PHVuc2lnbmVkPiB1bnNpZ25lZENhY2hlW2NhY2hlU2l6ZV07CisgICAgICAg IFVTdHJpbmcgc21hbGxJbnRDYWNoZVtjYWNoZVNpemVdOwogICAgIH07CiAKIH0gLy8gbmFtZXNw YWNlIEpTQwo=