<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>35812</bug_id>
          
          <creation_ts>2010-03-05 14:27:17 -0800</creation_ts>
          <short_desc>[new-run-webkit-tests][Chromium] split http_server into a new top level script plus a module</short_desc>
          <delta_ts>2010-03-05 16:40:06 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Tools / Tests</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>PC</rep_platform>
          <op_sys>OS X 10.5</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Dirk Pranke">dpranke</reporter>
          <assigned_to name="Dirk Pranke">dpranke</assigned_to>
          <cc>cjerdonek</cc>
    
    <cc>eric</cc>
    
    <cc>ojan</cc>
    
    <cc>tony</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>196668</commentid>
    <comment_count>0</comment_count>
    <who name="Dirk Pranke">dpranke</who>
    <bug_when>2010-03-05 14:27:17 -0800</bug_when>
    <thetext>Chromium&apos;s ui_test infrastructure uses the layout tests http_server infrastructure for some HTTP testing. At the moment it calls into webkitpy/layout_tests/port/http_server directly (as a __main__), but this is awkward, buggy on a mac, and has several layering violations.

I&apos;m going to resolve this by creating a new top-level new-run-webkit-httpd script and call that instead, and make http_server just be a module.

The new script only works w/ Chromium&apos;s LigHTTP implementation, but should be made generic.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>196743</commentid>
    <comment_count>1</comment_count>
      <attachid>50134</attachid>
    <who name="Dirk Pranke">dpranke</who>
    <bug_when>2010-03-05 15:38:19 -0800</bug_when>
    <thetext>Created attachment 50134
patch to split running http_server as a standalone script vs. an embedded library</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>196747</commentid>
    <comment_count>2</comment_count>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2010-03-05 15:41:13 -0800</bug_when>
    <thetext>LGTM, but I thought that Ojan had already made up a python version of run-webkit-httpd which knew how to talk to apache2?

I&apos;m ready to r+ this as soon as we hear from Ojan.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>196748</commentid>
    <comment_count>3</comment_count>
      <attachid>50134</attachid>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2010-03-05 15:42:09 -0800</bug_when>
    <thetext>Comment on attachment 50134
patch to split running http_server as a standalone script vs. an embedded library

Or rather, I&apos;ll r+ it, but I&apos;d like Ojan to bless the patch before landing. :)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>196771</commentid>
    <comment_count>4</comment_count>
    <who name="Dirk Pranke">dpranke</who>
    <bug_when>2010-03-05 16:12:59 -0800</bug_when>
    <thetext>(In reply to comment #2)
&gt; LGTM, but I thought that Ojan had already made up a python version of
&gt; run-webkit-httpd which knew how to talk to apache2?
&gt; 
&gt; I&apos;m ready to r+ this as soon as we hear from Ojan.

If he does, I haven&apos;t seen it. However, the chromium test code actually has switches hard-coded into it for the LigHTTPd version (unfortunately), so I would like to address the whole apache/lighttpd thing separately from this patch.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>196782</commentid>
    <comment_count>5</comment_count>
      <attachid>50134</attachid>
    <who name="Ojan Vafai">ojan</who>
    <bug_when>2010-03-05 16:27:03 -0800</bug_when>
    <thetext>Comment on attachment 50134
patch to split running http_server as a standalone script vs. an embedded library

A couple nits on comments. The code looks fine. No need for another review before committing though.

&gt; +++ b/WebKitTools/ChangeLog
&gt; +        the Chromium tree. At some point this script should be made to
&gt; +        work with Apache-based implementations and on other ports.

Could you file a bug for this and link to it in the ChangeLog description?

&gt; +++ b/WebKitTools/Scripts/new-run-webkit-httpd
&gt; +# TODO: currently this code only works with the Chromium ports and LigHTTPd.
s/TODO/FIXME

&gt; +# It should be made to work on all ports.
&gt; +#
&gt; +# This script is also used by Chromium&apos;s ui_tests to run http layout tests
&gt; +# in a browser.
I don&apos;t think this needs to be documented. It&apos;s not an explicit goal of the WebKit project to support Chromium&apos;s ui_test infrastructure. I don&apos;t think it&apos;s an issue in practice, but if WebKit needed this to change in a way that&apos;s incompatible with Chromium&apos;s needs, then it should be able to.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>196795</commentid>
    <comment_count>6</comment_count>
    <who name="Dirk Pranke">dpranke</who>
    <bug_when>2010-03-05 16:33:01 -0800</bug_when>
    <thetext>(In reply to comment #5)
&gt; (From update of attachment 50134 [details])
&gt; A couple nits on comments. The code looks fine. No need for another review
&gt; before committing though.
&gt; 
&gt; &gt; +++ b/WebKitTools/ChangeLog
&gt; &gt; +        the Chromium tree. At some point this script should be made to
&gt; &gt; +        work with Apache-based implementations and on other ports.
&gt; 
&gt; Could you file a bug for this and link to it in the ChangeLog description?
&gt; 

Done. See bug 35820.

&gt; &gt; +++ b/WebKitTools/Scripts/new-run-webkit-httpd
&gt; &gt; +# TODO: currently this code only works with the Chromium ports and LigHTTPd.
&gt; s/TODO/FIXME
&gt; 

Grr. I thought FIXME was Chromium and TODO was WebKit. Guess I got it backwards.

&gt; &gt; +# It should be made to work on all ports.
&gt; &gt; +#
&gt; &gt; +# This script is also used by Chromium&apos;s ui_tests to run http layout tests
&gt; &gt; +# in a browser.
&gt; I don&apos;t think this needs to be documented. It&apos;s not an explicit goal of the
&gt; WebKit project to support Chromium&apos;s ui_test infrastructure. I don&apos;t think it&apos;s
&gt; an issue in practice, but if WebKit needed this to change in a way that&apos;s
&gt; incompatible with Chromium&apos;s needs, then it should be able to.

I agree that WebKit should be able to change things, but it doesn&apos;t hurt to have the dependency documented.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>196802</commentid>
    <comment_count>7</comment_count>
    <who name="Dirk Pranke">dpranke</who>
    <bug_when>2010-03-05 16:40:06 -0800</bug_when>
    <thetext>Patch landed as r55602: http://trac.webkit.org/changeset/55602</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>50134</attachid>
            <date>2010-03-05 15:38:19 -0800</date>
            <delta_ts>2010-03-05 16:27:03 -0800</delta_ts>
            <desc>patch to split running http_server as a standalone script vs. an embedded library</desc>
            <filename>wk35812_fix_http_server.diff</filename>
            <type>text/plain</type>
            <size>8694</size>
            <attacher name="Dirk Pranke">dpranke</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv
ZwppbmRleCBmYTY1YzMxLi5jNjgxMTBkIDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VM
b2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjMgQEAKKzIwMTAtMDMt
MDUgIERpcmsgUHJhbmtlICA8ZHByYW5rZUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3
ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgU3BsaXQgdGhlIGNvbW1hbmQtbGluZSBp
bnZvY2F0aW9uIG9mIHRoZSBDaHJvbWl1bS9weXRob24gTGlnSFRUUGQKKyAgICAgICAgc2VydmVy
IGltcGxlbWVudGF0aW9uIG91dCBpbnRvIGl0cyBvd24gdG9wIGxldmVsIHNjcmlwdCB0byBtYWtl
IGl0CisgICAgICAgIGEgbW9yZSAicHVibGljIiBpbnRlcmZhY2UgYW5kIHRvIHJlc29sdmUgc29t
ZSBhd2t3YXJkIGxheWVyaW5nCisgICAgICAgIGlzc3Vlcy4gVGhpcyBzY3JpcHQgd2lsbCBiZSBj
YWxsZWQgZGlyZWN0bHkgYnkgb3RoZXIgdGVzdCBzY3JpcHRzIGluCisgICAgICAgIHRoZSBDaHJv
bWl1bSB0cmVlLiBBdCBzb21lIHBvaW50IHRoaXMgc2NyaXB0IHNob3VsZCBiZSBtYWRlIHRvCisg
ICAgICAgIHdvcmsgd2l0aCBBcGFjaGUtYmFzZWQgaW1wbGVtZW50YXRpb25zIGFuZCBvbiBvdGhl
ciBwb3J0cy4KKworICAgICAgICBBbHNvIGZpeCBhIGJ1ZyBpbiBwb3J0L2ZhY3Rvcnkgd2hlcmUg
b3B0aW9ucy5jaHJvbWl1bSBjb3VsZCBiZQorICAgICAgICBkZXJlZmVyZW5jZWQgZXZlbiBpZiBp
dCB3YXNuJ3Qgc2V0LCByYWlzaW5nIGFuIGV4Y2VwdGlvbi4KKworICAgICAgICBodHRwczovL2J1
Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzU4MTIKKworICAgICAgICAqIFNjcmlwdHMv
d2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvZmFjdG9yeS5weToKKyAgICAgICAgKiBTY3JpcHRz
L3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L2h0dHBfc2VydmVyLnB5OgorICAgICAgICAqIFNj
cmlwdHMvbmV3LXJ1bi13ZWJraXQtaHR0cGQ6IEFkZGVkCisKIDIwMTAtMDMtMDIgIEFudG9uaW8g
R29tZXMgIDx0b25pa2l0b29Ad2Via2l0Lm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBLZW5u
ZXRoIENocmlzdGlhbnNlbi4KZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL1NjcmlwdHMvbmV3LXJ1
bi13ZWJraXQtaHR0cGQgYi9XZWJLaXRUb29scy9TY3JpcHRzL25ldy1ydW4td2Via2l0LWh0dHBk
Cm5ldyBmaWxlIG1vZGUgMTAwNzU1CmluZGV4IDAwMDAwMDAuLjEzZDRlMzAKLS0tIC9kZXYvbnVs
bAorKysgYi9XZWJLaXRUb29scy9TY3JpcHRzL25ldy1ydW4td2Via2l0LWh0dHBkCkBAIC0wLDAg
KzEsOTggQEAKKyMhL3Vzci9iaW4vZW52IHB5dGhvbgorIyBDb3B5cmlnaHQgKEMpIDIwMTAgR29v
Z2xlIEluYy4gQWxsIHJpZ2h0cyByZXNlcnZlZC4KKyMKKyMgUmVkaXN0cmlidXRpb24gYW5kIHVz
ZSBpbiBzb3VyY2UgYW5kIGJpbmFyeSBmb3Jtcywgd2l0aCBvciB3aXRob3V0CisjIG1vZGlmaWNh
dGlvbiwgYXJlIHBlcm1pdHRlZCBwcm92aWRlZCB0aGF0IHRoZSBmb2xsb3dpbmcgY29uZGl0aW9u
cyBhcmUKKyMgbWV0OgorIworIyAgICAgKiBSZWRpc3RyaWJ1dGlvbnMgb2Ygc291cmNlIGNvZGUg
bXVzdCByZXRhaW4gdGhlIGFib3ZlIGNvcHlyaWdodAorIyBub3RpY2UsIHRoaXMgbGlzdCBvZiBj
b25kaXRpb25zIGFuZCB0aGUgZm9sbG93aW5nIGRpc2NsYWltZXIuCisjICAgICAqIFJlZGlzdHJp
YnV0aW9ucyBpbiBiaW5hcnkgZm9ybSBtdXN0IHJlcHJvZHVjZSB0aGUgYWJvdmUKKyMgY29weXJp
Z2h0IG5vdGljZSwgdGhpcyBsaXN0IG9mIGNvbmRpdGlvbnMgYW5kIHRoZSBmb2xsb3dpbmcgZGlz
Y2xhaW1lcgorIyBpbiB0aGUgZG9jdW1lbnRhdGlvbiBhbmQvb3Igb3RoZXIgbWF0ZXJpYWxzIHBy
b3ZpZGVkIHdpdGggdGhlCisjIGRpc3RyaWJ1dGlvbi4KKyMgICAgICogTmVpdGhlciB0aGUgbmFt
ZSBvZiBHb29nbGUgSW5jLiBub3IgdGhlIG5hbWVzIG9mIGl0cworIyBjb250cmlidXRvcnMgbWF5
IGJlIHVzZWQgdG8gZW5kb3JzZSBvciBwcm9tb3RlIHByb2R1Y3RzIGRlcml2ZWQgZnJvbQorIyB0
aGlzIHNvZnR3YXJlIHdpdGhvdXQgc3BlY2lmaWMgcHJpb3Igd3JpdHRlbiBwZXJtaXNzaW9uLgor
IworIyBUSElTIFNPRlRXQVJFIElTIFBST1ZJREVEIEJZIFRIRSBDT1BZUklHSFQgSE9MREVSUyBB
TkQgQ09OVFJJQlVUT1JTCisjICJBUyBJUyIgQU5EIEFOWSBFWFBSRVNTIE9SIElNUExJRUQgV0FS
UkFOVElFUywgSU5DTFVESU5HLCBCVVQgTk9UCisjIExJTUlURUQgVE8sIFRIRSBJTVBMSUVEIFdB
UlJBTlRJRVMgT0YgTUVSQ0hBTlRBQklMSVRZIEFORCBGSVRORVNTIEZPUgorIyBBIFBBUlRJQ1VM
QVIgUFVSUE9TRSBBUkUgRElTQ0xBSU1FRC4gSU4gTk8gRVZFTlQgU0hBTEwgVEhFIENPUFlSSUdI
VAorIyBPV05FUiBPUiBDT05UUklCVVRPUlMgQkUgTElBQkxFIEZPUiBBTlkgRElSRUNULCBJTkRJ
UkVDVCwgSU5DSURFTlRBTCwKKyMgU1BFQ0lBTCwgRVhFTVBMQVJZLCBPUiBDT05TRVFVRU5USUFM
IERBTUFHRVMgKElOQ0xVRElORywgQlVUIE5PVAorIyBMSU1JVEVEIFRPLCBQUk9DVVJFTUVOVCBP
RiBTVUJTVElUVVRFIEdPT0RTIE9SIFNFUlZJQ0VTOyBMT1NTIE9GIFVTRSwKKyMgREFUQSwgT1Ig
UFJPRklUUzsgT1IgQlVTSU5FU1MgSU5URVJSVVBUSU9OKSBIT1dFVkVSIENBVVNFRCBBTkQgT04g
QU5ZCisjIFRIRU9SWSBPRiBMSUFCSUxJVFksIFdIRVRIRVIgSU4gQ09OVFJBQ1QsIFNUUklDVCBM
SUFCSUxJVFksIE9SIFRPUlQKKyMgKElOQ0xVRElORyBORUdMSUdFTkNFIE9SIE9USEVSV0lTRSkg
QVJJU0lORyBJTiBBTlkgV0FZIE9VVCBPRiBUSEUgVVNFCisjIE9GIFRISVMgU09GVFdBUkUsIEVW
RU4gSUYgQURWSVNFRCBPRiBUSEUgUE9TU0lCSUxJVFkgT0YgU1VDSCBEQU1BR0UuCisKKyIiIkEg
dXRpbGl0eSBzY3JpcHQgZm9yIHN0YXJ0aW5nIGFuZCBzdG9wcGluZyB0aGUgSFRUUCBzZXJ2ZXIg
d2l0aCB0aGUKKyAgIHNhbWUgY29uZmlndXJhdGlvbiBhcyB1c2VkIGluIHRoZSBsYXlvdXQgdGVz
dHMuIiIiCisKKyMKKyMgVE9ETzogY3VycmVudGx5IHRoaXMgY29kZSBvbmx5IHdvcmtzIHdpdGgg
dGhlIENocm9taXVtIHBvcnRzIGFuZCBMaWdIVFRQZC4KKyMgSXQgc2hvdWxkIGJlIG1hZGUgdG8g
d29yayBvbiBhbGwgcG9ydHMuCisjCisjIFRoaXMgc2NyaXB0IGlzIGFsc28gdXNlZCBieSBDaHJv
bWl1bSdzIHVpX3Rlc3RzIHRvIHJ1biBodHRwIGxheW91dCB0ZXN0cworIyBpbiBhIGJyb3dzZXIu
CisjCitpbXBvcnQgb3B0cGFyc2UKK2ltcG9ydCBvcworaW1wb3J0IHN5cworaW1wb3J0IHRlbXBm
aWxlCisKK3NjcmlwdHNfZGlyZWN0b3J5ID0gb3MucGF0aC5kaXJuYW1lKG9zLnBhdGguYWJzcGF0
aChzeXMuYXJndlswXSkpCit3ZWJraXRweV9kaXJlY3RvcnkgPSBvcy5wYXRoLmpvaW4oc2NyaXB0
c19kaXJlY3RvcnksICJ3ZWJraXRweSIpCitzeXMucGF0aC5hcHBlbmQob3MucGF0aC5qb2luKHdl
YmtpdHB5X2RpcmVjdG9yeSwgImxheW91dF90ZXN0cyIpKQorCitpbXBvcnQgcG9ydAorZnJvbSBw
b3J0IGltcG9ydCBodHRwX3NlcnZlcgorCitkZWYgcnVuKG9wdGlvbnMpOgorICAgIGlmIG5vdCBv
cHRpb25zLnNlcnZlcjoKKyAgICAgICAgcHJpbnQgKCdVc2FnZTogJXMgLS1zZXJ2ZXIge3N0YXJ0
fHN0b3B9IFstLXJvb3Q9cm9vdF9kaXJdJworICAgICAgICAgICAgICAgJyBbLS1wb3J0PXBvcnRf
bnVtYmVyXScgJSBzeXMuYXJndlswXSkKKyAgICBlbHNlOgorICAgICAgICBpZiAob3B0aW9ucy5y
b290IGlzIE5vbmUpIGFuZCAob3B0aW9ucy5wb3J0IGlzIG5vdCBOb25lKToKKyAgICAgICAgICAg
ICMgc3BlY2lmeWluZyByb290IGJ1dCBub3QgcG9ydCBtZWFucyB3ZSB3YW50IGh0dHBkIG9uIGRl
ZmF1bHQKKyAgICAgICAgICAgICMgc2V0IG9mIHBvcnRzIHRoYXQgTGF5b3V0VGVzdCB1c2UsIGJ1
dCBwb2ludGluZyB0byBhIGRpZmZlcmVudAorICAgICAgICAgICAgIyBzb3VyY2Ugb2YgdGVzdHMu
IFNwZWNpZnlpbmcgcG9ydCBidXQgbm8gcm9vdCBkb2VzIG5vdCBzZWVtCisgICAgICAgICAgICAj
IG1lYW5pbmdmdWwuCisgICAgICAgICAgICByYWlzZSAnU3BlY2lmeWluZyBwb3J0IHJlcXVpcmVz
IGFsc28gYSByb290LicKKyAgICAgICAgcG9ydF9vYmogPSBwb3J0LmdldChOb25lLCBvcHRpb25z
KQorICAgICAgICBodHRwZCA9IGh0dHBfc2VydmVyLkxpZ2h0dHBkKHBvcnRfb2JqLAorICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHRlbXBmaWxlLmdldHRlbXBkaXIoKSwKKyAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBwb3J0PW9wdGlvbnMucG9ydCwKKyAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICByb290PW9wdGlvbnMucm9vdCwKKyAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICByZWdpc3Rlcl9jeWd3aW49b3B0aW9u
cy5yZWdpc3Rlcl9jeWd3aW4sCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
cnVuX2JhY2tncm91bmQ9b3B0aW9ucy5ydW5fYmFja2dyb3VuZCkKKyAgICAgICAgaWYgb3B0aW9u
cy5zZXJ2ZXIgPT0gJ3N0YXJ0JzoKKyAgICAgICAgICAgIGh0dHBkLnN0YXJ0KCkKKyAgICAgICAg
ZWxzZToKKyAgICAgICAgICAgIGh0dHBkLnN0b3AoZm9yY2U9VHJ1ZSkKKworCitkZWYgbWFpbigp
OgorICAgIG9wdGlvbl9wYXJzZXIgPSBvcHRwYXJzZS5PcHRpb25QYXJzZXIoKQorICAgIG9wdGlv
bl9wYXJzZXIuYWRkX29wdGlvbignLWsnLCAnLS1zZXJ2ZXInLAorICAgICAgICBoZWxwPSdTZXJ2
ZXIgYWN0aW9uIChzdGFydHxzdG9wKScpCisgICAgb3B0aW9uX3BhcnNlci5hZGRfb3B0aW9uKCct
cCcsICctLXBvcnQnLAorICAgICAgICBoZWxwPSdQb3J0IHRvIGxpc3RlbiBvbiAob3ZlcnJpZGVz
IGxheW91dCB0ZXN0IHBvcnRzKScpCisgICAgb3B0aW9uX3BhcnNlci5hZGRfb3B0aW9uKCctcics
ICctLXJvb3QnLAorICAgICAgICBoZWxwPSdBYnNvbHV0ZSBwYXRoIHRvIERvY3VtZW50Um9vdCAo
b3ZlcnJpZGVzIGxheW91dCB0ZXN0IHJvb3RzKScpCisgICAgb3B0aW9uX3BhcnNlci5hZGRfb3B0
aW9uKCctLXJlZ2lzdGVyX2N5Z3dpbicsIGFjdGlvbj0ic3RvcmVfdHJ1ZSIsCisgICAgICAgIGRl
c3Q9InJlZ2lzdGVyX2N5Z3dpbiIsIGhlbHA9J1JlZ2lzdGVyIEN5Z3dpbiBwYXRocyAob24gV2lu
IHRyeSBib3RzKScpCisgICAgb3B0aW9uX3BhcnNlci5hZGRfb3B0aW9uKCctLXJ1bl9iYWNrZ3Jv
dW5kJywgYWN0aW9uPSJzdG9yZV90cnVlIiwKKyAgICAgICAgZGVzdD0icnVuX2JhY2tncm91bmQi
LAorICAgICAgICBoZWxwPSdSdW4gb24gYmFja2dyb3VuZCAoZm9yIHJ1bm5pbmcgYXMgVUkgdGVz
dCknKQorICAgIG9wdGlvbnMsIGFyZ3MgPSBvcHRpb25fcGFyc2VyLnBhcnNlX2FyZ3MoKQorCisg
ICAgIyBUT0RPOiBNYWtlIHRoaXMgd29yayB3aXRoIG90aGVyIHBvcnRzIGFzIHdlbGwuCisgICAg
b3B0aW9ucy5jaHJvbWl1bSA9IFRydWUKKworICAgIHJ1bihvcHRpb25zKQorCisKK2lmICdfX21h
aW5fXycgPT0gX19uYW1lX186CisgICAgbWFpbigpCmRpZmYgLS1naXQgYS9XZWJLaXRUb29scy9T
Y3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L2ZhY3RvcnkucHkgYi9XZWJLaXRUb29s
cy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L2ZhY3RvcnkucHkKaW5kZXggYjZm
NTMwZS4uYTE4ZGY5OSAxMDA2NDQKLS0tIGEvV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRweS9s
YXlvdXRfdGVzdHMvcG9ydC9mYWN0b3J5LnB5CisrKyBiL1dlYktpdFRvb2xzL1NjcmlwdHMvd2Vi
a2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvZmFjdG9yeS5weQpAQCAtNDQsNyArNDQsNyBAQCBkZWYg
Z2V0KHBvcnRfbmFtZT1Ob25lLCBvcHRpb25zPU5vbmUpOgogICAgICAgICBlbGlmIHN5cy5wbGF0
Zm9ybSA9PSAnbGludXgyJzoKICAgICAgICAgICAgIHBvcnRfdG9fdXNlID0gJ2Nocm9taXVtLWxp
bnV4JwogICAgICAgICBlbGlmIHN5cy5wbGF0Zm9ybSA9PSAnZGFyd2luJzoKLSAgICAgICAgICAg
IGlmIG9wdGlvbnMuY2hyb21pdW06CisgICAgICAgICAgICBpZiBvcHRpb25zIGFuZCBoYXNhdHRy
KG9wdGlvbnMsICdjaHJvbWl1bScpIGFuZCBvcHRpb25zLmNocm9taXVtOgogICAgICAgICAgICAg
ICAgIHBvcnRfdG9fdXNlID0gJ2Nocm9taXVtLW1hYycKICAgICAgICAgICAgIGVsc2U6CiAgICAg
ICAgICAgICAgICAgcG9ydF90b191c2UgPSAnbWFjJwpkaWZmIC0tZ2l0IGEvV2ViS2l0VG9vbHMv
U2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC9odHRwX3NlcnZlci5weSBiL1dlYktp
dFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvaHR0cF9zZXJ2ZXIucHkK
aW5kZXggN2RlNDRjNC4uMTYwNjY4YyAxMDA3NTUKLS0tIGEvV2ViS2l0VG9vbHMvU2NyaXB0cy93
ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC9odHRwX3NlcnZlci5weQorKysgYi9XZWJLaXRUb29s
cy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L2h0dHBfc2VydmVyLnB5CkBAIC0y
MzQsNDIgKzIzNCwzIEBAIGNsYXNzIExpZ2h0dHBkKGh0dHBfc2VydmVyX2Jhc2UuSHR0cFNlcnZl
ckJhc2UpOgogICAgICAgICBpZiBzZWxmLl9wcm9jZXNzOgogICAgICAgICAgICAgc2VsZi5fcHJv
Y2Vzcy53YWl0KCkKICAgICAgICAgICAgIHNlbGYuX3Byb2Nlc3MgPSBOb25lCi0KLWlmICdfX21h
aW5fXycgPT0gX19uYW1lX186Ci0gICAgIyBQcm92aWRlIHNvbWUgY29tbWFuZCBsaW5lIHBhcmFt
cyBmb3Igc3RhcnRpbmcvc3RvcHBpbmcgdGhlIGh0dHAgc2VydmVyCi0gICAgIyBtYW51YWxseS4g
QWxzbyB1c2VkIGluIHVpX3Rlc3RzIHRvIHJ1biBodHRwIGxheW91dCB0ZXN0cyBpbiBhIGJyb3dz
ZXIuCi0gICAgb3B0aW9uX3BhcnNlciA9IG9wdHBhcnNlLk9wdGlvblBhcnNlcigpCi0gICAgb3B0
aW9uX3BhcnNlci5hZGRfb3B0aW9uKCctaycsICctLXNlcnZlcicsCi0gICAgICAgIGhlbHA9J1Nl
cnZlciBhY3Rpb24gKHN0YXJ0fHN0b3ApJykKLSAgICBvcHRpb25fcGFyc2VyLmFkZF9vcHRpb24o
Jy1wJywgJy0tcG9ydCcsCi0gICAgICAgIGhlbHA9J1BvcnQgdG8gbGlzdGVuIG9uIChvdmVycmlk
ZXMgbGF5b3V0IHRlc3QgcG9ydHMpJykKLSAgICBvcHRpb25fcGFyc2VyLmFkZF9vcHRpb24oJy1y
JywgJy0tcm9vdCcsCi0gICAgICAgIGhlbHA9J0Fic29sdXRlIHBhdGggdG8gRG9jdW1lbnRSb290
IChvdmVycmlkZXMgbGF5b3V0IHRlc3Qgcm9vdHMpJykKLSAgICBvcHRpb25fcGFyc2VyLmFkZF9v
cHRpb24oJy0tcmVnaXN0ZXJfY3lnd2luJywgYWN0aW9uPSJzdG9yZV90cnVlIiwKLSAgICAgICAg
ZGVzdD0icmVnaXN0ZXJfY3lnd2luIiwgaGVscD0nUmVnaXN0ZXIgQ3lnd2luIHBhdGhzIChvbiBX
aW4gdHJ5IGJvdHMpJykKLSAgICBvcHRpb25fcGFyc2VyLmFkZF9vcHRpb24oJy0tcnVuX2JhY2tn
cm91bmQnLCBhY3Rpb249InN0b3JlX3RydWUiLAotICAgICAgICBkZXN0PSJydW5fYmFja2dyb3Vu
ZCIsCi0gICAgICAgIGhlbHA9J1J1biBvbiBiYWNrZ3JvdW5kIChmb3IgcnVubmluZyBhcyBVSSB0
ZXN0KScpCi0gICAgb3B0aW9ucywgYXJncyA9IG9wdGlvbl9wYXJzZXIucGFyc2VfYXJncygpCi0K
LSAgICBpZiBub3Qgb3B0aW9ucy5zZXJ2ZXI6Ci0gICAgICAgIHByaW50ICgnVXNhZ2U6ICVzIC0t
c2VydmVyIHtzdGFydHxzdG9wfSBbLS1yb290PXJvb3RfZGlyXScKLSAgICAgICAgICAgICAgICcg
Wy0tcG9ydD1wb3J0X251bWJlcl0nICUgc3lzLmFyZ3ZbMF0pCi0gICAgZWxzZToKLSAgICAgICAg
aWYgKG9wdGlvbnMucm9vdCBpcyBOb25lKSBhbmQgKG9wdGlvbnMucG9ydCBpcyBub3QgTm9uZSk6
Ci0gICAgICAgICAgICAjIHNwZWNpZnlpbmcgcm9vdCBidXQgbm90IHBvcnQgbWVhbnMgd2Ugd2Fu
dCBodHRwZCBvbiBkZWZhdWx0Ci0gICAgICAgICAgICAjIHNldCBvZiBwb3J0cyB0aGF0IExheW91
dFRlc3QgdXNlLCBidXQgcG9pbnRpbmcgdG8gYSBkaWZmZXJlbnQKLSAgICAgICAgICAgICMgc291
cmNlIG9mIHRlc3RzLiBTcGVjaWZ5aW5nIHBvcnQgYnV0IG5vIHJvb3QgZG9lcyBub3Qgc2VlbQot
ICAgICAgICAgICAgIyBtZWFuaW5nZnVsLgotICAgICAgICAgICAgcmFpc2UgJ1NwZWNpZnlpbmcg
cG9ydCByZXF1aXJlcyBhbHNvIGEgcm9vdC4nCi0gICAgICAgIHBvcnRfb2JqID0gZmFjdG9yeS5n
ZXQoKQotICAgICAgICBodHRwZCA9IExpZ2h0dHBkKHBvcnRfb2JqLAotICAgICAgICAgICAgICAg
ICAgICAgICAgIHRlbXBmaWxlLmdldHRlbXBkaXIoKSwKLSAgICAgICAgICAgICAgICAgICAgICAg
ICBwb3J0PW9wdGlvbnMucG9ydCwKLSAgICAgICAgICAgICAgICAgICAgICAgICByb290PW9wdGlv
bnMucm9vdCwKLSAgICAgICAgICAgICAgICAgICAgICAgICByZWdpc3Rlcl9jeWd3aW49b3B0aW9u
cy5yZWdpc3Rlcl9jeWd3aW4sCi0gICAgICAgICAgICAgICAgICAgICAgICAgcnVuX2JhY2tncm91
bmQ9b3B0aW9ucy5ydW5fYmFja2dyb3VuZCkKLSAgICAgICAgaWYgJ3N0YXJ0JyA9PSBvcHRpb25z
LnNlcnZlcjoKLSAgICAgICAgICAgIGh0dHBkLnN0YXJ0KCkKLSAgICAgICAgZWxzZToKLSAgICAg
ICAgICAgIGh0dHBkLnN0b3AoZm9yY2U9VHJ1ZSkK
</data>
<flag name="review"
          id="33194"
          type_id="1"
          status="+"
          setter="eric"
    />
          </attachment>
      

    </bug>

</bugzilla>