35803 2010-03-05 13:15:46 -0800 [Gtk] GEOLOCATION_POLICY_DECISION_CANCELLED unused 2010-03-06 06:23:20 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 35210 0 a.renevier webkit-unassigned commit-queue gustavo xan.lopez oldest_to_newest 196608 0 a.renevier 2010-03-05 13:15:46 -0800 In bug #35210, I used twice webkit_web_view_signals[GEOLOCATION_POLICY_DECISION_REQUESTED] = in WebKit/gtk/webkit/webkitwebview.cpp. One for geolocation-policy-decision-requested, which is correct; one for geolocation-policy-decision-cancelled which is a typo. 196613 1 50112 a.renevier 2010-03-05 13:19:12 -0800 Created attachment 50112 patch v1 196823 2 50112 eric 2010-03-05 17:18:14 -0800 Comment on attachment 50112 patch v1 LGTM. 196900 3 50112 commit-queue 2010-03-06 06:23:16 -0800 Comment on attachment 50112 patch v1 Clearing flags on attachment: 50112 Committed r55622: <http://trac.webkit.org/changeset/55622> 196901 4 commit-queue 2010-03-06 06:23:20 -0800 All reviewed patches have been landed. Closing bug. 50112 2010-03-05 13:19:12 -0800 2010-03-06 06:23:16 -0800 patch v1 bug-35803-20100305221910.patch text/plain 1246 a.renevier ZGlmZiAtLWdpdCBhL1dlYktpdC9ndGsvQ2hhbmdlTG9nIGIvV2ViS2l0L2d0ay9DaGFuZ2VMb2cK aW5kZXggNDA4ODA5ZS4uOTdhYjlkMSAxMDA2NDQKLS0tIGEvV2ViS2l0L2d0ay9DaGFuZ2VMb2cK KysrIGIvV2ViS2l0L2d0ay9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAxMC0wMy0wNSAg QXJubyBSZW5ldmllciAgPGFybm9AcmVuZXZpZXIubmV0PgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtHdGtdIEdFT0xPQ0FUSU9OX1BPTElDWV9ERUNJ U0lPTl9DQU5DRUxMRUQgdW51c2VkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0zNTgwMworCisgICAgICAgICogd2Via2l0L3dlYmtpdHdlYnZpZXcuY3Bw OgorICAgICAgICAoRE5EQ29udGVudHNSZXF1ZXN0Ojp3ZWJraXRfd2ViX3ZpZXdfY2xhc3NfaW5p dCk6CisKIDIwMTAtMDMtMDMgIEZyaWRyaWNoIFN0cmJhICA8ZnJpZHJpY2guc3RyYmFAYmx1ZXdp bi5jaD4KIAogICAgICAgICBSZXZpZXdlZCBieSBYYW4gTG9wZXouCmRpZmYgLS1naXQgYS9XZWJL aXQvZ3RrL3dlYmtpdC93ZWJraXR3ZWJ2aWV3LmNwcCBiL1dlYktpdC9ndGsvd2Via2l0L3dlYmtp dHdlYnZpZXcuY3BwCmluZGV4IGM2Zjk3OGEuLjhiNDMxZDggMTAwNjQ0Ci0tLSBhL1dlYktpdC9n dGsvd2Via2l0L3dlYmtpdHdlYnZpZXcuY3BwCisrKyBiL1dlYktpdC9ndGsvd2Via2l0L3dlYmtp dHdlYnZpZXcuY3BwCkBAIC0yMjQ5LDcgKzIyNDksNyBAQCBzdGF0aWMgdm9pZCB3ZWJraXRfd2Vi X3ZpZXdfY2xhc3NfaW5pdChXZWJLaXRXZWJWaWV3Q2xhc3MqIHdlYlZpZXdDbGFzcykKICAgICAg KgogICAgICAqIFNpbmNlOiAxLjEuMjMKICAgICAgKi8KLSAgICB3ZWJraXRfd2ViX3ZpZXdfc2ln bmFsc1tHRU9MT0NBVElPTl9QT0xJQ1lfREVDSVNJT05fUkVRVUVTVEVEXSA9IGdfc2lnbmFsX25l dygiZ2VvbG9jYXRpb24tcG9saWN5LWRlY2lzaW9uLWNhbmNlbGxlZCIsCisgICAgd2Via2l0X3dl Yl92aWV3X3NpZ25hbHNbR0VPTE9DQVRJT05fUE9MSUNZX0RFQ0lTSU9OX0NBTkNFTExFRF0gPSBn X3NpZ25hbF9uZXcoImdlb2xvY2F0aW9uLXBvbGljeS1kZWNpc2lvbi1jYW5jZWxsZWQiLAogICAg ICAgICAgICAgR19UWVBFX0ZST01fQ0xBU1Mod2ViVmlld0NsYXNzKSwKICAgICAgICAgICAgIChH U2lnbmFsRmxhZ3MpKEdfU0lHTkFMX1JVTl9MQVNUKSwKICAgICAgICAgICAgIDAsCg==