35800 2010-03-05 11:32:36 -0800 Notification object should expose absolute URL of icon 2010-03-15 23:42:40 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 johnnyg johnnyg commit-queue oldest_to_newest 196567 0 johnnyg 2010-03-05 11:32:36 -0800 Currently the Notification object only exposes the raw string that was supplied for the icon parameter in javascript, which prevents relative URLs from working. Furthermore the Chromium WebKit API exposes icon as a WebString, but it really should be a WebURL. 196571 1 50108 johnnyg 2010-03-05 11:58:52 -0800 Created attachment 50108 patch 196675 2 50108 fishd 2010-03-05 14:37:38 -0800 Comment on attachment 50108 patch Please preserve the old Chromium WebKit APIs temporarily to avoid requiring a 2-sided patch landing? Add a comment to the old method with the text "DEPRECATED", then after the Chromium side switches over to the new API, do another WebKit patch to remove the deprecated method. 197204 3 50230 johnnyg 2010-03-08 09:51:22 -0800 Created attachment 50230 new patch which leaves old interface temporarily new patch which leaves old interface temporarily 200030 4 50230 commit-queue 2010-03-15 23:42:36 -0700 Comment on attachment 50230 new patch which leaves old interface temporarily Clearing flags on attachment: 50230 Committed r56043: <http://trac.webkit.org/changeset/56043> 200031 5 commit-queue 2010-03-15 23:42:40 -0700 All reviewed patches have been landed. Closing bug. 50108 2010-03-05 11:58:52 -0800 2010-03-08 09:51:22 -0800 patch bug35800.patch text/plain 3763 johnnyg SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1NTU5MSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTcgQEAKKzIwMTAtMDMtMDUgIEpvaG4gR3JlZ2cgIDxqb2hubnlnQGdvb2dsZS5j b20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTm90 aWZpY2F0aW9uIG9iamVjdCBzaG91bGQgZXhwb3NlIGFic29sdXRlIFVSTCBvZiBpY29uCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zNTgwMAorCisgICAg ICAgIENvdmVyZWQgYnkgZXhpc3RpbmcgdGVzdHMuCisKKyAgICAgICAgKiBub3RpZmljYXRpb25z L05vdGlmaWNhdGlvbi5jcHA6CisgICAgICAgIChXZWJDb3JlOjpOb3RpZmljYXRpb246Ok5vdGlm aWNhdGlvbik6CisgICAgICAgICogbm90aWZpY2F0aW9ucy9Ob3RpZmljYXRpb24uaDoKKyAgICAg ICAgKFdlYkNvcmU6Ok5vdGlmaWNhdGlvbjo6aWNvblVSTCk6CisKIDIwMTAtMDMtMDUgIERpbWl0 cmkgR2xhemtvdiAgPGRnbGF6a292QGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBi eSBEYXZpZCBMZXZpbi4KSW5kZXg6IFdlYkNvcmUvbm90aWZpY2F0aW9ucy9Ob3RpZmljYXRpb24u Y3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvbm90aWZpY2F0aW9ucy9Ob3RpZmljYXRpb24uY3Bw CShyZXZpc2lvbiA1NTU5MSkKKysrIFdlYkNvcmUvbm90aWZpY2F0aW9ucy9Ob3RpZmljYXRpb24u Y3BwCSh3b3JraW5nIGNvcHkpCkBAIC03NSw5ICs3NSw5IEBAIE5vdGlmaWNhdGlvbjo6Tm90aWZp Y2F0aW9uKGNvbnN0IE5vdGlmaWMKICAgICAgICAgZWMgPSBTRUNVUklUWV9FUlI7CiAgICAgICAg IHJldHVybjsKICAgICB9Ci0gICAgCi0gICAgS1VSTCBpY29uID0gY29udGV4dC0+Y29tcGxldGVV UkwoY29udGVudHMuaWNvbigpKTsKLSAgICBpZiAoIWljb24uaXNFbXB0eSgpICYmICFpY29uLmlz VmFsaWQoKSkgeworCisgICAgbV9pY29uVVJMID0gY29udGV4dC0+Y29tcGxldGVVUkwoY29udGVu dHMuaWNvbigpKTsKKyAgICBpZiAoIW1faWNvblVSTC5pc0VtcHR5KCkgJiYgIW1faWNvblVSTC5p c1ZhbGlkKCkpIHsKICAgICAgICAgZWMgPSBTWU5UQVhfRVJSOwogICAgICAgICByZXR1cm47CiAg ICAgfQpJbmRleDogV2ViQ29yZS9ub3RpZmljYXRpb25zL05vdGlmaWNhdGlvbi5oCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIFdlYkNvcmUvbm90aWZpY2F0aW9ucy9Ob3RpZmljYXRpb24uaAkocmV2aXNpb24gNTU1 OTEpCisrKyBXZWJDb3JlL25vdGlmaWNhdGlvbnMvTm90aWZpY2F0aW9uLmgJKHdvcmtpbmcgY29w eSkKQEAgLTY1LDYgKzY1LDcgQEAgbmFtZXNwYWNlIFdlYkNvcmUgewogICAgIAogICAgICAgICBi b29sIGlzSFRNTCgpIHsgcmV0dXJuIG1faXNIVE1MOyB9CiAgICAgICAgIEtVUkwgdXJsKCkgeyBy ZXR1cm4gbV9ub3RpZmljYXRpb25VUkw7IH0KKyAgICAgICAgS1VSTCBpY29uVVJMKCkgeyByZXR1 cm4gbV9pY29uVVJMOyB9CiAgICAgICAgIE5vdGlmaWNhdGlvbkNvbnRlbnRzJiBjb250ZW50cygp IHsgcmV0dXJuIG1fY29udGVudHM7IH0KIAogICAgICAgICBERUZJTkVfQVRUUklCVVRFX0VWRU5U X0xJU1RFTkVSKGRpc3BsYXkpOwpAQCAtOTAsNiArOTEsNyBAQCBuYW1lc3BhY2UgV2ViQ29yZSB7 CiAKICAgICAgICAgYm9vbCBtX2lzSFRNTDsKICAgICAgICAgS1VSTCBtX25vdGlmaWNhdGlvblVS TDsKKyAgICAgICAgS1VSTCBtX2ljb25VUkw7CiAgICAgICAgIE5vdGlmaWNhdGlvbkNvbnRlbnRz IG1fY29udGVudHM7CiAKICAgICAgICAgYm9vbCBtX2lzU2hvd2luZzsKSW5kZXg6IFdlYktpdC9j aHJvbWl1bS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxv ZwkocmV2aXNpb24gNTU1OTEpCisrKyBXZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCSh3b3JraW5n IGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTAtMDMtMDUgIEpvaG4gR3JlZ2cgIDxqb2hubnln QGdvb2dsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgTm90aWZpY2F0aW9uIG9iamVjdCBzaG91bGQgZXhwb3NlIGFic29sdXRlIFVSTCBvZiBp Y29uCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zNTgw MAorCisgICAgICAgICogcHVibGljL1dlYk5vdGlmaWNhdGlvbi5oOgorICAgICAgICAqIHNyYy9X ZWJOb3RpZmljYXRpb24uY3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJOb3RpZmljYXRpb246Omlj b25VUkwpOgorCiAyMDEwLTAzLTA1ICBJbHlhIFRpa2hvbm92c2t5ICA8bG9pc2xvQGNocm9taXVt Lm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBQYXZlbCBGZWxkbWFuLgpJbmRleDogV2ViS2l0 L2Nocm9taXVtL3B1YmxpYy9XZWJOb3RpZmljYXRpb24uaAo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXQv Y2hyb21pdW0vcHVibGljL1dlYk5vdGlmaWNhdGlvbi5oCShyZXZpc2lvbiA1NTU5MSkKKysrIFdl YktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViTm90aWZpY2F0aW9uLmgJKHdvcmtpbmcgY29weSkKQEAg LTcyLDcgKzcyLDcgQEAgcHVibGljOgogICAgIFdFQktJVF9BUEkgV2ViVVJMIHVybCgpIGNvbnN0 OwogCiAgICAgLy8gSWYgbm90IEhUTUwsIHRoZSBwYXJhbWV0ZXJzIGZvciB0aGUgaWNvbi10aXRs ZS10ZXh0IG5vdGlmaWNhdGlvbi4KLSAgICBXRUJLSVRfQVBJIFdlYlN0cmluZyBpY29uKCkgY29u c3Q7CisgICAgV0VCS0lUX0FQSSBXZWJVUkwgaWNvblVSTCgpIGNvbnN0OwogICAgIFdFQktJVF9B UEkgV2ViU3RyaW5nIHRpdGxlKCkgY29uc3Q7CiAgICAgV0VCS0lUX0FQSSBXZWJTdHJpbmcgYm9k eSgpIGNvbnN0OwogCkluZGV4OiBXZWJLaXQvY2hyb21pdW0vc3JjL1dlYk5vdGlmaWNhdGlvbi5j cHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJOb3RpZmljYXRpb24uY3Bw CShyZXZpc2lvbiA1NTU5MSkKKysrIFdlYktpdC9jaHJvbWl1bS9zcmMvV2ViTm90aWZpY2F0aW9u LmNwcAkod29ya2luZyBjb3B5KQpAQCAtNzYsMTAgKzc2LDEwIEBAIFdlYlVSTCBXZWJOb3RpZmlj YXRpb246OnVybCgpIGNvbnN0CiAgICAgcmV0dXJuIG1fcHJpdmF0ZS0+dXJsKCk7CiB9CiAKLVdl YlN0cmluZyBXZWJOb3RpZmljYXRpb246Omljb24oKSBjb25zdAorV2ViVVJMIFdlYk5vdGlmaWNh dGlvbjo6aWNvblVSTCgpIGNvbnN0CiB7CiAgICAgQVNTRVJUKCFpc0hUTUwoKSk7Ci0gICAgcmV0 dXJuIG1fcHJpdmF0ZS0+Y29udGVudHMoKS5pY29uKCk7CisgICAgcmV0dXJuIG1fcHJpdmF0ZS0+ aWNvblVSTCgpOwogfQogCiBXZWJTdHJpbmcgV2ViTm90aWZpY2F0aW9uOjp0aXRsZSgpIGNvbnN0 Cg== 50230 2010-03-08 09:51:22 -0800 2010-03-15 23:42:36 -0700 new patch which leaves old interface temporarily bug35800b.patch text/plain 3946 johnnyg SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1NTU5MSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTcgQEAKKzIwMTAtMDMtMDUgIEpvaG4gR3JlZ2cgIDxqb2hubnlnQGdvb2dsZS5j b20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTm90 aWZpY2F0aW9uIG9iamVjdCBzaG91bGQgZXhwb3NlIGFic29sdXRlIFVSTCBvZiBpY29uCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zNTgwMAorCisgICAg ICAgIENvdmVyZWQgYnkgZXhpc3RpbmcgdGVzdHMuCisKKyAgICAgICAgKiBub3RpZmljYXRpb25z L05vdGlmaWNhdGlvbi5jcHA6CisgICAgICAgIChXZWJDb3JlOjpOb3RpZmljYXRpb246Ok5vdGlm aWNhdGlvbik6CisgICAgICAgICogbm90aWZpY2F0aW9ucy9Ob3RpZmljYXRpb24uaDoKKyAgICAg ICAgKFdlYkNvcmU6Ok5vdGlmaWNhdGlvbjo6aWNvblVSTCk6CisKIDIwMTAtMDMtMDUgIERpbWl0 cmkgR2xhemtvdiAgPGRnbGF6a292QGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBi eSBEYXZpZCBMZXZpbi4KSW5kZXg6IFdlYkNvcmUvbm90aWZpY2F0aW9ucy9Ob3RpZmljYXRpb24u Y3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvbm90aWZpY2F0aW9ucy9Ob3RpZmljYXRpb24uY3Bw CShyZXZpc2lvbiA1NTU5MSkKKysrIFdlYkNvcmUvbm90aWZpY2F0aW9ucy9Ob3RpZmljYXRpb24u Y3BwCSh3b3JraW5nIGNvcHkpCkBAIC03NSw5ICs3NSw5IEBAIE5vdGlmaWNhdGlvbjo6Tm90aWZp Y2F0aW9uKGNvbnN0IE5vdGlmaWMKICAgICAgICAgZWMgPSBTRUNVUklUWV9FUlI7CiAgICAgICAg IHJldHVybjsKICAgICB9Ci0gICAgCi0gICAgS1VSTCBpY29uID0gY29udGV4dC0+Y29tcGxldGVV UkwoY29udGVudHMuaWNvbigpKTsKLSAgICBpZiAoIWljb24uaXNFbXB0eSgpICYmICFpY29uLmlz VmFsaWQoKSkgeworCisgICAgbV9pY29uVVJMID0gY29udGV4dC0+Y29tcGxldGVVUkwoY29udGVu dHMuaWNvbigpKTsKKyAgICBpZiAoIW1faWNvblVSTC5pc0VtcHR5KCkgJiYgIW1faWNvblVSTC5p c1ZhbGlkKCkpIHsKICAgICAgICAgZWMgPSBTWU5UQVhfRVJSOwogICAgICAgICByZXR1cm47CiAg ICAgfQpJbmRleDogV2ViQ29yZS9ub3RpZmljYXRpb25zL05vdGlmaWNhdGlvbi5oCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIFdlYkNvcmUvbm90aWZpY2F0aW9ucy9Ob3RpZmljYXRpb24uaAkocmV2aXNpb24gNTU1 OTEpCisrKyBXZWJDb3JlL25vdGlmaWNhdGlvbnMvTm90aWZpY2F0aW9uLmgJKHdvcmtpbmcgY29w eSkKQEAgLTY1LDYgKzY1LDcgQEAgbmFtZXNwYWNlIFdlYkNvcmUgewogICAgIAogICAgICAgICBi b29sIGlzSFRNTCgpIHsgcmV0dXJuIG1faXNIVE1MOyB9CiAgICAgICAgIEtVUkwgdXJsKCkgeyBy ZXR1cm4gbV9ub3RpZmljYXRpb25VUkw7IH0KKyAgICAgICAgS1VSTCBpY29uVVJMKCkgeyByZXR1 cm4gbV9pY29uVVJMOyB9CiAgICAgICAgIE5vdGlmaWNhdGlvbkNvbnRlbnRzJiBjb250ZW50cygp IHsgcmV0dXJuIG1fY29udGVudHM7IH0KIAogICAgICAgICBERUZJTkVfQVRUUklCVVRFX0VWRU5U X0xJU1RFTkVSKGRpc3BsYXkpOwpAQCAtOTAsNiArOTEsNyBAQCBuYW1lc3BhY2UgV2ViQ29yZSB7 CiAKICAgICAgICAgYm9vbCBtX2lzSFRNTDsKICAgICAgICAgS1VSTCBtX25vdGlmaWNhdGlvblVS TDsKKyAgICAgICAgS1VSTCBtX2ljb25VUkw7CiAgICAgICAgIE5vdGlmaWNhdGlvbkNvbnRlbnRz IG1fY29udGVudHM7CiAKICAgICAgICAgYm9vbCBtX2lzU2hvd2luZzsKSW5kZXg6IFdlYktpdC9j aHJvbWl1bS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxv ZwkocmV2aXNpb24gNTU1OTEpCisrKyBXZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCSh3b3JraW5n IGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTAtMDMtMDUgIEpvaG4gR3JlZ2cgIDxqb2hubnln QGdvb2dsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgTm90aWZpY2F0aW9uIG9iamVjdCBzaG91bGQgZXhwb3NlIGFic29sdXRlIFVSTCBvZiBp Y29uCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zNTgw MAorCisgICAgICAgICogcHVibGljL1dlYk5vdGlmaWNhdGlvbi5oOgorICAgICAgICAqIHNyYy9X ZWJOb3RpZmljYXRpb24uY3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJOb3RpZmljYXRpb246Omlj b25VUkwpOgorCiAyMDEwLTAzLTA1ICBJbHlhIFRpa2hvbm92c2t5ICA8bG9pc2xvQGNocm9taXVt Lm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBQYXZlbCBGZWxkbWFuLgpJbmRleDogV2ViS2l0 L2Nocm9taXVtL3B1YmxpYy9XZWJOb3RpZmljYXRpb24uaAo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXQv Y2hyb21pdW0vcHVibGljL1dlYk5vdGlmaWNhdGlvbi5oCShyZXZpc2lvbiA1NTU5MSkKKysrIFdl YktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViTm90aWZpY2F0aW9uLmgJKHdvcmtpbmcgY29weSkKQEAg LTcyLDcgKzcyLDkgQEAgcHVibGljOgogICAgIFdFQktJVF9BUEkgV2ViVVJMIHVybCgpIGNvbnN0 OwogCiAgICAgLy8gSWYgbm90IEhUTUwsIHRoZSBwYXJhbWV0ZXJzIGZvciB0aGUgaWNvbi10aXRs ZS10ZXh0IG5vdGlmaWNhdGlvbi4KKyAgICAvLyBGSVhNRTogRGVwcmVjYXRlZDsgdXNlIGljb25V UkwoKSBpbnN0ZWFkLgogICAgIFdFQktJVF9BUEkgV2ViU3RyaW5nIGljb24oKSBjb25zdDsKKyAg ICBXRUJLSVRfQVBJIFdlYlVSTCBpY29uVVJMKCkgY29uc3Q7CiAgICAgV0VCS0lUX0FQSSBXZWJT dHJpbmcgdGl0bGUoKSBjb25zdDsKICAgICBXRUJLSVRfQVBJIFdlYlN0cmluZyBib2R5KCkgY29u c3Q7CiAKSW5kZXg6IFdlYktpdC9jaHJvbWl1bS9zcmMvV2ViTm90aWZpY2F0aW9uLmNwcAo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBXZWJLaXQvY2hyb21pdW0vc3JjL1dlYk5vdGlmaWNhdGlvbi5jcHAJKHJldmlz aW9uIDU1NTkxKQorKysgV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJOb3RpZmljYXRpb24uY3BwCSh3 b3JraW5nIGNvcHkpCkBAIC03NiwxMiArNzYsMTkgQEAgV2ViVVJMIFdlYk5vdGlmaWNhdGlvbjo6 dXJsKCkgY29uc3QKICAgICByZXR1cm4gbV9wcml2YXRlLT51cmwoKTsKIH0KIAorLy8gRklYTUU6 IHJlbW92ZSB0aGlzIGRlcHJlY2F0ZWQgZnVuY3Rpb24gb25jZSBhbGwgY2FsbGVycyB1c2UgaWNv blVSTCgpCiBXZWJTdHJpbmcgV2ViTm90aWZpY2F0aW9uOjppY29uKCkgY29uc3QKIHsKICAgICBB U1NFUlQoIWlzSFRNTCgpKTsKICAgICByZXR1cm4gbV9wcml2YXRlLT5jb250ZW50cygpLmljb24o KTsKIH0KIAorV2ViVVJMIFdlYk5vdGlmaWNhdGlvbjo6aWNvblVSTCgpIGNvbnN0Cit7CisgICAg QVNTRVJUKCFpc0hUTUwoKSk7CisgICAgcmV0dXJuIG1fcHJpdmF0ZS0+aWNvblVSTCgpOworfQor CiBXZWJTdHJpbmcgV2ViTm90aWZpY2F0aW9uOjp0aXRsZSgpIGNvbnN0CiB7CiAgICAgQVNTRVJU KCFpc0hUTUwoKSk7Cg==