35794 2010-03-05 09:56:28 -0800 [Qt] QtLauncher need a menu option to show/hide FPS 2010-03-13 01:38:15 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED Qt P2 Enhancement --- 1 jesus webkit-qt-unassigned commit-queue jturcotte oldest_to_newest 196523 0 jesus 2010-03-05 09:56:28 -0800 [Qt] QtLauncher need a menu option to show/hide FPS 196526 1 50101 jesus 2010-03-05 09:58:10 -0800 Created attachment 50101 Patch 196581 2 50101 eric 2010-03-05 12:28:54 -0800 Comment on attachment 50101 Patch This patch does not apply, thus it can't be commit-queue'd. Since when do browsers have an fps? :) 196982 3 50101 hausmann 2010-03-06 23:34:02 -0800 Comment on attachment 50101 Patch Apart from the commit queue problem the patch looks good to me (I've been looking for this option, too :) I think in general it would be good to replace all the commandline options of QtLauncher with menus actions. 197210 4 jesus 2010-03-08 09:56:23 -0800 (In reply to comment #3) There was a problem with the patches order, I guess. I'll fix this as soon as I'm back from Bossa conference (in 4 days). thanks for the review! 198109 5 vestbo 2010-03-10 06:43:50 -0800 Please follow the QtWebKit bug reporting guidelines when reporting bugs. See http://trac.webkit.org/wiki/QtWebKitBugs Specifically: - The 'QtWebKit' component should only be used for bugs/features in the public QtWebKit API layer, not to signify that the bug is specific to the Qt port of WebKit http://trac.webkit.org/wiki/QtWebKitBugs#Component - Add the keyword 'Qt' to signal that it's a Qt-related bug http://trac.webkit.org/wiki/QtWebKitBugs#Keywords 199169 6 50622 jesus 2010-03-12 12:28:22 -0800 Created attachment 50622 Add Show FPS option to QtLauncher Fixed. 199331 7 50622 commit-queue 2010-03-13 01:38:10 -0800 Comment on attachment 50622 Add Show FPS option to QtLauncher Clearing flags on attachment: 50622 Committed r55956: <http://trac.webkit.org/changeset/55956> 199332 8 commit-queue 2010-03-13 01:38:15 -0800 All reviewed patches have been landed. Closing bug. 50101 2010-03-05 09:58:10 -0800 2010-03-12 12:28:22 -0800 Patch bug-35794-20100305145934.patch text/plain 2206 jesus ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCBjOTM4YTYwLi45ODRlZDBkIDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VM b2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTAtMDMt MDUgIEplc3VzIFNhbmNoZXotUGFsZW5jaWEgIDxqZXN1cy5wYWxlbmNpYUBvcGVuYm9zc2Eub3Jn PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFkZCAi U2hvdyBGUFMiIG1lbnUgb3B0aW9uIHRvIFF0TGF1bmNoZXIuCisKKyAgICAgICAgW1F0XSBRdExh dW5jaGVyIG5lZWQgYSBtZW51IG9wdGlvbiB0byBzaG93L2hpZGUgRlBTCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zNTc5NAorCisgICAgICAgICogUXRM YXVuY2hlci9tYWluLmNwcDoKKyAgICAgICAgKExhdW5jaGVyV2luZG93OjpzaG93RlBTKToKKyAg ICAgICAgKExhdW5jaGVyV2luZG93OjpjcmVhdGVDaHJvbWUpOgorCiAyMDEwLTAzLTA0ICBKZXN1 cyBTYW5jaGV6LVBhbGVuY2lhICA8amVzdXMucGFsZW5jaWFAb3BlbmJvc3NhLm9yZz4KIAogICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xz L1F0TGF1bmNoZXIvbWFpbi5jcHAgYi9XZWJLaXRUb29scy9RdExhdW5jaGVyL21haW4uY3BwCmlu ZGV4IDMyYTZjNDMuLjliODY0NDYgMTAwNjQ0Ci0tLSBhL1dlYktpdFRvb2xzL1F0TGF1bmNoZXIv bWFpbi5jcHAKKysrIGIvV2ViS2l0VG9vbHMvUXRMYXVuY2hlci9tYWluLmNwcApAQCAtMTIwLDYg KzEyMCw3IEBAIHByb3RlY3RlZCBzbG90czoKICAgICB2b2lkIHRvZ2dsZVdlYkdMKGJvb2wgdG9n Z2xlKTsKICAgICB2b2lkIGluaXRpYWxpemVWaWV3KGJvb2wgdXNlR3JhcGhpY3NWaWV3ID0gZmFs c2UpOwogICAgIHZvaWQgdG9nZ2xlRnVsbFNjcmVlbk1vZGUoYm9vbCBlbmFibGUpOworICAgIHZv aWQgc2hvd0ZQUyhib29sIGVuYWJsZSk7CiAKIHB1YmxpYyBzbG90czoKICAgICB2b2lkIG5ld1dp bmRvdygpOwpAQCAtNTc3LDYgKzU3OCwxNiBAQCB2b2lkIExhdW5jaGVyV2luZG93Ojp0b2dnbGVG dWxsU2NyZWVuTW9kZShib29sIGVuYWJsZSkKICAgICB9CiB9CiAKK3ZvaWQgTGF1bmNoZXJXaW5k b3c6OnNob3dGUFMoYm9vbCBlbmFibGUpCit7CisgICAgaWYgKCFpc0dyYXBoaWNzQmFzZWQoKSkK KyAgICAgICAgcmV0dXJuOworCisgICAgZ1Nob3dGcmFtZVJhdGUgPSBlbmFibGU7CisgICAgV2Vi Vmlld0dyYXBoaWNzQmFzZWQqIHZpZXcgPSBzdGF0aWNfY2FzdDxXZWJWaWV3R3JhcGhpY3NCYXNl ZCo+KG1fdmlldyk7CisgICAgdmlldy0+c2V0RnJhbWVSYXRlTWVhc3VyZW1lbnRFbmFibGVkKGVu YWJsZSk7Cit9CisKIHZvaWQgTGF1bmNoZXJXaW5kb3c6Om5ld1dpbmRvdygpCiB7CiAgICAgTGF1 bmNoZXJXaW5kb3cqIG13ID0gbmV3IExhdW5jaGVyV2luZG93KHRoaXMsIGZhbHNlKTsKQEAgLTcw MCw2ICs3MTEsMTIgQEAgdm9pZCBMYXVuY2hlcldpbmRvdzo6Y3JlYXRlQ2hyb21lKCkKICAgICBR QWN0aW9uKiBjbG9uZVdpbmRvdyA9IGdyYXBoaWNzVmlld01lbnUtPmFkZEFjdGlvbigiQ2xvbmUg V2luZG93IiwgdGhpcywgU0xPVChjbG9uZVdpbmRvdygpKSk7CiAgICAgY2xvbmVXaW5kb3ctPmNv bm5lY3QodG9nZ2xlR3JhcGhpY3NWaWV3LCBTSUdOQUwodG9nZ2xlZChib29sKSksIFNMT1Qoc2V0 RW5hYmxlZChib29sKSkpOwogICAgIGNsb25lV2luZG93LT5zZXRFbmFibGVkKGlzR3JhcGhpY3NC YXNlZCgpKTsKKworICAgIFFBY3Rpb24qIHNob3dGUFMgPSBncmFwaGljc1ZpZXdNZW51LT5hZGRB Y3Rpb24oIlNob3cgRlBTIiwgdGhpcywgU0xPVChzaG93RlBTKGJvb2wpKSk7CisgICAgc2hvd0ZQ Uy0+c2V0Q2hlY2thYmxlKHRydWUpOworICAgIHNob3dGUFMtPnNldEVuYWJsZWQoaXNHcmFwaGlj c0Jhc2VkKCkpOworICAgIHNob3dGUFMtPmNvbm5lY3QodG9nZ2xlR3JhcGhpY3NWaWV3LCBTSUdO QUwodG9nZ2xlZChib29sKSksIFNMT1Qoc2V0RW5hYmxlZChib29sKSkpOworICAgIHNob3dGUFMt PnNldENoZWNrZWQoZ1Nob3dGcmFtZVJhdGUpOwogfQogCiBRV2ViUGFnZSogV2ViUGFnZTo6Y3Jl YXRlV2luZG93KFFXZWJQYWdlOjpXZWJXaW5kb3dUeXBlIHR5cGUpCg== 50622 2010-03-12 12:28:22 -0800 2010-03-13 01:38:10 -0800 Add Show FPS option to QtLauncher 0001-Add-Show-FPS-menu-option-to-QtLauncher.patch text/plain 2830 jesus RnJvbSBlM2MyZTg3MDZhNTZjZGRjZDU2ZGNmYWRmNDc3MGZjZjMzZmM3ODgxIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBKZXN1cyBTYW5jaGV6LVBhbGVuY2lhIDxqZXN1cy5wYWxlbmNp YUBvcGVuYm9zc2Eub3JnPgpEYXRlOiBGcmksIDUgTWFyIDIwMTAgMTU6MDE6MjggLTAzMDAKU3Vi amVjdDogW1BBVENIXSBBZGQgIlNob3cgRlBTIiBtZW51IG9wdGlvbiB0byBRdExhdW5jaGVyLgoK UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCgpbUXRdIFF0TGF1bmNoZXIgbmVlZCBhIG1lbnUg b3B0aW9uIHRvIHNob3cvaGlkZSBGUFMKaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTM1Nzk0CgoqIFF0TGF1bmNoZXIvbWFpbi5jcHA6CihMYXVuY2hlcldpbmRvdzo6c2hv d0ZQUyk6CihMYXVuY2hlcldpbmRvdzo6Y3JlYXRlQ2hyb21lKToKLS0tCiBXZWJLaXRUb29scy9D aGFuZ2VMb2cgICAgICAgICAgIHwgICAxMyArKysrKysrKysrKysrCiBXZWJLaXRUb29scy9RdExh dW5jaGVyL21haW4uY3BwIHwgICAxNyArKysrKysrKysrKysrKysrKwogMiBmaWxlcyBjaGFuZ2Vk LCAzMCBpbnNlcnRpb25zKCspLCAwIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL1dlYktpdFRv b2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxvZwppbmRleCA5OGJkYTEwLi4yN2My NDIzIDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0VG9vbHMv Q2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTAtMDMtMDUgIEplc3VzIFNhbmNoZXotUGFs ZW5jaWEgIDxqZXN1cy5wYWxlbmNpYUBvcGVuYm9zc2Eub3JnPgorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFkZCAiU2hvdyBGUFMiIG1lbnUgb3B0aW9u IHRvIFF0TGF1bmNoZXIuCisKKyAgICAgICAgW1F0XSBRdExhdW5jaGVyIG5lZWQgYSBtZW51IG9w dGlvbiB0byBzaG93L2hpZGUgRlBTCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0zNTc5NAorCisgICAgICAgICogUXRMYXVuY2hlci9tYWluLmNwcDoKKyAg ICAgICAgKExhdW5jaGVyV2luZG93OjpzaG93RlBTKToKKyAgICAgICAgKExhdW5jaGVyV2luZG93 OjpjcmVhdGVDaHJvbWUpOgorCiAyMDEwLTAzLTA0ICBKZXN1cyBTYW5jaGV6LVBhbGVuY2lhICA8 amVzdXMucGFsZW5jaWFAb3BlbmJvc3NhLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL1F0TGF1bmNoZXIvbWFpbi5jcHAg Yi9XZWJLaXRUb29scy9RdExhdW5jaGVyL21haW4uY3BwCmluZGV4IDc3ZGJjNmUuLjY3ODVlYzgg MTAwNjQ0Ci0tLSBhL1dlYktpdFRvb2xzL1F0TGF1bmNoZXIvbWFpbi5jcHAKKysrIGIvV2ViS2l0 VG9vbHMvUXRMYXVuY2hlci9tYWluLmNwcApAQCAtMTIxLDYgKzEyMSw3IEBAIHByb3RlY3RlZCBz bG90czoKICAgICB2b2lkIGluaXRpYWxpemVWaWV3KGJvb2wgdXNlR3JhcGhpY3NWaWV3ID0gZmFs c2UpOwogICAgIHZvaWQgdG9nZ2xlU3BhdGlhbE5hdmlnYXRpb24oYm9vbCBiKTsKICAgICB2b2lk IHRvZ2dsZUZ1bGxTY3JlZW5Nb2RlKGJvb2wgZW5hYmxlKTsKKyAgICB2b2lkIHNob3dGUFMoYm9v bCBlbmFibGUpOwogCiBwdWJsaWMgc2xvdHM6CiAgICAgdm9pZCBuZXdXaW5kb3coKTsKQEAgLTU4 Myw2ICs1ODQsMTYgQEAgdm9pZCBMYXVuY2hlcldpbmRvdzo6dG9nZ2xlRnVsbFNjcmVlbk1vZGUo Ym9vbCBlbmFibGUpCiAgICAgfQogfQogCit2b2lkIExhdW5jaGVyV2luZG93OjpzaG93RlBTKGJv b2wgZW5hYmxlKQoreworICAgIGlmICghaXNHcmFwaGljc0Jhc2VkKCkpCisgICAgICAgIHJldHVy bjsKKworICAgIGdTaG93RnJhbWVSYXRlID0gZW5hYmxlOworICAgIFdlYlZpZXdHcmFwaGljc0Jh c2VkKiB2aWV3ID0gc3RhdGljX2Nhc3Q8V2ViVmlld0dyYXBoaWNzQmFzZWQqPihtX3ZpZXcpOwor ICAgIHZpZXctPnNldEZyYW1lUmF0ZU1lYXN1cmVtZW50RW5hYmxlZChlbmFibGUpOworfQorCiB2 b2lkIExhdW5jaGVyV2luZG93OjpuZXdXaW5kb3coKQogewogICAgIExhdW5jaGVyV2luZG93KiBt dyA9IG5ldyBMYXVuY2hlcldpbmRvdyh0aGlzLCBmYWxzZSk7CkBAIC03MTAsNiArNzIxLDEyIEBA IHZvaWQgTGF1bmNoZXJXaW5kb3c6OmNyZWF0ZUNocm9tZSgpCiAgICAgUUFjdGlvbiogY2xvbmVX aW5kb3cgPSBncmFwaGljc1ZpZXdNZW51LT5hZGRBY3Rpb24oIkNsb25lIFdpbmRvdyIsIHRoaXMs IFNMT1QoY2xvbmVXaW5kb3coKSkpOwogICAgIGNsb25lV2luZG93LT5jb25uZWN0KHRvZ2dsZUdy YXBoaWNzVmlldywgU0lHTkFMKHRvZ2dsZWQoYm9vbCkpLCBTTE9UKHNldEVuYWJsZWQoYm9vbCkp KTsKICAgICBjbG9uZVdpbmRvdy0+c2V0RW5hYmxlZChpc0dyYXBoaWNzQmFzZWQoKSk7CisKKyAg ICBRQWN0aW9uKiBzaG93RlBTID0gZ3JhcGhpY3NWaWV3TWVudS0+YWRkQWN0aW9uKCJTaG93IEZQ UyIsIHRoaXMsIFNMT1Qoc2hvd0ZQUyhib29sKSkpOworICAgIHNob3dGUFMtPnNldENoZWNrYWJs ZSh0cnVlKTsKKyAgICBzaG93RlBTLT5zZXRFbmFibGVkKGlzR3JhcGhpY3NCYXNlZCgpKTsKKyAg ICBzaG93RlBTLT5jb25uZWN0KHRvZ2dsZUdyYXBoaWNzVmlldywgU0lHTkFMKHRvZ2dsZWQoYm9v bCkpLCBTTE9UKHNldEVuYWJsZWQoYm9vbCkpKTsKKyAgICBzaG93RlBTLT5zZXRDaGVja2VkKGdT aG93RnJhbWVSYXRlKTsKIH0KIAogUVdlYlBhZ2UqIFdlYlBhZ2U6OmNyZWF0ZVdpbmRvdyhRV2Vi UGFnZTo6V2ViV2luZG93VHlwZSB0eXBlKQotLSAKMS42LjYKCg==