35779 2010-03-04 20:03:53 -0800 Fix event handling in WebPluginContainer 2010-03-05 18:34:58 -0800 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 jam jam commit-queue fishd oldest_to_newest 196322 0 jam 2010-03-04 20:03:53 -0800 We have the code that does "handled != handled" in WebPluginContainerImpl.cpp. We need to move this logic to webplugin_delegate_impl_win.cc and webplugin_delegate_impl_gtk.cc since we don't want this for Pepper plugins. This code is needed because Flash/Silverlight (only two I could test in windowless) return false even when they use the event. On Windows, Flash is sending the event to its windowed wndproc, which returns 0 when an event is handled per Windows convention. Not sure what's happening on Linux, but I verified that it's also needed. 196327 1 50084 jam 2010-03-04 20:23:32 -0800 Created attachment 50084 Proposed patch 196839 2 50084 commit-queue 2010-03-05 18:34:53 -0800 Comment on attachment 50084 Proposed patch Clearing flags on attachment: 50084 Committed r55606: <http://trac.webkit.org/changeset/55606> 196840 3 commit-queue 2010-03-05 18:34:58 -0800 All reviewed patches have been landed. Closing bug. 50084 2010-03-04 20:23:32 -0800 2010-03-05 18:34:53 -0800 Proposed patch handleevent.txt text/plain 2868 jam SW5kZXg6IFdlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZwkocmV2aXNpb24gNTU1NjUpCisrKyBXZWJLaXQvY2hyb21pdW0vQ2hh bmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTAtMDMtMDQgIEpvaG4g QWJkLUVsLU1hbGVrICA8amFtQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUYWtlIG91dCBjb2RlIGhhY2sgdGhhdCBmbGlwcyB0 aGUgcmVzdWx0IG9mIE5QUF9IYW5kbGVFdmVudC4gIFRoaXMgbmVlZHMgdG8gbW92ZSB0bworICAg ICAgICB0aGUgTlBBUEkgY29kZSBzbyB0aGF0IFBlcHBlciBwbHVnaW5zIGRvbid0IGhpdCBpdC4K KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM1Nzc5CisK KyAgICAgICAgKiBwdWJsaWMvV2ViUGx1Z2luQ29udGFpbmVyLmg6CisgICAgICAgICogc3JjL1dl YlBsdWdpbkNvbnRhaW5lckltcGwuY3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJQbHVnaW5Db250 YWluZXJJbXBsOjpoYW5kbGVNb3VzZUV2ZW50KToKKyAgICAgICAgKFdlYktpdDo6V2ViUGx1Z2lu Q29udGFpbmVySW1wbDo6aGFuZGxlS2V5Ym9hcmRFdmVudCk6CisKIDIwMTAtMDMtMDQgIERhcmlu IEZpc2hlciAgPGRhcmluQGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBEbWl0 cnkgVGl0b3YuCkluZGV4OiBXZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYlBsdWdpbkNvbnRhaW5l ci5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIFdlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViUGx1Z2luQ29udGFp bmVyLmgJKHJldmlzaW9uIDU1NTY1KQorKysgV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJQbHVn aW5Db250YWluZXIuaAkod29ya2luZyBjb3B5KQpAQCAtMzMsNiArMzMsOSBAQAogCiBzdHJ1Y3Qg TlBPYmplY3Q7CiAKKy8vIFRlbXBvcmFyeSBpZmRlZiBzaW5jZSB0aGlzIGlzIHR3by1zaWRlZC4K KyNkZWZpbmUgV0VCUExVR0lOQ09OVEFJTkVSX0RPRVNOVF9NT0RJRllfSEFORExFRCAxCisKIG5h bWVzcGFjZSBXZWJLaXQgewogCiBjbGFzcyBXZWJTdHJpbmc7CkluZGV4OiBXZWJLaXQvY2hyb21p dW0vc3JjL1dlYlBsdWdpbkNvbnRhaW5lckltcGwuY3BwCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdC9j aHJvbWl1bS9zcmMvV2ViUGx1Z2luQ29udGFpbmVySW1wbC5jcHAJKHJldmlzaW9uIDU1NTY1KQor KysgV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJQbHVnaW5Db250YWluZXJJbXBsLmNwcAkod29ya2lu ZyBjb3B5KQpAQCAtMzYwLDIwICszNjAsNiBAQCB2b2lkIFdlYlBsdWdpbkNvbnRhaW5lckltcGw6 OmhhbmRsZU1vdXNlCiAKICAgICBXZWJDdXJzb3JJbmZvIGN1cnNvckluZm87CiAgICAgYm9vbCBo YW5kbGVkID0gbV93ZWJQbHVnaW4tPmhhbmRsZUlucHV0RXZlbnQod2ViRXZlbnQsIGN1cnNvcklu Zm8pOwotI2lmICFPUyhEQVJXSU4pCi0gICAgLy8gVE9ETyhwa2FzdGluZyk6IGh0dHA6Ly9iLzEx MTk2OTEgVGhpcyBjb25kaXRpb25hbCBzZWVtcyBleGFjdGx5Ci0gICAgLy8gYmFja3dhcmRzLCBi dXQgaWYgSSByZXZlcnNlIGl0LCBnaXZpbmcgZm9jdXMgdG8gYSB0cmFuc3BhcmVudAotICAgIC8v ICh3aW5kb3dsZXNzKSBwbHVnaW4gZmFpbHMuCi0gICAgaGFuZGxlZCA9ICFoYW5kbGVkOwotICAg IC8vIFRPRE8oYXdhbGtlcik6IG9kZGx5LCB0aGUgYWJvdmUgaXMgbm90IHRydWUgaW4gTWFjIGJ1 aWxkcy4gIExvb2tpbmcKLSAgICAvLyBhdCBBcHBsZSdzIGNvcnJlc3BvbmRpbmcgY29kZSBmb3Ig TWFjIGFuZCBXaW5kb3dzIChQbHVnaW5WaWV3TWFjIGFuZAotICAgIC8vIFBsdWdpblZpZXdXaW4p LCBzZXREZWZhdWx0SGFuZGxlZCgpIGdldHMgY2FsbGVkIHdoZW4gaGFuZGxlSW5wdXRFdmVudCgp Ci0gICAgLy8gcmV0dXJucyB0cnVlLCB3aGljaCB0aGVuIGluZGljYXRlcyB0byBXZWJDb3JlIHRo YXQgdGhlIHBsdWdpbiB3YW50cyB0bwotICAgIC8vIHN3YWxsb3cgdGhlIGV2ZW50LS13aGljaCBp cyB3aGF0IHdlIHdhbnQuICBDYWxsaW5nIHNldERlZmF1bHRIYW5kbGVkKCkKLSAgICAvLyBmaXhl cyBzZXZlcmFsIE1hYyBDaHJvbWl1bSBidWdzLCBidXQgZG9lcyBpbmRlZWQgcHJldmVudCB3aW5k b3dsZXNzIHBsdWdpbnMKLSAgICAvLyBmcm9tIGdldHRpbmcgZm9jdXMgaW4gV2luZG93cyBidWls ZHMsIGFzIHBrYXN0aW5nIG5vdGVzIGFib3ZlLiAgU28gZm9yCi0gICAgLy8gbm93LCB3ZSBvbmx5 IGRvIHNvIGluIE1hYyBidWlsZHMuCi0jZW5kaWYKICAgICBpZiAoaGFuZGxlZCkKICAgICAgICAg ZXZlbnQtPnNldERlZmF1bHRIYW5kbGVkKCk7CiAKQEAgLTM5NiwxMCArMzgyLDYgQEAgdm9pZCBX ZWJQbHVnaW5Db250YWluZXJJbXBsOjpoYW5kbGVLZXlibwogCiAgICAgV2ViQ3Vyc29ySW5mbyBj dXJzb3JfaW5mbzsKICAgICBib29sIGhhbmRsZWQgPSBtX3dlYlBsdWdpbi0+aGFuZGxlSW5wdXRF dmVudCh3ZWJFdmVudCwgY3Vyc29yX2luZm8pOwotI2lmICFPUyhEQVJXSU4pCi0gICAgLy8gVE9E Tyhwa2FzdGluZyk6IGh0dHA6Ly9iLzExMTk2OTEgU2VlIGFib3ZlLgotICAgIGhhbmRsZWQgPSAh aGFuZGxlZDsKLSNlbmRpZgogICAgIGlmIChoYW5kbGVkKQogICAgICAgICBldmVudC0+c2V0RGVm YXVsdEhhbmRsZWQoKTsKIH0K