35778 2010-03-04 19:57:26 -0800 new-run-webkit-tests: fix --clobber-old-results 2010-03-09 13:23:43 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 dpranke dpranke michaeln tony oldest_to_newest 196316 0 dpranke 2010-03-04 19:57:26 -0800 new-run-webkit-tests: fix --clobber-old-results 196317 1 50082 dpranke 2010-03-04 19:57:40 -0800 Created attachment 50082 Patch 196320 2 tony 2010-03-04 20:00:56 -0800 I'm not a reviewer, but LGTM. 196591 3 50082 eric 2010-03-05 12:46:59 -0800 Comment on attachment 50082 Patch I'm confused by this change. What directories are we rm -rf-ing? Does Chromium store results separate from the actual test files? webkit.org does not. Directories like platform/mac may contain both results and additional mac-specific tests. FYI, there is a similar (same?) option on run-webkit-tests called --reset-results, which runs the tests like normal, except tricks the test engine into thinking that every result is new and causes it to overwrite all -expected.txt files in their proper places. 196614 4 dpranke 2010-03-05 13:25:34 -0800 This deletes the results of the test run (files in layout-test-results/) , not the actual baselines. For some reason Chromium doesn't do this by default every time, and so things like the rebaseline tool may get confused and pull old stale results. Tony, is there some reason we don't just make this option true by default (or just do it every time)? 196998 5 tony 2010-03-07 04:19:21 -0800 (In reply to comment #4) > Tony, is there some reason we don't just make this option true by default (or > just do it every time)? run-webkit-tests doesn't delete results every time either: http://trac.webkit.org/browser/trunk/WebKitTools/Scripts/run-webkit-tests#L997 As far as I can tell, it doesn't have an option to delete the results. But the buildbot slaves on build.webkit.org must delete results between runs because you can download the failing tests from the waterfall. Maybe it's done in by the slave rather than by run-webkit-tests. I don't have a preference for which script does this. 197340 6 50082 dglazkov 2010-03-08 15:19:14 -0800 Comment on attachment 50082 Patch rs=me. 197377 7 dpranke 2010-03-08 15:57:04 -0800 Committed r55689: <http://trac.webkit.org/changeset/55689> 197449 8 michaeln 2010-03-08 21:45:02 -0800 This patch was reverted, path_utils.py is nowhere to be found upstream so the canary bots weren't running the layout tests at all. (And heaven forbid we roll that into view). Dumi helped me do the revert since I'm not a webkit committer. See https://trac.webkit.org/changeset/55709 197450 9 dpranke 2010-03-08 21:50:52 -0800 Thanks for catching this. Apparently I didn't actually test this upstream, as it wouldn't have executed. Very sloppy :( 197713 10 50337 dpranke 2010-03-09 11:58:55 -0800 Created attachment 50337 change 'path_utils.' to 'port_obj.' fix bad merge from downstream - rename 'path_utils.' to 'port_obj.' 197737 11 50337 japhet 2010-03-09 13:15:48 -0800 Comment on attachment 50337 change 'path_utils.' to 'port_obj.' rs=me 197739 12 50337 japhet 2010-03-09 13:18:45 -0800 Comment on attachment 50337 change 'path_utils.' to 'port_obj.' rs=me for real this time, apparently I can't operate a dropdown menu. 197742 13 dpranke 2010-03-09 13:23:43 -0800 Committed r55741: <http://trac.webkit.org/changeset/55741> 50082 2010-03-04 19:57:40 -0800 2010-03-09 11:58:55 -0800 Patch bug-35778-20100304195739.patch text/plain 1727 dpranke ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCBjNzk3ODU2Li45ZDM5MWZjIDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VM b2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTEgQEAKKzIwMTAtMDMt MDQgIERpcmsgUHJhbmtlICA8ZHByYW5rZUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRml4IC0tY2xvYmJlci1vbGQtcmVzdWx0 cyBpbiBuZXctcnVuLXdlYmtpdC10ZXN0cy4KKworICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkv bGF5b3V0X3Rlc3RzL3J1bl93ZWJraXRfdGVzdHMucHk6CisKIDIwMTAtMDMtMDMgIEplc3VzIFNh bmNoZXotUGFsZW5jaWEgIDxqZXN1cy5wYWxlbmNpYUBvcGVuYm9zc2Eub3JnPgogCiAgICAgICAg IFJldmlld2VkIGJ5IFNpbW9uIEhhdXNtYW5uLgpkaWZmIC0tZ2l0IGEvV2ViS2l0VG9vbHMvU2Ny aXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcnVuX3dlYmtpdF90ZXN0cy5weSBiL1dlYktpdFRv b2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3J1bl93ZWJraXRfdGVzdHMucHkKaW5k ZXggMDQyZTc5MS4uZTg0MmYyYSAxMDA3NTUKLS0tIGEvV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJr aXRweS9sYXlvdXRfdGVzdHMvcnVuX3dlYmtpdF90ZXN0cy5weQorKysgYi9XZWJLaXRUb29scy9T Y3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9ydW5fd2Via2l0X3Rlc3RzLnB5CkBAIC0xNDA3 LDkgKzE0MDcsMTQgQEAgZGVmIG1haW4ob3B0aW9ucywgYXJncyk6CiAgICAgICAgICMgSnVzdCBj bG9iYmVyIHRoZSBhY3R1YWwgdGVzdCByZXN1bHRzIGRpcmVjdG9yaWVzIHNpbmNlIHRoZSBvdGhl cgogICAgICAgICAjIGZpbGVzIGluIHRoZSByZXN1bHRzIGRpcmVjdG9yeSBhcmUgZXhwbGljaXRs eSB1c2VkIGZvciBjcm9zcy1ydW4KICAgICAgICAgIyB0cmFja2luZy4KLSAgICAgICAgcGF0aCA9 IG9zLnBhdGguam9pbihvcHRpb25zLnJlc3VsdHNfZGlyZWN0b3J5LCAnTGF5b3V0VGVzdHMnKQot ICAgICAgICBpZiBvcy5wYXRoLmV4aXN0cyhwYXRoKToKLSAgICAgICAgICAgIHNodXRpbC5ybXRy ZWUocGF0aCkKKyAgICAgICAgbWV0ZXIudXBkYXRlKCJDbG9iYmVyaW5nIG9sZCByZXN1bHRzIGlu ICVzIiAlCisgICAgICAgICAgICAgICAgICAgICBvcHRpb25zLnJlc3VsdHNfZGlyZWN0b3J5KQor ICAgICAgICBsYXlvdXRfdGVzdHNfZGlyID0gcGF0aF91dGlscy5sYXlvdXRfdGVzdHNfZGlyKCkK KyAgICAgICAgcG9zc2libGVfZGlycyA9IG9zLmxpc3RkaXIobGF5b3V0X3Rlc3RzX2RpcikKKyAg ICAgICAgZm9yIGRpcm5hbWUgaW4gcG9zc2libGVfZGlyczoKKyAgICAgICAgICAgIGlmIG9zLnBh dGguaXNkaXIob3MucGF0aC5qb2luKGxheW91dF90ZXN0c19kaXIsIGRpcm5hbWUpKToKKyAgICAg ICAgICAgICAgICBzaHV0aWwucm10cmVlKG9zLnBhdGguam9pbihvcHRpb25zLnJlc3VsdHNfZGly ZWN0b3J5LCBkaXJuYW1lKSwKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGlnbm9yZV9l cnJvcnM9VHJ1ZSkKIAogICAgIGlmIG5vdCBvcHRpb25zLm51bV90ZXN0X3NoZWxsczoKICAgICAg ICAgIyBUT0RPKG9qYW4pOiBJbnZlc3RpZ2F0ZSBwZXJmL2ZsYWtpbmVzcyBpbXBhY3Qgb2YgdXNp bmcgbnVtY29yZXMgKyAxLgo= 50337 2010-03-09 11:58:55 -0800 2010-03-09 13:18:45 -0800 change 'path_utils.' to 'port_obj.' wk35778_clobber_old_results.diff text/plain 1773 dpranke ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCBlODgxY2QwLi42MDA0NTY3IDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VM b2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTAtMDMt MDkgIERpcmsgUHJhbmtlICA8ZHByYW5rZUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRml4IC0tY2xvYmJlci1vbGQtcmVzdWx0 cyBpbiBuZXctcnVuLXdlYmtpdC10ZXN0cy4KKworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzU3NzgKKworICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkv bGF5b3V0X3Rlc3RzL3J1bl93ZWJraXRfdGVzdHMucHk6CisKIDIwMTAtMDMtMDkgIENocmlzIEZs ZWl6YWNoICA8Y2ZsZWl6YWNoQGFwcGxlLmNvbT4KIAogICAgICAgICBEUlQgYnVpbGQgZml4IGZv ciBUaWdlci4gTm8gcmV2aWV3LgpkaWZmIC0tZ2l0IGEvV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJr aXRweS9sYXlvdXRfdGVzdHMvcnVuX3dlYmtpdF90ZXN0cy5weSBiL1dlYktpdFRvb2xzL1Njcmlw dHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3J1bl93ZWJraXRfdGVzdHMucHkKaW5kZXggMWMxMzlh Zi4uNWVjMGVjNSAxMDA3NTUKLS0tIGEvV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlv dXRfdGVzdHMvcnVuX3dlYmtpdF90ZXN0cy5weQorKysgYi9XZWJLaXRUb29scy9TY3JpcHRzL3dl YmtpdHB5L2xheW91dF90ZXN0cy9ydW5fd2Via2l0X3Rlc3RzLnB5CkBAIC0xNDA5LDkgKzE0MDks MTQgQEAgZGVmIG1haW4ob3B0aW9ucywgYXJncyk6CiAgICAgICAgICMgSnVzdCBjbG9iYmVyIHRo ZSBhY3R1YWwgdGVzdCByZXN1bHRzIGRpcmVjdG9yaWVzIHNpbmNlIHRoZSBvdGhlcgogICAgICAg ICAjIGZpbGVzIGluIHRoZSByZXN1bHRzIGRpcmVjdG9yeSBhcmUgZXhwbGljaXRseSB1c2VkIGZv ciBjcm9zcy1ydW4KICAgICAgICAgIyB0cmFja2luZy4KLSAgICAgICAgcGF0aCA9IG9zLnBhdGgu am9pbihvcHRpb25zLnJlc3VsdHNfZGlyZWN0b3J5LCAnTGF5b3V0VGVzdHMnKQotICAgICAgICBp ZiBvcy5wYXRoLmV4aXN0cyhwYXRoKToKLSAgICAgICAgICAgIHNodXRpbC5ybXRyZWUocGF0aCkK KyAgICAgICAgbWV0ZXIudXBkYXRlKCJDbG9iYmVyaW5nIG9sZCByZXN1bHRzIGluICVzIiAlCisg ICAgICAgICAgICAgICAgICAgICBvcHRpb25zLnJlc3VsdHNfZGlyZWN0b3J5KQorICAgICAgICBs YXlvdXRfdGVzdHNfZGlyID0gcG9ydF9vYmoubGF5b3V0X3Rlc3RzX2RpcigpCisgICAgICAgIHBv c3NpYmxlX2RpcnMgPSBvcy5saXN0ZGlyKGxheW91dF90ZXN0c19kaXIpCisgICAgICAgIGZvciBk aXJuYW1lIGluIHBvc3NpYmxlX2RpcnM6CisgICAgICAgICAgICBpZiBvcy5wYXRoLmlzZGlyKG9z LnBhdGguam9pbihsYXlvdXRfdGVzdHNfZGlyLCBkaXJuYW1lKSk6CisgICAgICAgICAgICAgICAg c2h1dGlsLnJtdHJlZShvcy5wYXRoLmpvaW4ob3B0aW9ucy5yZXN1bHRzX2RpcmVjdG9yeSwgZGly bmFtZSksCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBpZ25vcmVfZXJyb3JzPVRydWUp CiAKICAgICBpZiBub3Qgb3B0aW9ucy5udW1fdGVzdF9zaGVsbHM6CiAgICAgICAgICMgVE9ETyhv amFuKTogSW52ZXN0aWdhdGUgcGVyZi9mbGFraW5lc3MgaW1wYWN0IG9mIHVzaW5nIG51bWNvcmVz ICsgMS4K