35771 2010-03-04 15:27:58 -0800 [chromium] WebDocument:applicationID() crashes on <meta> tag with no http-equiv attribute 2010-03-04 21:52:25 -0800 1 1 1 Unclassified WebKit WebKit API 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 johnnyg johnnyg aa commit-queue fishd webkit.review.bot oldest_to_newest 196243 0 johnnyg 2010-03-04 15:27:58 -0800 if all the other checks fail, and there is a meta tag with no http-equiv attribute, the code calls .lower() on null. see also http://code.google.com/p/chromium/issues/detail?id=34961 for repro steps using chrome. 196254 1 50061 johnnyg 2010-03-04 15:58:26 -0800 Created attachment 50061 patch 196255 2 webkit.review.bot 2010-03-04 16:04:20 -0800 Attachment 50061 did not pass style-queue: Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1 WebKit/chromium/src/WebDocument.cpp:152: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 196257 3 50062 johnnyg 2010-03-04 16:25:14 -0800 Created attachment 50062 fix style warning 196264 4 50062 fishd 2010-03-04 16:38:14 -0800 Comment on attachment 50062 fix style warning Can we please just remove WebDocument::applicationID. As I mentioned to Aaron, it doesn't belong here and can be implemented purely in terms of WebKit APIs. 196265 5 50062 fishd 2010-03-04 16:39:22 -0800 Comment on attachment 50062 fix style warning > Index: WebKit/chromium/src/WebDocument.cpp > + if (element->hasAttribute("http-equiv") > + && element->getAttribute("http-equiv").lower() == kChromeApplicationHeader) { > return element->getAttribute("value"); > } nit: there should be no brackets around single line statements 196267 6 aa 2010-03-04 16:42:14 -0800 Darin, I knew you'd say that. I am going to start pulling it out soon. Can johnnyg just fix this immediate issue in the meantime? 196268 7 johnnyg 2010-03-04 16:47:07 -0800 Because notifications are hooked up to applicationID() already, this is causing real crashes when people use notifications... so i'd rather not wait for a large refactor to fix that. 196270 8 50065 johnnyg 2010-03-04 16:48:31 -0800 Created attachment 50065 removing {}s well I didn't put the braces there but I can remove them... 196323 9 fishd 2010-03-04 20:09:38 -0800 Sorry to give you a hard time about the applicationID thing. I would have r+'d the patch before if it didn't have the style issue. 196353 10 50065 commit-queue 2010-03-04 21:52:20 -0800 Comment on attachment 50065 removing {}s Clearing flags on attachment: 50065 Committed r55571: <http://trac.webkit.org/changeset/55571> 196354 11 commit-queue 2010-03-04 21:52:25 -0800 All reviewed patches have been landed. Closing bug. 50061 2010-03-04 15:58:26 -0800 2010-03-04 16:25:14 -0800 patch bug35771.patch text/plain 1456 johnnyg SW5kZXg6IFdlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZwkocmV2aXNpb24gNTU1NTgpCisrKyBXZWJLaXQvY2hyb21pdW0vQ2hh bmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTAtMDMtMDQgIEpvaG4g R3JlZ2cgIDxqb2hubnlnQGdvb2dsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgW2Nocm9taXVtXSBXZWJEb2N1bWVudDphcHBsaWNhdGlvbklE KCkgY3Jhc2hlcyBvbiA8bWV0YT4gdGFnIHdpdGggbm8gaHR0cC1lcXVpdiBhdHRyaWJ1dGUKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM1NzcxCisKKyAg ICAgICAgKiBzcmMvV2ViRG9jdW1lbnQuY3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJEb2N1bWVu dDo6YXBwbGljYXRpb25JRCk6CisgICAgICAgIGNoZWNrIGZvciBwcmVzZW5jZSBvZiBodHRwLWVx dWl2IGF0dHJpYnV0ZSBiZWZvcmUgbG93ZXIoKWluZyBpdC4KKwogMjAxMC0wMy0wNCAgRGFyaW4g RmlzaGVyICA8ZGFyaW5AY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERtaXRy eSBUaXRvdi4KSW5kZXg6IFdlYktpdC9jaHJvbWl1bS9zcmMvV2ViRG9jdW1lbnQuY3BwCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFdlYktpdC9jaHJvbWl1bS9zcmMvV2ViRG9jdW1lbnQuY3BwCShyZXZpc2lvbiA1 NTU1NykKKysrIFdlYktpdC9jaHJvbWl1bS9zcmMvV2ViRG9jdW1lbnQuY3BwCSh3b3JraW5nIGNv cHkpCkBAIC0xNDksNyArMTQ5LDggQEAgV2ViU3RyaW5nIFdlYkRvY3VtZW50OjphcHBsaWNhdGlv bklEKCkgYwogICAgICAgICBjb25zdF9jYXN0PERvY3VtZW50Kj4oZG9jdW1lbnQpLT5nZXRFbGVt ZW50c0J5VGFnTmFtZSgibWV0YSIpOwogICAgIGZvciAodW5zaWduZWQgaSA9IDA7IGkgPCBtZXRh VGFncy0+bGVuZ3RoKCk7ICsraSkgewogICAgICAgICBFbGVtZW50KiBlbGVtZW50ID0gc3RhdGlj X2Nhc3Q8RWxlbWVudCo+KG1ldGFUYWdzLT5pdGVtKGkpKTsKLSAgICAgICAgaWYgKGVsZW1lbnQt PmdldEF0dHJpYnV0ZSgiaHR0cC1lcXVpdiIpLmxvd2VyKCkgPT0KKyAgICAgICAgaWYgKGVsZW1l bnQtPmhhc0F0dHJpYnV0ZSgiaHR0cC1lcXVpdiIpICYmCisgICAgICAgICAgICBlbGVtZW50LT5n ZXRBdHRyaWJ1dGUoImh0dHAtZXF1aXYiKS5sb3dlcigpID09CiAgICAgICAgICAgICAgICAga0No cm9tZUFwcGxpY2F0aW9uSGVhZGVyKSB7CiAgICAgICAgICAgICByZXR1cm4gZWxlbWVudC0+Z2V0 QXR0cmlidXRlKCJ2YWx1ZSIpOwogICAgICAgICB9Cg== 50062 2010-03-04 16:25:14 -0800 2010-03-04 16:48:31 -0800 fix style warning bug35771b.patch text/plain 1491 johnnyg SW5kZXg6IFdlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZwkocmV2aXNpb24gNTU1NTgpCisrKyBXZWJLaXQvY2hyb21pdW0vQ2hh bmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTAtMDMtMDQgIEpvaG4g R3JlZ2cgIDxqb2hubnlnQGdvb2dsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgW2Nocm9taXVtXSBXZWJEb2N1bWVudDphcHBsaWNhdGlvbklE KCkgY3Jhc2hlcyBvbiA8bWV0YT4gdGFnIHdpdGggbm8gaHR0cC1lcXVpdiBhdHRyaWJ1dGUKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM1NzcxCisKKyAg ICAgICAgKiBzcmMvV2ViRG9jdW1lbnQuY3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJEb2N1bWVu dDo6YXBwbGljYXRpb25JRCk6CisgICAgICAgIGNoZWNrIGZvciBwcmVzZW5jZSBvZiBodHRwLWVx dWl2IGF0dHJpYnV0ZSBiZWZvcmUgbG93ZXIoKWluZyBpdC4KKwogMjAxMC0wMy0wNCAgRGFyaW4g RmlzaGVyICA8ZGFyaW5AY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERtaXRy eSBUaXRvdi4KSW5kZXg6IFdlYktpdC9jaHJvbWl1bS9zcmMvV2ViRG9jdW1lbnQuY3BwCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFdlYktpdC9jaHJvbWl1bS9zcmMvV2ViRG9jdW1lbnQuY3BwCShyZXZpc2lvbiA1 NTU1NykKKysrIFdlYktpdC9jaHJvbWl1bS9zcmMvV2ViRG9jdW1lbnQuY3BwCSh3b3JraW5nIGNv cHkpCkBAIC0xNDksOCArMTQ5LDggQEAgV2ViU3RyaW5nIFdlYkRvY3VtZW50OjphcHBsaWNhdGlv bklEKCkgYwogICAgICAgICBjb25zdF9jYXN0PERvY3VtZW50Kj4oZG9jdW1lbnQpLT5nZXRFbGVt ZW50c0J5VGFnTmFtZSgibWV0YSIpOwogICAgIGZvciAodW5zaWduZWQgaSA9IDA7IGkgPCBtZXRh VGFncy0+bGVuZ3RoKCk7ICsraSkgewogICAgICAgICBFbGVtZW50KiBlbGVtZW50ID0gc3RhdGlj X2Nhc3Q8RWxlbWVudCo+KG1ldGFUYWdzLT5pdGVtKGkpKTsKLSAgICAgICAgaWYgKGVsZW1lbnQt PmdldEF0dHJpYnV0ZSgiaHR0cC1lcXVpdiIpLmxvd2VyKCkgPT0KLSAgICAgICAgICAgICAgICBr Q2hyb21lQXBwbGljYXRpb25IZWFkZXIpIHsKKyAgICAgICAgaWYgKGVsZW1lbnQtPmhhc0F0dHJp YnV0ZSgiaHR0cC1lcXVpdiIpCisgICAgICAgICAgICAmJiBlbGVtZW50LT5nZXRBdHRyaWJ1dGUo Imh0dHAtZXF1aXYiKS5sb3dlcigpID09IGtDaHJvbWVBcHBsaWNhdGlvbkhlYWRlcikgewogICAg ICAgICAgICAgcmV0dXJuIGVsZW1lbnQtPmdldEF0dHJpYnV0ZSgidmFsdWUiKTsKICAgICAgICAg fQogICAgIH0K 50065 2010-03-04 16:48:31 -0800 2010-03-04 21:52:20 -0800 removing {}s bug35771c.patch text/plain 1517 johnnyg SW5kZXg6IFdlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZwkocmV2aXNpb24gNTU1NTgpCisrKyBXZWJLaXQvY2hyb21pdW0vQ2hh bmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTAtMDMtMDQgIEpvaG4g R3JlZ2cgIDxqb2hubnlnQGdvb2dsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgW2Nocm9taXVtXSBXZWJEb2N1bWVudDphcHBsaWNhdGlvbklE KCkgY3Jhc2hlcyBvbiA8bWV0YT4gdGFnIHdpdGggbm8gaHR0cC1lcXVpdiBhdHRyaWJ1dGUKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM1NzcxCisKKyAg ICAgICAgKiBzcmMvV2ViRG9jdW1lbnQuY3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJEb2N1bWVu dDo6YXBwbGljYXRpb25JRCk6CisgICAgICAgIGNoZWNrIGZvciBwcmVzZW5jZSBvZiBodHRwLWVx dWl2IGF0dHJpYnV0ZSBiZWZvcmUgbG93ZXIoKWluZyBpdC4KKwogMjAxMC0wMy0wNCAgRGFyaW4g RmlzaGVyICA8ZGFyaW5AY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERtaXRy eSBUaXRvdi4KSW5kZXg6IFdlYktpdC9jaHJvbWl1bS9zcmMvV2ViRG9jdW1lbnQuY3BwCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFdlYktpdC9jaHJvbWl1bS9zcmMvV2ViRG9jdW1lbnQuY3BwCShyZXZpc2lvbiA1 NTU1NykKKysrIFdlYktpdC9jaHJvbWl1bS9zcmMvV2ViRG9jdW1lbnQuY3BwCSh3b3JraW5nIGNv cHkpCkBAIC0xNDksMTAgKzE0OSw5IEBAIFdlYlN0cmluZyBXZWJEb2N1bWVudDo6YXBwbGljYXRp b25JRCgpIGMKICAgICAgICAgY29uc3RfY2FzdDxEb2N1bWVudCo+KGRvY3VtZW50KS0+Z2V0RWxl bWVudHNCeVRhZ05hbWUoIm1ldGEiKTsKICAgICBmb3IgKHVuc2lnbmVkIGkgPSAwOyBpIDwgbWV0 YVRhZ3MtPmxlbmd0aCgpOyArK2kpIHsKICAgICAgICAgRWxlbWVudCogZWxlbWVudCA9IHN0YXRp Y19jYXN0PEVsZW1lbnQqPihtZXRhVGFncy0+aXRlbShpKSk7Ci0gICAgICAgIGlmIChlbGVtZW50 LT5nZXRBdHRyaWJ1dGUoImh0dHAtZXF1aXYiKS5sb3dlcigpID09Ci0gICAgICAgICAgICAgICAg a0Nocm9tZUFwcGxpY2F0aW9uSGVhZGVyKSB7CisgICAgICAgIGlmIChlbGVtZW50LT5oYXNBdHRy aWJ1dGUoImh0dHAtZXF1aXYiKQorICAgICAgICAgICAgJiYgZWxlbWVudC0+Z2V0QXR0cmlidXRl KCJodHRwLWVxdWl2IikubG93ZXIoKSA9PSBrQ2hyb21lQXBwbGljYXRpb25IZWFkZXIpCiAgICAg ICAgICAgICByZXR1cm4gZWxlbWVudC0+Z2V0QXR0cmlidXRlKCJ2YWx1ZSIpOwotICAgICAgICB9 CiAgICAgfQogCiAgICAgcmV0dXJuIFdlYlN0cmluZygpOwo=