35733 2010-03-04 04:40:09 -0800 webkit-patch doesn't work well with security bug 2010-03-08 22:20:33 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 ukai ukai abarth commit-queue eric hamaji oldest_to_newest 196006 0 ukai 2010-03-04 04:40:09 -0800 security bug is restricted to access. Even if I could browse the security bug, webkit-patch fails to prepare or post. $ ./WebKitTools/Scripts/webkit-patch prepare XXXXX Running status to find changed, added, or removed files. Reviewing diff to determine which lines changed. Extracting affected function names from source files. Change author: Fumitoshi Ukai <ukai@chromium.org>. Bug XXXXX has no bug description. Maybe you set wrong bug ID? The bug URL: https://bugs.webkit.org/show_bug.cgi?id=XXXXX&ctype=xml ERROR: Unable to prepare ChangeLogs. $ ./WebKitTools/Scripts/webkit-patch post Running check-webkit-style Total errors found: 0 in 8 files Was that diff correct? [Y/n]: y Fetching: https://bugs.webkit.org/show_bug.cgi?id=XXXXX&ctype=xml Traceback (most recent call last): File "./WebKitTools/Scripts/webkit-patch", line 109, in <module> WebKitPatch().main() File "/Users/ukai/src/chromium-webkit/src/third_party/WebKit/WebKitTools/Scripts/webkitpy/multicommandtool.py", line 299, in main File "/Users/ukai/src/chromium-webkit/src/third_party/WebKit/WebKitTools/Scripts/webkitpy/multicommandtool.py", line 113, in check_arguments_and_execute File "/Users/ukai/src/chromium-webkit/src/third_party/WebKit/WebKitTools/Scripts/webkitpy/commands/abstractsequencedcommand.py", line 43, in execute File "/Users/ukai/src/chromium-webkit/src/third_party/WebKit/WebKitTools/Scripts/webkitpy/stepsequence.py", line 66, in run_and_handle_errors File "/Users/ukai/src/chromium-webkit/src/third_party/WebKit/WebKitTools/Scripts/webkitpy/stepsequence.py", line 60, in _run File "/Users/ukai/src/chromium-webkit/src/third_party/WebKit/WebKitTools/Scripts/webkitpy/steps/obsoletepatches.py", line 46, in run File "/Users/ukai/src/chromium-webkit2/src/third_party/WebKit/WebKitTools/Scripts/webkitpy/bugzilla.py", line 426, in fetch_bug return Bug(self.fetch_bug_dictionary(bug_id), self) File "/Users/ukai/src/chromium-webkit2/src/third_party/WebKit/WebKitTools/Scripts/webkitpy/bugzilla.py", line 421, in fetch_bug_dictionary return self._parse_bug_page(self._fetch_bug_page(bug_id)) File "/Users/ukai/src/chromium-webkit2/src/third_party/WebKit/WebKitTools/Scripts/webkitpy/bugzilla.py", line 404, in _parse_bug_page bug["title"] = unicode(soup.find("short_desc").string) AttributeError: 'NoneType' object has no attribute 'string' 196344 1 ukai 2010-03-04 21:22:06 -0800 land also fails $ TZ=America/Los_Angeles ./WebKitTools/Scripts/webkit-patch land Fetching: https://bugs.webkit.org/show_bug.cgi?id=XXXX&ctype=xml Traceback (most recent call last): File "./WebKitTools/Scripts/webkit-patch", line 109, in <module> WebKitPatch().main() File "/Users/ukai/src/chromium-webkit/src/third_party/WebKit/WebKitTools/Scripts/webkitpy/multicommandtool.py", line 299, in main File "/Users/ukai/src/chromium-webkit/src/third_party/WebKit/WebKitTools/Scripts/webkitpy/multicommandtool.py", line 113, in check_arguments_and_execute File "/Users/ukai/src/chromium-webkit/src/third_party/WebKit/WebKitTools/Scripts/webkitpy/commands/abstractsequencedcommand.py", line 43, in execute File "/Users/ukai/src/chromium-webkit/src/third_party/WebKit/WebKitTools/Scripts/webkitpy/stepsequence.py", line 66, in run_and_handle_errors File "/Users/ukai/src/chromium-webkit/src/third_party/WebKit/WebKitTools/Scripts/webkitpy/stepsequence.py", line 60, in _run File "/Users/ukai/src/chromium-webkit/src/third_party/WebKit/WebKitTools/Scripts/webkitpy/steps/updatechangelogswithreviewer.py", line 63, in run File "/Users/ukai/src/chromium-webkit/src/third_party/WebKit/WebKitTools/Scripts/webkitpy/steps/updatechangelogswithreviewer.py", line 45, in _guess_reviewer_from_bug File "/Users/ukai/src/chromium-webkit2/src/third_party/WebKit/WebKitTools/Scripts/webkitpy/bugzilla.py", line 426, in fetch_bug return Bug(self.fetch_bug_dictionary(bug_id), self) File "/Users/ukai/src/chromium-webkit2/src/third_party/WebKit/WebKitTools/Scripts/webkitpy/bugzilla.py", line 421, in fetch_bug_dictionary return self._parse_bug_page(self._fetch_bug_page(bug_id)) File "/Users/ukai/src/chromium-webkit2/src/third_party/WebKit/WebKitTools/Scripts/webkitpy/bugzilla.py", line 404, in _parse_bug_page bug["title"] = unicode(soup.find("short_desc").string) AttributeError: 'NoneType' object has no attribute 'string' 196347 2 abarth 2010-03-04 21:34:17 -0800 Yeah. We need to call bugzilla.py's authenticate method more often. The patches are pretty simple to write one you have a reproducing test case. You can see other examples in bugzilla.py. 196379 3 50091 ukai 2010-03-05 01:01:01 -0800 Created attachment 50091 Patch 196380 4 ukai 2010-03-05 01:04:32 -0800 (In reply to comment #2) > Yeah. We need to call bugzilla.py's authenticate method more often. The > patches are pretty simple to write one you have a reproducing test case. You > can see other examples in bugzilla.py. I'm not sure if we always authenticate before accessing bugzilla. This patch set 1 would fix the post and land. For prepare, webkit-patch calls prepare-ChangesLogs and it just uses curl to access bugzilla. How could we fix it? Use --netrc ? 196403 5 50091 abarth 2010-03-05 05:36:24 -0800 Comment on attachment 50091 Patch Interesting approach. In general, we prefer a test for every change to webkit-patch, especially for low frequency bugs like this one. I'm not sure of the best solution for prepare-ChangeLog. It's outside of our python infrastructure, so it doesn't have access to our identify information... 196647 6 commit-queue 2010-03-05 14:05:15 -0800 Attachment 50091 was posted by a committer and has review+, assigning to Fumitoshi Ukai for commit. 196955 7 ap 2010-03-06 17:25:23 -0800 ChangeLog should say what was fixed here. "Doesn't work well" is not a sufficient explanation. 197196 8 abarth 2010-03-08 09:43:44 -0800 Are you looking for a resolution here, or just giving advice for the future? 197432 9 ukai 2010-03-08 20:21:22 -0800 Committed r55704: <http://trac.webkit.org/changeset/55704> 197434 10 ukai 2010-03-08 20:25:43 -0800 (In reply to comment #8) > Are you looking for a resolution here, or just giving advice for the future? Sorry for the delay. I just landed this patch, and create new bug for prepare-ChangeLog https://bugs.webkit.org/show_bug.cgi?id=35901 Shoud we develop webkitpy version of prepare-ChangeLog? 197457 11 eric 2010-03-08 22:20:33 -0800 If it offered other benefits as part of a re-write, sure. But I think we have bigger fish to fry for the moment. Most critical in terms of python re-writes is to finish the new-run-webkit-tests (python) to run-webkit-tests conversion. 50091 2010-03-05 01:01:01 -0800 2010-03-05 05:36:24 -0800 Patch bug-35733-20100305180059.patch text/plain 1274 ukai ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCAzMzFhY2Y2Li4wNTUzMWU5IDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VM b2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTAtMDMt MDUgIEZ1bWl0b3NoaSBVa2FpICA8dWthaUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgd2Via2l0LXBhdGNoIGRvZXNuJ3Qgd29y ayB3ZWxsIHdpdGggc2VjdXJpdHkgYnVnCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0zNTczMworICAgICAgICAKKyAgICAgICAgRml4ZWQgd2Via2l0LXBh dGNoIHBvc3QgYW5kIGxhbmQgZm9yIHNlY3VyaXR5IGJ1Z3MuCisKKyAgICAgICAgKiBTY3JpcHRz L3dlYmtpdHB5L2J1Z3ppbGxhLnB5OgorCiAyMDEwLTAzLTA0ICBNYXJrIFJvd2UgIDxtcm93ZUBh cHBsZS5jb20+CiAKICAgICAgICAgUnViYmVyLXN0YW1wZWQgYnkgQWxpY2UgTGl1LgpkaWZmIC0t Z2l0IGEvV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRweS9idWd6aWxsYS5weSBiL1dlYktpdFRv b2xzL1NjcmlwdHMvd2Via2l0cHkvYnVnemlsbGEucHkKaW5kZXggMDBlNjk0MC4uNDdhMWE0MyAx MDA2NDQKLS0tIGEvV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRweS9idWd6aWxsYS5weQorKysg Yi9XZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L2J1Z3ppbGxhLnB5CkBAIC00MTgsNyArNDE4 LDExIEBAIGNsYXNzIEJ1Z3ppbGxhKG9iamVjdCk6CiAgICAgICAgIHJldHVybiBzZWxmLmJyb3dz ZXIub3BlbihidWdfdXJsKQogCiAgICAgZGVmIGZldGNoX2J1Z19kaWN0aW9uYXJ5KHNlbGYsIGJ1 Z19pZCk6Ci0gICAgICAgIHJldHVybiBzZWxmLl9wYXJzZV9idWdfcGFnZShzZWxmLl9mZXRjaF9i dWdfcGFnZShidWdfaWQpKQorICAgICAgICB0cnk6CisgICAgICAgICAgICByZXR1cm4gc2VsZi5f cGFyc2VfYnVnX3BhZ2Uoc2VsZi5fZmV0Y2hfYnVnX3BhZ2UoYnVnX2lkKSkKKyAgICAgICAgZXhj ZXB0OgorICAgICAgICAgICAgc2VsZi5hdXRoZW50aWNhdGUoKQorICAgICAgICAgICAgcmV0dXJu IHNlbGYuX3BhcnNlX2J1Z19wYWdlKHNlbGYuX2ZldGNoX2J1Z19wYWdlKGJ1Z19pZCkpCiAKICAg ICAjIEZJWE1FOiBBIEJ1Z3ppbGxhQ2FjaGUgb2JqZWN0IHNob3VsZCBwcm92aWRlIGFsbCB0aGVz ZSBmZXRjaF8gbWV0aG9kcy4KIAo=