35717 2010-03-03 22:01:56 -0800 check-webkit-style: false positive for empty loop 2010-03-07 22:56:09 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC All RESOLVED FIXED P2 Normal --- 1 hamaji hamaji commit-queue oldest_to_newest 195886 0 hamaji 2010-03-03 22:01:56 -0800 For loops like "for (...) {}", check-webkit-style thinks the opened brace isn't closed and produces a false alarm for the close brace in two lines below. void foo() { for (int i = 0; i < 100; i++) { } return; } // check-webkit-style thinks this close brace corresponds to the open brace after "for (...)" . test.cpp:5: One line control clauses should not use braces. [whitespace/braces] [4] Total errors found: 1 in 1 files See Bug 35557 for a real example. 195887 1 49984 hamaji 2010-03-03 22:02:54 -0800 Created attachment 49984 Patch v1 196217 2 49984 eric 2010-03-04 14:03:26 -0800 Comment on attachment 49984 Patch v1 I'm not sure I understand. Why would one ever want if (foo) {}? Can you point to the style guide as to where this is documented? Or maybe the tests just need to be changed to use for or while. 196304 3 50080 hamaji 2010-03-04 18:58:13 -0800 Created attachment 50080 Patch v2 196305 4 hamaji 2010-03-04 18:59:55 -0800 > Can you point to the style guide as to where this is documented? Or maybe the > tests just need to be changed to use for or while. Oops! Yes, we need to use for or while to make the tests reasonable. Thanks for catching this. 196612 5 50080 eric 2010-03-05 13:18:46 -0800 Comment on attachment 50080 Patch v2 OK. "while (condition)" would still be better with a real example of a useful "condition", but this looks OK. 196646 6 commit-queue 2010-03-05 14:05:11 -0800 Attachment 50080 was posted by a committer and has review+, assigning to Shinichiro Hamaji for commit. 197069 7 hamaji 2010-03-07 22:56:09 -0800 Committed r55656: <http://trac.webkit.org/changeset/55656> 49984 2010-03-03 22:02:54 -0800 2010-03-04 18:58:09 -0800 Patch v1 bug-35717-20100303220252.patch text/plain 2663 hamaji ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCBjNzk3ODU2Li5jZTdiMTZmIDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VM b2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTAtMDMt MDMgIFNoaW5pY2hpcm8gSGFtYWppICA8aGFtYWppQGNocm9taXVtLm9yZz4KKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBjaGVjay13ZWJraXQtc3R5bGU6 IGZhbHNlIHBvc2l0aXZlIGZvciBlbXB0eSBsb29wCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zNTcxNworCisgICAgICAgICogU2NyaXB0cy93ZWJraXRw eS9zdHlsZS9wcm9jZXNzb3JzL2NwcC5weToKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L3N0 eWxlL3Byb2Nlc3NvcnMvY3BwX3VuaXR0ZXN0LnB5OgorCiAyMDEwLTAzLTAzICBKZXN1cyBTYW5j aGV6LVBhbGVuY2lhICA8amVzdXMucGFsZW5jaWFAb3BlbmJvc3NhLm9yZz4KIAogICAgICAgICBS ZXZpZXdlZCBieSBTaW1vbiBIYXVzbWFubi4KZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL1Njcmlw dHMvd2Via2l0cHkvc3R5bGUvcHJvY2Vzc29ycy9jcHAucHkgYi9XZWJLaXRUb29scy9TY3JpcHRz L3dlYmtpdHB5L3N0eWxlL3Byb2Nlc3NvcnMvY3BwLnB5Cm9sZCBtb2RlIDEwMDY0NApuZXcgbW9k ZSAxMDA3NTUKaW5kZXggMTdiZjg0YS4uODE0YjYwNwotLS0gYS9XZWJLaXRUb29scy9TY3JpcHRz L3dlYmtpdHB5L3N0eWxlL3Byb2Nlc3NvcnMvY3BwLnB5CisrKyBiL1dlYktpdFRvb2xzL1Njcmlw dHMvd2Via2l0cHkvc3R5bGUvcHJvY2Vzc29ycy9jcHAucHkKQEAgLTE2NTIsNyArMTY1Miw3IEBA IGRlZiBjaGVja19icmFjZXMoY2xlYW5fbGluZXMsIGxpbmVfbnVtYmVyLCBlcnJvcik6CiAgICAg ICAgICMgV2UgY2hlY2sgaWYgYSBjbG9zZWQgYnJhY2UgaGFzIHN0YXJ0ZWQgYSBsaW5lIHRvIHNl ZSBpZiBhCiAgICAgICAgICMgb25lIGxpbmUgY29udHJvbCBzdGF0ZW1lbnQgd2FzIHByZXZpb3Vz LgogICAgICAgICBwcmV2aW91c19saW5lID0gY2xlYW5fbGluZXMuZWxpZGVkW2xpbmVfbnVtYmVy IC0gMl0KLSAgICAgICAgaWYgKHByZXZpb3VzX2xpbmUuZmluZCgneycpID4gMAorICAgICAgICBp ZiAocHJldmlvdXNfbGluZS5maW5kKCd7JykgPiAwIGFuZCBwcmV2aW91c19saW5lLmZpbmQoJ30n KSA8IDAKICAgICAgICAgICAgIGFuZCBzZWFyY2gocidcYihpZnxmb3J8Zm9yZWFjaHx3aGlsZXxl bHNlKVxiJywgcHJldmlvdXNfbGluZSkpOgogICAgICAgICAgICAgZXJyb3IobGluZV9udW1iZXIs ICd3aGl0ZXNwYWNlL2JyYWNlcycsIDQsCiAgICAgICAgICAgICAgICAgICAnT25lIGxpbmUgY29u dHJvbCBjbGF1c2VzIHNob3VsZCBub3QgdXNlIGJyYWNlcy4nKQpkaWZmIC0tZ2l0IGEvV2ViS2l0 VG9vbHMvU2NyaXB0cy93ZWJraXRweS9zdHlsZS9wcm9jZXNzb3JzL2NwcF91bml0dGVzdC5weSBi L1dlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5bGUvcHJvY2Vzc29ycy9jcHBfdW5pdHRl c3QucHkKb2xkIG1vZGUgMTAwNjQ0Cm5ldyBtb2RlIDEwMDc1NQppbmRleCA0Mzk4ZDJlLi5lYWU5 ZGZkCi0tLSBhL1dlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5bGUvcHJvY2Vzc29ycy9j cHBfdW5pdHRlc3QucHkKKysrIGIvV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRweS9zdHlsZS9w cm9jZXNzb3JzL2NwcF91bml0dGVzdC5weQpAQCAtMzA2NCw2ICszMDY0LDIwIEBAIGNsYXNzIFdl YktpdFN0eWxlVGVzdChDcHBTdHlsZVRlc3RCYXNlKToKICAgICAgICAgICAgICd9XG4nLAogICAg ICAgICAgICAgWydNb3JlIHRoYW4gb25lIGNvbW1hbmQgb24gdGhlIHNhbWUgbGluZSBpbiBpZiAg W3doaXRlc3BhY2UvcGFyZW5zXSBbNF0nLAogICAgICAgICAgICAgICdPbmUgbGluZSBjb250cm9s IGNsYXVzZXMgc2hvdWxkIG5vdCB1c2UgYnJhY2VzLiAgW3doaXRlc3BhY2UvYnJhY2VzXSBbNF0n XSkKKyAgICAgICAgc2VsZi5hc3NlcnRfbXVsdGlfbGluZV9saW50KAorICAgICAgICAgICAgJ3Zv aWQgZnVuYygpXG4nCisgICAgICAgICAgICAne1xuJworICAgICAgICAgICAgJyAgICBpZiAoY29u ZGl0aW9uKSB7IH1cbicKKyAgICAgICAgICAgICcgICAgcmV0dXJuIDA7XG4nCisgICAgICAgICAg ICAnfVxuJywKKyAgICAgICAgICAgICcnKQorICAgICAgICBzZWxmLmFzc2VydF9tdWx0aV9saW5l X2xpbnQoCisgICAgICAgICAgICAndm9pZCBmdW5jKClcbicKKyAgICAgICAgICAgICd7XG4nCisg ICAgICAgICAgICAnICAgIGlmIChjb25kaXRpb24pIHsgZm9vYmFyKCk7IH1cbicKKyAgICAgICAg ICAgICcgICAgcmV0dXJuIDA7XG4nCisgICAgICAgICAgICAnfVxuJywKKyAgICAgICAgICAgICdN b3JlIHRoYW4gb25lIGNvbW1hbmQgb24gdGhlIHNhbWUgbGluZSBpbiBpZiAgW3doaXRlc3BhY2Uv cGFyZW5zXSBbNF0nKQogCiAgICAgICAgICMgMy4gQW4gZWxzZSBpZiBzdGF0ZW1lbnQgc2hvdWxk IGJlIHdyaXR0ZW4gYXMgYW4gaWYgc3RhdGVtZW50CiAgICAgICAgICMgICAgd2hlbiB0aGUgcHJp b3IgaWYgY29uY2x1ZGVzIHdpdGggYSByZXR1cm4gc3RhdGVtZW50Lgo= 50080 2010-03-04 18:58:13 -0800 2010-03-05 13:18:46 -0800 Patch v2 bug-35717-20100304185812.patch text/plain 2607 hamaji ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCBjMjNmYWVhLi41YmQ0YzFmIDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VM b2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTAtMDMt MDQgIFNoaW5pY2hpcm8gSGFtYWppICA8aGFtYWppQGNocm9taXVtLm9yZz4KKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBjaGVjay13ZWJraXQtc3R5bGU6 IGZhbHNlIHBvc2l0aXZlIGZvciBlbXB0eSBsb29wCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zNTcxNworCisgICAgICAgICogU2NyaXB0cy93ZWJraXRw eS9zdHlsZS9wcm9jZXNzb3JzL2NwcC5weToKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L3N0 eWxlL3Byb2Nlc3NvcnMvY3BwX3VuaXR0ZXN0LnB5OgorCiAyMDEwLTAzLTA0ICBLZW50IFRhbXVy YSAgPHRrZW50QGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBEaW1pdHJpIEds YXprb3YuCmRpZmYgLS1naXQgYS9XZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxlL3By b2Nlc3NvcnMvY3BwLnB5IGIvV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRweS9zdHlsZS9wcm9j ZXNzb3JzL2NwcC5weQppbmRleCAxN2JmODRhLi44MTRiNjA3IDEwMDY0NAotLS0gYS9XZWJLaXRU b29scy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxlL3Byb2Nlc3NvcnMvY3BwLnB5CisrKyBiL1dlYktp dFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5bGUvcHJvY2Vzc29ycy9jcHAucHkKQEAgLTE2NTIs NyArMTY1Miw3IEBAIGRlZiBjaGVja19icmFjZXMoY2xlYW5fbGluZXMsIGxpbmVfbnVtYmVyLCBl cnJvcik6CiAgICAgICAgICMgV2UgY2hlY2sgaWYgYSBjbG9zZWQgYnJhY2UgaGFzIHN0YXJ0ZWQg YSBsaW5lIHRvIHNlZSBpZiBhCiAgICAgICAgICMgb25lIGxpbmUgY29udHJvbCBzdGF0ZW1lbnQg d2FzIHByZXZpb3VzLgogICAgICAgICBwcmV2aW91c19saW5lID0gY2xlYW5fbGluZXMuZWxpZGVk W2xpbmVfbnVtYmVyIC0gMl0KLSAgICAgICAgaWYgKHByZXZpb3VzX2xpbmUuZmluZCgneycpID4g MAorICAgICAgICBpZiAocHJldmlvdXNfbGluZS5maW5kKCd7JykgPiAwIGFuZCBwcmV2aW91c19s aW5lLmZpbmQoJ30nKSA8IDAKICAgICAgICAgICAgIGFuZCBzZWFyY2gocidcYihpZnxmb3J8Zm9y ZWFjaHx3aGlsZXxlbHNlKVxiJywgcHJldmlvdXNfbGluZSkpOgogICAgICAgICAgICAgZXJyb3Io bGluZV9udW1iZXIsICd3aGl0ZXNwYWNlL2JyYWNlcycsIDQsCiAgICAgICAgICAgICAgICAgICAn T25lIGxpbmUgY29udHJvbCBjbGF1c2VzIHNob3VsZCBub3QgdXNlIGJyYWNlcy4nKQpkaWZmIC0t Z2l0IGEvV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRweS9zdHlsZS9wcm9jZXNzb3JzL2NwcF91 bml0dGVzdC5weSBiL1dlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5bGUvcHJvY2Vzc29y cy9jcHBfdW5pdHRlc3QucHkKaW5kZXggNDM5OGQyZS4uYzQ3MzhmOSAxMDA2NDQKLS0tIGEvV2Vi S2l0VG9vbHMvU2NyaXB0cy93ZWJraXRweS9zdHlsZS9wcm9jZXNzb3JzL2NwcF91bml0dGVzdC5w eQorKysgYi9XZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxlL3Byb2Nlc3NvcnMvY3Bw X3VuaXR0ZXN0LnB5CkBAIC0zMDY0LDYgKzMwNjQsMjAgQEAgY2xhc3MgV2ViS2l0U3R5bGVUZXN0 KENwcFN0eWxlVGVzdEJhc2UpOgogICAgICAgICAgICAgJ31cbicsCiAgICAgICAgICAgICBbJ01v cmUgdGhhbiBvbmUgY29tbWFuZCBvbiB0aGUgc2FtZSBsaW5lIGluIGlmICBbd2hpdGVzcGFjZS9w YXJlbnNdIFs0XScsCiAgICAgICAgICAgICAgJ09uZSBsaW5lIGNvbnRyb2wgY2xhdXNlcyBzaG91 bGQgbm90IHVzZSBicmFjZXMuICBbd2hpdGVzcGFjZS9icmFjZXNdIFs0XSddKQorICAgICAgICBz ZWxmLmFzc2VydF9tdWx0aV9saW5lX2xpbnQoCisgICAgICAgICAgICAndm9pZCBmdW5jKClcbicK KyAgICAgICAgICAgICd7XG4nCisgICAgICAgICAgICAnICAgIHdoaWxlIChjb25kaXRpb24pIHsg fVxuJworICAgICAgICAgICAgJyAgICByZXR1cm4gMDtcbicKKyAgICAgICAgICAgICd9XG4nLAor ICAgICAgICAgICAgJycpCisgICAgICAgIHNlbGYuYXNzZXJ0X211bHRpX2xpbmVfbGludCgKKyAg ICAgICAgICAgICd2b2lkIGZ1bmMoKVxuJworICAgICAgICAgICAgJ3tcbicKKyAgICAgICAgICAg ICcgICAgZm9yIChpID0gMDsgaSA8IDQyOyBpKyspIHsgZm9vYmFyKCk7IH1cbicKKyAgICAgICAg ICAgICcgICAgcmV0dXJuIDA7XG4nCisgICAgICAgICAgICAnfVxuJywKKyAgICAgICAgICAgICdN b3JlIHRoYW4gb25lIGNvbW1hbmQgb24gdGhlIHNhbWUgbGluZSBpbiBmb3IgIFt3aGl0ZXNwYWNl L3BhcmVuc10gWzRdJykKIAogICAgICAgICAjIDMuIEFuIGVsc2UgaWYgc3RhdGVtZW50IHNob3Vs ZCBiZSB3cml0dGVuIGFzIGFuIGlmIHN0YXRlbWVudAogICAgICAgICAjICAgIHdoZW4gdGhlIHBy aW9yIGlmIGNvbmNsdWRlcyB3aXRoIGEgcmV0dXJuIHN0YXRlbWVudC4K