35710 2010-03-03 17:04:44 -0800 [chromium] DateExtension fires incorrectly 2010-03-04 01:24:56 -0800 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 jam jam commit-queue dglazkov fishd ojan oldest_to_newest 195824 0 jam 2010-03-03 17:04:44 -0800 Full background here: http://code.google.com/p/chromium/issues/detail?id=33441#makechanges The problem was this line: argv[0] = v8::String::New(allow ? "false" : "true"); since the JS function did "if (enable)" and treated the string as bool, it was always true. 195825 1 49965 jam 2010-03-03 17:11:47 -0800 Created attachment 49965 Proposed patch 195828 2 49965 abarth 2010-03-03 17:23:39 -0800 Comment on attachment 49965 Proposed patch Type FTW 195832 3 jam 2010-03-03 17:31:52 -0800 Thanks for the quick review! 195944 4 49965 commit-queue 2010-03-04 01:24:52 -0800 Comment on attachment 49965 Proposed patch Clearing flags on attachment: 49965 Committed r55513: <http://trac.webkit.org/changeset/55513> 195945 5 commit-queue 2010-03-04 01:24:56 -0800 All reviewed patches have been landed. Closing bug. 49965 2010-03-03 17:11:47 -0800 2010-03-04 01:24:52 -0800 Proposed patch baddate2.txt text/plain 3022 jam SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1NTQ4NykKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTMgQEAKKzIwMTAtMDMtMDMgIEpvaG4gQWJkLUVsLU1hbGVrICA8amFtQGNocm9t aXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBGaXggaW5jb3JyZWN0IHNldHVwIG9mIERhdGVFeHRlbnNpb24uCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zNTcxMAorCisgICAgICAgICogYmluZGlu Z3MvdjgvRGF0ZUV4dGVuc2lvbi5jcHA6CisgICAgICAgIChXZWJDb3JlOjpEYXRlRXh0ZW5zaW9u OjpzZXRBbGxvd1NsZWVwKToKKwogMjAxMC0wMy0wMiAgRHVtaXRydSBEYW5pbGl1YyAgPGR1bWlA Y2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERpbWl0cmkgR2xhemtvdi4KSW5k ZXg6IFdlYkNvcmUvYmluZGluZ3MvdjgvRGF0ZUV4dGVuc2lvbi5jcHAKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g V2ViQ29yZS9iaW5kaW5ncy92OC9EYXRlRXh0ZW5zaW9uLmNwcAkocmV2aXNpb24gNTU0NzgpCisr KyBXZWJDb3JlL2JpbmRpbmdzL3Y4L0RhdGVFeHRlbnNpb24uY3BwCSh3b3JraW5nIGNvcHkpCkBA IC04OCw3ICs4OCw3IEBAIHZvaWQgRGF0ZUV4dGVuc2lvbjo6c2V0QWxsb3dTbGVlcChib29sIGEK ICAgICAgICAgcmV0dXJuOwogCiAgICAgdjg6OkhhbmRsZTx2ODo6VmFsdWU+IGFyZ3ZbMV07Ci0g ICAgYXJndlswXSA9IHY4OjpTdHJpbmc6Ok5ldyhhbGxvdyA/ICJmYWxzZSIgOiAidHJ1ZSIpOwor ICAgIGFyZ3ZbMF0gPSB2ODo6Qm9vbGVhbjo6TmV3KCFhbGxvdyk7CiAgICAgdjg6OkhhbmRsZTx2 ODo6RnVuY3Rpb24+OjpDYXN0KHNsZWVwRnVuY3Rpb25IYW5kbGUpLT5DYWxsKHY4OjpPYmplY3Q6 Ok5ldygpLCAxLCBhcmd2KTsKIH0KIApJbmRleDogTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIExheW91dFRlc3RzL0NoYW5nZUxvZwkocmV2aXNpb24gNTU0ODcpCisrKyBMYXlv dXRUZXN0cy9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxMiBAQAorMjAxMC0w My0wMyAgSm9obiBBYmQtRWwtTWFsZWsgIDxqYW1AY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEZpeCBpbmNvcnJlY3Qgc2V0dXAg b2YgRGF0ZUV4dGVuc2lvbi4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTM1NzEwCisKKyAgICAgICAgKiBmYXN0L2RvbS9XaW5kb3cvcmVzb3VyY2VzL3Ns b3dfdW5sb2FkX2hhbmRsZXIxLmh0bWw6CisKIDIwMTAtMDMtMDMgIEFsZXhleSBQcm9za3VyeWFr b3YgIDxhcEBhcHBsZS5jb20+CiAKICAgICAgICAgTm90IHJldmlld2VkLgpJbmRleDogTGF5b3V0 VGVzdHMvZmFzdC9kb20vV2luZG93L3Jlc291cmNlcy9zbG93X3VubG9hZF9oYW5kbGVyMS5odG1s Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2Zhc3QvZG9tL1dpbmRvdy9yZXNvdXJjZXMvc2xv d191bmxvYWRfaGFuZGxlcjEuaHRtbAkocmV2aXNpb24gNTU0NzgpCisrKyBMYXlvdXRUZXN0cy9m YXN0L2RvbS9XaW5kb3cvcmVzb3VyY2VzL3Nsb3dfdW5sb2FkX2hhbmRsZXIxLmh0bWwJKHdvcmtp bmcgY29weSkKQEAgLTEsOCArMSwxMyBAQAogPGh0bWw+Cis8aGVhZD4KIDxzY3JpcHQ+Ci1mdW5j dGlvbiBwYXVzZShtaWxsaXNlY29uZHMpIHsKK3dpbmRvdy5hZGRFdmVudExpc3RlbmVyKCd1bmxv YWQnLCBub3BhdXNlMSwgZmFsc2UpOword2luZG93LmFkZEV2ZW50TGlzdGVuZXIoJ3VubG9hZCcs IG5vcGF1c2UyLCBmYWxzZSk7Cit3aW5kb3cuYWRkRXZlbnRMaXN0ZW5lcigndW5sb2FkJywgcGF1 c2UsIGZhbHNlKTsKKworZnVuY3Rpb24gcGF1c2UoKSB7CiAgICAgdmFyIG5vdyA9IG5ldyBEYXRl KCk7Ci0gICAgdmFyIGV4aXRUaW1lID0gbm93LmdldFRpbWUoKSArIG1pbGxpc2Vjb25kczsKKyAg ICB2YXIgZXhpdFRpbWUgPSBub3cuZ2V0VGltZSgpICsgMTAwMDA7CiAgICAgd2hpbGUgKHRydWUp IHsKICAgICAgICAgbm93ID0gbmV3IERhdGUoKTsKICAgICAgICAgaWYgKG5vdy5nZXRUaW1lKCkg PiBleGl0VGltZSkKQEAgLTEyLDcgKzE3LDI0IEBAIGZ1bmN0aW9uIHBhdXNlKG1pbGxpc2Vjb25k cykgewogICAgIGlmIChsYXlvdXRUZXN0Q29udHJvbGxlcikKICAgICAgICAgbGF5b3V0VGVzdENv bnRyb2xsZXIubm90aWZ5RG9uZSgpOwogfQorCitmdW5jdGlvbiBub3BhdXNlKCkgeworICAgIHRy eSB7CisgICAgICAgIHZhciB0aW1lMSA9IChuZXcgRGF0ZSgpKS5nZXRUaW1lKCk7CisgICAgfSBj YXRjaChlKSB7CisgICAgICAgIHBhcmVudC5kb2N1bWVudC5nZXRFbGVtZW50QnlJZCgicmVzdWx0 cyIpLmFwcGVuZENoaWxkKGRvY3VtZW50LmNyZWF0ZVRleHROb2RlKCJGQUlMIikpOworICAgICAg ICBpZiAobGF5b3V0VGVzdENvbnRyb2xsZXIpCisgICAgICAgICAgICBsYXlvdXRUZXN0Q29udHJv bGxlci5ub3RpZnlEb25lKCk7CisgICAgfQorfQorZnVuY3Rpb24gbm9wYXVzZTEoKSB7CisgICAg bm9wYXVzZSgpOworfQorCitmdW5jdGlvbiBub3BhdXNlMigpIHsKKyAgICBub3BhdXNlKCk7Cit9 CiA8L3NjcmlwdD4KLTxib2R5IG9udW5sb2FkPSJwYXVzZSgxMDAwMCk7Ij4KLTwvYm9keT4KKzwv aGVhZD4KKzxib2R5PjwvYm9keT4KIDwvaHRtbD4KXCBObyBuZXdsaW5lIGF0IGVuZCBvZiBmaWxl Cg==