35699 2010-03-03 13:43:33 -0800 [DRT] Add toggle on/off stub methods for Spatial Navigation in win, gtk and mac LayoutTestController class implementations 2010-03-05 08:42:02 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC All RESOLVED FIXED P2 Normal --- 18662 35705 1 tonikitoo tonikitoo oldest_to_newest 195738 0 tonikitoo 2010-03-03 13:43:33 -0800 After bug 18662 lands, setSpatialNavigationEnabled and friend methods will have to be added to the cross platform DRT files , so we can run them. i've added it to Qt's DRT, which does not inherit from the cross platform one - see bug 33715. this bug is about adding the stubs so other ports can implement them properly. (i have a patch for gtk's already) 195740 1 49941 tonikitoo 2010-03-03 13:47:53 -0800 Created attachment 49941 (landed in r55582) patch 0.1 196453 2 49941 tonikitoo 2010-03-05 08:41:44 -0800 Comment on attachment 49941 (landed in r55582) patch 0.1 clearing flags. patch landed. thx for reviewing kenneth 49941 2010-03-03 13:47:53 -0800 2010-03-05 08:41:44 -0800 (landed in r55582) patch 0.1 0001-Add-toggle-on-off-stub-methods-for-Spatial-Navigatio.patch text/plain 7615 tonikitoo RnJvbSAxYThkOGIxNGJjNzZlYzE2NGEwMjA3ZWQzYWVlMzg1NDBlNmYyNTdiIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBbnRvbmlvIEdvbWVzIDx0b25pa2l0b29Ad2Via2l0Lm9yZz4K RGF0ZTogVHVlLCAyMyBGZWIgMjAxMCAxMTo1MjoyOCAtMDQwMApTdWJqZWN0OiBbUEFUQ0hdIEFk ZCB0b2dnbGUgb24vb2ZmIHN0dWIgbWV0aG9kcyBmb3IgU3BhdGlhbCBOYXZpZ2F0aW9uIGluIHdp biwgZ3RrIGFuZCBtYWMgTGF5b3V0VGVzdENvbnRyb2xsZXIgY2xhc3MgaW1wbGVtZW50YXRpb25z LgogaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM1Njk5CgpSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KUGF0Y2ggYnkgQW50b25pbyBHb21lcyA8dG9uaWtpdG9vQHdl YmtpdC5vcmc+CgoqIER1bXBSZW5kZXJUcmVlL0xheW91dFRlc3RDb250cm9sbGVyLmNwcDoKKHNl dFNwYXRpYWxOYXZpZ2F0aW9uRW5hYmxlZENhbGxiYWNrKToKKExheW91dFRlc3RDb250cm9sbGVy OjpzdGF0aWNGdW5jdGlvbnMpOgoqIER1bXBSZW5kZXJUcmVlL0xheW91dFRlc3RDb250cm9sbGVy Lmg6CiogRHVtcFJlbmRlclRyZWUvZ3RrL0xheW91dFRlc3RDb250cm9sbGVyR3RrLmNwcDoKKExh eW91dFRlc3RDb250cm9sbGVyOjpzZXRTcGF0aWFsTmF2aWdhdGlvbkVuYWJsZWQpOgoqIER1bXBS ZW5kZXJUcmVlL21hYy9MYXlvdXRUZXN0Q29udHJvbGxlck1hYy5tbToKKExheW91dFRlc3RDb250 cm9sbGVyOjpzZXRTcGF0aWFsTmF2aWdhdGlvbkVuYWJsZWQpOgoqIER1bXBSZW5kZXJUcmVlL3dp bi9MYXlvdXRUZXN0Q29udHJvbGxlcldpbi5jcHA6CihMYXlvdXRUZXN0Q29udHJvbGxlcjo6c2V0 U3BhdGlhbE5hdmlnYXRpb25FbmFibGVkKToKLS0tCiBXZWJLaXRUb29scy9DaGFuZ2VMb2cgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICB8ICAgMjAgKysrKysrKysrKysrKysrKysrKysKIC4u Li9EdW1wUmVuZGVyVHJlZS9MYXlvdXRUZXN0Q29udHJvbGxlci5jcHAgICAgICAgIHwgICAxMyAr KysrKysrKysrKysrCiBXZWJLaXRUb29scy9EdW1wUmVuZGVyVHJlZS9MYXlvdXRUZXN0Q29udHJv bGxlci5oICB8ICAgIDEgKwogLi4uL0R1bXBSZW5kZXJUcmVlL2d0ay9MYXlvdXRUZXN0Q29udHJv bGxlckd0ay5jcHAgfCAgICA1ICsrKysrCiAuLi4vRHVtcFJlbmRlclRyZWUvbWFjL0xheW91dFRl c3RDb250cm9sbGVyTWFjLm1tICB8ICAgIDUgKysrKysKIC4uLi9EdW1wUmVuZGVyVHJlZS93aW4v TGF5b3V0VGVzdENvbnRyb2xsZXJXaW4uY3BwIHwgICAgNSArKysrKwogNiBmaWxlcyBjaGFuZ2Vk LCA0OSBpbnNlcnRpb25zKCspLCAwIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL1dlYktpdFRv b2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxvZwppbmRleCA3NTM4YzdjLi4wYThl NzYwIDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0VG9vbHMv Q2hhbmdlTG9nCkBAIC0zLDYgKzMsMjYgQEAKICAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCiAgICAgICAgIFBhdGNoIGJ5IEFudG9uaW8gR29tZXMgPHRvbmlraXRvb0B3ZWJraXQu b3JnPgogCisgICAgICAgIEFkZCB0b2dnbGUgb24vb2ZmIHN0dWIgbWV0aG9kcyBmb3IgU3BhdGlh bCBOYXZpZ2F0aW9uIGluIHdpbiwgZ3RrIGFuZCBtYWMgTGF5b3V0VGVzdENvbnRyb2xsZXIgY2xh c3MgaW1wbGVtZW50YXRpb25zLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MzU2OTkKKworICAgICAgICAqIER1bXBSZW5kZXJUcmVlL0xheW91dFRlc3RD b250cm9sbGVyLmNwcDoKKyAgICAgICAgKHNldFNwYXRpYWxOYXZpZ2F0aW9uRW5hYmxlZENhbGxi YWNrKToKKyAgICAgICAgKExheW91dFRlc3RDb250cm9sbGVyOjpzdGF0aWNGdW5jdGlvbnMpOgor ICAgICAgICAqIER1bXBSZW5kZXJUcmVlL0xheW91dFRlc3RDb250cm9sbGVyLmg6CisgICAgICAg ICogRHVtcFJlbmRlclRyZWUvZ3RrL0R1bXBSZW5kZXJUcmVlLmNwcDoKKyAgICAgICAgKiBEdW1w UmVuZGVyVHJlZS9ndGsvTGF5b3V0VGVzdENvbnRyb2xsZXJHdGsuY3BwOgorICAgICAgICAoTGF5 b3V0VGVzdENvbnRyb2xsZXI6OnNldFNwYXRpYWxOYXZpZ2F0aW9uRW5hYmxlZCk6CisgICAgICAg ICogRHVtcFJlbmRlclRyZWUvbWFjL0xheW91dFRlc3RDb250cm9sbGVyTWFjLm1tOgorICAgICAg ICAoTGF5b3V0VGVzdENvbnRyb2xsZXI6OnNldFNwYXRpYWxOYXZpZ2F0aW9uRW5hYmxlZCk6Cisg ICAgICAgICogRHVtcFJlbmRlclRyZWUvd2luL0xheW91dFRlc3RDb250cm9sbGVyV2luLmNwcDoK KyAgICAgICAgKExheW91dFRlc3RDb250cm9sbGVyOjpzZXRTcGF0aWFsTmF2aWdhdGlvbkVuYWJs ZWQpOgorCisyMDEwLTAyLTE4ICBBbnRvbmlvIEdvbWVzICA8dG9uaWtpdG9vQHdlYmtpdC5vcmc+ CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisgICAgICAgIFBhdGNoIGJ5 IEFudG9uaW8gR29tZXMgPHRvbmlraXRvb0B3ZWJraXQub3JnPgorCiAgICAgICAgIEFkZCB0b2dn bGUgb24vb2ZmIG1lY2hhbmlzbSBmb3IgU3BhdGlhbCBOYXZpZ2F0aW9uIGluIFF0TGF1bmNoZXIu CiAKICAgICAgICAgKiBRdExhdW5jaGVyL21haW4uY3BwOgpkaWZmIC0tZ2l0IGEvV2ViS2l0VG9v bHMvRHVtcFJlbmRlclRyZWUvTGF5b3V0VGVzdENvbnRyb2xsZXIuY3BwIGIvV2ViS2l0VG9vbHMv RHVtcFJlbmRlclRyZWUvTGF5b3V0VGVzdENvbnRyb2xsZXIuY3BwCmluZGV4IDBlYjU1M2UuLjQz YTdhNzMgMTAwNjQ0Ci0tLSBhL1dlYktpdFRvb2xzL0R1bXBSZW5kZXJUcmVlL0xheW91dFRlc3RD b250cm9sbGVyLmNwcAorKysgYi9XZWJLaXRUb29scy9EdW1wUmVuZGVyVHJlZS9MYXlvdXRUZXN0 Q29udHJvbGxlci5jcHAKQEAgLTkxNCw2ICs5MTQsMTggQEAgc3RhdGljIEpTVmFsdWVSZWYgc2V0 WFNTQXVkaXRvckVuYWJsZWRDYWxsYmFjayhKU0NvbnRleHRSZWYgY29udGV4dCwgSlNPYmplY3RS ZWYKICAgICByZXR1cm4gSlNWYWx1ZU1ha2VVbmRlZmluZWQoY29udGV4dCk7CiB9CiAKK3N0YXRp YyBKU1ZhbHVlUmVmIHNldFNwYXRpYWxOYXZpZ2F0aW9uRW5hYmxlZENhbGxiYWNrKEpTQ29udGV4 dFJlZiBjb250ZXh0LCBKU09iamVjdFJlZiBmdW5jdGlvbiwgSlNPYmplY3RSZWYgdGhpc09iamVj dCwgc2l6ZV90IGFyZ3VtZW50Q291bnQsIGNvbnN0IEpTVmFsdWVSZWYgYXJndW1lbnRzW10sIEpT VmFsdWVSZWYqIGV4Y2VwdGlvbikKK3sKKyAgICBpZiAoYXJndW1lbnRDb3VudCA8IDEpCisgICAg ICAgIHJldHVybiBKU1ZhbHVlTWFrZVVuZGVmaW5lZChjb250ZXh0KTsKKworICAgIExheW91dFRl c3RDb250cm9sbGVyKiBjb250cm9sbGVyID0gc3RhdGljX2Nhc3Q8TGF5b3V0VGVzdENvbnRyb2xs ZXIqPihKU09iamVjdEdldFByaXZhdGUodGhpc09iamVjdCkpOworICAgIGNvbnRyb2xsZXItPnNl dFNwYXRpYWxOYXZpZ2F0aW9uRW5hYmxlZChKU1ZhbHVlVG9Cb29sZWFuKGNvbnRleHQsIGFyZ3Vt ZW50c1swXSkpOworCisgICAgcmV0dXJuIEpTVmFsdWVNYWtlVW5kZWZpbmVkKGNvbnRleHQpOwor fQorCisKIHN0YXRpYyBKU1ZhbHVlUmVmIHNldEZyYW1lU2V0RmxhdHRlbmluZ0VuYWJsZWRDYWxs YmFjayhKU0NvbnRleHRSZWYgY29udGV4dCwgSlNPYmplY3RSZWYgZnVuY3Rpb24sIEpTT2JqZWN0 UmVmIHRoaXNPYmplY3QsIHNpemVfdCBhcmd1bWVudENvdW50LCBjb25zdCBKU1ZhbHVlUmVmIGFy Z3VtZW50c1tdLCBKU1ZhbHVlUmVmKiBleGNlcHRpb24pCiB7CiAgICAgLy8gSGFzIG1hYyAmIHdp bmRvd3MgaW1wbGVtZW50YXRpb24KQEAgLTE0NDEsNiArMTQ1Myw3IEBAIEpTU3RhdGljRnVuY3Rp b24qIExheW91dFRlc3RDb250cm9sbGVyOjpzdGF0aWNGdW5jdGlvbnMoKQogICAgICAgICB7ICJz ZXRQb3B1cEJsb2NraW5nRW5hYmxlZCIsIHNldFBvcHVwQmxvY2tpbmdFbmFibGVkQ2FsbGJhY2ss IGtKU1Byb3BlcnR5QXR0cmlidXRlUmVhZE9ubHkgfCBrSlNQcm9wZXJ0eUF0dHJpYnV0ZURvbnRE ZWxldGUgfSwKICAgICAgICAgeyAic2V0UHJpdmF0ZUJyb3dzaW5nRW5hYmxlZCIsIHNldFByaXZh dGVCcm93c2luZ0VuYWJsZWRDYWxsYmFjaywga0pTUHJvcGVydHlBdHRyaWJ1dGVSZWFkT25seSB8 IGtKU1Byb3BlcnR5QXR0cmlidXRlRG9udERlbGV0ZSB9LAogICAgICAgICB7ICJzZXRYU1NBdWRp dG9yRW5hYmxlZCIsIHNldFhTU0F1ZGl0b3JFbmFibGVkQ2FsbGJhY2ssIGtKU1Byb3BlcnR5QXR0 cmlidXRlUmVhZE9ubHkgfCBrSlNQcm9wZXJ0eUF0dHJpYnV0ZURvbnREZWxldGUgfSwKKyAgICAg ICAgeyAic2V0U3BhdGlhbE5hdmlnYXRpb25FbmFibGVkIiwgc2V0U3BhdGlhbE5hdmlnYXRpb25F bmFibGVkQ2FsbGJhY2ssIGtKU1Byb3BlcnR5QXR0cmlidXRlUmVhZE9ubHkgfCBrSlNQcm9wZXJ0 eUF0dHJpYnV0ZURvbnREZWxldGUgfSwKICAgICAgICAgeyAic2V0RnJhbWVTZXRGbGF0dGVuaW5n RW5hYmxlZCIsIHNldEZyYW1lU2V0RmxhdHRlbmluZ0VuYWJsZWRDYWxsYmFjaywga0pTUHJvcGVy dHlBdHRyaWJ1dGVSZWFkT25seSB8IGtKU1Byb3BlcnR5QXR0cmlidXRlRG9udERlbGV0ZSB9LAog ICAgICAgICB7ICJzZXRTZWxlY3RUcmFpbGluZ1doaXRlc3BhY2VFbmFibGVkIiwgc2V0U2VsZWN0 VHJhaWxpbmdXaGl0ZXNwYWNlRW5hYmxlZENhbGxiYWNrLCBrSlNQcm9wZXJ0eUF0dHJpYnV0ZVJl YWRPbmx5IHwga0pTUHJvcGVydHlBdHRyaWJ1dGVEb250RGVsZXRlIH0sCiAgICAgICAgIHsgInNl dFNtYXJ0SW5zZXJ0RGVsZXRlRW5hYmxlZCIsIHNldFNtYXJ0SW5zZXJ0RGVsZXRlRW5hYmxlZENh bGxiYWNrLCBrSlNQcm9wZXJ0eUF0dHJpYnV0ZVJlYWRPbmx5IHwga0pTUHJvcGVydHlBdHRyaWJ1 dGVEb250RGVsZXRlIH0sCmRpZmYgLS1naXQgYS9XZWJLaXRUb29scy9EdW1wUmVuZGVyVHJlZS9M YXlvdXRUZXN0Q29udHJvbGxlci5oIGIvV2ViS2l0VG9vbHMvRHVtcFJlbmRlclRyZWUvTGF5b3V0 VGVzdENvbnRyb2xsZXIuaAppbmRleCA5ODc2NWQ4Li4xOWEwM2EzIDEwMDY0NAotLS0gYS9XZWJL aXRUb29scy9EdW1wUmVuZGVyVHJlZS9MYXlvdXRUZXN0Q29udHJvbGxlci5oCisrKyBiL1dlYktp dFRvb2xzL0R1bXBSZW5kZXJUcmVlL0xheW91dFRlc3RDb250cm9sbGVyLmgKQEAgLTkyLDYgKzky LDcgQEAgcHVibGljOgogICAgIHZvaWQgc2V0VXNlclN0eWxlU2hlZXRMb2NhdGlvbihKU1N0cmlu Z1JlZiBwYXRoKTsKICAgICB2b2lkIHNldFhTU0F1ZGl0b3JFbmFibGVkKGJvb2wgZmxhZyk7CiAg ICAgdm9pZCBzZXRGcmFtZVNldEZsYXR0ZW5pbmdFbmFibGVkKGJvb2wgZW5hYmxlKTsKKyAgICB2 b2lkIHNldFNwYXRpYWxOYXZpZ2F0aW9uRW5hYmxlZChib29sIGVuYWJsZSk7CiAKICAgICB2b2lk IHdhaXRGb3JQb2xpY3lEZWxlZ2F0ZSgpOwogICAgIHNpemVfdCB3ZWJIaXN0b3J5SXRlbUNvdW50 KCk7CmRpZmYgLS1naXQgYS9XZWJLaXRUb29scy9EdW1wUmVuZGVyVHJlZS9ndGsvTGF5b3V0VGVz dENvbnRyb2xsZXJHdGsuY3BwIGIvV2ViS2l0VG9vbHMvRHVtcFJlbmRlclRyZWUvZ3RrL0xheW91 dFRlc3RDb250cm9sbGVyR3RrLmNwcAppbmRleCBlNDA1NzAyLi45YjE0YWM0IDEwMDY0NAotLS0g YS9XZWJLaXRUb29scy9EdW1wUmVuZGVyVHJlZS9ndGsvTGF5b3V0VGVzdENvbnRyb2xsZXJHdGsu Y3BwCisrKyBiL1dlYktpdFRvb2xzL0R1bXBSZW5kZXJUcmVlL2d0ay9MYXlvdXRUZXN0Q29udHJv bGxlckd0ay5jcHAKQEAgLTMzOSw2ICszMzksMTEgQEAgdm9pZCBMYXlvdXRUZXN0Q29udHJvbGxl cjo6c2V0RnJhbWVTZXRGbGF0dGVuaW5nRW5hYmxlZChib29sIGZsYWcpCiAgICAgLy8gRklYTUU6 IGltcGxlbWVudAogfQogCit2b2lkIExheW91dFRlc3RDb250cm9sbGVyOjpzZXRTcGF0aWFsTmF2 aWdhdGlvbkVuYWJsZWQoYm9vbCBmbGFnKQoreworICAgIC8vIEZJWE1FOiBpbXBsZW1lbnQKK30K Kwogdm9pZCBMYXlvdXRUZXN0Q29udHJvbGxlcjo6c2V0QWxsb3dVbml2ZXJzYWxBY2Nlc3NGcm9t RmlsZVVSTHMoYm9vbCBmbGFnKQogewogICAgIFdlYktpdFdlYlZpZXcqIHZpZXcgPSB3ZWJraXRf d2ViX2ZyYW1lX2dldF93ZWJfdmlldyhtYWluRnJhbWUpOwpkaWZmIC0tZ2l0IGEvV2ViS2l0VG9v bHMvRHVtcFJlbmRlclRyZWUvbWFjL0xheW91dFRlc3RDb250cm9sbGVyTWFjLm1tIGIvV2ViS2l0 VG9vbHMvRHVtcFJlbmRlclRyZWUvbWFjL0xheW91dFRlc3RDb250cm9sbGVyTWFjLm1tCmluZGV4 IDU3ZGYwNzEuLmUzZTA3MjkgMTAwNjQ0Ci0tLSBhL1dlYktpdFRvb2xzL0R1bXBSZW5kZXJUcmVl L21hYy9MYXlvdXRUZXN0Q29udHJvbGxlck1hYy5tbQorKysgYi9XZWJLaXRUb29scy9EdW1wUmVu ZGVyVHJlZS9tYWMvTGF5b3V0VGVzdENvbnRyb2xsZXJNYWMubW0KQEAgLTMyOSw2ICszMjksMTEg QEAgdm9pZCBMYXlvdXRUZXN0Q29udHJvbGxlcjo6c2V0RnJhbWVTZXRGbGF0dGVuaW5nRW5hYmxl ZChib29sIGVuYWJsZWQpCiAgICAgW1tbbWFpbkZyYW1lIHdlYlZpZXddIHByZWZlcmVuY2VzXSBz ZXRGcmFtZVNldEZsYXR0ZW5pbmdFbmFibGVkOmVuYWJsZWRdOwogfQogCit2b2lkIExheW91dFRl c3RDb250cm9sbGVyOjpzZXRTcGF0aWFsTmF2aWdhdGlvbkVuYWJsZWQoYm9vbCBlbmFibGVkKQor eworICAgIC8vIEZJWE1FOiBJbXBsZW1lbnQgZm9yIFNwYXRpYWxOYXZpZ2F0aW9uIGxheW91dCB0 ZXN0cy4KK30KKwogdm9pZCBMYXlvdXRUZXN0Q29udHJvbGxlcjo6c2V0QWxsb3dVbml2ZXJzYWxB Y2Nlc3NGcm9tRmlsZVVSTHMoYm9vbCBlbmFibGVkKQogewogICAgIFtbW21haW5GcmFtZSB3ZWJW aWV3XSBwcmVmZXJlbmNlc10gc2V0QWxsb3dVbml2ZXJzYWxBY2Nlc3NGcm9tRmlsZVVSTHM6ZW5h YmxlZF07CmRpZmYgLS1naXQgYS9XZWJLaXRUb29scy9EdW1wUmVuZGVyVHJlZS93aW4vTGF5b3V0 VGVzdENvbnRyb2xsZXJXaW4uY3BwIGIvV2ViS2l0VG9vbHMvRHVtcFJlbmRlclRyZWUvd2luL0xh eW91dFRlc3RDb250cm9sbGVyV2luLmNwcAppbmRleCBiNDEyNWJmLi5mODQ0OWY0IDEwMDY0NAot LS0gYS9XZWJLaXRUb29scy9EdW1wUmVuZGVyVHJlZS93aW4vTGF5b3V0VGVzdENvbnRyb2xsZXJX aW4uY3BwCisrKyBiL1dlYktpdFRvb2xzL0R1bXBSZW5kZXJUcmVlL3dpbi9MYXlvdXRUZXN0Q29u dHJvbGxlcldpbi5jcHAKQEAgLTM4OSw2ICszODksMTEgQEAgdm9pZCBMYXlvdXRUZXN0Q29udHJv bGxlcjo6c2V0RnJhbWVTZXRGbGF0dGVuaW5nRW5hYmxlZChib29sIGVuYWJsZWQpCiAgICAgcHJl ZnNQcml2YXRlLT5zZXRGcmFtZVNldEZsYXR0ZW5pbmdFbmFibGVkKGVuYWJsZWQpOwogfQogCit2 b2lkIExheW91dFRlc3RDb250cm9sbGVyOjpzZXRTcGF0aWFsTmF2aWdhdGlvbkVuYWJsZWQoYm9v bCBlbmFibGVkKQoreworICAgIC8vIEZJWE1FOiBJbXBsZW1lbnQgZm9yIFNwYXRpYWxOYXZpZ2F0 aW9uIGxheW91dCB0ZXN0cy4KK30KKwogdm9pZCBMYXlvdXRUZXN0Q29udHJvbGxlcjo6c2V0QWxs b3dVbml2ZXJzYWxBY2Nlc3NGcm9tRmlsZVVSTHMoYm9vbCBlbmFibGVkKQogewogICAgIENPTVB0 cjxJV2ViVmlldz4gd2ViVmlldzsKLS0gCjEuNi4wLjQKCg==