35692 2010-03-03 11:05:22 -0800 Crash when calling abort() on an XHR while in a windowless WebView 2010-03-03 11:34:47 -0800 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) Mac All RESOLVED FIXED InRadar P1 Normal --- 1 ap ap oldest_to_newest 195671 0 ap 2010-03-03 11:05:22 -0800 -[WebAuthenticationPanel runAsModalDialogWithChallenge:] doesn't retain the challenge, unlike -[WebAuthenticationPanel runAsSheetOnWindow:withChallenge:]. But there is no real difference between these, because timers can fire behind either. 195672 1 ap 2010-03-03 11:05:58 -0800 <rdar://problem/7703622> 195675 2 49922 ap 2010-03-03 11:08:47 -0800 Created attachment 49922 proposed fix 195681 3 49922 timothy 2010-03-03 11:18:16 -0800 Comment on attachment 49922 proposed fix You have two ChangeLog entries. 195682 4 49922 oliver 2010-03-03 11:21:05 -0800 Comment on attachment 49922 proposed fix can you use a retainptr for this instead of manual refcounting? kthxbai 195690 5 ap 2010-03-03 11:34:47 -0800 Committed <http://trac.webkit.org/changeset/55470>. > can you use a retainptr for this instead of manual refcounting? kthxbai No, it's a .m file. 49922 2010-03-03 11:08:47 -0800 2010-03-03 11:21:05 -0800 proposed fix XHRAbort.txt text/plain 1760 ap SW5kZXg6IFdlYktpdC9tYWMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdC9tYWMvQ2hh bmdlTG9nCShyZXZpc2lvbiA1NTQ2OCkKKysrIFdlYktpdC9tYWMvQ2hhbmdlTG9nCSh3b3JraW5n IGNvcHkpCkBAIC0xLDMgKzEsMjIgQEAKKzIwMTAtMDMtMDMgIEFsZXhleSBQcm9za3VyeWFrb3Yg IDxhcEBhcHBsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM1NjkyCisg ICAgICAgIDxyZGFyOi8vcHJvYmxlbS83NzAzNjIyPiBDcmFzaCB3aGVuIGNhbGxpbmcgYWJvcnQo KSBvbiBhbiBYSFIgd2hpbGUgaW4gYSB3aW5kb3dsZXNzIFdlYlZpZXcKKworICAgICAgICAqIFBh bmVscy9XZWJBdXRoZW50aWNhdGlvblBhbmVsLm06ICgtW1dlYkF1dGhlbnRpY2F0aW9uUGFuZWwg cnVuQXNNb2RhbERpYWxvZ1dpdGhDaGFsbGVuZ2U6XSk6CisgICAgICAgIFJldGFpbiB0aGUgY2hh bGxlbmdlLCBqdXN0IGxpa2UgaXQncyBkb25lIGZvciBzaGVldC4KKworMjAxMC0wMy0wMyAgQWxl eGV5IFByb3NrdXJ5YWtvdiAgPGFwQGFwcGxlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBOZWVkIGEgc2hvcnQgZGVzY3JpcHRpb24gYW5kIGJ1 ZyBVUkwgKE9PUFMhKQorCisgICAgICAgICogUGFuZWxzL1dlYkF1dGhlbnRpY2F0aW9uUGFuZWwu bToKKyAgICAgICAgKC1bV2ViQXV0aGVudGljYXRpb25QYW5lbCBydW5Bc01vZGFsRGlhbG9nV2l0 aENoYWxsZW5nZTpdKToKKwogMjAxMC0wMy0wMiAgRXJpYyBVaHJoYW5lICA8ZXJpY3VAY2hyb21p dW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERhdmlkIExldmluLgpJbmRleDogV2ViS2l0 L21hYy9QYW5lbHMvV2ViQXV0aGVudGljYXRpb25QYW5lbC5tCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktp dC9tYWMvUGFuZWxzL1dlYkF1dGhlbnRpY2F0aW9uUGFuZWwubQkocmV2aXNpb24gNTU0MzEpCisr KyBXZWJLaXQvbWFjL1BhbmVscy9XZWJBdXRoZW50aWNhdGlvblBhbmVsLm0JKHdvcmtpbmcgY29w eSkKQEAgLTIxOCw3ICsyMTgsOSBAQAogLSAodm9pZClydW5Bc01vZGFsRGlhbG9nV2l0aENoYWxs ZW5nZTooTlNVUkxBdXRoZW50aWNhdGlvbkNoYWxsZW5nZSAqKWNoYWxsCiB7CiAgICAgW3NlbGYg c2V0VXBGb3JDaGFsbGVuZ2U6Y2hhbGxdOworCiAgICAgdXNpbmdTaGVldCA9IEZBTFNFOworICAg IFtjaGFsbCByZXRhaW5dOwogICAgIE5TVVJMQ3JlZGVudGlhbCAqY3JlZGVudGlhbCA9IG5pbDsK IAogICAgIGlmIChbW05TQXBwbGljYXRpb24gc2hhcmVkQXBwbGljYXRpb25dIHJ1bk1vZGFsRm9y V2luZG93OnBhbmVsXSA9PSAwKSB7CkBAIC0yMjcsNiArMjI5LDcgQEAKIAogICAgIFtjYWxsYmFj ayBwZXJmb3JtU2VsZWN0b3I6c2VsZWN0b3Igd2l0aE9iamVjdDpjaGFsbCB3aXRoT2JqZWN0OmNy ZWRlbnRpYWxdOwogICAgIFtjcmVkZW50aWFsIHJlbGVhc2VdOworICAgIFtjaGFsbCByZWxlYXNl XTsKIH0KIAogLSAodm9pZClydW5Bc1NoZWV0T25XaW5kb3c6KE5TV2luZG93ICopd2luZG93IHdp dGhDaGFsbGVuZ2U6KE5TVVJMQXV0aGVudGljYXRpb25DaGFsbGVuZ2UgKiljaGFsbAo=