35666 2010-03-03 03:50:51 -0800 [Gtk]: assertion triggered when geolocation getCurrentPosition without an option argument. 2010-03-03 05:30:59 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 0 a.renevier webkit-unassigned commit-queue oldest_to_newest 195468 0 a.renevier 2010-03-03 03:50:51 -0800 Hi, when getCurrentPosition is called without an option argument (or with an object that don't have a timeout property), PositionOptions does not have a timeout (m_hasTimeout is false). Currently in GeolocationServiceGtk::startUpdating, we have following code: timeout = options->timeout(); without checking if options->hasTimeout(). We should check if options has a timeout before trying to get its value. 195470 1 49897 a.renevier 2010-03-03 03:54:01 -0800 Created attachment 49897 patch v1 195488 2 49897 gustavo 2010-03-03 05:14:00 -0800 Comment on attachment 49897 patch v1 Looks sane, from looking at the PositionOptions code. 195491 3 49897 commit-queue 2010-03-03 05:30:55 -0800 Comment on attachment 49897 patch v1 Clearing flags on attachment: 49897 Committed r55459: <http://trac.webkit.org/changeset/55459> 195492 4 commit-queue 2010-03-03 05:30:59 -0800 All reviewed patches have been landed. Closing bug. 49897 2010-03-03 03:54:01 -0800 2010-03-03 05:30:55 -0800 patch v1 35666.patch text/plain 1308 a.renevier ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg MjdmYmFjYy4uMGFmNjdmNyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAxMC0wMy0wMyAgQXJubyBSZW5ldmll ciAgPGFybm9AcmVuZXZpZXIubmV0PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIFtHdGtdOiBhc3NlcnRpb24gdHJpZ2dlcmVkIHdoZW4gZ2VvbG9jYXRp b24gZ2V0Q3VycmVudFBvc2l0aW9uIHdpdGhvdXQgYW4gb3B0aW9uIGFyZ3VtZW50LgorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzU2NjYKKworICAgICAg ICAqIHBsYXRmb3JtL2d0ay9HZW9sb2NhdGlvblNlcnZpY2VHdGsuY3BwOgorICAgICAgICAoV2Vi Q29yZTo6R2VvbG9jYXRpb25TZXJ2aWNlR3RrOjpzdGFydFVwZGF0aW5nKToKKwogMjAxMC0wMi0y MyAgQXJubyBSZW5ldmllciAgPGFybm9AcmVuZXZpZXIubmV0PgogCiAgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9wbGF0Zm9ybS9ndGsvR2Vv bG9jYXRpb25TZXJ2aWNlR3RrLmNwcCBiL1dlYkNvcmUvcGxhdGZvcm0vZ3RrL0dlb2xvY2F0aW9u U2VydmljZUd0ay5jcHAKaW5kZXggNTljOTUzOC4uMjI2OWNlMCAxMDA2NDQKLS0tIGEvV2ViQ29y ZS9wbGF0Zm9ybS9ndGsvR2VvbG9jYXRpb25TZXJ2aWNlR3RrLmNwcAorKysgYi9XZWJDb3JlL3Bs YXRmb3JtL2d0ay9HZW9sb2NhdGlvblNlcnZpY2VHdGsuY3BwCkBAIC05NCw3ICs5NCw4IEBAIGJv b2wgR2VvbG9jYXRpb25TZXJ2aWNlR3RrOjpzdGFydFVwZGF0aW5nKFBvc2l0aW9uT3B0aW9ucyog b3B0aW9ucykKICAgICBpbnQgdGltZW91dCA9IDA7CiAgICAgaWYgKG9wdGlvbnMpIHsKICAgICAg ICAgYWNjdXJhY3lMZXZlbCA9IG9wdGlvbnMtPmVuYWJsZUhpZ2hBY2N1cmFjeSgpID8gR0VPQ0xV RV9BQ0NVUkFDWV9MRVZFTF9ERVRBSUxFRCA6IEdFT0NMVUVfQUNDVVJBQ1lfTEVWRUxfTE9DQUxJ VFk7Ci0gICAgICAgIHRpbWVvdXQgPSBvcHRpb25zLT50aW1lb3V0KCk7CisgICAgICAgIGlmIChv cHRpb25zLT5oYXNUaW1lb3V0KCkpCisgICAgICAgICAgICB0aW1lb3V0ID0gb3B0aW9ucy0+dGlt ZW91dCgpOwogICAgIH0KIAogICAgIGdib29sZWFuIHJlc3VsdCA9IGdlb2NsdWVfbWFzdGVyX2Ns aWVudF9zZXRfcmVxdWlyZW1lbnRzKGNsaWVudCwgYWNjdXJhY3lMZXZlbCwgdGltZW91dCwK