35629 2010-03-02 22:18:09 -0800 [Chromium] Should remove paddings of Win/Linux chromium's buttons 2010-03-26 17:36:03 -0700 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 1 hamaji webkit-unassigned arv hyatt ojan oldest_to_newest 195384 0 hamaji 2010-03-02 22:18:09 -0800 Per discussion on Bug 35231 and http://code.google.com/p/chromium/issues/detail?id=1437 , let's remove the extra paddings which causes web compatibility issues. 195386 1 49878 hamaji 2010-03-02 22:20:21 -0800 Created attachment 49878 Patch v1 195387 2 hamaji 2010-03-02 22:22:30 -0800 > Created an attachment (id=49878) [details] > Patch v1 Or, should we remove buttonInternalPadding* even from RenderTheme ? David, could you give me your suggestion if you have any opinion about this? 195388 3 49878 hamaji 2010-03-02 22:25:28 -0800 Comment on attachment 49878 Patch v1 cq- because this patch will break bunch of chromium's layout tests so I need to communicate with WebKit sheriff before I land this patch. 196780 4 49878 eric 2010-03-05 16:25:23 -0800 Comment on attachment 49878 Patch v1 OK. 196813 5 ojan 2010-03-05 16:55:35 -0800 To give context for this. We've found a number of sites whose layout breaks due to this extra internal padding. We originally added this to match Firefox since padding:0 buttons look pretty crappy without having any internal padding. Chromium would like to run an experiment removing the padding and see if there's any fallout. We're hoping that not many sites use padding:0. If it turns out they do, then we'll probably revert this change. If they don't, we should consider making Safari Win also not having internal button padding. Some sites that break with the internal padding: http://topkayaker.net/TopKayakerShop/ http://www.qotsa.com/ http://catalinaexpress.com/ http://www.dekalb.k12.ga.us/ http://balkanweb.com/poll/pollsys/ http://www.indianmasala.com/ 197487 6 49878 hamaji 2010-03-09 00:24:12 -0800 Comment on attachment 49878 Patch v1 Clearing flags on attachment: 49878 Committed r55714: <http://trac.webkit.org/changeset/55714> 197488 7 hamaji 2010-03-09 00:24:21 -0800 All reviewed patches have been landed. Closing bug. 204875 8 arv 2010-03-26 17:36:03 -0700 *** Bug 31703 has been marked as a duplicate of this bug. *** 49878 2010-03-02 22:20:21 -0800 2010-03-09 00:24:12 -0800 Patch v1 bug-35629-20100303152020.patch text/plain 2296 hamaji ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg MDUyOGQ4Ny4uNDIwMDdmMiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAxMC0wMy0wMiAgU2hpbmljaGlybyBI YW1hamkgIDxoYW1hamlAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFtDaHJvbWl1bV0gU2hvdWxkIHJlbW92ZSBwYWRkaW5ncyBv ZiBXaW4vTGludXggY2hyb21pdW0ncyBidXR0b25zCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zNTYyOQorCisgICAgICAgIE5vIG5ldyB0ZXN0cywgYnV0 IHdlIG1heSBuZWVkIHRvIHJlYmFzZWxpbmUgYnVuY2ggb2YgZXhwZWN0YXRpb24KKyAgICAgICAg aW1hZ2VzIGluIGNocm9taXVtJ3MgdHJlZS4KKworICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJU aGVtZUNocm9taXVtU2tpYS5jcHA6CisgICAgICAgICogcmVuZGVyaW5nL1JlbmRlclRoZW1lQ2hy b21pdW1Ta2lhLmg6CisKIDIwMTAtMDMtMDIgIEJyYWR5IEVpZHNvbiAgPGJlaWRzb25AYXBwbGUu Y29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IFNhbSBXZWluaWcuCmRpZmYgLS1naXQgYS9XZWJD b3JlL3JlbmRlcmluZy9SZW5kZXJUaGVtZUNocm9taXVtU2tpYS5jcHAgYi9XZWJDb3JlL3JlbmRl cmluZy9SZW5kZXJUaGVtZUNocm9taXVtU2tpYS5jcHAKaW5kZXggN2QzYmNlYy4uMmJmYjlkZiAx MDA2NDQKLS0tIGEvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVGhlbWVDaHJvbWl1bVNraWEuY3Bw CisrKyBiL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclRoZW1lQ2hyb21pdW1Ta2lhLmNwcApAQCAt NzIxLDI2ICs3MjEsNiBAQCBpbnQgUmVuZGVyVGhlbWVDaHJvbWl1bVNraWE6OnBvcHVwSW50ZXJu YWxQYWRkaW5nQm90dG9tKFJlbmRlclN0eWxlKiBzdHlsZSkgY29ucwogICAgIHJldHVybiBtZW51 TGlzdEludGVybmFsUGFkZGluZyhzdHlsZSwgQm90dG9tUGFkZGluZyk7CiB9CiAKLWludCBSZW5k ZXJUaGVtZUNocm9taXVtU2tpYTo6YnV0dG9uSW50ZXJuYWxQYWRkaW5nTGVmdCgpIGNvbnN0Ci17 Ci0gICAgcmV0dXJuIDM7Ci19Ci0KLWludCBSZW5kZXJUaGVtZUNocm9taXVtU2tpYTo6YnV0dG9u SW50ZXJuYWxQYWRkaW5nUmlnaHQoKSBjb25zdAotewotICAgIHJldHVybiAzOwotfQotCi1pbnQg UmVuZGVyVGhlbWVDaHJvbWl1bVNraWE6OmJ1dHRvbkludGVybmFsUGFkZGluZ1RvcCgpIGNvbnN0 Ci17Ci0gICAgcmV0dXJuIDE7Ci19Ci0KLWludCBSZW5kZXJUaGVtZUNocm9taXVtU2tpYTo6YnV0 dG9uSW50ZXJuYWxQYWRkaW5nQm90dG9tKCkgY29uc3QKLXsKLSAgICByZXR1cm4gMTsKLX0KLQog I2lmIEVOQUJMRShWSURFTykKIGJvb2wgUmVuZGVyVGhlbWVDaHJvbWl1bVNraWE6OnNob3VsZFJl bmRlck1lZGlhQ29udHJvbFBhcnQoQ29udHJvbFBhcnQgcGFydCwgRWxlbWVudCogZSkKIHsKZGlm ZiAtLWdpdCBhL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclRoZW1lQ2hyb21pdW1Ta2lhLmggYi9X ZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJUaGVtZUNocm9taXVtU2tpYS5oCmluZGV4IDE4ZmE4NTku LjIzMWM1ZWUgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclRoZW1lQ2hyb21p dW1Ta2lhLmgKKysrIGIvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVGhlbWVDaHJvbWl1bVNraWEu aApAQCAtMTIzLDExICsxMjMsNiBAQCBuYW1lc3BhY2UgV2ViQ29yZSB7CiAgICAgICAgIHZpcnR1 YWwgaW50IHBvcHVwSW50ZXJuYWxQYWRkaW5nVG9wKFJlbmRlclN0eWxlKikgY29uc3Q7CiAgICAg ICAgIHZpcnR1YWwgaW50IHBvcHVwSW50ZXJuYWxQYWRkaW5nQm90dG9tKFJlbmRlclN0eWxlKikg Y29uc3Q7CiAKLSAgICAgICAgdmlydHVhbCBpbnQgYnV0dG9uSW50ZXJuYWxQYWRkaW5nTGVmdCgp IGNvbnN0OwotICAgICAgICB2aXJ0dWFsIGludCBidXR0b25JbnRlcm5hbFBhZGRpbmdSaWdodCgp IGNvbnN0OwotICAgICAgICB2aXJ0dWFsIGludCBidXR0b25JbnRlcm5hbFBhZGRpbmdUb3AoKSBj b25zdDsKLSAgICAgICAgdmlydHVhbCBpbnQgYnV0dG9uSW50ZXJuYWxQYWRkaW5nQm90dG9tKCkg Y29uc3Q7Ci0KICNpZiBFTkFCTEUoVklERU8pCiAgICAgICAgIC8vIE1lZGlhIGNvbnRyb2xzCiAg ICAgICAgIHZpcnR1YWwgYm9vbCBzaG91bGRSZW5kZXJNZWRpYUNvbnRyb2xQYXJ0KENvbnRyb2xQ YXJ0LCBFbGVtZW50Kik7Cg==