35628 2010-03-02 20:45:28 -0800 add a flag to WebURLResponse so we can identify multipart content 2010-03-02 23:22:35 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 tony webkit-unassigned fishd oldest_to_newest 195369 0 tony 2010-03-02 20:45:28 -0800 add a flag to WebURLResponse so we can identify multipart content 195370 1 49875 tony 2010-03-02 20:45:51 -0800 Created attachment 49875 Patch 195371 2 49875 tony 2010-03-02 20:46:51 -0800 Comment on attachment 49875 Patch This is the webkit side of http://codereview.chromium.org/661445. This is to fix http://code.google.com/p/chromium/issues/detail?id=34350 195382 3 49875 fishd 2010-03-02 22:11:47 -0800 Comment on attachment 49875 Patch > +++ b/WebCore/ChangeLog > @@ -1,3 +1,17 @@ > +2010-03-02 Tony Chang <tony@chromium.org> > + > + Reviewed by NOBODY (OOPS!). > + > + add a flag to WebURLResponse so we can identify multipart content > + https://bugs.webkit.org/show_bug.cgi?id=35628 > + > + No new tests. (OOPS!) ^^^ This oops is going to cause the commit-queue to barf. Otherwise, r=me 195383 4 tony 2010-03-02 22:14:03 -0800 (In reply to comment #3) > (From update of attachment 49875 [details]) > > +++ b/WebCore/ChangeLog > > @@ -1,3 +1,17 @@ > > +2010-03-02 Tony Chang <tony@chromium.org> > > + > > + Reviewed by NOBODY (OOPS!). > > + > > + add a flag to WebURLResponse so we can identify multipart content > > + https://bugs.webkit.org/show_bug.cgi?id=35628 > > + > > + No new tests. (OOPS!) > > ^^^ This oops is going to cause the commit-queue to barf. > > Otherwise, r=me D'oh. Will land manually. Thanks for the fast review! 195405 5 tony 2010-03-02 23:22:35 -0800 Committed r55451: <http://trac.webkit.org/changeset/55451> 49875 2010-03-02 20:45:51 -0800 2010-03-02 22:11:47 -0800 Patch bug-35628-20100302204550.patch text/plain 3776 tony ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg YjE2OTY5OS4uMmFmMWVjMSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNyBAQAorMjAxMC0wMy0wMiAgVG9ueSBDaGFuZyAg PHRvbnlAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIGFkZCBhIGZsYWcgdG8gV2ViVVJMUmVzcG9uc2Ugc28gd2UgY2FuIGlkZW50 aWZ5IG11bHRpcGFydCBjb250ZW50CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0zNTYyOAorCisgICAgICAgIE5vIG5ldyB0ZXN0cy4gKE9PUFMhKQorCisg ICAgICAgICogcGxhdGZvcm0vbmV0d29yay9jaHJvbWl1bS9SZXNvdXJjZVJlc3BvbnNlLmg6Cisg ICAgICAgIChXZWJDb3JlOjpSZXNvdXJjZVJlc3BvbnNlOjpSZXNvdXJjZVJlc3BvbnNlKToKKyAg ICAgICAgKFdlYkNvcmU6OlJlc291cmNlUmVzcG9uc2U6OmlzTXVsdGlwYXJ0UGF5bG9hZCk6Cisg ICAgICAgIChXZWJDb3JlOjpSZXNvdXJjZVJlc3BvbnNlOjpzZXRJc011bHRpcGFydFBheWxvYWQp OgorCiAyMDEwLTAzLTAyICBBZGFtIEJhcnRoICA8YWJhcnRoQHdlYmtpdC5vcmc+CiAKICAgICAg ICAgUmV2aWV3ZWQgYnkgRGFyaW4gRmlzaGVyLgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9wbGF0Zm9y bS9uZXR3b3JrL2Nocm9taXVtL1Jlc291cmNlUmVzcG9uc2UuaCBiL1dlYkNvcmUvcGxhdGZvcm0v bmV0d29yay9jaHJvbWl1bS9SZXNvdXJjZVJlc3BvbnNlLmgKaW5kZXggMWI5ZGUwNC4uZjdhMmM2 YyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL2Nocm9taXVtL1Jlc291cmNl UmVzcG9uc2UuaAorKysgYi9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvY2hyb21pdW0vUmVzb3Vy Y2VSZXNwb25zZS5oCkBAIC00Nyw2ICs0Nyw3IEBAIG5hbWVzcGFjZSBXZWJDb3JlIHsKICAgICAg ICAgICAgICwgbV9pc0NvbnRlbnRGaWx0ZXJlZChmYWxzZSkKICAgICAgICAgICAgICwgbV9hcHBD YWNoZUlEKDApCiAgICAgICAgICAgICAsIG1fd2FzRmV0Y2hlZFZpYVNQRFkoZmFsc2UpCisgICAg ICAgICAgICAsIG1faXNNdWx0aXBhcnRQYXlsb2FkKGZhbHNlKQogICAgICAgICB7CiAgICAgICAg IH0KIApAQCAtODAsNiArODEsMTIgQEAgbmFtZXNwYWNlIFdlYkNvcmUgewogICAgICAgICAgICAg bV93YXNGZXRjaGVkVmlhU1BEWSA9IHZhbHVlOwogICAgICAgICB9CiAKKyAgICAgICAgYm9vbCBp c011bHRpcGFydFBheWxvYWQoKSBjb25zdCB7IHJldHVybiBtX2lzTXVsdGlwYXJ0UGF5bG9hZDsg fQorICAgICAgICB2b2lkIHNldElzTXVsdGlwYXJ0UGF5bG9hZChib29sIHZhbHVlKQorICAgICAg ICB7CisgICAgICAgICAgICBtX2lzTXVsdGlwYXJ0UGF5bG9hZCA9IHZhbHVlOworICAgICAgICB9 CisKICAgICBwcml2YXRlOgogICAgICAgICBmcmllbmQgY2xhc3MgUmVzb3VyY2VSZXNwb25zZUJh c2U7CiAKQEAgLTEwNiw2ICsxMTMsOSBAQCBuYW1lc3BhY2UgV2ViQ29yZSB7CiAgICAgICAgIEtV UkwgbV9hcHBDYWNoZU1hbmlmZXN0VVJMOwogCiAgICAgICAgIGJvb2wgbV93YXNGZXRjaGVkVmlh U1BEWTsKKworICAgICAgICAvLyBTZXQgdG8gdHJ1ZSBpZiB0aGlzIGlzIHBhcnQgb2YgYSBtdWx0 aXBhcnQgcmVzcG9uc2UuCisgICAgICAgIGJvb2wgbV9pc011bHRpcGFydFBheWxvYWQ7CiAgICAg fTsKIAogfSAvLyBuYW1lc3BhY2UgV2ViQ29yZQpkaWZmIC0tZ2l0IGEvV2ViS2l0L2Nocm9taXVt L0NoYW5nZUxvZyBiL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKaW5kZXggMTY4ZTA2Ni4uYjhm YmEyNyAxMDA2NDQKLS0tIGEvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZworKysgYi9XZWJLaXQv Y2hyb21pdW0vQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTAtMDMtMDIgIFRvbnkgQ2hh bmcgIDx0b255QGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBhZGQgYSBmbGFnIHRvIFdlYlVSTFJlc3BvbnNlIHNvIHdlIGNhbiBp ZGVudGlmeSBtdWx0aXBhcnQgY29udGVudAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MzU2MjgKKworICAgICAgICAqIHB1YmxpYy9XZWJVUkxSZXNwb25z ZS5oOgorICAgICAgICAqIHNyYy9XZWJVUkxSZXNwb25zZS5jcHA6CisgICAgICAgIChXZWJLaXQ6 OldlYlVSTFJlc3BvbnNlOjppc011bHRpcGFydFBheWxvYWQpOgorICAgICAgICAoV2ViS2l0OjpX ZWJVUkxSZXNwb25zZTo6c2V0SXNNdWx0aXBhcnRQYXlsb2FkKToKKwogMjAxMC0wMy0wMiAgQWRh bSBCYXJ0aCAgPGFiYXJ0aEB3ZWJraXQub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERhcmlu IEZpc2hlci4KZGlmZiAtLWdpdCBhL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViVVJMUmVzcG9u c2UuaCBiL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViVVJMUmVzcG9uc2UuaAppbmRleCAxZGFj MDY5Li4zYWNhY2Y4IDEwMDY0NAotLS0gYS9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYlVSTFJl c3BvbnNlLmgKKysrIGIvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJVUkxSZXNwb25zZS5oCkBA IC0xMjMsNiArMTIzLDEwIEBAIHB1YmxpYzoKICAgICBXRUJLSVRfQVBJIGJvb2wgd2FzRmV0Y2hl ZFZpYVNQRFkoKSBjb25zdDsKICAgICBXRUJLSVRfQVBJIHZvaWQgc2V0V2FzRmV0Y2hlZFZpYVNQ RFkoYm9vbCk7CiAKKyAgICAvLyBGbGFnIHdoZXRoZXIgdGhpcyByZXF1ZXN0IGlzIHBhcnQgb2Yg YSBtdWx0aXBhcnQgcmVzcG9uc2UuCisgICAgV0VCS0lUX0FQSSBib29sIGlzTXVsdGlwYXJ0UGF5 bG9hZCgpIGNvbnN0OworICAgIFdFQktJVF9BUEkgdm9pZCBzZXRJc011bHRpcGFydFBheWxvYWQo Ym9vbCk7CisKIHByb3RlY3RlZDoKICAgICB2b2lkIGFzc2lnbihXZWJVUkxSZXNwb25zZVByaXZh dGUqKTsKIApkaWZmIC0tZ2l0IGEvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJVUkxSZXNwb25zZS5j cHAgYi9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYlVSTFJlc3BvbnNlLmNwcAppbmRleCA5NWUwYmUy Li43N2ZjNjU1IDEwMDY0NAotLS0gYS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYlVSTFJlc3BvbnNl LmNwcAorKysgYi9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYlVSTFJlc3BvbnNlLmNwcApAQCAtMjY1 LDYgKzI2NSwxNiBAQCB2b2lkIFdlYlVSTFJlc3BvbnNlOjpzZXRXYXNGZXRjaGVkVmlhU1BEWShi b29sIHZhbHVlKQogICAgIG1fcHJpdmF0ZS0+bV9yZXNvdXJjZVJlc3BvbnNlLT5zZXRXYXNGZXRj aGVkVmlhU1BEWSh2YWx1ZSk7CiB9CiAKK2Jvb2wgV2ViVVJMUmVzcG9uc2U6OmlzTXVsdGlwYXJ0 UGF5bG9hZCgpIGNvbnN0Cit7CisgICAgcmV0dXJuIG1fcHJpdmF0ZS0+bV9yZXNvdXJjZVJlc3Bv bnNlLT5pc011bHRpcGFydFBheWxvYWQoKTsKK30KKwordm9pZCBXZWJVUkxSZXNwb25zZTo6c2V0 SXNNdWx0aXBhcnRQYXlsb2FkKGJvb2wgdmFsdWUpCit7CisgICAgbV9wcml2YXRlLT5tX3Jlc291 cmNlUmVzcG9uc2UtPnNldElzTXVsdGlwYXJ0UGF5bG9hZCh2YWx1ZSk7Cit9CisKIHZvaWQgV2Vi VVJMUmVzcG9uc2U6OmFzc2lnbihXZWJVUkxSZXNwb25zZVByaXZhdGUqIHApCiB7CiAgICAgLy8g U3ViY2xhc3NlcyBtYXkgY2FsbCB0aGlzIGRpcmVjdGx5IHNvIGEgc2VsZi1hc3NpZ25tZW50IGNo ZWNrIGlzIG5lZWRlZAo=