<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>35627</bug_id>
          
          <creation_ts>2010-03-02 20:16:44 -0800</creation_ts>
          <short_desc>Rework r55443 to avoid #ifdefs in Page.cpp</short_desc>
          <delta_ts>2010-03-02 20:17:45 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Plug-ins</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>All</rep_platform>
          <op_sys>All</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>DUPLICATE</resolution>
          <dup_id>35623</dup_id>
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Darin Fisher (:fishd, Google)">fishd</reporter>
          <assigned_to name="Darin Fisher (:fishd, Google)">fishd</assigned_to>
          <cc>mrowe</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>195364</commentid>
    <comment_count>0</comment_count>
    <who name="Darin Fisher (:fishd, Google)">fishd</who>
    <bug_when>2010-03-02 20:16:44 -0800</bug_when>
    <thetext>Rework http://trac.webkit.org/changeset/55443 to avoid #ifdefs in Page.cpp

One idea is to move the body of Page::privateBrowsingStateChanged to a
static function on PluginView.  That function would be passed the Page,
and it would then iterate over the list of PluginViews and notify each.

This way PluginViewNone.cpp can just have an empty body for that static
method.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>195365</commentid>
    <comment_count>1</comment_count>
    <who name="Mark Rowe (bdash)">mrowe</who>
    <bug_when>2010-03-02 20:17:45 -0800</bug_when>
    <thetext>

*** This bug has been marked as a duplicate of bug 35623 ***</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>