35624 2010-03-02 18:06:50 -0800 Closing a database while a transaction is in progress can cause a crash 2010-03-03 17:02:29 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 dumi dumi michaeln oldest_to_newest 195341 0 dumi 2010-03-02 18:06:50 -0800 Before running any transaction step on the DB thread or the main thread, we check if the database is closed by calling the SQLTransaction::checkAndHandleClosedDatabase() method. Parts of that method though are intended to run only on the DB thread, and could cause a crash if run on the main thread. In particular, calling SQLTransactionCoordinator::releaseLock() on the main thread after SQLTransactionCoordinator::shutdown() was called on the DB thread triggers an assertion failure. Solution: check what thread we're on inside SQLTransaction::checkAndHandleClosedDatabase() and only run the appropriate code for that thread. 195355 1 49874 dumi 2010-03-02 18:40:48 -0800 Created attachment 49874 patch 195356 2 michaeln 2010-03-02 18:52:13 -0800 yup... lgtm 195727 3 49874 dglazkov 2010-03-03 13:11:18 -0800 Comment on attachment 49874 patch Per our IM discussion, please describe why it's impossible to write a deterministic regression test for it and mention the flakiness in the layout test it fixes. 195823 4 dumi 2010-03-03 17:02:29 -0800 Landed as r55487. 49874 2010-03-02 18:40:48 -0800 2010-03-03 13:11:18 -0800 patch patch text/plain 1382 dumi SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1NTQ0NykKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTYgQEAKKzIwMTAtMDMtMDIgIER1bWl0cnUgRGFuaWxpdWMgIDxkdW1pQGNocm9t aXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBGaXggYSBidWcgdGhhdCBjb3VsZCBsZWFkIHRvIGEgY3Jhc2guIFNvbWUgcGFydHMgb2YKKyAg ICAgICAgU1FMVHJhbnNhY3Rpb246OmNoZWNrQW5kSGFuZGxlQ2xvc2VkRGF0YWJhc2UoKSBzaG91 bGQgb25seSBiZSBydW4KKyAgICAgICAgd2hlbiB0aGF0IG1ldGhvZCBpcyBpbnZva2VkIG9uIHRo ZSBEQiB0aHJlYWQuCisKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTM1NjI0CisKKyAgICAgICAgKiBzdG9yYWdlL1NRTFRyYW5zYWN0aW9uLmNwcDoKKyAg ICAgICAgKFdlYkNvcmU6OlNRTFRyYW5zYWN0aW9uOjpjaGVja0FuZEhhbmRsZUNsb3NlZERhdGFi YXNlKToKKwogMjAxMC0wMy0wMiAgRXZhbiBTdGFkZSAgPGVzdGFkZUBjaHJvbWl1bS5vcmc+CiAK ICAgICAgICAgUmV2aWV3ZWQgYnkgRGF2aWQgTGV2aW4uCkluZGV4OiBXZWJDb3JlL3N0b3JhZ2Uv U1FMVHJhbnNhY3Rpb24uY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvc3RvcmFnZS9TUUxUcmFu c2FjdGlvbi5jcHAJKHJldmlzaW9uIDU1NDQ1KQorKysgV2ViQ29yZS9zdG9yYWdlL1NRTFRyYW5z YWN0aW9uLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTU4LDYgKzE1OCwxMCBAQCB2b2lkIFNRTFRy YW5zYWN0aW9uOjpjaGVja0FuZEhhbmRsZUNsb3NlCiAgICAgbV9zdGF0ZW1lbnRRdWV1ZS5jbGVh cigpOwogICAgIG1fbmV4dFN0ZXAgPSAwOwogCisgICAgLy8gVGhlIG5leHQgc3RlcHMgc2hvdWxk IGJlIGV4ZWN1dGVkIG9ubHkgaWYgd2UncmUgb24gdGhlIERCIHRocmVhZC4KKyAgICBpZiAoY3Vy cmVudFRocmVhZCgpICE9IGRhdGFiYXNlKCktPnNjcmlwdEV4ZWN1dGlvbkNvbnRleHQoKS0+ZGF0 YWJhc2VUaHJlYWQoKS0+Z2V0VGhyZWFkSUQoKSkKKyAgICAgICAgcmV0dXJuOworCiAgICAgLy8g VGhlIGN1cnJlbnQgU1FMaXRlIHRyYW5zYWN0aW9uIHNob3VsZCBiZSBzdG9wcGVkLCBhcyB3ZWxs CiAgICAgaWYgKG1fc3FsaXRlVHJhbnNhY3Rpb24pIHsKICAgICAgICAgbV9zcWxpdGVUcmFuc2Fj dGlvbi0+c3RvcCgpOwo=