35623 2010-03-02 17:23:55 -0800 Page should not care about Chromium plug-in implementation details 2010-03-03 16:47:38 -0800 1 1 1 Unclassified WebKit Plug-ins 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 mrowe fishd fishd oldest_to_newest 195327 0 mrowe 2010-03-02 17:23:55 -0800 <http://trac.webkit.org/changeset/55443> added #if !PLATFORM(CHROMIUM) in the middle of a cross-platform block of code. The build failure that it claimed to address was addressed on other platforms that don’t use PluginView by <http://trac.webkit.org/changeset/55440>, which doesn’t require Page to know about how each platform happens to implement plug-ins. Chromium should follow this approach rather than adding #ifs in the manner of r55443. 195366 1 mrowe 2010-03-02 20:17:45 -0800 *** Bug 35627 has been marked as a duplicate of this bug. *** 195367 2 fishd 2010-03-02 20:20:04 -0800 From bug 35627: > One idea is to move the body of Page::privateBrowsingStateChanged to a > static function on PluginView. That function would be passed the Page, > and it would then iterate over the list of PluginViews and notify each. > > This way PluginViewNone.cpp can just have an empty body for that static > method. Sound good? 195716 3 49933 fishd 2010-03-03 12:47:12 -0800 Created attachment 49933 v1 patch Just building PluginViewNone.cpp turns out to be sufficient. Page::privateBrowsingStateChanged() is optimized away (tested using Visual Studio 8). 195817 4 fishd 2010-03-03 16:47:38 -0800 Landed as http://trac.webkit.org/changeset/55486 49933 2010-03-03 12:47:12 -0800 2010-03-03 16:47:25 -0800 v1 patch page_1.txt text/plain 1907 fishd SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nDQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09DQotLS0gV2ViQ29yZS9DaGFuZ2VM b2cJKHJldmlzaW9uIDU1NDcwKQorKysgV2ViQ29yZS9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkK QEAgLTEsMyArMSwxNSBAQAorMjAxMC0wMy0wMyAgRGFyaW4gRmlzaGVyICA8ZGFyaW5AY2hyb21p dW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IFBhZ2Ugc2hvdWxkIG5vdCBjYXJlIGFib3V0IENocm9taXVtIHBsdWctaW4gaW1wbGVtZW50YXRp b24gZGV0YWlscworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MzU2MjMKKworICAgICAgICAqIFdlYkNvcmUuZ3lwaTogQ29tcGlsZSBQbHVnaW5WaWV3Tm9u ZS5jcHAKKyAgICAgICAgKiBwYWdlL1BhZ2UuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UGFnZTo6 cHJpdmF0ZUJyb3dzaW5nU3RhdGVDaGFuZ2VkKTogUmVtb3ZlIGNvbmRpdGlvbmFsCisgICAgICAg IGNvbXBpbGF0aW9uIGZvciBQTEFURk9STShDSFJPTUlVTSkuCisKIDIwMTAtMDMtMDMgIEFsZXhh bmRlciBQYXZsb3YgIDxhcGF2bG92QGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBi eSBQYXZlbCBGZWxkbWFuLgpJbmRleDogV2ViQ29yZS9XZWJDb3JlLmd5cGkNCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0N Ci0tLSBXZWJDb3JlL1dlYkNvcmUuZ3lwaQkocmV2aXNpb24gNTU0NzApCisrKyBXZWJDb3JlL1dl YkNvcmUuZ3lwaQkod29ya2luZyBjb3B5KQpAQCAtMjkxNiw2ICsyOTE2LDcgQEAKICAgICAgICAg ICAgICdwbHVnaW5zL1BsdWdpblN0cmVhbS5oJywKICAgICAgICAgICAgICdwbHVnaW5zL1BsdWdp blZpZXcuY3BwJywKICAgICAgICAgICAgICdwbHVnaW5zL1BsdWdpblZpZXcuaCcsCisgICAgICAg ICAgICAncGx1Z2lucy9QbHVnaW5WaWV3Tm9uZS5jcHAnLAogICAgICAgICAgICAgJ3BsdWdpbnMv bnBhcGkuY3BwJywKICAgICAgICAgICAgICdwbHVnaW5zL25wZnVuY3Rpb25zLmgnLAogICAgICAg ICAgICAgJ3JlbmRlcmluZy9zdHlsZS9CaW5kaW5nVVJJLmNwcCcsCkluZGV4OiBXZWJDb3JlL3Bh Z2UvUGFnZS5jcHANCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0NCi0tLSBXZWJDb3JlL3BhZ2UvUGFnZS5jcHAJKHJldmlz aW9uIDU1NDcwKQorKysgV2ViQ29yZS9wYWdlL1BhZ2UuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC03 NzgsNyArNzc4LDYgQEAgSW5zcGVjdG9yVGltZWxpbmVBZ2VudCogUGFnZTo6aW5zcGVjdG9yVAog CiB2b2lkIFBhZ2U6OnByaXZhdGVCcm93c2luZ1N0YXRlQ2hhbmdlZCgpCiB7Ci0jaWYgIVBMQVRG T1JNKENIUk9NSVVNKQogICAgIGJvb2wgcHJpdmF0ZUJyb3dzaW5nRW5hYmxlZCA9IG1fc2V0dGlu Z3MtPnByaXZhdGVCcm93c2luZ0VuYWJsZWQoKTsKIAogICAgIC8vIENvbGxlY3QgdGhlIFBsdWdp blZpZXdzIGluIHRvIGEgdmVjdG9yIHRvIGVuc3VyZSB0aGF0IGFjdGlvbiB0aGUgcGx1Zy1pbiB0 YWtlcwpAQCAtODA0LDcgKzgwMyw2IEBAIHZvaWQgUGFnZTo6cHJpdmF0ZUJyb3dzaW5nU3RhdGVD aGFuZ2VkKCkKIAogICAgIGZvciAoc2l6ZV90IGkgPSAwOyBpIDwgcGx1Z2luVmlld3Muc2l6ZSgp OyBpKyspCiAgICAgICAgIHBsdWdpblZpZXdzW2ldLT5wcml2YXRlQnJvd3NpbmdTdGF0ZUNoYW5n ZWQocHJpdmF0ZUJyb3dzaW5nRW5hYmxlZCk7Ci0jZW5kaWYKIH0KIAogdm9pZCBQYWdlOjpwbHVn aW5BbGxvd2VkUnVuVGltZUNoYW5nZWQoKQo=