35613 2010-03-02 15:10:46 -0800 Document cookieURL and firstPartyForCookies 2010-03-03 06:48:44 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 abarth webkit-unassigned ap commit-queue fishd oldest_to_newest 195263 0 abarth 2010-03-02 15:10:46 -0800 Document cookieURL and firstPartyForCookies 195264 1 49855 abarth 2010-03-02 15:11:59 -0800 Created attachment 49855 Patch 195269 2 49856 abarth 2010-03-02 15:19:38 -0800 Created attachment 49856 Patch 195320 3 49856 darin 2010-03-02 17:00:07 -0800 Comment on attachment 49856 Patch > + // inherits its cookieURL but not it's URL. its URL 195322 4 ap 2010-03-02 17:04:31 -0800 + // A: The two URLs are the same almost all the time. However, if one + // document inherits the security context of another document, it + // inherits its cookieURL but not it's URL. It's interesting that we have this code: void Document::open(Document* ownerDocument) { if (ownerDocument) { setURL(ownerDocument->url()); m_cookieURL = ownerDocument->cookieURL(); 195323 5 49869 abarth 2010-03-02 17:07:35 -0800 Created attachment 49869 Patch for landing 195411 6 49869 commit-queue 2010-03-03 00:31:44 -0800 Comment on attachment 49869 Patch for landing Rejecting patch 49869 from commit-queue. Failed to run "['git', 'svn', 'dcommit']" exit_code: 1 Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/dom/Document.h A repository hook failed: MERGE request failed on '/repository/webkit/trunk': Commit blocked by pre-commit hook (exit code 1) with output: svnlook: Can't write to stream: Broken pipe The following ChangeLog files contain OOPS: trunk/WebCore/ChangeLog Please don't ever say "OOPS" in a ChangeLog file. at /usr/local/git/libexec/git-core/git-svn line 558 Full output: http://webkit-commit-queue.appspot.com/results/323345 195514 7 abarth 2010-03-03 06:48:44 -0800 Committed r55461: <http://trac.webkit.org/changeset/55461> 49855 2010-03-02 15:11:59 -0800 2010-03-02 15:19:32 -0800 Patch bug-35613-20100302151156.patch text/plain 2197 abarth ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg YjRlZjAyZC4uZmQ2MzRiNCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAxMC0wMy0wMiAgQWRhbSBCYXJ0aCAg PGFiYXJ0aEB3ZWJraXQub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIERvY3VtZW50IGNvb2tpZVVSTCBhbmQgZmlyc3RQYXJ0eUZvckNvb2tpZXMK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM1NjEzCisK KyAgICAgICAgU29tZSBmb2xrcyBhc2tlZCB3aGF0IHRoZSBjb29raWVVUkwgYW5kIHRoZSBmaXJz dFBhcnR5Rm9yQ29va2llcyB3ZXJlCisgICAgICAgIG9uIElSQy4gIFRoaXMgcGF0Y2ggZG9jdW1l bnRzIHRoZXNlIHByb3BlcnRpZXMgaW4gdGhlIGNvZGUgc28gZm9sa3MKKyAgICAgICAgZG9uJ3Qg aGF2ZSB0byBhc2sgb24gSVJDIGFueW1vcmUuCisKKyAgICAgICAgKiBkb20vRG9jdW1lbnQuaDoK KwogMjAxMC0wMy0wMiAgQW5kZXJzIENhcmxzc29uICA8YW5kZXJzY2FAYXBwbGUuY29tPgogCiAg ICAgICAgIFJldmlld2VkIGJ5IFNhbSBXZWluaWcuCmRpZmYgLS1naXQgYS9XZWJDb3JlL2RvbS9E b2N1bWVudC5oIGIvV2ViQ29yZS9kb20vRG9jdW1lbnQuaAppbmRleCBlOGIzZTZlLi5hMDkxODc1 IDEwMDY0NAotLS0gYS9XZWJDb3JlL2RvbS9Eb2N1bWVudC5oCisrKyBiL1dlYkNvcmUvZG9tL0Rv Y3VtZW50LmgKQEAgLTcxNCw4ICs3MTQsMjggQEAgcHVibGljOgogCiAgICAgU3RyaW5nIGxhc3RN b2RpZmllZCgpIGNvbnN0OwogCisgICAgLy8gVGhlIGNvb2tpZVVSTCBpcyB1c2VkIHRvIHF1ZXJ5 IHRoZSBjb29raWUgZGF0YWJhc2UgZm9yIHRoaXMgZG9jdW1lbnQncworICAgIC8vIGNvb2tpZXMu IEZvciBleGFtcGxlLCBpZiB0aGUgY29va2llIFVSTCBpcyBodHRwOi8vZXhhbXBsZS5jb20sIHdl J2xsCisgICAgLy8gdXNlIHRoZSBub24tU2VjdXJlIGNvb2tpZXMgZm9yIGV4YW1wbGUuY29tIHdo ZW4gY29tcHV0aW5nCisgICAgLy8gZG9jdW1lbnQuY29va2llLgorICAgIC8vCisgICAgLy8gUTog SG93IGlzIHRoZSBjb29raWVVUkwgZGlmZmVyZW50IGZyb20gdGhlIGRvY3VtZW50J3MgVVJMPwor ICAgIC8vIEE6IFRoZSB0d28gVVJMcyBhcmUgdGhlIHNhbWUgYWxtb3N0IGFsbCB0aGUgdGltZS4g IEhvd2V2ZXIsIGlmIG9uZQorICAgIC8vICAgIGRvY3VtZW50IGNhbGxzIGRvY3VtZW50Lm9wZW4o KSBvbiBhbm90aGVyIGRvY3VtZW50LCB0aGUgc2Vjb25kCisgICAgLy8gICAgZG9jdW1lbnQgaW5o ZXJpdHMgdGhlIGZpcnN0IGRvY3VtZW50J3MgY29va2llVVJMLgorICAgIC8vCiAgICAgY29uc3Qg S1VSTCYgY29va2llVVJMKCkgY29uc3QgeyByZXR1cm4gbV9jb29raWVVUkw7IH0KIAorICAgIC8v IFRoZSBmaXJzdFBhcnR5Rm9yQ29va2llcyBpcyB1c2VkIHRvIGNvbXB1dGUgd2hldGhlciB0aGlz IGRvY3VtZW50CisgICAgLy8gYXBwZWFycyBpbiBhICJ0aGlyZC1wYXJ0eSIgY29udGV4dCBmb3Ig dGhlIHB1cnBvc2Ugb2YgdGhpcmQtcGFydHkKKyAgICAvLyBjb29raWUgYmxvY2tpbmcuICBUaGUg ZG9jdW1lbnQgaXMgaW4gYSB0aGlyZC1wYXJ0eSBjb250ZXh0IGlmIHRoZQorICAgIC8vIGNvb2tp ZVVSTCBhbmQgdGhlIGZpcnN0UGFydHlGb3JDb29raWVzIGFyZSBmcm9tIGRpZmZlcmVudCBob3N0 cy4KKyAgICAvLworICAgIC8vIE5vdGU6IFNvbWUgcG9ydHMgKGluY2x1ZGluZyBwb3NzaWJseSBB cHBsZSdzKSBvbmx5IGNvbnNpZGVyIHRoZQorICAgIC8vICAgICAgIGRvY3VtZW50IGluIGEgdGhp cmQtcGFydHkgY29udGV4dCBpZiB0aGUgY29va2llVVJMIGFuZCB0aGUKKyAgICAvLyAgICAgICBm aXJzdFBhcnR5Rm9yQ29va2llcyBoYXZlIGEgZGlmZmVyZW50IHJlZ2lzdHJ5LWNvbnRyb2xsZWQK KyAgICAvLyAgICAgICBkb21haW4uCisgICAgLy8KICAgICBjb25zdCBLVVJMJiBmaXJzdFBhcnR5 Rm9yQ29va2llcygpIGNvbnN0IHsgcmV0dXJuIG1fZmlyc3RQYXJ0eUZvckNvb2tpZXM7IH0KICAg ICB2b2lkIHNldEZpcnN0UGFydHlGb3JDb29raWVzKGNvbnN0IEtVUkwmIHVybCkgeyBtX2ZpcnN0 UGFydHlGb3JDb29raWVzID0gdXJsOyB9CiAgICAgCg== 49856 2010-03-02 15:19:38 -0800 2010-03-02 17:07:31 -0800 Patch bug-35613-20100302151934.patch text/plain 2188 abarth ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg YjRlZjAyZC4uZmQ2MzRiNCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAxMC0wMy0wMiAgQWRhbSBCYXJ0aCAg PGFiYXJ0aEB3ZWJraXQub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIERvY3VtZW50IGNvb2tpZVVSTCBhbmQgZmlyc3RQYXJ0eUZvckNvb2tpZXMK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM1NjEzCisK KyAgICAgICAgU29tZSBmb2xrcyBhc2tlZCB3aGF0IHRoZSBjb29raWVVUkwgYW5kIHRoZSBmaXJz dFBhcnR5Rm9yQ29va2llcyB3ZXJlCisgICAgICAgIG9uIElSQy4gIFRoaXMgcGF0Y2ggZG9jdW1l bnRzIHRoZXNlIHByb3BlcnRpZXMgaW4gdGhlIGNvZGUgc28gZm9sa3MKKyAgICAgICAgZG9uJ3Qg aGF2ZSB0byBhc2sgb24gSVJDIGFueW1vcmUuCisKKyAgICAgICAgKiBkb20vRG9jdW1lbnQuaDoK KwogMjAxMC0wMy0wMiAgQW5kZXJzIENhcmxzc29uICA8YW5kZXJzY2FAYXBwbGUuY29tPgogCiAg ICAgICAgIFJldmlld2VkIGJ5IFNhbSBXZWluaWcuCmRpZmYgLS1naXQgYS9XZWJDb3JlL2RvbS9E b2N1bWVudC5oIGIvV2ViQ29yZS9kb20vRG9jdW1lbnQuaAppbmRleCBlOGIzZTZlLi5lNjFlZTU3 IDEwMDY0NAotLS0gYS9XZWJDb3JlL2RvbS9Eb2N1bWVudC5oCisrKyBiL1dlYkNvcmUvZG9tL0Rv Y3VtZW50LmgKQEAgLTcxNCw4ICs3MTQsMjggQEAgcHVibGljOgogCiAgICAgU3RyaW5nIGxhc3RN b2RpZmllZCgpIGNvbnN0OwogCisgICAgLy8gVGhlIGNvb2tpZVVSTCBpcyB1c2VkIHRvIHF1ZXJ5 IHRoZSBjb29raWUgZGF0YWJhc2UgZm9yIHRoaXMgZG9jdW1lbnQncworICAgIC8vIGNvb2tpZXMu IEZvciBleGFtcGxlLCBpZiB0aGUgY29va2llIFVSTCBpcyBodHRwOi8vZXhhbXBsZS5jb20sIHdl J2xsCisgICAgLy8gdXNlIHRoZSBub24tU2VjdXJlIGNvb2tpZXMgZm9yIGV4YW1wbGUuY29tIHdo ZW4gY29tcHV0aW5nCisgICAgLy8gZG9jdW1lbnQuY29va2llLgorICAgIC8vCisgICAgLy8gUTog SG93IGlzIHRoZSBjb29raWVVUkwgZGlmZmVyZW50IGZyb20gdGhlIGRvY3VtZW50J3MgVVJMPwor ICAgIC8vIEE6IFRoZSB0d28gVVJMcyBhcmUgdGhlIHNhbWUgYWxtb3N0IGFsbCB0aGUgdGltZS4g IEhvd2V2ZXIsIGlmIG9uZQorICAgIC8vICAgIGRvY3VtZW50IGluaGVyaXRzIHRoZSBzZWN1cml0 eSBjb250ZXh0IG9mIGFub3RoZXIgZG9jdW1lbnQsIGl0CisgICAgLy8gICAgaW5oZXJpdHMgaXRz IGNvb2tpZVVSTCBidXQgbm90IGl0J3MgVVJMLgorICAgIC8vCiAgICAgY29uc3QgS1VSTCYgY29v a2llVVJMKCkgY29uc3QgeyByZXR1cm4gbV9jb29raWVVUkw7IH0KIAorICAgIC8vIFRoZSBmaXJz dFBhcnR5Rm9yQ29va2llcyBpcyB1c2VkIHRvIGNvbXB1dGUgd2hldGhlciB0aGlzIGRvY3VtZW50 CisgICAgLy8gYXBwZWFycyBpbiBhICJ0aGlyZC1wYXJ0eSIgY29udGV4dCBmb3IgdGhlIHB1cnBv c2Ugb2YgdGhpcmQtcGFydHkKKyAgICAvLyBjb29raWUgYmxvY2tpbmcuICBUaGUgZG9jdW1lbnQg aXMgaW4gYSB0aGlyZC1wYXJ0eSBjb250ZXh0IGlmIHRoZQorICAgIC8vIGNvb2tpZVVSTCBhbmQg dGhlIGZpcnN0UGFydHlGb3JDb29raWVzIGFyZSBmcm9tIGRpZmZlcmVudCBob3N0cy4KKyAgICAv LworICAgIC8vIE5vdGU6IFNvbWUgcG9ydHMgKGluY2x1ZGluZyBwb3NzaWJseSBBcHBsZSdzKSBv bmx5IGNvbnNpZGVyIHRoZQorICAgIC8vICAgICAgIGRvY3VtZW50IGluIGEgdGhpcmQtcGFydHkg Y29udGV4dCBpZiB0aGUgY29va2llVVJMIGFuZCB0aGUKKyAgICAvLyAgICAgICBmaXJzdFBhcnR5 Rm9yQ29va2llcyBoYXZlIGEgZGlmZmVyZW50IHJlZ2lzdHJ5LWNvbnRyb2xsZWQKKyAgICAvLyAg ICAgICBkb21haW4uCisgICAgLy8KICAgICBjb25zdCBLVVJMJiBmaXJzdFBhcnR5Rm9yQ29va2ll cygpIGNvbnN0IHsgcmV0dXJuIG1fZmlyc3RQYXJ0eUZvckNvb2tpZXM7IH0KICAgICB2b2lkIHNl dEZpcnN0UGFydHlGb3JDb29raWVzKGNvbnN0IEtVUkwmIHVybCkgeyBtX2ZpcnN0UGFydHlGb3JD b29raWVzID0gdXJsOyB9CiAgICAgCg== 49869 2010-03-02 17:07:35 -0800 2010-03-03 00:31:44 -0800 Patch for landing bug-35613-20100302170732.patch text/plain 2187 abarth ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg YjRlZjAyZC4uZmQ2MzRiNCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAxMC0wMy0wMiAgQWRhbSBCYXJ0aCAg PGFiYXJ0aEB3ZWJraXQub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIERvY3VtZW50IGNvb2tpZVVSTCBhbmQgZmlyc3RQYXJ0eUZvckNvb2tpZXMK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM1NjEzCisK KyAgICAgICAgU29tZSBmb2xrcyBhc2tlZCB3aGF0IHRoZSBjb29raWVVUkwgYW5kIHRoZSBmaXJz dFBhcnR5Rm9yQ29va2llcyB3ZXJlCisgICAgICAgIG9uIElSQy4gIFRoaXMgcGF0Y2ggZG9jdW1l bnRzIHRoZXNlIHByb3BlcnRpZXMgaW4gdGhlIGNvZGUgc28gZm9sa3MKKyAgICAgICAgZG9uJ3Qg aGF2ZSB0byBhc2sgb24gSVJDIGFueW1vcmUuCisKKyAgICAgICAgKiBkb20vRG9jdW1lbnQuaDoK KwogMjAxMC0wMy0wMiAgQW5kZXJzIENhcmxzc29uICA8YW5kZXJzY2FAYXBwbGUuY29tPgogCiAg ICAgICAgIFJldmlld2VkIGJ5IFNhbSBXZWluaWcuCmRpZmYgLS1naXQgYS9XZWJDb3JlL2RvbS9E b2N1bWVudC5oIGIvV2ViQ29yZS9kb20vRG9jdW1lbnQuaAppbmRleCBlOGIzZTZlLi4yMGRmMTM4 IDEwMDY0NAotLS0gYS9XZWJDb3JlL2RvbS9Eb2N1bWVudC5oCisrKyBiL1dlYkNvcmUvZG9tL0Rv Y3VtZW50LmgKQEAgLTcxNCw4ICs3MTQsMjggQEAgcHVibGljOgogCiAgICAgU3RyaW5nIGxhc3RN b2RpZmllZCgpIGNvbnN0OwogCisgICAgLy8gVGhlIGNvb2tpZVVSTCBpcyB1c2VkIHRvIHF1ZXJ5 IHRoZSBjb29raWUgZGF0YWJhc2UgZm9yIHRoaXMgZG9jdW1lbnQncworICAgIC8vIGNvb2tpZXMu IEZvciBleGFtcGxlLCBpZiB0aGUgY29va2llIFVSTCBpcyBodHRwOi8vZXhhbXBsZS5jb20sIHdl J2xsCisgICAgLy8gdXNlIHRoZSBub24tU2VjdXJlIGNvb2tpZXMgZm9yIGV4YW1wbGUuY29tIHdo ZW4gY29tcHV0aW5nCisgICAgLy8gZG9jdW1lbnQuY29va2llLgorICAgIC8vCisgICAgLy8gUTog SG93IGlzIHRoZSBjb29raWVVUkwgZGlmZmVyZW50IGZyb20gdGhlIGRvY3VtZW50J3MgVVJMPwor ICAgIC8vIEE6IFRoZSB0d28gVVJMcyBhcmUgdGhlIHNhbWUgYWxtb3N0IGFsbCB0aGUgdGltZS4g IEhvd2V2ZXIsIGlmIG9uZQorICAgIC8vICAgIGRvY3VtZW50IGluaGVyaXRzIHRoZSBzZWN1cml0 eSBjb250ZXh0IG9mIGFub3RoZXIgZG9jdW1lbnQsIGl0CisgICAgLy8gICAgaW5oZXJpdHMgaXRz IGNvb2tpZVVSTCBidXQgbm90IGl0cyBVUkwuCisgICAgLy8KICAgICBjb25zdCBLVVJMJiBjb29r aWVVUkwoKSBjb25zdCB7IHJldHVybiBtX2Nvb2tpZVVSTDsgfQogCisgICAgLy8gVGhlIGZpcnN0 UGFydHlGb3JDb29raWVzIGlzIHVzZWQgdG8gY29tcHV0ZSB3aGV0aGVyIHRoaXMgZG9jdW1lbnQK KyAgICAvLyBhcHBlYXJzIGluIGEgInRoaXJkLXBhcnR5IiBjb250ZXh0IGZvciB0aGUgcHVycG9z ZSBvZiB0aGlyZC1wYXJ0eQorICAgIC8vIGNvb2tpZSBibG9ja2luZy4gIFRoZSBkb2N1bWVudCBp cyBpbiBhIHRoaXJkLXBhcnR5IGNvbnRleHQgaWYgdGhlCisgICAgLy8gY29va2llVVJMIGFuZCB0 aGUgZmlyc3RQYXJ0eUZvckNvb2tpZXMgYXJlIGZyb20gZGlmZmVyZW50IGhvc3RzLgorICAgIC8v CisgICAgLy8gTm90ZTogU29tZSBwb3J0cyAoaW5jbHVkaW5nIHBvc3NpYmx5IEFwcGxlJ3MpIG9u bHkgY29uc2lkZXIgdGhlCisgICAgLy8gICAgICAgZG9jdW1lbnQgaW4gYSB0aGlyZC1wYXJ0eSBj b250ZXh0IGlmIHRoZSBjb29raWVVUkwgYW5kIHRoZQorICAgIC8vICAgICAgIGZpcnN0UGFydHlG b3JDb29raWVzIGhhdmUgYSBkaWZmZXJlbnQgcmVnaXN0cnktY29udHJvbGxlZAorICAgIC8vICAg ICAgIGRvbWFpbi4KKyAgICAvLwogICAgIGNvbnN0IEtVUkwmIGZpcnN0UGFydHlGb3JDb29raWVz KCkgY29uc3QgeyByZXR1cm4gbV9maXJzdFBhcnR5Rm9yQ29va2llczsgfQogICAgIHZvaWQgc2V0 Rmlyc3RQYXJ0eUZvckNvb2tpZXMoY29uc3QgS1VSTCYgdXJsKSB7IG1fZmlyc3RQYXJ0eUZvckNv b2tpZXMgPSB1cmw7IH0KICAgICAK