35601 2010-03-02 13:59:18 -0800 new-run-webkit-tests doesn't work on chromium-win (close_fds not supported) 2010-03-02 16:14:46 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 dpranke dpranke abarth eric oldest_to_newest 195216 0 dpranke 2010-03-02 13:59:18 -0800 Bug 35553 introduced a workaround to a python bug in subprocess.open(). Unfortunately, the workaround causes new-run-webkit-tests to fail outright on windows because the parameter (close_fds) isn't supported. 195218 1 49844 dpranke 2010-03-02 14:02:46 -0800 Created attachment 49844 Patch 195229 2 49844 dglazkov 2010-03-02 14:15:17 -0800 Comment on attachment 49844 Patch ok. 195301 3 dpranke 2010-03-02 16:14:46 -0800 Fix landed as http://trac.webkit.org/changeset/55434 . 49844 2010-03-02 14:02:46 -0800 2010-03-02 14:15:17 -0800 Patch bug-35601-20100302140245.patch text/plain 1973 dpranke ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCA5OTVhYzI1Li42OWY5ZGRjIDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VM b2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTAtMDMt MDIgIERpcmsgUHJhbmtlICA8ZHByYW5rZUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgcjU1Mzg4IChidWcgMzU1NTMpIHdvcmtl ZCBhcm91bmQgYSBidWcgaW4gUHl0aG9uJ3Mgc3VicHJvY2Vzcy5Qb3BlbigpCisgICAgICAgIHRo YXQgd2FzIGNhdXNpbmcgRFJUIHRvIGhhbmcgb24gZXhpdCBpbiBuZXctcnVuLXdlYmtpdC10ZXN0 cy4KKyAgICAgICAgVW5mb3J0dW5hdGVseSwgdGhhdCB3b3JrYXJvdW5kIGRvZXNuJ3Qgd29yayBv biBjaHJvbWl1bS13aW4KKyAgICAgICAgKGFuZCB0aGUgc2NyaXB0IGZhaWxzIGNvbXBsZXRlbHkp LiBUaGUgZ29vZCBuZXdzIGlzIHRoYXQgdGhlIGNoZWNrCisgICAgICAgIGlzbid0IGFjdHVhbGx5 IG5lY2Vzc2FyeSwgYW5kIHNvIHRoaXMgY2hhbmdlIG1ha2VzIGl0IGNvbmRpdGlvbmFsLgorCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zNTYwMQorCisg ICAgICAgICogU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC9jaHJvbWl1bS5weToK KwogMjAxMC0wMy0wMiAgR3VzdGF2byBOb3JvbmhhIFNpbHZhICA8Z3VzdGF2by5ub3JvbmhhQGNv bGxhYm9yYS5jby51az4KIAogICAgICAgICBSZXZpZXdlZCBieSBBbGV4ZXkgUHJvc2t1cnlha292 LgpkaWZmIC0tZ2l0IGEvV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMv cG9ydC9jaHJvbWl1bS5weSBiL1dlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rl c3RzL3BvcnQvY2hyb21pdW0ucHkKaW5kZXggZjU3ZmE3NC4uMTAyNTlhMCAxMDA2NDQKLS0tIGEv V2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC9jaHJvbWl1bS5w eQorKysgYi9XZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L2No cm9taXVtLnB5CkBAIC0yMzEsMTAgKzIzMSwxMyBAQCBjbGFzcyBDaHJvbWl1bURyaXZlcihiYXNl LkRyaXZlcik6CiAgICAgICAgICMgV2UgbmVlZCB0byBwYXNzIGNsb3NlX2Zkcz1UcnVlIHRvIHdv cmsgYXJvdW5kIFB5dGhvbiBidWcgIzIzMjAKICAgICAgICAgIyAob3RoZXJ3aXNlIHdlIGNhbiBo YW5nIHdoZW4gd2Uga2lsbCB0ZXN0X3NoZWxsIHdoZW4gd2UgYXJlIHJ1bm5pbmcKICAgICAgICAg IyBtdWx0aXBsZSB0aHJlYWRzKS4gU2VlIGh0dHA6Ly9idWdzLnB5dGhvbi5vcmcvaXNzdWUyMzIw IC4KKyAgICAgICAgIyBOb3RlIHRoYXQgY2xvc2VfZmRzIGlzbid0IHN1cHBvcnRlZCBvbiBXaW5k b3dzLCBidXQgdGhpcyBidWcgb25seQorICAgICAgICAjIHNob3dzIHVwIG9uIE1hYyBhbmQgTGlu dXguCisgICAgICAgIGNsb3NlX2ZsYWcgPSBzeXMucGxhdGZvcm0gbm90IGluICgnd2luMzInLCAn Y3lnd2luJykKICAgICAgICAgc2VsZi5fcHJvYyA9IHN1YnByb2Nlc3MuUG9wZW4oY21kLCBzdGRp bj1zdWJwcm9jZXNzLlBJUEUsCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg IHN0ZG91dD1zdWJwcm9jZXNzLlBJUEUsCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgIHN0ZGVycj1zdWJwcm9jZXNzLlNURE9VVCwKLSAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgY2xvc2VfZmRzPVRydWUpCisgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgIGNsb3NlX2Zkcz1jbG9zZV9mbGFnKQogICAgIGRlZiBwb2xsKHNlbGYpOgog ICAgICAgICByZXR1cm4gc2VsZi5fcHJvYy5wb2xsKCkKIAo=