35600 2010-03-02 13:48:15 -0800 shouldBe() fails when comparing an array to null 2010-03-02 14:26:18 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 ap ap aroben oldest_to_newest 195211 0 ap 2010-03-02 13:48:15 -0800 Patch forthcoming. 195213 1 49842 ap 2010-03-02 13:50:06 -0800 Created attachment 49842 proposed fix 195214 2 49842 aroben 2010-03-02 13:52:32 -0800 Comment on attachment 49842 proposed fix r=me 195226 3 49847 ap 2010-03-02 14:10:46 -0800 Created attachment 49847 a working fix 195227 4 49847 aroben 2010-03-02 14:12:46 -0800 Comment on attachment 49847 a working fix Is there any value in communicating more information about what happened? r=me 195236 5 ap 2010-03-02 14:26:18 -0800 Committed <http://trac.webkit.org/changeset/55430>. > Is there any value in communicating more information about what happened? Not in this specific case - shouldBe(myArray, null) just needs to silently return false. It may be more interesting in other cases, but it may be not. 49842 2010-03-02 13:50:06 -0800 2010-03-02 14:10:46 -0800 proposed fix shouldBeArrayNull.txt text/plain 1445 ap SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDU1NDI4KQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTAtMDMtMDIgIEFsZXhleSBQcm9za3VyeWFr b3YgIDxhcEBhcHBsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM1NjAw CisgICAgICAgIHNob3VsZEJlKCkgZmFpbHMgd2hlbiBjb21wYXJpbmcgYW4gYXJyYXkgdG8gbnVs bC4KKworICAgICAgICAqIGZhc3QvanMvcmVzb3VyY2VzL2pzLXRlc3QtcHJlLmpzOiAoaXNSZXN1 bHRDb3JyZWN0KTogQ2hlY2sgYm90aCBleHBlY3RlZCBhbmQgYWN0dWFsIHR5cGVzCisgICAgICAg IGJlZm9yZSBjYWxsaW5nIGNvZGUgdGhhdCBvbmx5IGRlYWxzIHdpdGggYXJyYXlzLgorCiAyMDEw LTAzLTAyICBCcmFkeSBFaWRzb24gIDxiZWlkc29uQGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZp ZXdlZCBieSBTYW0gV2VpbmlnLgpJbmRleDogTGF5b3V0VGVzdHMvZmFzdC9qcy9yZXNvdXJjZXMv anMtdGVzdC1wcmUuanMKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvZmFzdC9qcy9yZXNvdXJj ZXMvanMtdGVzdC1wcmUuanMJKHJldmlzaW9uIDU1MjYxKQorKysgTGF5b3V0VGVzdHMvZmFzdC9q cy9yZXNvdXJjZXMvanMtdGVzdC1wcmUuanMJKHdvcmtpbmcgY29weSkKQEAgLTYwLDcgKzYwLDgg QEAgZnVuY3Rpb24gaXNSZXN1bHRDb3JyZWN0KF9hY3R1YWwsIF9leHBlYwogICAgICAgICByZXR1 cm4gdHJ1ZTsKICAgICBpZiAodHlwZW9mKF9leHBlY3RlZCkgPT0gIm51bWJlciIgJiYgaXNOYU4o X2V4cGVjdGVkKSkKICAgICAgICAgcmV0dXJuIHR5cGVvZihfYWN0dWFsKSA9PSAibnVtYmVyIiAm JiBpc05hTihfYWN0dWFsKTsKLSAgICBpZiAoT2JqZWN0LnByb3RvdHlwZS50b1N0cmluZy5jYWxs KF9leHBlY3RlZCkgPT0gT2JqZWN0LnByb3RvdHlwZS50b1N0cmluZy5jYWxsKFtdKSkKKyAgICBp ZiAoT2JqZWN0LnByb3RvdHlwZS50b1N0cmluZy5jYWxsKF9leHBlY3RlZCkgPT0gT2JqZWN0LnBy b3RvdHlwZS50b1N0cmluZy5jYWxsKFtdKQorICAgICAgICAmJiBPYmplY3QucHJvdG90eXBlLnRv U3RyaW5nLmNhbGwoX2FjdHVhbCkgPT0gT2JqZWN0LnByb3RvdHlwZS50b1N0cmluZy5jYWxsKFtd KSkKICAgICAgICAgcmV0dXJuIGFyZUFycmF5c0VxdWFsKF9hY3R1YWwsIF9leHBlY3RlZCk7CiAg ICAgcmV0dXJuIGZhbHNlOwogfQo= 49847 2010-03-02 14:10:46 -0800 2010-03-02 14:12:46 -0800 a working fix shouldBeArrayNull.txt text/plain 1477 ap SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDU1NDI4KQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTAtMDMtMDIgIEFsZXhleSBQcm9za3VyeWFr b3YgIDxhcEBhcHBsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM1NjAw CisgICAgICAgIHNob3VsZEJlKCkgZmFpbHMgd2hlbiBjb21wYXJpbmcgYW4gYXJyYXkgdG8gbnVs bC4KKworICAgICAgICAqIGZhc3QvanMvcmVzb3VyY2VzL2pzLXRlc3QtcHJlLmpzOiAoYXJlQXJy YXlzRXF1YWwpOiBUaGlzIGZ1bmN0aW9uIGlzIGV4cGVjdGVkIHRvIGJlIGNhbGxlZAorICAgICAg ICB3aXRoIHdlaXJkIGFyZ3VtZW50cywgYXMgaXQncyB1c2VkIHdpdGggYXJyYXktbGlrZSBvYmpl Y3RzIGxpa2UgV2ViR0xCeXRlQXJyYXkuIE1hZGUgaXQKKyAgICAgICAgcmVzaWxpZW50IGFnYWlu c3QgZXhjZXB0aW9ucyByYWlzZWQgd2hlbiBkZWFsaW5nIHdpdGggdGhvc2UuCisKIDIwMTAtMDMt MDIgIEJyYWR5IEVpZHNvbiAgPGJlaWRzb25AYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2Vk IGJ5IFNhbSBXZWluaWcuCkluZGV4OiBMYXlvdXRUZXN0cy9mYXN0L2pzL3Jlc291cmNlcy9qcy10 ZXN0LXByZS5qcwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9mYXN0L2pzL3Jlc291cmNlcy9q cy10ZXN0LXByZS5qcwkocmV2aXNpb24gNTUyNjEpCisrKyBMYXlvdXRUZXN0cy9mYXN0L2pzL3Jl c291cmNlcy9qcy10ZXN0LXByZS5qcwkod29ya2luZyBjb3B5KQpAQCAtMzcsMTEgKzM3LDE1IEBA IGZ1bmN0aW9uIHRlc3RGYWlsZWQobXNnKQogCiBmdW5jdGlvbiBhcmVBcnJheXNFcXVhbChfYSwg X2IpCiB7Ci0gICAgaWYgKF9hLmxlbmd0aCAhPT0gX2IubGVuZ3RoKQotICAgICAgICByZXR1cm4g ZmFsc2U7Ci0gICAgZm9yICh2YXIgaSA9IDA7IGkgPCBfYS5sZW5ndGg7IGkrKykKLSAgICAgICAg aWYgKF9hW2ldICE9PSBfYltpXSkKKyAgICB0cnkgeworICAgICAgICBpZiAoX2EubGVuZ3RoICE9 PSBfYi5sZW5ndGgpCiAgICAgICAgICAgICByZXR1cm4gZmFsc2U7CisgICAgICAgIGZvciAodmFy IGkgPSAwOyBpIDwgX2EubGVuZ3RoOyBpKyspCisgICAgICAgICAgICBpZiAoX2FbaV0gIT09IF9i W2ldKQorICAgICAgICAgICAgICAgIHJldHVybiBmYWxzZTsKKyAgICB9IGNhdGNoIChleCkgewor ICAgICAgICByZXR1cm4gZmFsc2U7CisgICAgfQogICAgIHJldHVybiB0cnVlOwogfQogCg==