35592 2010-03-02 11:22:33 -0800 Expose a WebDocument::firstPartyForCookies property 2010-03-13 00:31:24 -0800 1 1 1 Unclassified WebKit WebKit API 528+ (Nightly build) All All RESOLVED FIXED P2 Enhancement --- 1 wtc eroman abarth commit-queue fishd oldest_to_newest 195128 0 wtc 2010-03-02 11:22:33 -0800 This bug proposes that we add a firstPartyForCookies method to WebDocument to expose the firstPartyForCookies property of the underlying Document. This was suggested by Darin Fisher in Chromium code review http://codereview.chromium.org/601038. The attached patch does that. I'm having problem running the prepare-ChangeLog script, so the patch was not generated properly. Here is the prepare-ChangeLog error I got: $ /d/chrome-nss-static/src/third_party/WebKit/WebKitTools/Scripts/prepare-Chang eLog --name="Wan-Teh Chang" --email=wtc@google.com WebKit/chromium Running status to find changed, added, or removed files. ? WebKit\chromium\WebKit.sln ? WebKit\chromium\webkit.vcproj ? WebKit\chromium\webkit_unit_tests.vcproj.GOOGLE.wtc.user ? WebKit\chromium\webkit_unit_tests.vcproj ? WebKit\chromium\webkit.vcproj.GOOGLE.wtc.user Reviewing diff to determine which lines changed. Extracting affected function names from source files. Change author: Wan-Teh Chang <wtc@google.com>. Running 'svn update' to update ChangeLog files. Can't use an undefined value as filehandle reference at /d/chrome-nss-static/src /third_party/WebKit/WebKitTools/Scripts/prepare-ChangeLog line 328. 195129 1 49820 wtc 2010-03-02 11:23:15 -0800 Created attachment 49820 Patch (not generated properly) 195165 2 fishd 2010-03-02 12:22:21 -0800 Try running prepare-ChangeLog from within the WebKit/chromium directory. 195778 3 49953 wtc 2010-03-03 15:09:10 -0800 Created attachment 49953 Proposed patch Eric Roman generated a patch properly. 195782 4 49953 fishd 2010-03-03 15:14:53 -0800 Comment on attachment 49953 Proposed patch > Index: ChangeLog > =================================================================== > --- ChangeLog (revision 55480) > +++ ChangeLog (working copy) > @@ -1,3 +1,13 @@ > +2010-03-03 Eric Roman <eroman@chromium.org> > + > + Reviewed by NOBODY (OOPS!). > + > + Add a firstPartyForCookies() property to WebDocument. actually, this needs to include a link back to this bug. sorry for wasting cycles. please add this link before committing. r=me otherwise (cq- because this patch needs an edit before it can be committed) 195785 5 49954 wtc 2010-03-03 15:19:23 -0800 Created attachment 49954 Proposed patch (with link to bug report) No problem. Here it is. 195913 6 49954 commit-queue 2010-03-03 23:45:17 -0800 Comment on attachment 49954 Proposed patch (with link to bug report) Rejecting patch 49954 from commit-queue. Failed to run "['/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', '--reviewer', 'Darin Fisher', '--force']" exit_code: 1 Last 500 characters of output: ------------------------- No file to patch. Skipping patch. 1 out of 1 hunk ignored can't find file to patch at input line 5 Perhaps you used the wrong -p or --strip option? The text leading up to this was: -------------------------- |Index: src/WebDocument.cpp |=================================================================== |--- src/WebDocument.cpp (revision 55462) |+++ src/WebDocument.cpp (working copy) -------------------------- No file to patch. Skipping patch. 1 out of 1 hunk ignored Full output: http://webkit-commit-queue.appspot.com/results/332304 196015 7 49954 abarth 2010-03-04 05:44:29 -0800 Comment on attachment 49954 Proposed patch (with link to bug report) This patch is incorrectly based in $WEBKIT/WebKit/chromium instead of in $WEBKIT itself. It will need to be landed manually. 196638 8 49953 commit-queue 2010-03-05 14:03:01 -0800 Comment on attachment 49953 Proposed patch Cleared Darin Fisher's review+ from obsolete attachment 49953 so that this bug does not appear in http://webkit.org/pending-commit. 199131 9 50609 wtc 2010-03-12 10:50:44 -0800 Created attachment 50609 Proposed patch (with correct pathnames) I fixed the pathnames in the patch. Please review again. Sorry to waste your time. 199135 10 50609 abarth 2010-03-12 10:58:09 -0800 Comment on attachment 50609 Proposed patch (with correct pathnames) No worries. 199323 11 50609 commit-queue 2010-03-13 00:31:19 -0800 Comment on attachment 50609 Proposed patch (with correct pathnames) Clearing flags on attachment: 50609 Committed r55952: <http://trac.webkit.org/changeset/55952> 199324 12 commit-queue 2010-03-13 00:31:24 -0800 All reviewed patches have been landed. Closing bug. 49820 2010-03-02 11:23:15 -0800 2010-03-03 15:09:40 -0800 Patch (not generated properly) webdocument.txt text/plain 999 wtc SW5kZXg6IHNyYy9XZWJEb2N1bWVudC5jcHANCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0NCi0tLSBzcmMvV2ViRG9jdW1l bnQuY3BwCShyZXZpc2lvbiA1NTQxNikNCisrKyBzcmMvV2ViRG9jdW1lbnQuY3BwCSh3b3JraW5n IGNvcHkpDQpAQCAtODQsNiArODQsMTEgQEANCiAgICAgcmV0dXJuIGNvbnN0VW53cmFwPERvY3Vt ZW50PigpLT5iYXNlVVJMKCk7CiB9CiAKK1dlYlVSTCBXZWJEb2N1bWVudDo6Zmlyc3RQYXJ0eUZv ckNvb2tpZXMoKSBjb25zdAoreworICAgIHJldHVybiBjb25zdFVud3JhcDxEb2N1bWVudD4oKS0+ Zmlyc3RQYXJ0eUZvckNvb2tpZXMoKTsKK30KKwogV2ViRWxlbWVudCBXZWJEb2N1bWVudDo6ZG9j dW1lbnRFbGVtZW50KCkgY29uc3QKIHsKICAgICByZXR1cm4gV2ViRWxlbWVudChjb25zdFVud3Jh cDxEb2N1bWVudD4oKS0+ZG9jdW1lbnRFbGVtZW50KCkpOwpJbmRleDogcHVibGljL1dlYkRvY3Vt ZW50LmgNCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0NCi0tLSBwdWJsaWMvV2ViRG9jdW1lbnQuaAkocmV2aXNpb24gNTU0 MTYpDQorKysgcHVibGljL1dlYkRvY3VtZW50LmgJKHdvcmtpbmcgY29weSkNCkBAIC02Myw2ICs2 Myw3IEBADQogICAgIFdFQktJVF9BUEkgV2ViRnJhbWUqIGZyYW1lKCkgY29uc3Q7CiAgICAgV0VC S0lUX0FQSSBib29sIGlzSFRNTERvY3VtZW50KCkgY29uc3Q7CiAgICAgV0VCS0lUX0FQSSBXZWJV UkwgYmFzZVVSTCgpIGNvbnN0OworICAgIFdFQktJVF9BUEkgV2ViVVJMIGZpcnN0UGFydHlGb3JD b29raWVzKCkgY29uc3Q7CiAgICAgV0VCS0lUX0FQSSBXZWJFbGVtZW50IGRvY3VtZW50RWxlbWVu dCgpIGNvbnN0OwogICAgIFdFQktJVF9BUEkgV2ViRWxlbWVudCBib2R5KCkgY29uc3Q7CiAgICAg V0VCS0lUX0FQSSBXZWJFbGVtZW50IGhlYWQoKTsK 49953 2010-03-03 15:09:10 -0800 2010-03-05 14:03:01 -0800 Proposed patch eroman-webkit.patch text/plain 1551 wtc SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDU1NDgw KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTAtMDMt MDMgIEVyaWMgUm9tYW4gIDxlcm9tYW5AY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFkZCBhIGZpcnN0UGFydHlGb3JDb29raWVz KCkgcHJvcGVydHkgdG8gV2ViRG9jdW1lbnQuCisKKyAgICAgICAgKiBwdWJsaWMvV2ViRG9jdW1l bnQuaDoKKyAgICAgICAgKiBzcmMvV2ViRG9jdW1lbnQuY3BwOgorICAgICAgICAoV2ViS2l0OjpX ZWJEb2N1bWVudDo6Zmlyc3RQYXJ0eUZvckNvb2tpZXMpOgorCiAyMDEwLTAzLTAyICBUb255IENo YW5nICA8dG9ueUBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGFyaW4gRmlz aGVyLgpJbmRleDogcHVibGljL1dlYkRvY3VtZW50LmgKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gcHVibGljL1dl YkRvY3VtZW50LmgJKHJldmlzaW9uIDU1NDYyKQorKysgcHVibGljL1dlYkRvY3VtZW50LmgJKHdv cmtpbmcgY29weSkKQEAgLTYzLDYgKzYzLDcgQEAgcHVibGljOgogICAgIFdFQktJVF9BUEkgV2Vi RnJhbWUqIGZyYW1lKCkgY29uc3Q7CiAgICAgV0VCS0lUX0FQSSBib29sIGlzSFRNTERvY3VtZW50 KCkgY29uc3Q7CiAgICAgV0VCS0lUX0FQSSBXZWJVUkwgYmFzZVVSTCgpIGNvbnN0OworICAgIFdF QktJVF9BUEkgV2ViVVJMIGZpcnN0UGFydHlGb3JDb29raWVzKCkgY29uc3Q7CiAgICAgV0VCS0lU X0FQSSBXZWJFbGVtZW50IGRvY3VtZW50RWxlbWVudCgpIGNvbnN0OwogICAgIFdFQktJVF9BUEkg V2ViRWxlbWVudCBib2R5KCkgY29uc3Q7CiAgICAgV0VCS0lUX0FQSSBXZWJFbGVtZW50IGhlYWQo KTsKSW5kZXg6IHNyYy9XZWJEb2N1bWVudC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gc3JjL1dlYkRvY3Vt ZW50LmNwcAkocmV2aXNpb24gNTU0NjIpCisrKyBzcmMvV2ViRG9jdW1lbnQuY3BwCSh3b3JraW5n IGNvcHkpCkBAIC04NCw2ICs4NCwxMSBAQCBXZWJVUkwgV2ViRG9jdW1lbnQ6OmJhc2VVUkwoKSBj b25zdAogICAgIHJldHVybiBjb25zdFVud3JhcDxEb2N1bWVudD4oKS0+YmFzZVVSTCgpOwogfQog CitXZWJVUkwgV2ViRG9jdW1lbnQ6OmZpcnN0UGFydHlGb3JDb29raWVzKCkgY29uc3QKK3sKKyAg ICByZXR1cm4gY29uc3RVbndyYXA8RG9jdW1lbnQ+KCktPmZpcnN0UGFydHlGb3JDb29raWVzKCk7 Cit9CisKIFdlYkVsZW1lbnQgV2ViRG9jdW1lbnQ6OmRvY3VtZW50RWxlbWVudCgpIGNvbnN0CiB7 CiAgICAgcmV0dXJuIFdlYkVsZW1lbnQoY29uc3RVbndyYXA8RG9jdW1lbnQ+KCktPmRvY3VtZW50 RWxlbWVudCgpKTsK 49954 2010-03-03 15:19:23 -0800 2010-03-12 10:50:44 -0800 Proposed patch (with link to bug report) eroman-webkit.patch text/plain 1606 wtc SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDU1NDgw KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTAtMDMt MDMgIEVyaWMgUm9tYW4gIDxlcm9tYW5AY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFkZCBhIGZpcnN0UGFydHlGb3JDb29raWVz KCkgcHJvcGVydHkgdG8gV2ViRG9jdW1lbnQuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0zNTU5MgorCisgICAgICAgICogcHVibGljL1dlYkRvY3VtZW50 Lmg6CisgICAgICAgICogc3JjL1dlYkRvY3VtZW50LmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2Vi RG9jdW1lbnQ6OmZpcnN0UGFydHlGb3JDb29raWVzKToKKwogMjAxMC0wMy0wMiAgVG9ueSBDaGFu ZyAgPHRvbnlAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERhcmluIEZpc2hl ci4KSW5kZXg6IHB1YmxpYy9XZWJEb2N1bWVudC5oCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIHB1YmxpYy9XZWJE b2N1bWVudC5oCShyZXZpc2lvbiA1NTQ2MikKKysrIHB1YmxpYy9XZWJEb2N1bWVudC5oCSh3b3Jr aW5nIGNvcHkpCkBAIC02Myw2ICs2Myw3IEBAIHB1YmxpYzoKICAgICBXRUJLSVRfQVBJIFdlYkZy YW1lKiBmcmFtZSgpIGNvbnN0OwogICAgIFdFQktJVF9BUEkgYm9vbCBpc0hUTUxEb2N1bWVudCgp IGNvbnN0OwogICAgIFdFQktJVF9BUEkgV2ViVVJMIGJhc2VVUkwoKSBjb25zdDsKKyAgICBXRUJL SVRfQVBJIFdlYlVSTCBmaXJzdFBhcnR5Rm9yQ29va2llcygpIGNvbnN0OwogICAgIFdFQktJVF9B UEkgV2ViRWxlbWVudCBkb2N1bWVudEVsZW1lbnQoKSBjb25zdDsKICAgICBXRUJLSVRfQVBJIFdl YkVsZW1lbnQgYm9keSgpIGNvbnN0OwogICAgIFdFQktJVF9BUEkgV2ViRWxlbWVudCBoZWFkKCk7 CkluZGV4OiBzcmMvV2ViRG9jdW1lbnQuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIHNyYy9XZWJEb2N1bWVu dC5jcHAJKHJldmlzaW9uIDU1NDYyKQorKysgc3JjL1dlYkRvY3VtZW50LmNwcAkod29ya2luZyBj b3B5KQpAQCAtODQsNiArODQsMTEgQEAgV2ViVVJMIFdlYkRvY3VtZW50OjpiYXNlVVJMKCkgY29u c3QKICAgICByZXR1cm4gY29uc3RVbndyYXA8RG9jdW1lbnQ+KCktPmJhc2VVUkwoKTsKIH0KIAor V2ViVVJMIFdlYkRvY3VtZW50OjpmaXJzdFBhcnR5Rm9yQ29va2llcygpIGNvbnN0Cit7CisgICAg cmV0dXJuIGNvbnN0VW53cmFwPERvY3VtZW50PigpLT5maXJzdFBhcnR5Rm9yQ29va2llcygpOwor fQorCiBXZWJFbGVtZW50IFdlYkRvY3VtZW50Ojpkb2N1bWVudEVsZW1lbnQoKSBjb25zdAogewog ICAgIHJldHVybiBXZWJFbGVtZW50KGNvbnN0VW53cmFwPERvY3VtZW50PigpLT5kb2N1bWVudEVs ZW1lbnQoKSk7Cg== 50609 2010-03-12 10:50:44 -0800 2010-03-13 00:31:19 -0800 Proposed patch (with correct pathnames) eroman-webkit-2.patch text/plain 1750 wtc SW5kZXg6IFdlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZwkocmV2aXNpb24gNTU0ODApCisrKyBXZWJLaXQvY2hyb21pdW0vQ2hh bmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTAtMDMtMDMgIEVyaWMg Um9tYW4gIDxlcm9tYW5AY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIEFkZCBhIGZpcnN0UGFydHlGb3JDb29raWVzKCkgcHJvcGVy dHkgdG8gV2ViRG9jdW1lbnQuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0zNTU5MgorCisgICAgICAgICogcHVibGljL1dlYkRvY3VtZW50Lmg6CisgICAg ICAgICogc3JjL1dlYkRvY3VtZW50LmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2ViRG9jdW1lbnQ6 OmZpcnN0UGFydHlGb3JDb29raWVzKToKKwogMjAxMC0wMy0wMiAgVG9ueSBDaGFuZyAgPHRvbnlA Y2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERhcmluIEZpc2hlci4KSW5kZXg6 IFdlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViRG9jdW1lbnQuaAo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJL aXQvY2hyb21pdW0vcHVibGljL1dlYkRvY3VtZW50LmgJKHJldmlzaW9uIDU1NDYyKQorKysgV2Vi S2l0L2Nocm9taXVtL3B1YmxpYy9XZWJEb2N1bWVudC5oCSh3b3JraW5nIGNvcHkpCkBAIC02Myw2 ICs2Myw3IEBAIHB1YmxpYzoKICAgICBXRUJLSVRfQVBJIFdlYkZyYW1lKiBmcmFtZSgpIGNvbnN0 OwogICAgIFdFQktJVF9BUEkgYm9vbCBpc0hUTUxEb2N1bWVudCgpIGNvbnN0OwogICAgIFdFQktJ VF9BUEkgV2ViVVJMIGJhc2VVUkwoKSBjb25zdDsKKyAgICBXRUJLSVRfQVBJIFdlYlVSTCBmaXJz dFBhcnR5Rm9yQ29va2llcygpIGNvbnN0OwogICAgIFdFQktJVF9BUEkgV2ViRWxlbWVudCBkb2N1 bWVudEVsZW1lbnQoKSBjb25zdDsKICAgICBXRUJLSVRfQVBJIFdlYkVsZW1lbnQgYm9keSgpIGNv bnN0OwogICAgIFdFQktJVF9BUEkgV2ViRWxlbWVudCBoZWFkKCk7CkluZGV4OiBXZWJLaXQvY2hy b21pdW0vc3JjL1dlYkRvY3VtZW50LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXQvY2hyb21pdW0v c3JjL1dlYkRvY3VtZW50LmNwcAkocmV2aXNpb24gNTU0NjIpCisrKyBXZWJLaXQvY2hyb21pdW0v c3JjL1dlYkRvY3VtZW50LmNwcAkod29ya2luZyBjb3B5KQpAQCAtODQsNiArODQsMTEgQEAgV2Vi VVJMIFdlYkRvY3VtZW50OjpiYXNlVVJMKCkgY29uc3QKICAgICByZXR1cm4gY29uc3RVbndyYXA8 RG9jdW1lbnQ+KCktPmJhc2VVUkwoKTsKIH0KIAorV2ViVVJMIFdlYkRvY3VtZW50OjpmaXJzdFBh cnR5Rm9yQ29va2llcygpIGNvbnN0Cit7CisgICAgcmV0dXJuIGNvbnN0VW53cmFwPERvY3VtZW50 PigpLT5maXJzdFBhcnR5Rm9yQ29va2llcygpOworfQorCiBXZWJFbGVtZW50IFdlYkRvY3VtZW50 Ojpkb2N1bWVudEVsZW1lbnQoKSBjb25zdAogewogICAgIHJldHVybiBXZWJFbGVtZW50KGNvbnN0 VW53cmFwPERvY3VtZW50PigpLT5kb2N1bWVudEVsZW1lbnQoKSk7Cg==