35588 2010-03-02 10:40:02 -0800 [V8] NPN_GetProperty shouldn't crash if the property doesn't exist 2010-03-02 17:11:50 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 japhet japhet ap dglazkov oldest_to_newest 195105 0 japhet 2010-03-02 10:40:02 -0800 Currently, if the property doesn't exist, v8::Object::Get() returns an empty handle and we fail an ASSERT when we try to convert that handle to an NPVariant, so we should exit early before trying to convert. 195107 1 49818 japhet 2010-03-02 10:43:01 -0800 Created attachment 49818 patch 195120 2 49818 dglazkov 2010-03-02 11:07:07 -0800 Comment on attachment 49818 patch ok. 195324 3 ap 2010-03-02 17:11:50 -0800 This was landed in <http://trac.webkit.org/changeset/55417>. 49818 2010-03-02 10:43:01 -0800 2010-03-02 11:07:07 -0800 patch patch.txt text/plain 1327 japhet SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1NTQxNSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTYgQEAKKzIwMTAtMDMtMDIgIE5hdGUgQ2hhcGluICA8amFwaGV0QGNocm9taXVt Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBb VjhdIEZhaWwgZ3JhY2VmdWxseSBpZiBOUE5fR2V0UHJvcGVydHkgdHJpZXMgdG8gcmV0cmlldmUg YSBwcm9wZXJ0eSB0aGF0IGRvZXNuJ3QgZXhpc3QuCisKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM1NTg4CisKKyAgICAgICAgUmVxdWlyZWQgZm9yIHBh c3NpbmcgTGF5b3V0VGVzdHMvcGx1Z2lucy9uZXRzY2FwZS1wbHVnaW4tcHJvcGVydHktYWNjZXNz LWV4Y2VwdGlvbi5odG1sIG9uIENocm9taXVtLgorCisgICAgICAgICogYmluZGluZ3MvdjgvTlBW OE9iamVjdC5jcHA6CisgICAgICAgIChfTlBOX0dldFByb3BlcnR5KTogSWYgdGhlIHJlc3VsdCBp cyBlbXB0eSwgZG9uJ3QgdHJ5IHRvIGNvbnZlcnQgaXQgdG8gYW4gTlBWYXJpYW50IGFuZCByZXR1 cm4gZmFsc2UuCisKIDIwMTAtMDMtMDIgIEJyYWR5IEVpZHNvbiAgPGJlaWRzb25AYXBwbGUuY29t PgogCiAgICAgICAgIFJldmlld2VkIGJ5IFNhbSBXZWluaWcuCkluZGV4OiBXZWJDb3JlL2JpbmRp bmdzL3Y4L05QVjhPYmplY3QuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvYmluZGluZ3Mvdjgv TlBWOE9iamVjdC5jcHAJKHJldmlzaW9uIDU1NDEzKQorKysgV2ViQ29yZS9iaW5kaW5ncy92OC9O UFY4T2JqZWN0LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMjk5LDYgKzI5OSw5IEBACiAKICAgICAg ICAgdjg6OkhhbmRsZTx2ODo6T2JqZWN0PiBvYmoob2JqZWN0LT52OE9iamVjdCk7CiAgICAgICAg IHY4OjpMb2NhbDx2ODo6VmFsdWU+IHY4cmVzdWx0ID0gb2JqLT5HZXQobnBJZGVudGlmaWVyVG9W OElkZW50aWZpZXIocHJvcGVydHlOYW1lKSk7CisgICAgICAgIAorICAgICAgICBpZiAodjhyZXN1 bHQuSXNFbXB0eSgpKQorICAgICAgICAgICAgcmV0dXJuIGZhbHNlOwogCiAgICAgICAgIGNvbnZl cnRWOE9iamVjdFRvTlBWYXJpYW50KHY4cmVzdWx0LCBucE9iamVjdCwgcmVzdWx0KTsKICAgICAg ICAgcmV0dXJuIHRydWU7Cg==