35587 2010-03-02 10:18:47 -0800 Test plugin still has issues with releasing objects, and variants 2010-03-02 10:35:04 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC All RESOLVED FIXED P2 Normal --- 1 gustavo webkit-unassigned oldest_to_newest 195086 0 gustavo 2010-03-02 10:18:47 -0800 ap found out my patch to fix releasing variants was a bit wrong in a couple places, and that the plugin failed to release a bunch of variables it should. 195093 1 49816 gustavo 2010-03-02 10:24:05 -0800 Created attachment 49816 proposed patch This covers all issues ap found, and discussed with me on IRC. 195095 2 49816 ap 2010-03-02 10:25:29 -0800 Comment on attachment 49816 proposed patch r=me 195101 3 49816 gustavo 2010-03-02 10:34:57 -0800 Comment on attachment 49816 proposed patch Landed as r55415. 49816 2010-03-02 10:24:05 -0800 2010-03-02 10:34:57 -0800 proposed patch 0001-2010-03-02-Gustavo-Noronha-Silva-gustavo.noronha-col.patch text/plain 4853 gustavo RnJvbSA0MGM0YzM2ZTE3ZDlkM2M1ZGM2Y2QxZDAwZWYxMWI3N2QwZGNjMmVhIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBHdXN0YXZvIE5vcm9uaGEgU2lsdmEgPGduc0Bnbm9tZS5vcmc+ CkRhdGU6IFR1ZSwgMiBNYXIgMjAxMCAxNToyMDo0NyAtMDMwMApTdWJqZWN0OiBbUEFUQ0hdIDIw MTAtMDMtMDIgIEd1c3Rhdm8gTm9yb25oYSBTaWx2YSAgPGd1c3Rhdm8ubm9yb25oYUBjb2xsYWJv cmEuY28udWs+CgogICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgoKICAgICAgICBU ZXN0IHBsdWdpbiBzdGlsbCBoYXMgaXNzdWVzIHdpdGggcmVsZWFzaW5nIG9iamVjdHMsIGFuZCB2 YXJpYW50cwogICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0z NTU4NwoKICAgICAgICBGaXggdGhlIGNvbmRpdGlvbnMgZm9yIHJlbGVhc2luZyB0aGUgdmFyaWFu dHMgYWZ0ZXIgY2FsbGluZwogICAgICAgIGludm9rZSwgYW5kIGF2b2lkIGhhdmluZyBhIG51bWJl ciBvZiBvYmplY3RzIGxlYWsuCgogICAgICAgICogRHVtcFJlbmRlclRyZWUvVGVzdE5ldHNjYXBl UGx1Z0luLnN1YnByb2ovUGx1Z2luT2JqZWN0LmNwcDoKICAgICAgICAodGVzdERvY3VtZW50T3Bl bik6CiAgICAgICAgKHRlc3RXaW5kb3dPcGVuKToKLS0tCiBXZWJLaXRUb29scy9DaGFuZ2VMb2cg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICB8ICAgMTQgKysrKysrCiAuLi4vVGVzdE5ldHNj YXBlUGx1Z0luLnN1YnByb2ovUGx1Z2luT2JqZWN0LmNwcCAgICB8ICAgNDggKysrKysrKysrKysr Ky0tLS0tLQogMiBmaWxlcyBjaGFuZ2VkLCA0NyBpbnNlcnRpb25zKCspLCAxNSBkZWxldGlvbnMo LSkKCmRpZmYgLS1naXQgYS9XZWJLaXRUb29scy9DaGFuZ2VMb2cgYi9XZWJLaXRUb29scy9DaGFu Z2VMb2cKaW5kZXggOTk4ZDI5Ni4uZTBiZTYwYyAxMDA2NDQKLS0tIGEvV2ViS2l0VG9vbHMvQ2hh bmdlTG9nCisrKyBiL1dlYktpdFRvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEw LTAzLTAyICBHdXN0YXZvIE5vcm9uaGEgU2lsdmEgIDxndXN0YXZvLm5vcm9uaGFAY29sbGFib3Jh LmNvLnVrPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IFRlc3QgcGx1Z2luIHN0aWxsIGhhcyBpc3N1ZXMgd2l0aCByZWxlYXNpbmcgb2JqZWN0cywgYW5k IHZhcmlhbnRzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0zNTU4NworCisgICAgICAgIEZpeCB0aGUgY29uZGl0aW9ucyBmb3IgcmVsZWFzaW5nIHRoZSB2 YXJpYW50cyBhZnRlciBjYWxsaW5nCisgICAgICAgIGludm9rZSwgYW5kIGF2b2lkIGhhdmluZyBh IG51bWJlciBvZiBvYmplY3RzIGxlYWsuCisKKyAgICAgICAgKiBEdW1wUmVuZGVyVHJlZS9UZXN0 TmV0c2NhcGVQbHVnSW4uc3VicHJvai9QbHVnaW5PYmplY3QuY3BwOgorICAgICAgICAodGVzdERv Y3VtZW50T3Blbik6CisgICAgICAgICh0ZXN0V2luZG93T3Blbik6CisKIDIwMTAtMDMtMDEgIEd1 c3Rhdm8gTm9yb25oYSBTaWx2YSAgPGd1c3Rhdm8ubm9yb25oYUBjb2xsYWJvcmEuY28udWs+CiAK ICAgICAgICAgUmV2aWV3ZWQgYnkgRXJpYyBTZWlkZWwuCmRpZmYgLS1naXQgYS9XZWJLaXRUb29s cy9EdW1wUmVuZGVyVHJlZS9UZXN0TmV0c2NhcGVQbHVnSW4uc3VicHJvai9QbHVnaW5PYmplY3Qu Y3BwIGIvV2ViS2l0VG9vbHMvRHVtcFJlbmRlclRyZWUvVGVzdE5ldHNjYXBlUGx1Z0luLnN1YnBy b2ovUGx1Z2luT2JqZWN0LmNwcAppbmRleCBlYTEzMGMyLi41OGQyZjM4IDEwMDY0NAotLS0gYS9X ZWJLaXRUb29scy9EdW1wUmVuZGVyVHJlZS9UZXN0TmV0c2NhcGVQbHVnSW4uc3VicHJvai9QbHVn aW5PYmplY3QuY3BwCisrKyBiL1dlYktpdFRvb2xzL0R1bXBSZW5kZXJUcmVlL1Rlc3ROZXRzY2Fw ZVBsdWdJbi5zdWJwcm9qL1BsdWdpbk9iamVjdC5jcHAKQEAgLTcxMSw4ICs3MTEsMTAgQEAgYm9v bCB0ZXN0RG9jdW1lbnRPcGVuKE5QUCBucHApCiAKICAgICBOUFZhcmlhbnQgZG9jVmFyaWFudDsK ICAgICBicm93c2VyLT5nZXRwcm9wZXJ0eShucHAsIHdpbmRvd09iamVjdCwgZG9jdW1lbnRJZCwg JmRvY1ZhcmlhbnQpOwotICAgIGlmIChkb2NWYXJpYW50LnR5cGUgIT0gTlBWYXJpYW50VHlwZV9P YmplY3QpCisgICAgaWYgKGRvY1ZhcmlhbnQudHlwZSAhPSBOUFZhcmlhbnRUeXBlX09iamVjdCkg eworICAgICAgICBicm93c2VyLT5yZWxlYXNlb2JqZWN0KHdpbmRvd09iamVjdCk7CiAgICAgICAg IHJldHVybiBmYWxzZTsKKyAgICB9CiAKICAgICBOUE9iamVjdCAqZG9jdW1lbnRPYmplY3QgPSBO UFZBUklBTlRfVE9fT0JKRUNUKGRvY1ZhcmlhbnQpOwogCkBAIC03MjEsMTcgKzcyMywyNSBAQCBi b29sIHRlc3REb2N1bWVudE9wZW4oTlBQIG5wcCkKICAgICBTVFJJTkdaX1RPX05QVkFSSUFOVCgi X2JsYW5rIiwgb3BlbkFyZ3NbMV0pOwogCiAgICAgTlBWYXJpYW50IHJlc3VsdDsKLSAgICBpZiAo YnJvd3Nlci0+aW52b2tlKG5wcCwgZG9jdW1lbnRPYmplY3QsIG9wZW5JZCwgb3BlbkFyZ3MsIDIs ICZyZXN1bHQpKQorICAgIGlmICghYnJvd3Nlci0+aW52b2tlKG5wcCwgZG9jdW1lbnRPYmplY3Qs IG9wZW5JZCwgb3BlbkFyZ3MsIDIsICZyZXN1bHQpKSB7CisgICAgICAgIGJyb3dzZXItPnJlbGVh c2VvYmplY3Qod2luZG93T2JqZWN0KTsKICAgICAgICAgYnJvd3Nlci0+cmVsZWFzZW9iamVjdChk b2N1bWVudE9iamVjdCk7CisgICAgICAgIHJldHVybiBmYWxzZTsKKyAgICB9CiAKLSAgICBpZiAo cmVzdWx0LnR5cGUgPT0gTlBWYXJpYW50VHlwZV9PYmplY3QpIHsKLSAgICAgICAgcGx1Z2luTG9n V2l0aFdpbmRvd09iamVjdFZhcmlhYmxlQXJncyh3aW5kb3dPYmplY3QsIG5wcCwgIkRPQ1VNRU5U IE9QRU4gU1VDQ0VTUyIpOwotICAgICAgICBub3RpZnlUZXN0Q29tcGxldGlvbihucHAsIHJlc3Vs dC52YWx1ZS5vYmplY3RWYWx1ZSk7Ci0gICAgICAgIGJyb3dzZXItPnJlbGVhc2VvYmplY3QocmVz dWx0LnZhbHVlLm9iamVjdFZhbHVlKTsKLSAgICAgICAgcmV0dXJuIHRydWU7CisgICAgYnJvd3Nl ci0+cmVsZWFzZW9iamVjdChkb2N1bWVudE9iamVjdCk7CisKKyAgICBpZiAocmVzdWx0LnR5cGUg IT0gTlBWYXJpYW50VHlwZV9PYmplY3QpIHsKKyAgICAgICAgYnJvd3Nlci0+cmVsZWFzZW9iamVj dCh3aW5kb3dPYmplY3QpOworICAgICAgICBicm93c2VyLT5yZWxlYXNldmFyaWFudHZhbHVlKCZy ZXN1bHQpOworICAgICAgICByZXR1cm4gZmFsc2U7CiAgICAgfQogCi0gICAgcmV0dXJuIGZhbHNl OworICAgIHBsdWdpbkxvZ1dpdGhXaW5kb3dPYmplY3RWYXJpYWJsZUFyZ3Mod2luZG93T2JqZWN0 LCBucHAsICJET0NVTUVOVCBPUEVOIFNVQ0NFU1MiKTsKKyAgICBub3RpZnlUZXN0Q29tcGxldGlv bihucHAsIHJlc3VsdC52YWx1ZS5vYmplY3RWYWx1ZSk7CisgICAgYnJvd3Nlci0+cmVsZWFzZW9i amVjdChyZXN1bHQudmFsdWUub2JqZWN0VmFsdWUpOworICAgIGJyb3dzZXItPnJlbGVhc2VvYmpl Y3Qod2luZG93T2JqZWN0KTsKKyAgICByZXR1cm4gdHJ1ZTsKIH0KIAogYm9vbCB0ZXN0V2luZG93 T3BlbihOUFAgbnBwKQpAQCAtNzQ4LDE0ICs3NTgsMjIgQEAgYm9vbCB0ZXN0V2luZG93T3BlbihO UFAgbnBwKQogICAgIFNUUklOR1pfVE9fTlBWQVJJQU5UKCJfYmxhbmsiLCBvcGVuQXJnc1sxXSk7 CiAKICAgICBOUFZhcmlhbnQgcmVzdWx0OwotICAgIGJvb2wgZGlkU3VjY2VlZCA9IGJyb3dzZXIt Pmludm9rZShucHAsIHdpbmRvd09iamVjdCwgb3BlbklkLCBvcGVuQXJncywgMiwgJnJlc3VsdCk7 Ci0gICAgaWYgKGRpZFN1Y2NlZWQgJiYgKHJlc3VsdC50eXBlID09IE5QVmFyaWFudFR5cGVfT2Jq ZWN0KSkgewotICAgICAgICBwbHVnaW5Mb2dXaXRoV2luZG93T2JqZWN0VmFyaWFibGVBcmdzKHdp bmRvd09iamVjdCwgbnBwLCAiV0lORE9XIE9QRU4gU1VDQ0VTUyIpOwotICAgICAgICBub3RpZnlU ZXN0Q29tcGxldGlvbihucHAsIHJlc3VsdC52YWx1ZS5vYmplY3RWYWx1ZSk7Ci0gICAgICAgIGJy b3dzZXItPnJlbGVhc2VvYmplY3QocmVzdWx0LnZhbHVlLm9iamVjdFZhbHVlKTsKLSAgICAgICAg cmV0dXJuIHRydWU7CisgICAgaWYgKCFicm93c2VyLT5pbnZva2UobnBwLCB3aW5kb3dPYmplY3Qs IG9wZW5JZCwgb3BlbkFyZ3MsIDIsICZyZXN1bHQpKSB7CisgICAgICAgIGJyb3dzZXItPnJlbGVh c2VvYmplY3Qod2luZG93T2JqZWN0KTsKKyAgICAgICAgcmV0dXJuIGZhbHNlOwogICAgIH0KLSAg ICByZXR1cm4gZmFsc2U7CisKKyAgICBpZiAocmVzdWx0LnR5cGUgIT0gTlBWYXJpYW50VHlwZV9P YmplY3QpIHsKKyAgICAgICAgYnJvd3Nlci0+cmVsZWFzZW9iamVjdCh3aW5kb3dPYmplY3QpOwor ICAgICAgICBicm93c2VyLT5yZWxlYXNldmFyaWFudHZhbHVlKCZyZXN1bHQpOworICAgICAgICBy ZXR1cm4gZmFsc2U7CisgICAgfQorCisgICAgcGx1Z2luTG9nV2l0aFdpbmRvd09iamVjdFZhcmlh YmxlQXJncyh3aW5kb3dPYmplY3QsIG5wcCwgIldJTkRPVyBPUEVOIFNVQ0NFU1MiKTsKKyAgICBu b3RpZnlUZXN0Q29tcGxldGlvbihucHAsIHJlc3VsdC52YWx1ZS5vYmplY3RWYWx1ZSk7CisgICAg YnJvd3Nlci0+cmVsZWFzZW9iamVjdChyZXN1bHQudmFsdWUub2JqZWN0VmFsdWUpOworICAgIGJy b3dzZXItPnJlbGVhc2VvYmplY3Qod2luZG93T2JqZWN0KTsKKyAgICByZXR1cm4gdHJ1ZTsKIH0K IAogc3RhdGljIGJvb2wgdGVzdFNldFN0YXR1cyhQbHVnaW5PYmplY3QqIG9iaiwgY29uc3QgTlBW YXJpYW50KiBhcmdzLCB1aW50MzJfdCBhcmdDb3VudCwgTlBWYXJpYW50KiByZXN1bHQpCi0tIAox LjYuNi4yCgo=