35583 2010-03-02 09:05:58 -0800 if font-family lists several generic families, the last one takes precedence 2022-07-23 12:47:10 -0700 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) PC Linux RESOLVED CONFIGURATION CHANGED P2 Normal --- 1 olivier webkit-unassigned ahmad.saleem792 ap bfulgham mitz mrmazda olivier rniwa simon.fraser xan.lopez oldest_to_newest 195065 0 olivier 2010-03-02 09:05:58 -0800 According to the CSS fonts specification (http://www.w3.org/TR/css3-fonts/#font-family-the-font-family-property), "[the font-family property] specifies a prioritized list of font family names or generic family names", and "authors are encouraged to append a generic font family as a last alternative for improved robustness". It doesn't make much sense to list several generic families in a font-family property, since all generic font families are guaranteed to be always available by the user agent. However if one does, the current behaviour of webkit is to override the fallback family with the last generic family encountered in the list. Consider the following example: font-family: ThisFontIsInvalid, monospace, sans-serif If the first font family is not found on the system, the font selected should be the UA's default monospace font. Instead, it is the default sans-serif font. A real life example is at http://svn.debian.org/wsvn/secure-testing/doc/narrative_introduction. The text of the page is intended to be displayed with a fixed width, and the the style is defined like this: font-family:'Consolas',monospace,sans-serif; (in http://svn.debian.org/websvn/templates/calm/styles.css) 195068 1 49808 olivier 2010-03-02 09:22:50 -0800 Created attachment 49808 layout test case This is a layout test case that highlights the issue. I used the offsetWidth property of inline <p> elements to determine whether the font used for the two paragraphs is the same, if there is a more elegant solution it is welcome. I guess this test could go in LayoutTests/fast/css. 195075 2 49810 olivier 2010-03-02 09:39:30 -0800 Created attachment 49810 [patch] set the generic family only once This patch fixes the issue by setting the generic family only once. If another generic family is encountered in the list, setGenericFamily() is not called again. 195315 3 ap 2010-03-02 16:47:01 -0800 The test says "PASS" for me. I was testing in Safari on Mac OS X. OIf the behavior is indeed correct in some ports, it's likely that a proper fix wouldn't need to touch cross-platform code. Please see <https://webkit.org/coding/contributing.html> for detailed information about contributing code to WebKit - we do require creating a single patch with tests and ChangeLogs. 195414 4 olivier 2010-03-03 00:59:16 -0800 Thanks for your feedback Alexey. It looks like the bug I'm trying to fix is indeed platform-specific. Since I could reproduce it on the GTK and QT ports on linux, I assumed a bit too fast it was general. Still, I believe the first part of my analysis and the patch are valid, as far as I can interpret the specification and understand the CSSStyleSelector code correctly. I can't think of an obvious layout test for it though. If anyone who knows better this part of the code could take a look into it, it would be much appreciated! If my change makes sense I'll gladly generate a suitable patch with the Changelog. As far as the layout test I attached is concerned, my guess is that ports that do the right thing (like the mac one) iterate over the list of families, discarding the first one as invalid and falling back on the second one ("-webkit-monospace"), whereas the GTK port seems to always generate a font from the first family, using the family name and falling back to the font description's generic family (which explains why this patch seems to fix it). I will file a separate bug for the GTK port. 195648 5 ap 2010-03-03 09:54:32 -0800 > If anyone who knows better this part of the code could take a look into it, it > would be much appreciated! A bug without any patches marked for review has pretty low visibility. Please consider either submitting a patch for review (as documented at https://webkit.org/coding/contributing.html), or e-mailing webkit-dev. 195653 6 49919 olivier 2010-03-03 10:14:05 -0800 Created attachment 49919 Updated patch with Changelog entry 195654 7 49919 darin 2010-03-03 10:18:51 -0800 Comment on attachment 49919 Updated patch with Changelog entry Even if you can't test with DumpRenderTree cross-platform you can do the following: 1) Add a DumpRenderTree test that requires per-platform results. 2) Create a manual test with instructions for how to interpret the results and put it in WebCore/manual-tests. 3) Add some new feature to DumpRenderTree to make it possible to test this across platforms. As another possibility, is there perhaps some way to detect which family is used with computed style? It's not OK to make the change without a test at all, so you need to do at least one of the things above. 195658 8 olivier 2010-03-03 10:29:05 -0800 (In reply to comment #7) > (From update of attachment 49919 [details]) > Even if you can't test with DumpRenderTree cross-platform you can do the > following: > > 1) Add a DumpRenderTree test that requires per-platform results. > > 2) Create a manual test with instructions for how to interpret the results > and put it in WebCore/manual-tests. > > 3) Add some new feature to DumpRenderTree to make it possible to test this > across platforms. #3 looks like the best option, but also the most complex to implement (given my current knowledge of the code). Also, wouldn't changing the output of DumpRenderTree break a lot of existing tests? > As another possibility, is there perhaps some way to detect which family is > used with computed style? No, I already tried that, but the computed style only contains an ordered list of font families as encountered by the CSS parser, no hint on which of them is actually used. The fact that webkit chooses to remember only one generic family instead of a list of them is an implementation detail that's unknown to the CSS specification. 195693 9 mitz 2010-03-03 11:40:14 -0800 So I noticed that platform/graphics/chromium/FontCacheChromiumWin.cpp platform/graphics/chromium/FontCacheLinux.cpp platform/graphics/gtk/FontPlatformDataGtk.cpp platform/graphics/gtk/FontPlatformDataPango.cpp platform/graphics/wx/FontPlatformDataWx.cpp are the only files in platform/graphics that refer to the generic family in the font description. The Mac, Windows and Qt implementations don’t do this. I think this is the problem. The mapping from generic family to concrete family happes through the -webkit-* family names (e.g. -webkit-serif) and the Settings object in CSSFontSelector. I don’t know why the aforementioned ports don’t take advantage of that and do platform-level mapping. 1886202 10 ahmad.saleem792 2022-07-23 05:46:16 -0700 All browsers (Safari 15.6 on macOS 12.5, Chrome Canary 106 and Firefox Nightly 104) show "PASS" in the attached test case, if it this desired output then I think this bug can be marked "RESOLVED CONFIGURATION CHANGED". NOTE - Safari do fail some 'font-family' css test cases as shown in WPT: https://wpt.fyi/results/css/css-fonts?label=master&label=experimental&aligned&q=font-family 49808 2010-03-02 09:22:50 -0800 2010-03-02 09:22:50 -0800 layout test case several-generic-font-families.html text/html 847 olivier PGh0bWw+CiAgPGhlYWQ+CiAgICA8c2NyaXB0PgogICAgICBpZiAod2luZG93LmxheW91dFRlc3RD b250cm9sbGVyKQogICAgICAgIGxheW91dFRlc3RDb250cm9sbGVyLmR1bXBBc1RleHQoKTsKICAg ICAgPCEtLSBDb21wYXJlIHRoZSB3aWR0aHMgb2YgdGhlIHR3byBwYXJhZ3JhcGhzLiBJZiB0aGV5 IGFyZSBlcXVhbCwgdGhleSBhcmUgZGlzcGxheWVkIHVzaW5nIHRoZSBzYW1lIGZvbnQgIC0tPgog ICAgICBmdW5jdGlvbiBjb21wYXJlV2lkdGhzKCkgewogICAgICAgIHcxID0gZG9jdW1lbnQuZ2V0 RWxlbWVudEJ5SWQoImZpcnN0Iikub2Zmc2V0V2lkdGg7CiAgICAgICAgdzIgPSBkb2N1bWVudC5n ZXRFbGVtZW50QnlJZCgic2Vjb25kIikub2Zmc2V0V2lkdGg7CiAgICAgICAgZG9jdW1lbnQuYm9k eS5pbm5lckhUTUwgPSAodzEgPT0gdzIpID8gJ1BBU1MnIDogJ0ZBSUwnOwogICAgICB9CiAgICA8 L3NjcmlwdD4KICA8L2hlYWQ+CiAgPGJvZHkgb25sb2FkPSJjb21wYXJlV2lkdGhzKCkiPgogICAg PCEtLSBUaGUgZm9udCBhcHBsaWVkIHRvIGJvdGggb2YgdGhlc2UgcGFyYWdyYXBocyBzaG91bGQg YmUgdGhlIFVBJ3MgZGVmYXVsdCBtb25vc3BhY2UgZm9udCAtLT4KICAgIDxwIGlkPSJmaXJzdCIg c3R5bGU9ImRpc3BsYXk6IGlubGluZTsgZm9udC1zaXplOiAxMHB4OyBmb250LWZhbWlseTogVGhp c0ZvbnRJc0ludmFsaWQsIG1vbm9zcGFjZSwgc2Fucy1zZXJpZiI+bW1tbW1sPC9wPgogICAgPHAg aWQ9InNlY29uZCIgc3R5bGU9ImRpc3BsYXk6IGlubGluZTsgZm9udC1zaXplOiAxMHB4OyBmb250 LWZhbWlseTogbW9ub3NwYWNlIj5tbW1tbWw8L3A+CiAgPC9ib2R5Pgo8L2h0bWw+Cg== 49810 2010-03-02 09:39:30 -0800 2010-03-03 10:14:05 -0800 [patch] set the generic family only once set_generic_family_only_once.diff text/plain 2365 olivier ZGlmZiAtLWdpdCBhL1dlYkNvcmUvY3NzL0NTU1N0eWxlU2VsZWN0b3IuY3BwIGIvV2ViQ29yZS9j c3MvQ1NTU3R5bGVTZWxlY3Rvci5jcHAKaW5kZXggMTI0ZWI5Zi4uYTIwNjY5ZSAxMDA2NDQKLS0t IGEvV2ViQ29yZS9jc3MvQ1NTU3R5bGVTZWxlY3Rvci5jcHAKKysrIGIvV2ViQ29yZS9jc3MvQ1NT U3R5bGVTZWxlY3Rvci5jcHAKQEAgLTQyNDQsMjMgKzQyNDQsMjggQEAgdm9pZCBDU1NTdHlsZVNl bGVjdG9yOjphcHBseVByb3BlcnR5KGludCBpZCwgQ1NTVmFsdWUgKnZhbHVlKQogICAgICAgICAg ICAgICAgICAgICAgICAgYnJlYWs7CiAgICAgICAgICAgICAgICAgICAgIGNhc2UgQ1NTVmFsdWVT ZXJpZjoKICAgICAgICAgICAgICAgICAgICAgICAgIGZhY2UgPSAiLXdlYmtpdC1zZXJpZiI7Ci0g ICAgICAgICAgICAgICAgICAgICAgICBmb250RGVzY3JpcHRpb24uc2V0R2VuZXJpY0ZhbWlseShG b250RGVzY3JpcHRpb246OlNlcmlmRmFtaWx5KTsKKyAgICAgICAgICAgICAgICAgICAgICAgIGlm IChmb250RGVzY3JpcHRpb24uZ2VuZXJpY0ZhbWlseSgpID09IEZvbnREZXNjcmlwdGlvbjo6Tm9G YW1pbHkpCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgZm9udERlc2NyaXB0aW9uLnNldEdl bmVyaWNGYW1pbHkoRm9udERlc2NyaXB0aW9uOjpTZXJpZkZhbWlseSk7CiAgICAgICAgICAgICAg ICAgICAgICAgICBicmVhazsKICAgICAgICAgICAgICAgICAgICAgY2FzZSBDU1NWYWx1ZVNhbnNT ZXJpZjoKICAgICAgICAgICAgICAgICAgICAgICAgIGZhY2UgPSAiLXdlYmtpdC1zYW5zLXNlcmlm IjsKLSAgICAgICAgICAgICAgICAgICAgICAgIGZvbnREZXNjcmlwdGlvbi5zZXRHZW5lcmljRmFt aWx5KEZvbnREZXNjcmlwdGlvbjo6U2Fuc1NlcmlmRmFtaWx5KTsKKyAgICAgICAgICAgICAgICAg ICAgICAgIGlmIChmb250RGVzY3JpcHRpb24uZ2VuZXJpY0ZhbWlseSgpID09IEZvbnREZXNjcmlw dGlvbjo6Tm9GYW1pbHkpCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgZm9udERlc2NyaXB0 aW9uLnNldEdlbmVyaWNGYW1pbHkoRm9udERlc2NyaXB0aW9uOjpTYW5zU2VyaWZGYW1pbHkpOwog ICAgICAgICAgICAgICAgICAgICAgICAgYnJlYWs7CiAgICAgICAgICAgICAgICAgICAgIGNhc2Ug Q1NTVmFsdWVDdXJzaXZlOgogICAgICAgICAgICAgICAgICAgICAgICAgZmFjZSA9ICItd2Via2l0 LWN1cnNpdmUiOwotICAgICAgICAgICAgICAgICAgICAgICAgZm9udERlc2NyaXB0aW9uLnNldEdl bmVyaWNGYW1pbHkoRm9udERlc2NyaXB0aW9uOjpDdXJzaXZlRmFtaWx5KTsKKyAgICAgICAgICAg ICAgICAgICAgICAgIGlmIChmb250RGVzY3JpcHRpb24uZ2VuZXJpY0ZhbWlseSgpID09IEZvbnRE ZXNjcmlwdGlvbjo6Tm9GYW1pbHkpCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgZm9udERl c2NyaXB0aW9uLnNldEdlbmVyaWNGYW1pbHkoRm9udERlc2NyaXB0aW9uOjpDdXJzaXZlRmFtaWx5 KTsKICAgICAgICAgICAgICAgICAgICAgICAgIGJyZWFrOwogICAgICAgICAgICAgICAgICAgICBj YXNlIENTU1ZhbHVlRmFudGFzeToKICAgICAgICAgICAgICAgICAgICAgICAgIGZhY2UgPSAiLXdl YmtpdC1mYW50YXN5IjsKLSAgICAgICAgICAgICAgICAgICAgICAgIGZvbnREZXNjcmlwdGlvbi5z ZXRHZW5lcmljRmFtaWx5KEZvbnREZXNjcmlwdGlvbjo6RmFudGFzeUZhbWlseSk7CisgICAgICAg ICAgICAgICAgICAgICAgICBpZiAoZm9udERlc2NyaXB0aW9uLmdlbmVyaWNGYW1pbHkoKSA9PSBG b250RGVzY3JpcHRpb246Ok5vRmFtaWx5KQorICAgICAgICAgICAgICAgICAgICAgICAgICAgIGZv bnREZXNjcmlwdGlvbi5zZXRHZW5lcmljRmFtaWx5KEZvbnREZXNjcmlwdGlvbjo6RmFudGFzeUZh bWlseSk7CiAgICAgICAgICAgICAgICAgICAgICAgICBicmVhazsKICAgICAgICAgICAgICAgICAg ICAgY2FzZSBDU1NWYWx1ZU1vbm9zcGFjZToKICAgICAgICAgICAgICAgICAgICAgICAgIGZhY2Ug PSAiLXdlYmtpdC1tb25vc3BhY2UiOwotICAgICAgICAgICAgICAgICAgICAgICAgZm9udERlc2Ny aXB0aW9uLnNldEdlbmVyaWNGYW1pbHkoRm9udERlc2NyaXB0aW9uOjpNb25vc3BhY2VGYW1pbHkp OworICAgICAgICAgICAgICAgICAgICAgICAgaWYgKGZvbnREZXNjcmlwdGlvbi5nZW5lcmljRmFt aWx5KCkgPT0gRm9udERlc2NyaXB0aW9uOjpOb0ZhbWlseSkKKyAgICAgICAgICAgICAgICAgICAg ICAgICAgICBmb250RGVzY3JpcHRpb24uc2V0R2VuZXJpY0ZhbWlseShGb250RGVzY3JpcHRpb246 Ok1vbm9zcGFjZUZhbWlseSk7CiAgICAgICAgICAgICAgICAgICAgICAgICBicmVhazsKICAgICAg ICAgICAgICAgICB9CiAgICAgICAgICAgICB9Cg== 49919 2010-03-03 10:14:05 -0800 2010-06-10 21:13:26 -0700 Updated patch with Changelog entry set_generic_family_only_once_with_changelog.diff text/plain 3096 olivier ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg MjA0NWVmMi4uYjhhOTBhYiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNyBAQAorMjAxMC0wMy0wMyAgT2xpdmllciBUaWxs b3kgIDxvbGl2aWVyQHRpbGxveS5uZXQ+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgRG8gbm90IG92ZXJyaWRlIHRoZSBnZW5lcmljIGZvbnQgZmFtaWx5 IGlmIGFscmVhZHkgZGVmaW5lZCB3aGVuIHBhcnNpbmcKKyAgICAgICAgdGhlIGZvbnQtZmFtaWx5 IHByb3BlcnR5LgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MzU1ODMKKworICAgICAgICBUaGlzIGRvZXNuJ3QgYXBwZWFyIHRvIGJlIHRlc3RhYmxlIGZy b20gd2l0aGluIER1bXBSZW5kZXJUcmVlIGFzIHRoZQorICAgICAgICBhY3R1YWwgZm9udCBhcHBs aWVkIGlzIHBsYXRmb3JtLWRlcGVuZGVudCBhbmQgaXMgbm90IGV4cG9zZWQuCisKKyAgICAgICAg KiBjc3MvQ1NTU3R5bGVTZWxlY3Rvci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpDU1NTdHlsZVNl bGVjdG9yOjphcHBseVByb3BlcnR5KToKKwogMjAxMC0wMi0yNiAgWmhlbnlhbyBNbyAgPHptb0Bn b29nbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERhdmlkIExldmluLgpkaWZmIC0tZ2l0 IGEvV2ViQ29yZS9jc3MvQ1NTU3R5bGVTZWxlY3Rvci5jcHAgYi9XZWJDb3JlL2Nzcy9DU1NTdHls ZVNlbGVjdG9yLmNwcAppbmRleCAxMjRlYjlmLi5hMjA2NjllIDEwMDY0NAotLS0gYS9XZWJDb3Jl L2Nzcy9DU1NTdHlsZVNlbGVjdG9yLmNwcAorKysgYi9XZWJDb3JlL2Nzcy9DU1NTdHlsZVNlbGVj dG9yLmNwcApAQCAtNDI0NCwyMyArNDI0NCwyOCBAQCB2b2lkIENTU1N0eWxlU2VsZWN0b3I6OmFw cGx5UHJvcGVydHkoaW50IGlkLCBDU1NWYWx1ZSAqdmFsdWUpCiAgICAgICAgICAgICAgICAgICAg ICAgICBicmVhazsKICAgICAgICAgICAgICAgICAgICAgY2FzZSBDU1NWYWx1ZVNlcmlmOgogICAg ICAgICAgICAgICAgICAgICAgICAgZmFjZSA9ICItd2Via2l0LXNlcmlmIjsKLSAgICAgICAgICAg ICAgICAgICAgICAgIGZvbnREZXNjcmlwdGlvbi5zZXRHZW5lcmljRmFtaWx5KEZvbnREZXNjcmlw dGlvbjo6U2VyaWZGYW1pbHkpOworICAgICAgICAgICAgICAgICAgICAgICAgaWYgKGZvbnREZXNj cmlwdGlvbi5nZW5lcmljRmFtaWx5KCkgPT0gRm9udERlc2NyaXB0aW9uOjpOb0ZhbWlseSkKKyAg ICAgICAgICAgICAgICAgICAgICAgICAgICBmb250RGVzY3JpcHRpb24uc2V0R2VuZXJpY0ZhbWls eShGb250RGVzY3JpcHRpb246OlNlcmlmRmFtaWx5KTsKICAgICAgICAgICAgICAgICAgICAgICAg IGJyZWFrOwogICAgICAgICAgICAgICAgICAgICBjYXNlIENTU1ZhbHVlU2Fuc1NlcmlmOgogICAg ICAgICAgICAgICAgICAgICAgICAgZmFjZSA9ICItd2Via2l0LXNhbnMtc2VyaWYiOwotICAgICAg ICAgICAgICAgICAgICAgICAgZm9udERlc2NyaXB0aW9uLnNldEdlbmVyaWNGYW1pbHkoRm9udERl c2NyaXB0aW9uOjpTYW5zU2VyaWZGYW1pbHkpOworICAgICAgICAgICAgICAgICAgICAgICAgaWYg KGZvbnREZXNjcmlwdGlvbi5nZW5lcmljRmFtaWx5KCkgPT0gRm9udERlc2NyaXB0aW9uOjpOb0Zh bWlseSkKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICBmb250RGVzY3JpcHRpb24uc2V0R2Vu ZXJpY0ZhbWlseShGb250RGVzY3JpcHRpb246OlNhbnNTZXJpZkZhbWlseSk7CiAgICAgICAgICAg ICAgICAgICAgICAgICBicmVhazsKICAgICAgICAgICAgICAgICAgICAgY2FzZSBDU1NWYWx1ZUN1 cnNpdmU6CiAgICAgICAgICAgICAgICAgICAgICAgICBmYWNlID0gIi13ZWJraXQtY3Vyc2l2ZSI7 Ci0gICAgICAgICAgICAgICAgICAgICAgICBmb250RGVzY3JpcHRpb24uc2V0R2VuZXJpY0ZhbWls eShGb250RGVzY3JpcHRpb246OkN1cnNpdmVGYW1pbHkpOworICAgICAgICAgICAgICAgICAgICAg ICAgaWYgKGZvbnREZXNjcmlwdGlvbi5nZW5lcmljRmFtaWx5KCkgPT0gRm9udERlc2NyaXB0aW9u OjpOb0ZhbWlseSkKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICBmb250RGVzY3JpcHRpb24u c2V0R2VuZXJpY0ZhbWlseShGb250RGVzY3JpcHRpb246OkN1cnNpdmVGYW1pbHkpOwogICAgICAg ICAgICAgICAgICAgICAgICAgYnJlYWs7CiAgICAgICAgICAgICAgICAgICAgIGNhc2UgQ1NTVmFs dWVGYW50YXN5OgogICAgICAgICAgICAgICAgICAgICAgICAgZmFjZSA9ICItd2Via2l0LWZhbnRh c3kiOwotICAgICAgICAgICAgICAgICAgICAgICAgZm9udERlc2NyaXB0aW9uLnNldEdlbmVyaWNG YW1pbHkoRm9udERlc2NyaXB0aW9uOjpGYW50YXN5RmFtaWx5KTsKKyAgICAgICAgICAgICAgICAg ICAgICAgIGlmIChmb250RGVzY3JpcHRpb24uZ2VuZXJpY0ZhbWlseSgpID09IEZvbnREZXNjcmlw dGlvbjo6Tm9GYW1pbHkpCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgZm9udERlc2NyaXB0 aW9uLnNldEdlbmVyaWNGYW1pbHkoRm9udERlc2NyaXB0aW9uOjpGYW50YXN5RmFtaWx5KTsKICAg ICAgICAgICAgICAgICAgICAgICAgIGJyZWFrOwogICAgICAgICAgICAgICAgICAgICBjYXNlIENT U1ZhbHVlTW9ub3NwYWNlOgogICAgICAgICAgICAgICAgICAgICAgICAgZmFjZSA9ICItd2Via2l0 LW1vbm9zcGFjZSI7Ci0gICAgICAgICAgICAgICAgICAgICAgICBmb250RGVzY3JpcHRpb24uc2V0 R2VuZXJpY0ZhbWlseShGb250RGVzY3JpcHRpb246Ok1vbm9zcGFjZUZhbWlseSk7CisgICAgICAg ICAgICAgICAgICAgICAgICBpZiAoZm9udERlc2NyaXB0aW9uLmdlbmVyaWNGYW1pbHkoKSA9PSBG b250RGVzY3JpcHRpb246Ok5vRmFtaWx5KQorICAgICAgICAgICAgICAgICAgICAgICAgICAgIGZv bnREZXNjcmlwdGlvbi5zZXRHZW5lcmljRmFtaWx5KEZvbnREZXNjcmlwdGlvbjo6TW9ub3NwYWNl RmFtaWx5KTsKICAgICAgICAgICAgICAgICAgICAgICAgIGJyZWFrOwogICAgICAgICAgICAgICAg IH0KICAgICAgICAgICAgIH0K