35577 2010-03-02 04:27:23 -0800 [Qt] QScriptConverter::toString() should use QVarLengthArray instead of QByteArray 2010-03-07 00:16:21 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED Qt P3 Minor --- 34850 31863 1 jedrzej.nowacki jedrzej.nowacki commit-queue jedrzej.nowacki oldest_to_newest 195022 0 jedrzej.nowacki 2010-03-02 04:27:23 -0800 QScriptConverter::toString() should use the QVarLengthArray instead of the QByteArray. The QVarLengthArray uses stack memory allocation which is faster. The enhancement was suggested in bug 34850. 196022 1 50008 jedrzej.nowacki 2010-03-04 05:56:02 -0800 Created attachment 50008 Fix v1 The patch reduces run time of the QScriptValue::toString() about 2 ms per iteration. So it is about 3.5% speed gain in a simple benchmark like this: { QScriptValue v(112312.234334); QBENCHMARK { v.toString(); } } 196990 2 50008 commit-queue 2010-03-07 00:16:17 -0800 Comment on attachment 50008 Fix v1 Clearing flags on attachment: 50008 Committed r55634: <http://trac.webkit.org/changeset/55634> 196991 3 commit-queue 2010-03-07 00:16:21 -0800 All reviewed patches have been landed. Closing bug. 50008 2010-03-04 05:56:02 -0800 2010-03-07 00:16:17 -0800 Fix v1 toStringFixV1.diff text/plain 4262 jedrzej.nowacki ZGlmZiAtLWdpdCBhL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZyBiL0phdmFTY3JpcHRDb3JlL0No YW5nZUxvZwppbmRleCA2ZmMzZTA3Li45ZjVlMjBhIDEwMDY0NAotLS0gYS9KYXZhU2NyaXB0Q29y ZS9DaGFuZ2VMb2cKKysrIGIvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTgg QEAKKzIwMTAtMDMtMDQgIEplZHJ6ZWogTm93YWNraSAgPGplZHJ6ZWoubm93YWNraUBub2tpYS5j b20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgU21h bGwgcGVyZm9ybWFuY2UgZml4IGluIHRoZSBRU2NyaXB0Q29udmVydGVyOjp0b1N0cmluZygpLgor CisgICAgICAgIFRoZSBRQnl0ZUFycmF5IHdhcyByZXBsYWNlZCBieSB0aGUgUVZhckxlbmd0aEFy cmF5IHdoaWNoIGRvZXNuJ3QKKyAgICAgICAgaGF2ZSB0byBhbGxvY2F0ZSBhbnkgbWVtb3J5IG9u IGhlYXAuCisKKyAgICAgICAgW1F0XSBRU2NyaXB0Q29udmVydGVyOjp0b1N0cmluZygpIHNob3Vs ZCB1c2UgUVZhckxlbmd0aEFycmF5IGluc3RlYWQgb2YgUUJ5dGVBcnJheQorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzU1NzcKKworICAgICAgICAqIHF0 L2FwaS9xc2NyaXB0Y29udmVydGVyX3AuaDoKKyAgICAgICAgKFFTY3JpcHRDb252ZXJ0ZXI6OnRv U3RyaW5nKToKKwogMjAxMC0wMy0wMiAgRnJpZHJpY2ggU3RyYmEgIDxmcmlkcmljaC5zdHJiYUBi bHVld2luLmNoPgogCiAgICAgICAgIFJldmlld2VkIGJ5IE9saXZlciBIdW50LgpkaWZmIC0tZ2l0 IGEvSmF2YVNjcmlwdENvcmUvcXQvYXBpL3FzY3JpcHRjb252ZXJ0ZXJfcC5oIGIvSmF2YVNjcmlw dENvcmUvcXQvYXBpL3FzY3JpcHRjb252ZXJ0ZXJfcC5oCmluZGV4IDFjNTNlYzMuLmNkODZlMjAg MTAwNjQ0Ci0tLSBhL0phdmFTY3JpcHRDb3JlL3F0L2FwaS9xc2NyaXB0Y29udmVydGVyX3AuaAor KysgYi9KYXZhU2NyaXB0Q29yZS9xdC9hcGkvcXNjcmlwdGNvbnZlcnRlcl9wLmgKQEAgLTIzLDYg KzIzLDcgQEAKICNpbmNsdWRlIDxKYXZhU2NyaXB0Q29yZS9KYXZhU2NyaXB0Lmg+CiAjaW5jbHVk ZSA8UXRDb3JlL3FudW1lcmljLmg+CiAjaW5jbHVkZSA8UXRDb3JlL3FzdHJpbmcuaD4KKyNpbmNs dWRlIDxRdENvcmUvcXZhcmxlbmd0aGFycmF5Lmg+CiAKIGV4dGVybiBjaGFyICpxZHRvYShkb3Vi bGUgZCwgaW50IG1vZGUsIGludCBuZGlnaXRzLCBpbnQgKmRlY3B0LCBpbnQgKnNpZ24sIGNoYXIg KipydmUsIGNoYXIgKipkaWdpdHNfc3RyKTsKIApAQCAtNzMsNDkgKzc0LDU4IEBAIHB1YmxpYzoK ICAgICAgICAgaWYgKCF2YWx1ZSkKICAgICAgICAgICAgIHJldHVybiBRU3RyaW5nOjpmcm9tTGF0 aW4xKCIwIik7CiAKLSAgICAgICAgUUJ5dGVBcnJheSBidWY7Ci0gICAgICAgIGJ1Zi5yZXNlcnZl KDI0KTsKKyAgICAgICAgUVZhckxlbmd0aEFycmF5PGNoYXIsIDI1PiBidWY7CiAgICAgICAgIGlu dCBkZWNwdDsKICAgICAgICAgaW50IHNpZ247CiAgICAgICAgIGNoYXIqIHJlc3VsdCA9IDA7Ci0g ICAgICAgICh2b2lkKXFkdG9hKHZhbHVlLCAwLCAwLCAmZGVjcHQsICZzaWduLCAwLCAmcmVzdWx0 KTsKKyAgICAgICAgY2hhciogZW5kcmVzdWx0OworICAgICAgICAodm9pZClxZHRvYSh2YWx1ZSwg MCwgMCwgJmRlY3B0LCAmc2lnbiwgJmVuZHJlc3VsdCwgJnJlc3VsdCk7CiAKICAgICAgICAgaWYg KCFyZXN1bHQpCiAgICAgICAgICAgICByZXR1cm4gUVN0cmluZygpOwogCisgICAgICAgIGludCBy ZXN1bHRMZW4gPSBlbmRyZXN1bHQgLSByZXN1bHQ7CiAgICAgICAgIGlmIChkZWNwdCA8PSAwICYm IGRlY3B0ID4gLTYpIHsKLSAgICAgICAgICAgIGJ1Zi5maWxsKCcwJywgLWRlY3B0ICsgMiArIHNp Z24pOworICAgICAgICAgICAgYnVmLnJlc2l6ZSgtZGVjcHQgKyAyICsgc2lnbik7CisgICAgICAg ICAgICBxTWVtU2V0KGJ1Zi5kYXRhKCksICcwJywgLWRlY3B0ICsgMiArIHNpZ24pOwogICAgICAg ICAgICAgaWYgKHNpZ24pIC8vIGZpeCB0aGUgc2lnbi4KICAgICAgICAgICAgICAgICBidWZbMF0g PSAnLSc7CiAgICAgICAgICAgICBidWZbc2lnbiArIDFdID0gJy4nOwotICAgICAgICAgICAgYnVm ICs9IHJlc3VsdDsKKyAgICAgICAgICAgIGJ1Zi5hcHBlbmQocmVzdWx0LCByZXN1bHRMZW4pOwog ICAgICAgICB9IGVsc2UgewogICAgICAgICAgICAgaWYgKHNpZ24pCi0gICAgICAgICAgICAgICAg YnVmICs9ICctJzsKLSAgICAgICAgICAgIGJ1ZiArPSByZXN1bHQ7Ci0gICAgICAgICAgICBpbnQg bGVuZ3RoID0gYnVmLmxlbmd0aCgpIC0gc2lnbjsKKyAgICAgICAgICAgICAgICBidWYuYXBwZW5k KCctJyk7CisgICAgICAgICAgICBpbnQgbGVuZ3RoID0gYnVmLnNpemUoKSAtIHNpZ24gKyByZXN1 bHRMZW47CiAgICAgICAgICAgICBpZiAoZGVjcHQgPD0gMjEgJiYgZGVjcHQgPiAwKSB7Ci0gICAg ICAgICAgICAgICAgaWYgKGxlbmd0aCA8PSBkZWNwdCkKLSAgICAgICAgICAgICAgICAgICAgYnVm ICs9IFFCeXRlQXJyYXkoKS5maWxsKCcwJywgZGVjcHQgLSBsZW5ndGgpOwotICAgICAgICAgICAg ICAgIGVsc2UKLSAgICAgICAgICAgICAgICAgICAgYnVmLmluc2VydChkZWNwdCArIHNpZ24sICcu Jyk7CisgICAgICAgICAgICAgICAgaWYgKGxlbmd0aCA8PSBkZWNwdCkgeworICAgICAgICAgICAg ICAgICAgICBjb25zdCBjaGFyKiB6ZXJvcyA9ICIwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwIjsK KyAgICAgICAgICAgICAgICAgICAgYnVmLmFwcGVuZChyZXN1bHQsIHJlc3VsdExlbik7CisgICAg ICAgICAgICAgICAgICAgIGJ1Zi5hcHBlbmQoemVyb3MsIGRlY3B0IC0gbGVuZ3RoKTsKKyAgICAg ICAgICAgICAgICB9IGVsc2UgeworICAgICAgICAgICAgICAgICAgICBidWYuYXBwZW5kKHJlc3Vs dCwgZGVjcHQpOworICAgICAgICAgICAgICAgICAgICBidWYuYXBwZW5kKCcuJyk7CisgICAgICAg ICAgICAgICAgICAgIGJ1Zi5hcHBlbmQocmVzdWx0ICsgZGVjcHQsIHJlc3VsdExlbiAtIGRlY3B0 KTsKKyAgICAgICAgICAgICAgICB9CiAgICAgICAgICAgICB9IGVsc2UgaWYgKHJlc3VsdFswXSA+ PSAnMCcgJiYgcmVzdWx0WzBdIDw9ICc5JykgewotICAgICAgICAgICAgICAgIGlmIChsZW5ndGgg PiAxKQotICAgICAgICAgICAgICAgICAgICBidWYuaW5zZXJ0KDEgKyBzaWduLCAnLicpOwotICAg ICAgICAgICAgICAgIGJ1ZiArPSAnZSc7Ci0gICAgICAgICAgICAgICAgYnVmICs9IChkZWNwdCA+ PSAwKSA/ICcrJyA6ICctJzsKLSAgICAgICAgICAgICAgICBpbnQgZSA9IGRlY3B0IC0gMTsKLSAg ICAgICAgICAgICAgICBpZiAoZSA8IDApCi0gICAgICAgICAgICAgICAgICAgIGUgPSAtZTsKKyAg ICAgICAgICAgICAgICBpZiAobGVuZ3RoID4gMSkgeworICAgICAgICAgICAgICAgICAgICBidWYu YXBwZW5kKHJlc3VsdCwgMSk7CisgICAgICAgICAgICAgICAgICAgIGJ1Zi5hcHBlbmQoJy4nKTsK KyAgICAgICAgICAgICAgICAgICAgYnVmLmFwcGVuZChyZXN1bHQgKyAxLCByZXN1bHRMZW4gLSAx KTsKKyAgICAgICAgICAgICAgICB9IGVsc2UKKyAgICAgICAgICAgICAgICAgICAgYnVmLmFwcGVu ZChyZXN1bHQsIHJlc3VsdExlbik7CisgICAgICAgICAgICAgICAgYnVmLmFwcGVuZCgnZScpOwor ICAgICAgICAgICAgICAgIGJ1Zi5hcHBlbmQoZGVjcHQgPj0gMCA/ICcrJyA6ICctJyk7CisgICAg ICAgICAgICAgICAgaW50IGUgPSBxQWJzKGRlY3B0IC0gMSk7CiAgICAgICAgICAgICAgICAgaWYg KGUgPj0gMTAwKQotICAgICAgICAgICAgICAgICAgICBidWYgKz0gJzAnICsgZSAvIDEwMDsKKyAg ICAgICAgICAgICAgICAgICAgYnVmLmFwcGVuZCgnMCcgKyBlIC8gMTAwKTsKICAgICAgICAgICAg ICAgICBpZiAoZSA+PSAxMCkKLSAgICAgICAgICAgICAgICAgICAgYnVmICs9ICcwJyArIChlICUg MTAwKSAvIDEwOwotICAgICAgICAgICAgICAgIGJ1ZiArPSAnMCcgKyBlICUgMTA7CisgICAgICAg ICAgICAgICAgICAgIGJ1Zi5hcHBlbmQoJzAnICsgKGUgJSAxMDApIC8gMTApOworICAgICAgICAg ICAgICAgIGJ1Zi5hcHBlbmQoJzAnICsgZSAlIDEwKTsKICAgICAgICAgICAgIH0KICAgICAgICAg fQogICAgICAgICBmcmVlKHJlc3VsdCk7Ci0gICAgICAgIHJldHVybiBRU3RyaW5nOjpmcm9tTGF0 aW4xKGJ1Zik7CisgICAgICAgIGJ1Zi5hcHBlbmQoMCk7CisgICAgICAgIHJldHVybiBRU3RyaW5n Ojpmcm9tTGF0aW4xKGJ1Zi5jb25zdERhdGEoKSk7CiAgICAgfQogfTsKIAo=