35553 2010-03-01 16:34:02 -0800 new-run-webkit-tests doesn't clean up drivers properly 2010-03-01 17:29:52 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 dpranke dpranke abarth cjerdonek eric ojan oldest_to_newest 194864 0 dpranke 2010-03-01 16:34:02 -0800 It turns out that there's a bug in Python ( http://bugs.python.org/issue2320 ) where subprocess.Popen() may get corrupted if you call it from multiple threads. The result is that trying to close the child file descriptors may not work properly, and as a result we end up not cleaning up test_shell / DumpRenderTree properly when we stop it. Workaround is to call subprocess.Popen() with close_fds=True . 194869 1 49764 dpranke 2010-03-01 16:41:08 -0800 Created attachment 49764 patch to spawn and stop dumprendertree/test_shell properly 194872 2 49764 eric 2010-03-01 16:53:24 -0800 Comment on attachment 49764 patch to spawn and stop dumprendertree/test_shell properly We really need to wrap this stuff in some helper functions. But this is better than what we had. 194873 3 dpranke 2010-03-01 16:54:50 -0800 Yeah, I think I can refactor the common driver code up into base.py ; I will look at doing that in a separate change. 194874 4 abarth 2010-03-01 16:55:24 -0800 I feel like this code is copy/pasted twice. Can't we factor it into a common base class? (Not a requirement before landing this patch.) 194879 5 dpranke 2010-03-01 17:07:21 -0800 Committed r55388: <http://trac.webkit.org/changeset/55388> 194886 6 dpranke 2010-03-01 17:29:52 -0800 Committed r55391: <http://trac.webkit.org/changeset/55391> 49764 2010-03-01 16:41:08 -0800 2010-03-01 16:59:01 -0800 patch to spawn and stop dumprendertree/test_shell properly wk35553_fix_stop.diff text/plain 6121 dpranke ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCBmMzMxNGMzLi5iNzAyNjhiIDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VM b2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTAtMDMt MDEgIERpcmsgUHJhbmtlICA8ZHByYW5rZUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgV29yayBhcm91bmQgYSBidWcgaW4gUHl0 aG9uJ3Mgc3VicHJvY2Vzcy5Qb3BlbigpIHRoYXQga2VlcHMgdXMgZnJvbQorICAgICAgICBjbGVh bmluZyB1cCBEdW1wUmVuZGVyVHJlZSAvIHRlc3Rfc2hlbGwgcHJvcGVybHkgd2hlbiB3ZSBmaW5p c2ggdGhlCisgICAgICAgIHRlc3RzIGluIG5ldy1ydW4td2Via2l0LXRlc3RzLgorCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zNTU1MworCisgICAgICAg ICogU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC9jaHJvbWl1bS5weToKKyAgICAg ICAgKiBTY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L21hYy5weToKKwogMjAxMC0w My0wMSAgQXJubyBSZW5ldmllciAgPGFybm9AcmVuZXZpZXIubmV0PgogCiAgICAgICAgIFJldmll d2VkIGJ5IFhhbiBMb3Blei4KZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0 cHkvbGF5b3V0X3Rlc3RzL3BvcnQvY2hyb21pdW0ucHkgYi9XZWJLaXRUb29scy9TY3JpcHRzL3dl YmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L2Nocm9taXVtLnB5CmluZGV4IDg3NDhjODkuLmU1YWZk MDkgMTAwNjQ0Ci0tLSBhL1dlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3Rz L3BvcnQvY2hyb21pdW0ucHkKKysrIGIvV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlv dXRfdGVzdHMvcG9ydC9jaHJvbWl1bS5weQpAQCAtMjI3LDEwICsyMjcsMTQgQEAgY2xhc3MgQ2hy b21pdW1Ecml2ZXIoYmFzZS5Ecml2ZXIpOgogICAgICAgICBjbWQgKz0gW3BvcnQuX3BhdGhfdG9f ZHJpdmVyKCksICctLWxheW91dC10ZXN0cyddCiAgICAgICAgIGlmIG9wdGlvbnM6CiAgICAgICAg ICAgICBjbWQgKz0gb3B0aW9ucworCisgICAgICAgICMgV2UgbmVlZCB0byBwYXNzIGNsb3NlX2Zk cz1UcnVlIHRvIHdvcmsgYXJvdW5kIFB5dGhvbiBidWcgIzIzMjAKKyAgICAgICAgIyAob3RoZXJ3 aXNlIHdlIGNhbiBoYW5nIHdoZW4gd2Uga2lsbCB0ZXN0X3NoZWxsIHdoZW4gd2UgYXJlIHJ1bm5p bmcKKyAgICAgICAgIyBtdWx0aXBsZSB0aHJlYWRzKS4gU2VlIGh0dHA6Ly9idWdzLnB5dGhvbi5v cmcvaXNzdWUyMzIwIC4KICAgICAgICAgc2VsZi5fcHJvYyA9IHN1YnByb2Nlc3MuUG9wZW4oY21k LCBzdGRpbj1zdWJwcm9jZXNzLlBJUEUsCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgIHN0ZG91dD1zdWJwcm9jZXNzLlBJUEUsCi0gICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgIHN0ZGVycj1zdWJwcm9jZXNzLlNURE9VVCkKLQorICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICBzdGRlcnI9c3VicHJvY2Vzcy5TVERPVVQsCisgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGNsb3NlX2Zkcz1UcnVlKQogICAgIGRlZiBw b2xsKHNlbGYpOgogICAgICAgICByZXR1cm4gc2VsZi5fcHJvYy5wb2xsKCkKIApAQCAtMjk5LDEw ICszMDMsMjEgQEAgY2xhc3MgQ2hyb21pdW1Ecml2ZXIoYmFzZS5Ecml2ZXIpOgogICAgICAgICAg ICAgc2VsZi5fcHJvYy5zdGRvdXQuY2xvc2UoKQogICAgICAgICAgICAgaWYgc2VsZi5fcHJvYy5z dGRlcnI6CiAgICAgICAgICAgICAgICAgc2VsZi5fcHJvYy5zdGRlcnIuY2xvc2UoKQotICAgICAg ICAgICAgaWYgKHN5cy5wbGF0Zm9ybSBub3QgaW4gKCd3aW4zMicsICdjeWd3aW4nKSBhbmQKLSAg ICAgICAgICAgICAgICBub3Qgc2VsZi5fcHJvYy5wb2xsKCkpOgotICAgICAgICAgICAgICAgICMg Q2xvc2luZyBzdGRpbi9zdGRvdXQvc3RkZXJyIGhhbmdzIHNvbWV0aW1lcyBvbiBPUyBYLgotICAg ICAgICAgICAgICAgIG51bGwgPSBvcGVuKG9zLmRldm51bGwsICJ3IikKLSAgICAgICAgICAgICAg ICBzdWJwcm9jZXNzLlBvcGVuKFsia2lsbCIsICItOSIsCi0gICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICBzdHIoc2VsZi5fcHJvYy5waWQpXSwgc3RkZXJyPW51bGwpCi0gICAgICAgICAg ICAgICAgbnVsbC5jbG9zZSgpCisgICAgICAgICAgICBpZiBzeXMucGxhdGZvcm0gbm90IGluICgn d2luMzInLCAnY3lnd2luJyk6CisgICAgICAgICAgICAgICAgIyBDbG9zaW5nIHN0ZGluL3N0ZG91 dC9zdGRlcnIgaGFuZ3Mgc29tZXRpbWVzIG9uIE9TIFgsCisgICAgICAgICAgICAgICAgIyAoc2Vl IF9faW5pdF9fKCksIGFib3ZlKSwgYW5kIGFueXdheSB3ZSBkb24ndCB3YW50IHRvIGhhbmcKKyAg ICAgICAgICAgICAgICAjIHRoZSBoYXJuZXNzIGlmIHRlc3Rfc2hlbGwgaXMgYnVnZ3ksIHNvIHdl IHdhaXQgYSBjb3VwbGUKKyAgICAgICAgICAgICAgICAjIHNlY29uZHMgdG8gZ2l2ZSB0ZXN0X3No ZWxsIGEgY2hhbmNlIHRvIGNsZWFuIHVwLCBidXQgdGhlbgorICAgICAgICAgICAgICAgICMgZm9y Y2Uta2lsbCB0aGUgcHJvY2VzcyBpZiBuZWNlc3NhcnkuCisgICAgICAgICAgICAgICAgS0lMTF9U SU1FT1VUID0gMy4wCisgICAgICAgICAgICAgICAgdGltZW91dCA9IHRpbWUudGltZSgpICsgS0lM TF9USU1FT1VUCisgICAgICAgICAgICAgICAgd2hpbGUgc2VsZi5fcHJvYy5wb2xsKCkgaXMgTm9u ZSBhbmQgdGltZS50aW1lKCkgPCB0aW1lb3V0OgorICAgICAgICAgICAgICAgICAgICB0aW1lLnNs ZWVwKDAuMSkKKyAgICAgICAgICAgICAgICBpZiBzZWxmLl9wcm9jLnBvbGwoKSBpcyBOb25lOgor ICAgICAgICAgICAgICAgICAgICBsb2dnaW5nLndhcm5pbmcoJyVkOiB0aW1lb3V0IGluIENocm9t aXVtRHJpdmVyLnN0b3AoKTogJworICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg J2tpbGxpbmcgdGVzdF9zaGVsbCcgJQorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgKHNlbGYuX3Byb2MucGlkKSkKKyAgICAgICAgICAgICAgICAgICAgbnVsbCA9IG9wZW4ob3Mu ZGV2bnVsbCwgInciKQorICAgICAgICAgICAgICAgICAgICBzdWJwcm9jZXNzLlBvcGVuKFsia2ls bCIsICItOSIsCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgc3RyKHNlbGYu X3Byb2MucGlkKV0sIHN0ZGVycj1udWxsKQorICAgICAgICAgICAgICAgICAgICBudWxsLmNsb3Nl KCkKZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3Rz L3BvcnQvbWFjLnB5IGIvV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMv cG9ydC9tYWMucHkKaW5kZXggYzUxYTkyYi4uY2NhZjJhZCAxMDA2NDQKLS0tIGEvV2ViS2l0VG9v bHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC9tYWMucHkKKysrIGIvV2ViS2l0 VG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC9tYWMucHkKQEAgLTMyMSwx MCArMzIxLDE0IEBAIGNsYXNzIE1hY0RyaXZlcihiYXNlLkRyaXZlcik6CiAKICAgICBkZWYgcmVz dGFydChzZWxmKToKICAgICAgICAgc2VsZi5zdG9wKCkKKyAgICAgICAgIyBXZSBuZWVkIHRvIHBh c3MgY2xvc2VfZmRzPVRydWUgdG8gd29yayBhcm91bmQgUHl0aG9uIGJ1ZyAjMjMyMAorICAgICAg ICAjIChvdGhlcndpc2Ugd2UgY2FuIGhhbmcgd2hlbiB3ZSBraWxsIHRlc3Rfc2hlbGwgd2hlbiB3 ZSBhcmUgcnVubmluZworICAgICAgICAjIG11bHRpcGxlIHRocmVhZHMpLiBTZWUgaHR0cDovL2J1 Z3MucHl0aG9uLm9yZy9pc3N1ZTIzMjAgLgogICAgICAgICBzZWxmLl9wcm9jID0gc3VicHJvY2Vz cy5Qb3BlbihzZWxmLl9jbWQsIHN0ZGluPXN1YnByb2Nlc3MuUElQRSwKICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgc3Rkb3V0PXN1YnByb2Nlc3MuUElQRSwKICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgc3RkZXJyPXN1YnByb2Nlc3MuUElQRSwKLSAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgZW52PXNlbGYuX2VudikKKyAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgZW52PXNlbGYuX2VudiwKKyAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgY2xvc2VfZmRzPVRydWUpCiAKICAgICBkZWYg cmV0dXJuY29kZShzZWxmKToKICAgICAgICAgcmV0dXJuIHNlbGYuX3Byb2MucmV0dXJuY29kZQpA QCAtNDI1LDEzICs0MjksMjQgQEAgY2xhc3MgTWFjRHJpdmVyKGJhc2UuRHJpdmVyKToKICAgICAg ICAgICAgIHNlbGYuX3Byb2Muc3Rkb3V0LmNsb3NlKCkKICAgICAgICAgICAgIGlmIHNlbGYuX3By b2Muc3RkZXJyOgogICAgICAgICAgICAgICAgIHNlbGYuX3Byb2Muc3RkZXJyLmNsb3NlKCkKLSAg ICAgICAgICAgIGlmIChzeXMucGxhdGZvcm0gbm90IGluICgnd2luMzInLCAnY3lnd2luJykgYW5k Ci0gICAgICAgICAgICAgICAgbm90IHNlbGYuX3Byb2MucG9sbCgpKToKLSAgICAgICAgICAgICAg ICAjIENsb3Npbmcgc3RkaW4vc3Rkb3V0L3N0ZGVyciBoYW5ncyBzb21ldGltZXMgb24gT1MgWC4K LSAgICAgICAgICAgICAgICBudWxsID0gb3Blbihvcy5kZXZudWxsLCAidyIpCi0gICAgICAgICAg ICAgICAgc3VicHJvY2Vzcy5Qb3BlbihbImtpbGwiLCAiLTkiLAotICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgc3RyKHNlbGYuX3Byb2MucGlkKV0sIHN0ZGVycj1udWxsKQotICAgICAg ICAgICAgICAgIG51bGwuY2xvc2UoKQorICAgICAgICAgICAgaWYgc3lzLnBsYXRmb3JtIG5vdCBp biAoJ3dpbjMyJywgJ2N5Z3dpbicpOgorICAgICAgICAgICAgICAgICMgQ2xvc2luZyBzdGRpbi9z dGRvdXQvc3RkZXJyIGhhbmdzIHNvbWV0aW1lcyBvbiBPUyBYLAorICAgICAgICAgICAgICAgICMg KHNlZSByZXN0YXJ0KCksIGFib3ZlKSwgYW5kIGFueXdheSB3ZSBkb24ndCB3YW50IHRvIGhhbmcK KyAgICAgICAgICAgICAgICAjIHRoZSBoYXJuZXNzIGlmIHRlc3Rfc2hlbGwgaXMgYnVnZ3ksIHNv IHdlIHdhaXQgYSBjb3VwbGUKKyAgICAgICAgICAgICAgICAjIHNlY29uZHMgdG8gZ2l2ZSB0ZXN0 X3NoZWxsIGEgY2hhbmNlIHRvIGNsZWFuIHVwLCBidXQgdGhlbgorICAgICAgICAgICAgICAgICMg Zm9yY2Uta2lsbCB0aGUgcHJvY2VzcyBpZiBuZWNlc3NhcnkuCisgICAgICAgICAgICAgICAgS0lM TF9USU1FT1VUID0gMy4wCisgICAgICAgICAgICAgICAgdGltZW91dCA9IHRpbWUudGltZSgpICsg S0lMTF9USU1FT1VUCisgICAgICAgICAgICAgICAgd2hpbGUgc2VsZi5fcHJvYy5wb2xsKCkgaXMg Tm9uZSBhbmQgdGltZS50aW1lKCkgPCB0aW1lb3V0OgorICAgICAgICAgICAgICAgICAgICB0aW1l LnNsZWVwKDAuMSkKKyAgICAgICAgICAgICAgICBpZiBzZWxmLl9wcm9jLnBvbGwoKSBpcyBOb25l OgorICAgICAgICAgICAgICAgICAgICBsb2dnaW5nLndhcm5pbmcoJyVkOiB0aW1lb3V0IGluIE1h Y0RyaXZlci5zdG9wKCk6ICcKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICdr aWxsaW5nIER1bXBSZW5kZXJUcmVlJyAlCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAoc2VsZi5fcHJvYy5waWQpKQorICAgICAgICAgICAgICAgICAgICBudWxsID0gb3Blbihv cy5kZXZudWxsLCAidyIpCisgICAgICAgICAgICAgICAgICAgIHN1YnByb2Nlc3MuUG9wZW4oWyJr aWxsIiwgIi05IiwKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBzdHIoc2Vs Zi5fcHJvYy5waWQpXSwgc3RkZXJyPW51bGwpCisgICAgICAgICAgICAgICAgICAgIG51bGwuY2xv c2UoKSAgICAgICAgICAgICAgICBub3Qgc2VsZi5fcHJvYy5wb2xsKCkpOgogCiAgICAgZGVmIF9y ZWFkX2xpbmUoc2VsZiwgdGltZW91dCwgc3RvcF90aW1lLCBpbWFnZV9sZW5ndGg9MCk6CiAgICAg ICAgIG5vdyA9IHRpbWUudGltZSgpCg==