35552 2010-03-01 16:01:06 -0800 [V8] DOMCoreException should be visible as DOMException 2010-03-02 11:05:11 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 jianli jianli dglazkov oldest_to_newest 194855 0 jianli 2010-03-01 16:01:06 -0800 We need to make DOMCoreException be visible as DOMException, similar to what JSC code generator does. This will fix several wrong layout test results, like LayoutTests/fast/dom/DOMException/prototype-object.html has the following wrong result: FAIL Object.prototype.toString.call(e) should be [object DOMException]. Was [object DOMCoreException]. ... FAIL e.constructor.toString() should be [object DOMExceptionConstructor]. Was function DOMCoreException() { [native code] }. This will also apply to FormData interface I am going to add at 26979. 194865 1 49763 jianli 2010-03-01 16:35:17 -0800 Created attachment 49763 Proposed Patch 195109 2 49763 japhet 2010-03-02 10:48:23 -0800 Comment on attachment 49763 Proposed Patch Yay for passing layout tests! 195118 3 jianli 2010-03-02 11:05:11 -0800 Committed as http://trac.webkit.org/changeset/55416. 49763 2010-03-01 16:35:17 -0800 2010-03-02 10:48:23 -0800 Proposed Patch 35552 text/plain 2067 jianli ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg NzU2YTc2MC4uOTBjZWZjMSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBAQAorMjAxMC0wMy0wMSAgSmlhbiBMaSAgPGpp YW5saUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgW1Y4XSBET01Db3JlRXhjZXB0aW9uIHNob3VsZCBiZSB2aXNpYmxlIGFzIERP TUV4Y2VwdGlvbiAKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTM1NTUyCisKKyAgICAgICAgRml4IFY4IGNvZGUgZ2VuZXJhdG9yIHRvIHVzZSB0aGUgY29y cmVjdCB2aXNpYmxlIG5hbWUuCisKKyAgICAgICAgKiBiaW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5l cmF0b3JWOC5wbToKKwogMjAxMC0wMy0wMSAgQWxleCBNaWxvd3NraSAgPGFsZXhAbWlsb3dza2ku Y29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEtlbm5ldGggUm9oZGUgQ2hyaXN0aWFuc2VuLgpk aWZmIC0tZ2l0IGEvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JWOC5wbSBi L1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9yVjgucG0KaW5kZXggMmQwYzUw NS4uOWQ3ZWQ0ZiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5l cmF0b3JWOC5wbQorKysgYi9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvclY4 LnBtCkBAIC0xNDg4LDYgKzE0ODgsNyBAQCBzdWIgR2VuZXJhdGVJbXBsZW1lbnRhdGlvbgogICAg IG15ICRvYmplY3QgPSBzaGlmdDsKICAgICBteSAkZGF0YU5vZGUgPSBzaGlmdDsKICAgICBteSAk aW50ZXJmYWNlTmFtZSA9ICRkYXRhTm9kZS0+bmFtZTsKKyAgICBteSAkdmlzaWJsZUludGVyZmFj ZU5hbWUgPSBHZXRWaXNpYmxlSW50ZXJmYWNlTmFtZSgkaW50ZXJmYWNlTmFtZSk7CiAgICAgbXkg JGNsYXNzTmFtZSA9ICJWOCRpbnRlcmZhY2VOYW1lIjsKICAgICBteSAkaW1wbENsYXNzTmFtZSA9 ICRpbnRlcmZhY2VOYW1lOwogICAgIG15ICRjbGFzc0luZGV4ID0gdWMoJGNvZGVHZW5lcmF0b3It PlN0cmlwTW9kdWxlKCRpbnRlcmZhY2VOYW1lKSk7CkBAIC0xNzM1LDcgKzE3MzYsNyBAQCBFTkQK ICAgICAjIEdlbmVyYXRlIHRoZSB0ZW1wbGF0ZSBjb25maWd1cmF0aW9uIG1ldGhvZAogICAgIHB1 c2goQGltcGxDb250ZW50LCAgPDxFTkQpOwogc3RhdGljIHY4OjpQZXJzaXN0ZW50PHY4OjpGdW5j dGlvblRlbXBsYXRlPiBDb25maWd1cmUke2NsYXNzTmFtZX1UZW1wbGF0ZSh2ODo6UGVyc2lzdGVu dDx2ODo6RnVuY3Rpb25UZW1wbGF0ZT4gZGVzYykgewotICB2ODo6TG9jYWw8djg6OlNpZ25hdHVy ZT4gZGVmYXVsdF9zaWduYXR1cmUgPSBjb25maWd1cmVUZW1wbGF0ZShkZXNjLCBcIiR7aW50ZXJm YWNlTmFtZX1cIiwKKyAgdjg6OkxvY2FsPHY4OjpTaWduYXR1cmU+IGRlZmF1bHRfc2lnbmF0dXJl ID0gY29uZmlndXJlVGVtcGxhdGUoZGVzYywgXCIke3Zpc2libGVJbnRlcmZhY2VOYW1lfVwiLAog ICAgICAgJHBhcmVudENsYXNzVGVtcGxhdGUsIFY4JHtpbnRlcmZhY2VOYW1lfTo6aW50ZXJuYWxG aWVsZENvdW50LAogRU5ECiAgICAgIyBTZXQgdXAgb3VyIGF0dHJpYnV0ZXMgaWYgd2UgaGF2ZSB0 aGVtCkBAIC0yOTIwLDYgKzI5MjEsMTUgQEAgc3ViIElzU1ZHTGlzdFR5cGVOZWVkaW5nU3BlY2lh bEhhbmRsaW5nCiAgICAgcmV0dXJuIDA7CiB9CiAKK3N1YiBHZXRWaXNpYmxlSW50ZXJmYWNlTmFt ZQoreworICAgIG15ICRpbnRlcmZhY2VOYW1lID0gc2hpZnQ7CisKKyAgICByZXR1cm4gIkRPTUV4 Y2VwdGlvbiIgaWYgJGludGVyZmFjZU5hbWUgZXEgIkRPTUNvcmVFeGNlcHRpb24iOworICAgIHJl dHVybiAiRm9ybURhdGEiIGlmICRpbnRlcmZhY2VOYW1lIGVxICJET01Gb3JtRGF0YSI7CisgICAg cmV0dXJuICRpbnRlcmZhY2VOYW1lOworfQorCiBzdWIgRGVidWdQcmludAogewogICAgIG15ICRv dXRwdXQgPSBzaGlmdDsK