35546 2010-03-01 14:27:56 -0800 Don't use uint that does not exist on Windows, but unsigned that is present in all ANSI C 2010-03-02 11:50:43 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC Windows XP RESOLVED FIXED P2 Normal --- 0 fridrich.strba webkit-unassigned commit-queue oldest_to_newest 194826 0 49753 fridrich.strba 2010-03-01 14:27:56 -0800 Created attachment 49753 Patch replacing uint by unsigned Patch replacing uint by unsigned 194841 1 49753 levin 2010-03-01 15:12:57 -0800 Comment on attachment 49753 Patch replacing uint by unsigned > Index: WebCore/ChangeLog > +2010-03-01 Fridrich Strba <fridrich.strba@bluewin.ch> > + > + Reviewed by NOBODY (OOPS!). > + > + Use unsigned instead of uint which does not exist on windows You should have a link to the bug here. (I would r+ and say fix this on landing but I don't think you have commit bit.) 194966 2 49786 fridrich.strba 2010-03-01 23:59:09 -0800 Created attachment 49786 Patch replacing uint by unsigned including the link to this honourable bug report 194968 3 49786 xan.lopez 2010-03-02 00:01:57 -0800 Comment on attachment 49786 Patch replacing uint by unsigned including the link to this honourable bug report r=me 195146 4 49786 commit-queue 2010-03-02 11:50:39 -0800 Comment on attachment 49786 Patch replacing uint by unsigned including the link to this honourable bug report Clearing flags on attachment: 49786 Committed r55420: <http://trac.webkit.org/changeset/55420> 195147 5 commit-queue 2010-03-02 11:50:43 -0800 All reviewed patches have been landed. Closing bug. 49753 2010-03-01 14:27:56 -0800 2010-03-01 23:59:09 -0800 Patch replacing uint by unsigned dont-use-uint.diff text/plain 1468 fridrich.strba SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1NTM3OSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTMgQEAKKzIwMTAtMDMtMDEgIEZyaWRyaWNoIFN0cmJhICA8ZnJpZHJpY2guc3Ry YmFAYmx1ZXdpbi5jaD4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBVc2UgdW5zaWduZWQgaW5zdGVhZCBvZiB1aW50IHdoaWNoIGRvZXMgbm90IGV4aXN0 IG9uIHdpbmRvd3MKKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2d0ay9JbWFnZUd0ay5j cHA6CisgICAgICAgIChXZWJDb3JlOjpnZXRDYWlyb1N1cmZhY2VQaXhlbCk6CisgICAgICAgIChX ZWJDb3JlOjpnZXRHZGtQaXhidWZQaXhlbCk6CisKIDIwMTAtMDMtMDEgIEZyaWRyaWNoIFN0cmJh ICA8ZnJpZHJpY2guc3RyYmFAYmx1ZXdpbi5jaD4KIAogICAgICAgICBSZXZpZXdlZCBieSBIb2xn ZXIgRnJleXRoZXIuCkluZGV4OiBXZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2d0ay9JbWFnZUd0 ay5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9ndGsvSW1hZ2VH dGsuY3BwCShyZXZpc2lvbiA1NTM3OCkKKysrIFdlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3Rr L0ltYWdlR3RrLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTA3LDEyICsxMDcsMTIgQEAgUGFzc1Jl ZlB0cjxJbWFnZT4gSW1hZ2U6OmxvYWRQbGF0Zm9ybVRoZQogICAgIHJldHVybiBsb2FkSW1hZ2VG cm9tRmlsZShnZXRUaGVtZUljb25GaWxlTmFtZShuYW1lLCBzaXplKSk7CiB9CiAKLXN0YXRpYyBp bmxpbmUgdW5zaWduZWQgY2hhciogZ2V0Q2Fpcm9TdXJmYWNlUGl4ZWwodW5zaWduZWQgY2hhciog ZGF0YSwgdWludCB4LCB1aW50IHksIHVpbnQgcm93U3RyaWRlKQorc3RhdGljIGlubGluZSB1bnNp Z25lZCBjaGFyKiBnZXRDYWlyb1N1cmZhY2VQaXhlbCh1bnNpZ25lZCBjaGFyKiBkYXRhLCB1bnNp Z25lZCB4LCB1bnNpZ25lZCB5LCB1bnNpZ25lZCByb3dTdHJpZGUpCiB7CiAgICAgcmV0dXJuIGRh dGEgKyAoeSAqIHJvd1N0cmlkZSkgKyB4ICogNDsKIH0KIAotc3RhdGljIGlubGluZSBndWNoYXIq IGdldEdka1BpeGJ1ZlBpeGVsKGd1Y2hhciogZGF0YSwgdWludCB4LCB1aW50IHksIHVpbnQgcm93 U3RyaWRlKQorc3RhdGljIGlubGluZSBndWNoYXIqIGdldEdka1BpeGJ1ZlBpeGVsKGd1Y2hhciog ZGF0YSwgdW5zaWduZWQgeCwgdW5zaWduZWQgeSwgdW5zaWduZWQgcm93U3RyaWRlKQogewogICAg IHJldHVybiBkYXRhICsgKHkgKiByb3dTdHJpZGUpICsgeCAqIDQ7CiB9Cg== 49786 2010-03-01 23:59:09 -0800 2010-03-02 11:50:39 -0800 Patch replacing uint by unsigned including the link to this honourable bug report dont-use-uint.diff text/plain 1513 fridrich.strba SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1NTM5OSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTQgQEAKKzIwMTAtMDMtMDEgIEZyaWRyaWNoIFN0cmJhICA8ZnJpZHJpY2guc3Ry YmFAYmx1ZXdpbi5jaD4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBVc2UgdW5zaWduZWQgaW5zdGVhZCBvZiB1aW50IHdoaWNoIGRvZXMgbm90IGV4aXN0 IG9uIHdpbmRvd3MKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTM1NTQ2CisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9ndGsvSW1hZ2VHdGsuY3Bw OgorICAgICAgICAoV2ViQ29yZTo6Z2V0Q2Fpcm9TdXJmYWNlUGl4ZWwpOgorICAgICAgICAoV2Vi Q29yZTo6Z2V0R2RrUGl4YnVmUGl4ZWwpOgorCiAyMDEwLTAzLTAxICBPbGl2ZXIgSHVudCAgPG9s aXZlckBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgR2F2aW4gQmFycmFjbG91Z2gu CkluZGV4OiBXZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2d0ay9JbWFnZUd0ay5jcHAKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9ndGsvSW1hZ2VHdGsuY3BwCShyZXZp c2lvbiA1NTM5OSkKKysrIFdlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3RrL0ltYWdlR3RrLmNw cAkod29ya2luZyBjb3B5KQpAQCAtMTA3LDEyICsxMDcsMTIgQEAgUGFzc1JlZlB0cjxJbWFnZT4g SW1hZ2U6OmxvYWRQbGF0Zm9ybVRoZQogICAgIHJldHVybiBsb2FkSW1hZ2VGcm9tRmlsZShnZXRU aGVtZUljb25GaWxlTmFtZShuYW1lLCBzaXplKSk7CiB9CiAKLXN0YXRpYyBpbmxpbmUgdW5zaWdu ZWQgY2hhciogZ2V0Q2Fpcm9TdXJmYWNlUGl4ZWwodW5zaWduZWQgY2hhciogZGF0YSwgdWludCB4 LCB1aW50IHksIHVpbnQgcm93U3RyaWRlKQorc3RhdGljIGlubGluZSB1bnNpZ25lZCBjaGFyKiBn ZXRDYWlyb1N1cmZhY2VQaXhlbCh1bnNpZ25lZCBjaGFyKiBkYXRhLCB1bnNpZ25lZCB4LCB1bnNp Z25lZCB5LCB1bnNpZ25lZCByb3dTdHJpZGUpCiB7CiAgICAgcmV0dXJuIGRhdGEgKyAoeSAqIHJv d1N0cmlkZSkgKyB4ICogNDsKIH0KIAotc3RhdGljIGlubGluZSBndWNoYXIqIGdldEdka1BpeGJ1 ZlBpeGVsKGd1Y2hhciogZGF0YSwgdWludCB4LCB1aW50IHksIHVpbnQgcm93U3RyaWRlKQorc3Rh dGljIGlubGluZSBndWNoYXIqIGdldEdka1BpeGJ1ZlBpeGVsKGd1Y2hhciogZGF0YSwgdW5zaWdu ZWQgeCwgdW5zaWduZWQgeSwgdW5zaWduZWQgcm93U3RyaWRlKQogewogICAgIHJldHVybiBkYXRh ICsgKHkgKiByb3dTdHJpZGUpICsgeCAqIDQ7CiB9Cg==