35534 2010-03-01 11:39:14 -0800 -[WebArchive initWithCoder:] leaks 2010-03-04 09:26:01 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Mac OS X 10.6 RESOLVED FIXED InRadar P2 Normal --- 1 jim.correia beidson beidson simon.fraser oldest_to_newest 194747 0 jim.correia 2010-03-01 11:39:14 -0800 As of r41903, -[WebArchive initWithCoder:] leaks. It retains the objects decoded from the unarchiver, passes them to another initializer, and never releases them. This bug was introduced in r31281. 194749 1 simon.fraser 2010-03-01 11:42:36 -0800 http://trac.webkit.org/changeset/31281 194750 2 beidson 2010-03-01 11:44:39 -0800 <rdar://problem/7702420> 196096 3 50028 beidson 2010-03-04 09:04:59 -0800 Created attachment 50028 Don't retain what we don't own. 196098 4 50028 ggaren 2010-03-04 09:11:02 -0800 Comment on attachment 50028 Don't retain what we don't own. r=me 196099 5 beidson 2010-03-04 09:26:01 -0800 http://trac.webkit.org/changeset/55529 50028 2010-03-04 09:04:59 -0800 2010-03-04 09:11:02 -0800 Don't retain what we don't own. patch.txt text/plain 1620 beidson SW5kZXg6IFdlYktpdC9tYWMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdC9tYWMvQ2hh bmdlTG9nCShyZXZpc2lvbiA1NTUyNykKKysrIFdlYktpdC9tYWMvQ2hhbmdlTG9nCSh3b3JraW5n IGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTAtMDMtMDQgIEJyYWR5IEVpZHNvbiAgPGJlaWRz b25AYXBwbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIFJFR1JFU1NJT04gKDMxMjgxKTogLVtXZWJBcmNoaXZlIGluaXRXaXRoQ29kZXI6XSBs ZWFrcworICAgICAgICA8cmRhcjovL3Byb2JsZW0vNzcwMjQyMD4gYW5kIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zNTUzNAorCisgICAgICAgICogV2ViVmlldy9XZWJB cmNoaXZlLm1tOgorICAgICAgICAoLVtXZWJBcmNoaXZlIGluaXRXaXRoQ29kZXI6XSk6IERvbid0 IHJldGFpbiBvYmplY3RzIHdlIGRvbid0IG93bi4KKwogMjAxMC0wMy0wMyAgQWxleGV5IFByb3Nr dXJ5YWtvdiAgPGFwQGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBUaW1vdGh5IEhh dGNoZXIuCkluZGV4OiBXZWJLaXQvbWFjL1dlYlZpZXcvV2ViQXJjaGl2ZS5tbQo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBXZWJLaXQvbWFjL1dlYlZpZXcvV2ViQXJjaGl2ZS5tbQkocmV2aXNpb24gNTU0OTEpCisr KyBXZWJLaXQvbWFjL1dlYlZpZXcvV2ViQXJjaGl2ZS5tbQkod29ya2luZyBjb3B5KQpAQCAtMjM5 LDEzICsyMzksMTMgQEAgc3RhdGljIEJPT0wgaXNBcnJheU9mQ2xhc3MoaWQgb2JqZWN0LCBDbAog ICAgIEB0cnkgewogICAgICAgICBpZCBvYmplY3QgPSBbZGVjb2RlciBkZWNvZGVPYmplY3RGb3JL ZXk6V2ViTWFpblJlc291cmNlS2V5XTsKICAgICAgICAgaWYgKFtvYmplY3QgaXNLaW5kT2ZDbGFz czpbV2ViUmVzb3VyY2UgY2xhc3NdXSkKLSAgICAgICAgICAgIG1haW5SZXNvdXJjZSA9IFtvYmpl Y3QgcmV0YWluXTsKKyAgICAgICAgICAgIG1haW5SZXNvdXJjZSA9IG9iamVjdDsKICAgICAgICAg b2JqZWN0ID0gW2RlY29kZXIgZGVjb2RlT2JqZWN0Rm9yS2V5OldlYlN1YnJlc291cmNlc0tleV07 CiAgICAgICAgIGlmIChpc0FycmF5T2ZDbGFzcyhvYmplY3QsIFtXZWJSZXNvdXJjZSBjbGFzc10p KQotICAgICAgICAgICAgc3VicmVzb3VyY2VzID0gW29iamVjdCByZXRhaW5dOworICAgICAgICAg ICAgc3VicmVzb3VyY2VzID0gb2JqZWN0OwogICAgICAgICBvYmplY3QgPSBbZGVjb2RlciBkZWNv ZGVPYmplY3RGb3JLZXk6V2ViU3ViZnJhbWVBcmNoaXZlc0tleV07CiAgICAgICAgIGlmIChpc0Fy cmF5T2ZDbGFzcyhvYmplY3QsIFtXZWJBcmNoaXZlIGNsYXNzXSkpCi0gICAgICAgICAgICBzdWJm cmFtZUFyY2hpdmVzID0gW29iamVjdCByZXRhaW5dOworICAgICAgICAgICAgc3ViZnJhbWVBcmNo aXZlcyA9IG9iamVjdDsKICAgICB9IEBjYXRjaChpZCkgewogICAgICAgICBbc2VsZiByZWxlYXNl XTsKICAgICAgICAgcmV0dXJuIG5pbDsK