35516 2010-03-01 00:30:34 -0800 [Qt] GraphicsLayer: Video element with 3d transform crashes when AC is enabled. 2010-03-02 12:15:38 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 0 kim.1.gronholm webkit-unassigned commit-queue noam webkit.review.bot oldest_to_newest 194642 0 49711 kim.1.gronholm 2010-03-01 00:30:34 -0800 Created attachment 49711 Video element with 3d transformation The crash happens because GraphicsLayerQt::setContentsToMedia(PlatformLayer* media) gets called with media==NULL. Attached a test page that demonstrates the issue. The crash doesn't happen if ACCELERATED_COMPOSITING is disabled. 194643 1 49712 kim.1.gronholm 2010-03-01 00:38:26 -0800 Created attachment 49712 Prevents the crash. This patch only prevents the crash without tackling the issue why the 'media'-pointer is NULL. 194649 2 noam 2010-03-01 01:37:06 -0800 The parameter is null when the compositor wants to cancel the compositing of this video element, and move it back to the regular renderer. we should, in that case, change the content type to HTML and not leave it as video. 194660 3 49715 kim.1.gronholm 2010-03-01 02:15:43 -0800 Created attachment 49715 Patch for preventing the crash in bug #35516 Made the changes Noam requested and submitted a new patch. 194680 4 noam 2010-03-01 04:39:29 -0800 You should r? cq? it again, if it's complete 194689 5 webkit.review.bot 2010-03-01 04:54:36 -0800 Attachment 49715 did not pass style-queue: Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1 WebCore/platform/graphics/qt/GraphicsLayerQt.cpp:857: One line control clauses should not use braces. [whitespace/braces] [4] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 194691 6 49720 kim.1.gronholm 2010-03-01 04:58:46 -0800 Created attachment 49720 Updated patch for preventing the crash in bug #35516 Fixed a style issue in the patch. 195160 7 49720 commit-queue 2010-03-02 12:15:34 -0800 Comment on attachment 49720 Updated patch for preventing the crash in bug #35516 Clearing flags on attachment: 49720 Committed r55421: <http://trac.webkit.org/changeset/55421> 195161 8 commit-queue 2010-03-02 12:15:38 -0800 All reviewed patches have been landed. Closing bug. 49711 2010-03-01 00:30:34 -0800 2010-03-01 00:30:34 -0800 Video element with 3d transformation video-css-anim-bug.html text/html 280 kim.1.gronholm PGh0bWw+CiAgICA8aGVhZD4KICAgICAgICA8c3R5bGU+CiAgICAgICAgICAgIHZpZGVvIHsKICAg ICAgICAgICAgICAgICAtd2Via2l0LXRyYW5zZm9ybTogcm90YXRlWSgxZGVnKTsKICAgICAgICAg ICAgfQogICAgICAgIDwvc3R5bGU+CiAgICA8L2hlYWQ+CiAgICA8Ym9keT4KICAgICAgICA8ZGl2 PgogICAgICAgICAgICA8dmlkZW8gd2lkdGg9IjMyMCIgaGVpZ2h0PSIyNDAiIHNyYz0iQUNUNjAu TVBHIiBhdXRvcGxheSAvPgogICAgICAgIDwvZGl2PgogICAgPC9ib2R5Pgo8L2h0bWw+Cg== 49712 2010-03-01 00:38:26 -0800 2010-03-01 02:15:43 -0800 Prevents the crash. patch-35516 text/plain 1545 kim.1.gronholm ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg MGM4Y2MwMS4uOTk0YWZhZCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxMC0wMy0wMSAgS2ltIEdyw7ZuaG9s bSAgPGtpbS5ncm9uaG9sbUBub21vdm9rLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBbUXRdIEdyYXBoaWNzTGF5ZXI6IFZpZGVvIGVsZW1lbnQg d2l0aCAzZCB0cmFuc2Zvcm0gY3Jhc2hlcyB3aGVuIEFDIGlzIGVuYWJsZWQuCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zNTUxNgorCisgICAgICAgIE5v IG5ldyB0ZXN0cy4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL3F0L0dyYXBoaWNzTGF5 ZXJRdC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpHcmFwaGljc0xheWVyUXQ6OnNldENvbnRlbnRz VG9NZWRpYSk6CisKIDIwMTAtMDItMjggIEFsZXhleSBQcm9za3VyeWFrb3YgIDxhcEBhcHBsZS5j b20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGFuIEJlcm5zdGVpbi4KZGlmZiAtLWdpdCBhL1dl YkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvcXQvR3JhcGhpY3NMYXllclF0LmNwcCBiL1dlYkNvcmUv cGxhdGZvcm0vZ3JhcGhpY3MvcXQvR3JhcGhpY3NMYXllclF0LmNwcAppbmRleCA5NzQ1YmQwLi4x Y2QyMzQ3IDEwMDY0NAotLS0gYS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3F0L0dyYXBoaWNz TGF5ZXJRdC5jcHAKKysrIGIvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9xdC9HcmFwaGljc0xh eWVyUXQuY3BwCkBAIC04NDksOSArODQ5LDExIEBAIHZvaWQgR3JhcGhpY3NMYXllclF0OjpzZXRD b250ZW50c0JhY2tncm91bmRDb2xvcihjb25zdCBDb2xvciYgY29sb3IpCiAKIHZvaWQgR3JhcGhp Y3NMYXllclF0OjpzZXRDb250ZW50c1RvTWVkaWEoUGxhdGZvcm1MYXllciogbWVkaWEpCiB7Ci0g ICAgbV9pbXBsLT5ub3RpZnlDaGFuZ2UoR3JhcGhpY3NMYXllclF0SW1wbDo6Q29udGVudENoYW5n ZSk7Ci0gICAgbV9pbXBsLT5tX3BlbmRpbmdDb250ZW50LmNvbnRlbnRUeXBlID0gR3JhcGhpY3NM YXllclF0SW1wbDo6TWVkaWFDb250ZW50VHlwZTsKLSAgICBtX2ltcGwtPm1fcGVuZGluZ0NvbnRl bnQubWVkaWFMYXllciA9IG1lZGlhLT50b0dyYXBoaWNzT2JqZWN0KCk7CisgICAgaWYgKG1lZGlh KSB7CisgICAgICAgIG1faW1wbC0+bm90aWZ5Q2hhbmdlKEdyYXBoaWNzTGF5ZXJRdEltcGw6OkNv bnRlbnRDaGFuZ2UpOworICAgICAgICBtX2ltcGwtPm1fcGVuZGluZ0NvbnRlbnQuY29udGVudFR5 cGUgPSBHcmFwaGljc0xheWVyUXRJbXBsOjpNZWRpYUNvbnRlbnRUeXBlOworICAgICAgICBtX2lt cGwtPm1fcGVuZGluZ0NvbnRlbnQubWVkaWFMYXllciA9IG1lZGlhLT50b0dyYXBoaWNzT2JqZWN0 KCk7CisgICAgfQogICAgIEdyYXBoaWNzTGF5ZXI6OnNldENvbnRlbnRzVG9NZWRpYShtZWRpYSk7 CiB9CiAK 49715 2010-03-01 02:15:43 -0800 2010-03-01 04:58:46 -0800 Patch for preventing the crash in bug #35516 patch-35516-2 text/plain 1578 kim.1.gronholm ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg MGM4Y2MwMS4uYjU5YWNmNSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxMC0wMy0wMSAgS2ltIEdyw7ZuaG9s bSAgPGtpbS5ncm9uaG9sbUBub21vdm9rLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBbUXRdIEdyYXBoaWNzTGF5ZXI6IFZpZGVvIGVsZW1lbnQg d2l0aCAzZCB0cmFuc2Zvcm0gY3Jhc2hlcyB3aGVuIEFDIGlzIGVuYWJsZWQuCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zNTUxNgorCisgICAgICAgIE5v IG5ldyB0ZXN0cy4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL3F0L0dyYXBoaWNzTGF5 ZXJRdC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpHcmFwaGljc0xheWVyUXQ6OnNldENvbnRlbnRz VG9NZWRpYSk6CisKIDIwMTAtMDItMjggIEFsZXhleSBQcm9za3VyeWFrb3YgIDxhcEBhcHBsZS5j b20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGFuIEJlcm5zdGVpbi4KZGlmZiAtLWdpdCBhL1dl YkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvcXQvR3JhcGhpY3NMYXllclF0LmNwcCBiL1dlYkNvcmUv cGxhdGZvcm0vZ3JhcGhpY3MvcXQvR3JhcGhpY3NMYXllclF0LmNwcAppbmRleCA5NzQ1YmQwLi42 NDU1MDE3IDEwMDY0NAotLS0gYS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3F0L0dyYXBoaWNz TGF5ZXJRdC5jcHAKKysrIGIvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9xdC9HcmFwaGljc0xh eWVyUXQuY3BwCkBAIC04NDksOSArODQ5LDEzIEBAIHZvaWQgR3JhcGhpY3NMYXllclF0OjpzZXRD b250ZW50c0JhY2tncm91bmRDb2xvcihjb25zdCBDb2xvciYgY29sb3IpCiAKIHZvaWQgR3JhcGhp Y3NMYXllclF0OjpzZXRDb250ZW50c1RvTWVkaWEoUGxhdGZvcm1MYXllciogbWVkaWEpCiB7Cisg ICAgaWYgKG1lZGlhKSB7CisgICAgICAgIG1faW1wbC0+bV9wZW5kaW5nQ29udGVudC5jb250ZW50 VHlwZSA9IEdyYXBoaWNzTGF5ZXJRdEltcGw6Ok1lZGlhQ29udGVudFR5cGU7CisgICAgICAgIG1f aW1wbC0+bV9wZW5kaW5nQ29udGVudC5tZWRpYUxheWVyID0gbWVkaWEtPnRvR3JhcGhpY3NPYmpl Y3QoKTsKKyAgICB9IGVsc2UgeworICAgICAgICBtX2ltcGwtPm1fcGVuZGluZ0NvbnRlbnQuY29u dGVudFR5cGUgPSBHcmFwaGljc0xheWVyUXRJbXBsOjpIVE1MQ29udGVudFR5cGU7CisgICAgfQog ICAgIG1faW1wbC0+bm90aWZ5Q2hhbmdlKEdyYXBoaWNzTGF5ZXJRdEltcGw6OkNvbnRlbnRDaGFu Z2UpOwotICAgIG1faW1wbC0+bV9wZW5kaW5nQ29udGVudC5jb250ZW50VHlwZSA9IEdyYXBoaWNz TGF5ZXJRdEltcGw6Ok1lZGlhQ29udGVudFR5cGU7Ci0gICAgbV9pbXBsLT5tX3BlbmRpbmdDb250 ZW50Lm1lZGlhTGF5ZXIgPSBtZWRpYS0+dG9HcmFwaGljc09iamVjdCgpOwogICAgIEdyYXBoaWNz TGF5ZXI6OnNldENvbnRlbnRzVG9NZWRpYShtZWRpYSk7CiB9CiAK 49720 2010-03-01 04:58:46 -0800 2010-03-02 12:15:34 -0800 Updated patch for preventing the crash in bug #35516 patch-35516-2 text/plain 1571 kim.1.gronholm ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg MGM4Y2MwMS4uYjU5YWNmNSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxMC0wMy0wMSAgS2ltIEdyw7ZuaG9s bSAgPGtpbS5ncm9uaG9sbUBub21vdm9rLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBbUXRdIEdyYXBoaWNzTGF5ZXI6IFZpZGVvIGVsZW1lbnQg d2l0aCAzZCB0cmFuc2Zvcm0gY3Jhc2hlcyB3aGVuIEFDIGlzIGVuYWJsZWQuCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zNTUxNgorCisgICAgICAgIE5v IG5ldyB0ZXN0cy4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL3F0L0dyYXBoaWNzTGF5 ZXJRdC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpHcmFwaGljc0xheWVyUXQ6OnNldENvbnRlbnRz VG9NZWRpYSk6CisKIDIwMTAtMDItMjggIEFsZXhleSBQcm9za3VyeWFrb3YgIDxhcEBhcHBsZS5j b20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGFuIEJlcm5zdGVpbi4KZGlmZiAtLWdpdCBhL1dl YkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvcXQvR3JhcGhpY3NMYXllclF0LmNwcCBiL1dlYkNvcmUv cGxhdGZvcm0vZ3JhcGhpY3MvcXQvR3JhcGhpY3NMYXllclF0LmNwcAppbmRleCA5NzQ1YmQwLi45 YTJlOTMyIDEwMDY0NAotLS0gYS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3F0L0dyYXBoaWNz TGF5ZXJRdC5jcHAKKysrIGIvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9xdC9HcmFwaGljc0xh eWVyUXQuY3BwCkBAIC04NDksOSArODQ5LDEzIEBAIHZvaWQgR3JhcGhpY3NMYXllclF0OjpzZXRD b250ZW50c0JhY2tncm91bmRDb2xvcihjb25zdCBDb2xvciYgY29sb3IpCiAKIHZvaWQgR3JhcGhp Y3NMYXllclF0OjpzZXRDb250ZW50c1RvTWVkaWEoUGxhdGZvcm1MYXllciogbWVkaWEpCiB7Cisg ICAgaWYgKG1lZGlhKSB7CisgICAgICAgIG1faW1wbC0+bV9wZW5kaW5nQ29udGVudC5jb250ZW50 VHlwZSA9IEdyYXBoaWNzTGF5ZXJRdEltcGw6Ok1lZGlhQ29udGVudFR5cGU7CisgICAgICAgIG1f aW1wbC0+bV9wZW5kaW5nQ29udGVudC5tZWRpYUxheWVyID0gbWVkaWEtPnRvR3JhcGhpY3NPYmpl Y3QoKTsKKyAgICB9IGVsc2UKKyAgICAgICAgbV9pbXBsLT5tX3BlbmRpbmdDb250ZW50LmNvbnRl bnRUeXBlID0gR3JhcGhpY3NMYXllclF0SW1wbDo6SFRNTENvbnRlbnRUeXBlOworCiAgICAgbV9p bXBsLT5ub3RpZnlDaGFuZ2UoR3JhcGhpY3NMYXllclF0SW1wbDo6Q29udGVudENoYW5nZSk7Ci0g ICAgbV9pbXBsLT5tX3BlbmRpbmdDb250ZW50LmNvbnRlbnRUeXBlID0gR3JhcGhpY3NMYXllclF0 SW1wbDo6TWVkaWFDb250ZW50VHlwZTsKLSAgICBtX2ltcGwtPm1fcGVuZGluZ0NvbnRlbnQubWVk aWFMYXllciA9IG1lZGlhLT50b0dyYXBoaWNzT2JqZWN0KCk7CiAgICAgR3JhcGhpY3NMYXllcjo6 c2V0Q29udGVudHNUb01lZGlhKG1lZGlhKTsKIH0KIAo=