35513 2010-02-28 22:53:32 -0800 Unnecessary code in ScrollView.cpp 2010-03-02 17:44:00 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) PC All RESOLVED FIXED P2 Normal --- 1 jam jam commit-queue oldest_to_newest 194628 0 jam 2010-02-28 22:53:32 -0800 I saw this by chance as I was reading the code. 194629 1 49708 jam 2010-02-28 22:55:01 -0800 Created attachment 49708 Proposed patch 195336 2 49708 commit-queue 2010-03-02 17:43:56 -0800 Comment on attachment 49708 Proposed patch Clearing flags on attachment: 49708 Committed r55445: <http://trac.webkit.org/changeset/55445> 195337 3 commit-queue 2010-03-02 17:44:00 -0800 All reviewed patches have been landed. Closing bug. 49708 2010-02-28 22:55:01 -0800 2010-03-02 17:43:56 -0800 Proposed patch extracode.txt text/plain 1329 jam SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1NTM2MCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTMgQEAKKzIwMTAtMDItMjggIEpvaG4gQWJkLUVsLU1hbGVrICA8amFtQGNocm9t aXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBSZW1vdmUgdW5uZWNlc3NhcnkgY2hlY2suCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0zNTUxMworCisgICAgICAgICogcGxhdGZvcm0vU2Nyb2xsVmll dy5jcHA6CisgICAgICAgIChXZWJDb3JlOjpTY3JvbGxWaWV3Ojp1cGRhdGVTY3JvbGxiYXJzKToK KwogMjAxMC0wMi0yOCAgQWxleGV5IFByb3NrdXJ5YWtvdiAgPGFwQGFwcGxlLmNvbT4KIAogICAg ICAgICBSZXZpZXdlZCBieSBEYW4gQmVybnN0ZWluLgpJbmRleDogV2ViQ29yZS9wbGF0Zm9ybS9T Y3JvbGxWaWV3LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL3BsYXRmb3JtL1Njcm9sbFZpZXcu Y3BwCShyZXZpc2lvbiA1NTM2MCkKKysrIFdlYkNvcmUvcGxhdGZvcm0vU2Nyb2xsVmlldy5jcHAJ KHdvcmtpbmcgY29weSkKQEAgLTQ0OCw4ICs0NDgsNiBAQCB2b2lkIFNjcm9sbFZpZXc6OnVwZGF0 ZVNjcm9sbGJhcnMoY29uc3QgCiAgICAgICAgIGludCBjbGllbnRIZWlnaHQgPSB2aXNpYmxlSGVp Z2h0KCk7CiAgICAgICAgIG1fdmVydGljYWxTY3JvbGxiYXItPnNldEVuYWJsZWQoY29udGVudHNI ZWlnaHQoKSA+IGNsaWVudEhlaWdodCk7CiAgICAgICAgIGludCBwYWdlU3RlcCA9IG1heChtYXg8 aW50PihjbGllbnRIZWlnaHQgKiBTY3JvbGxiYXI6Om1pbkZyYWN0aW9uVG9TdGVwV2hlblBhZ2lu ZygpLCBjbGllbnRIZWlnaHQgLSBTY3JvbGxiYXI6Om1heE92ZXJsYXBCZXR3ZWVuUGFnZXMoKSks IDEpOwotICAgICAgICBpZiAocGFnZVN0ZXAgPCAwKQotICAgICAgICAgICAgcGFnZVN0ZXAgPSBj bGllbnRIZWlnaHQ7CiAgICAgICAgIEludFJlY3Qgb2xkUmVjdChtX3ZlcnRpY2FsU2Nyb2xsYmFy LT5mcmFtZVJlY3QoKSk7CiAgICAgICAgIEludFJlY3QgdkJhclJlY3QgPSBJbnRSZWN0KHdpZHRo KCkgLSBtX3ZlcnRpY2FsU2Nyb2xsYmFyLT53aWR0aCgpLCAKICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgMCwK