35500 2010-02-28 13:03:09 -0800 [Gtk] Add private browing for plugins for Gtk too 2010-03-02 02:06:34 -0800 1 1 1 Unclassified WebKit Plug-ins 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 zecke webkit-unassigned gustavo oldest_to_newest 194597 0 zecke 2010-02-28 13:03:09 -0800 In bug #33180 PluginViewQt.cpp got extended to support private browsing for plugins. The bug equally applies to Gtk+. We are already sharing the PluginPackage, we should look into sharing the PluginView as well but it is a bit more difficult. 194599 1 49702 zecke 2010-02-28 13:11:54 -0800 Created attachment 49702 Add private browsing for plugins to PluginViewGtk.cpp This is the same code from PluginViewQt.cpp applied to PluginViewGtk.cpp 194830 2 49702 gustavo 2010-03-01 14:37:21 -0800 Comment on attachment 49702 Add private browsing for plugins to PluginViewGtk.cpp Looks good to me. 194985 3 zecke 2010-03-02 02:04:24 -0800 Landed in r55405. 49702 2010-02-28 13:11:54 -0800 2010-03-01 14:37:21 -0800 Add private browsing for plugins to PluginViewGtk.cpp 0001-Gtk-Support-private-browsing-mode-in-plugins.patch text/plain 3163 zecke RnJvbSAzMGZjNWQzMjEyMGQ1ZWU5YTA3ZTcyZmNiZGZlZGNkNjE4OWM5MTFkIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBIb2xnZXIgSGFucyBQZXRlciBGcmV5dGhlciA8emVja2VAc2Vs ZmlzaC5vcmc+CkRhdGU6IFN1biwgMjggRmViIDIwMTAgMjI6MDY6MTUgKzAxMDAKU3ViamVjdDog W1BBVENIXSBbR3RrXSBTdXBwb3J0IHByaXZhdGUgYnJvd3NpbmcgbW9kZSBpbiBwbHVnaW5zLgoK aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM1NTAwCgpJbnRlZ3JhdGUg dGhlIFBsdWdpblZpZXdRdC5jcHAgY2hhbmdlcyBmcm9tCnI1NTM1OCBpbnRvIEd0aysgYW5kIHVu c2tpcCB0aGUgdGVzdC4KCiogcGx1Z2lucy9ndGsvUGx1Z2luVmlld0d0ay5jcHA6CihXZWJDb3Jl OjpQbHVnaW5WaWV3OjpnZXRWYWx1ZSk6CiogcGxhdGZvcm0vZ3RrL1NraXBwZWQ6Ci0tLQogTGF5 b3V0VGVzdHMvQ2hhbmdlTG9nICAgICAgICAgICAgICAgICB8ICAgMTEgKysrKysrKysrKysKIExh eW91dFRlc3RzL3BsYXRmb3JtL2d0ay9Ta2lwcGVkICAgICAgfCAgICAyIC0tCiBXZWJDb3JlL0No YW5nZUxvZyAgICAgICAgICAgICAgICAgICAgIHwgICAxMiArKysrKysrKysrKysKIFdlYkNvcmUv cGx1Z2lucy9ndGsvUGx1Z2luVmlld0d0ay5jcHAgfCAgICA4ICsrKysrKysrCiA0IGZpbGVzIGNo YW5nZWQsIDMxIGluc2VydGlvbnMoKyksIDIgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvTGF5 b3V0VGVzdHMvQ2hhbmdlTG9nIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCmluZGV4IDQ4NzE5Yjku LmExZWVlNTEgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL0NoYW5nZUxvZworKysgYi9MYXlvdXRU ZXN0cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBAQAorMjAxMC0wMi0yOCAgSG9sZ2VyIEhhbnMg UGV0ZXIgRnJleXRoZXIgIDx6ZWNrZUBzZWxmaXNoLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbR3RrXSBTdXBwb3J0IHByaXZhdGUgYnJvd3Np bmcgbW9kZSBpbiBwbHVnaW5zLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MzU1MDAKKworICAgICAgICBVbnNraXAgdGVzdCBhZnRlciB0YWtpbmcgY29k ZSBmcm9tIFBsdWdpblZpZXdRdC5jcHAKKworICAgICAgICAqIHBsYXRmb3JtL2d0ay9Ta2lwcGVk OgorCiAyMDEwLTAyLTI4ICBSb2JlcnQgSG9nYW4gIDxyb2JlcnRAcm9iZXJ0aG9nYW4ubmV0Pgog CiAgICAgICAgIFJldmlld2VkIGJ5IFNpbW9uIEhhdXNtYW5uLgpkaWZmIC0tZ2l0IGEvTGF5b3V0 VGVzdHMvcGxhdGZvcm0vZ3RrL1NraXBwZWQgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9ndGsvU2tp cHBlZAppbmRleCAxYzljMzc1Li42ZjA1MmRkIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9wbGF0 Zm9ybS9ndGsvU2tpcHBlZAorKysgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9ndGsvU2tpcHBlZApA QCAtMzU5Niw4ICszNTk2LDYgQEAgcGx1Z2lucy9yZXR1cm4tZXJyb3ItZnJvbS1uZXctc3RyZWFt LWRvZXNudC1pbnZva2UtZGVzdHJveS1zdHJlYW0uaHRtbAogCiAjIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zMDU2MQogcGx1Z2lucy9wcml2YXRlLWJyb3dzaW5nLW1v ZGUuaHRtbAotIyBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzMxODAK LXBsdWdpbnMvcHJpdmF0ZS1icm93c2luZy1tb2RlLTIuaHRtbAogCiAjICAgVGVzdHMgZ2VuZXJh dGluZyBuZXcgcmVzdWx0cwogcGx1Z2lucy9lbWJlZC1hdHRyaWJ1dGVzLXN0eWxlLmh0bWwKZGlm ZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMGM4 Y2MwMS4uYzZiZTYwOCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2ViQ29y ZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxMC0wMi0yOCAgSG9sZ2VyIEhhbnMgUGV0 ZXIgRnJleXRoZXIgIDx6ZWNrZUBzZWxmaXNoLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbR3RrXSBTdXBwb3J0IHByaXZhdGUgYnJvd3Npbmcg bW9kZSBpbiBwbHVnaW5zLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MzU1MDAKKworICAgICAgICBJbnRlZ3JhdGUgdGhlIFBsdWdpblZpZXdRdC5jcHAg Y2hhbmdlcyBmcm9tIHI1NTM1OCBpbnRvIEd0aysuCisKKyAgICAgICAgKiBwbHVnaW5zL2d0ay9Q bHVnaW5WaWV3R3RrLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlBsdWdpblZpZXc6OmdldFZhbHVl KToKKwogMjAxMC0wMi0yOCAgQWxleGV5IFByb3NrdXJ5YWtvdiAgPGFwQGFwcGxlLmNvbT4KIAog ICAgICAgICBSZXZpZXdlZCBieSBEYW4gQmVybnN0ZWluLgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9w bHVnaW5zL2d0ay9QbHVnaW5WaWV3R3RrLmNwcCBiL1dlYkNvcmUvcGx1Z2lucy9ndGsvUGx1Z2lu Vmlld0d0ay5jcHAKaW5kZXggOGY2MGEyNi4uZDhjYmZmZSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9w bHVnaW5zL2d0ay9QbHVnaW5WaWV3R3RrLmNwcAorKysgYi9XZWJDb3JlL3BsdWdpbnMvZ3RrL1Bs dWdpblZpZXdHdGsuY3BwCkBAIC03MDAsNiArNzAwLDE0IEBAIE5QRXJyb3IgUGx1Z2luVmlldzo6 Z2V0VmFsdWUoTlBOVmFyaWFibGUgdmFyaWFibGUsIHZvaWQqIHZhbHVlKQogICAgICAgICAgICAg cmV0dXJuIE5QRVJSX05PX0VSUk9SOwogICAgICAgICB9CiAKKyAgICAgICAgY2FzZSBOUE5WcHJp dmF0ZU1vZGVCb29sOiB7CisgICAgICAgICAgICBQYWdlKiBwYWdlID0gbV9wYXJlbnRGcmFtZS0+ cGFnZSgpOworICAgICAgICAgICAgaWYgKCFwYWdlKQorICAgICAgICAgICAgICAgIHJldHVybiBO UEVSUl9HRU5FUklDX0VSUk9SOworICAgICAgICAgICAgKigoTlBCb29sKil2YWx1ZSkgPSAhcGFn ZS0+c2V0dGluZ3MoKSB8fCBwYWdlLT5zZXR0aW5ncygpLT5wcml2YXRlQnJvd3NpbmdFbmFibGVk KCk7CisgICAgICAgICAgICByZXR1cm4gTlBFUlJfTk9fRVJST1I7CisgICAgICAgIH0KKwogICAg ICAgICBkZWZhdWx0OgogICAgICAgICAgICAgcmV0dXJuIGdldFZhbHVlU3RhdGljKHZhcmlhYmxl LCB2YWx1ZSk7CiAgICAgfQotLSAKMS43LjAKCg==